[PATCH] alsa/usb-audio: Generic DSD detection for Thesycon-based implementations
Thesycon provides solutions to XMOS chips, and has its own device vendor id.
In this patch, we use generic method to detect DSD capability of Thesycon-based
UAC2
implementations in order to support a wide range of current and future devices.
The patch will enable the SNDRV_PCM_FMTBIT_DSD_U32_BE bit for the DAC
hence enable native DSD playback up to DSD512 format.
Signed-off-by: Yue Wang
---
sound/usb/quirks.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/sound/usb/quirks.c b/sound/usb/quirks.c
index 02b6cc02767f..06ae3f5adf4b 100644
--- a/sound/usb/quirks.c
+++ b/sound/usb/quirks.c
@@ -1443,6 +1443,7 @@ u64 snd_usb_interface_dsd_format_quirks(struct
snd_usb_audio *chip,
*/
switch (USB_ID_VENDOR(chip->usb_id)) {
case 0x20b1: /* XMOS based devices */
+ case 0x152a: /* Thesycon devices */
case 0x25ce: /* Mytek devices */
if (fp->dsd_raw)
return SNDRV_PCM_FMTBIT_DSD_U32_BE;
--
2.18.0
[PATCH] alsa/usb-audio: Generic DSD detection for Thesycon-based implementations
Thesycon provides solutions to XMOS chips, and has its own device vendor id.
In this patch, we use generic method to detect DSD capability of Thesycon-based
UAC2
implementations in order to support a wide range of current and future devices.
The patch will enable the SNDRV_PCM_FMTBIT_DSD_U32_BE bit for the DAC
hence enable native DSD playback up to DSD512 format.
Signed-off-by: Yue Wang
---
sound/usb/quirks.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/sound/usb/quirks.c b/sound/usb/quirks.c
index 02b6cc02767f..06ae3f5adf4b 100644
--- a/sound/usb/quirks.c
+++ b/sound/usb/quirks.c
@@ -1443,6 +1443,7 @@ u64 snd_usb_interface_dsd_format_quirks(struct
snd_usb_audio *chip,
*/
switch (USB_ID_VENDOR(chip->usb_id)) {
case 0x20b1: /* XMOS based devices */
+ case 0x152a: /* Thesycon devices */
case 0x25ce: /* Mytek devices */
if (fp->dsd_raw)
return SNDRV_PCM_FMTBIT_DSD_U32_BE;
--
2.18.0
Re: [PATCH] alsa/usb-audio: Generic DSD detection for Thesycon-based implementations
Please ignore this commit. there's something wrong. My apologies again. On Mon, Jul 23, 2018 at 1:53 AM Yue Wang wrote: > > Thesycon provides solutions to XMOS chips, and has its own device vendor id. > > In this patch, we use generic method to detect DSD capability of > Thesycon-based UAC2 > implementations in order to support a wide range of current and future > devices. > > The patch will enable the SNDRV_PCM_FMTBIT_DSD_U32_BE bit for the DAC > hence enable native DSD playback up to DSD512 format. > > Signed-off-by: Yue Wang > --- > sound/usb/quirks.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/sound/usb/quirks.c b/sound/usb/quirks.c > index 02b6cc02767f..c51e2dee3075 100644 > --- a/sound/usb/quirks.c > +++ b/sound/usb/quirks.c > @@ -1374,6 +1374,7 @@ u64 snd_usb_interface_dsd_format_quirks(struct > snd_usb_audio *chip, > break; > > case USB_ID(0x0d8c, 0x0316): /* Hegel HD12 DSD */ > + case USB_ID(0x152a, 0x8750): /* Topping DX7s */ > case USB_ID(0x16b0, 0x06b2): /* NuPrime DAC-10 */ > case USB_ID(0x16d0, 0x0733): /* Furutech ADL Stratos */ > case USB_ID(0x16d0, 0x09db): /* NuPrime Audio DAC-9 */ > -- > 2.18.0 >
Re: [PATCH] alsa/usb-audio: Generic DSD detection for Thesycon-based implementations
Please ignore this commit. there's something wrong. My apologies again. On Mon, Jul 23, 2018 at 1:53 AM Yue Wang wrote: > > Thesycon provides solutions to XMOS chips, and has its own device vendor id. > > In this patch, we use generic method to detect DSD capability of > Thesycon-based UAC2 > implementations in order to support a wide range of current and future > devices. > > The patch will enable the SNDRV_PCM_FMTBIT_DSD_U32_BE bit for the DAC > hence enable native DSD playback up to DSD512 format. > > Signed-off-by: Yue Wang > --- > sound/usb/quirks.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/sound/usb/quirks.c b/sound/usb/quirks.c > index 02b6cc02767f..c51e2dee3075 100644 > --- a/sound/usb/quirks.c > +++ b/sound/usb/quirks.c > @@ -1374,6 +1374,7 @@ u64 snd_usb_interface_dsd_format_quirks(struct > snd_usb_audio *chip, > break; > > case USB_ID(0x0d8c, 0x0316): /* Hegel HD12 DSD */ > + case USB_ID(0x152a, 0x8750): /* Topping DX7s */ > case USB_ID(0x16b0, 0x06b2): /* NuPrime DAC-10 */ > case USB_ID(0x16d0, 0x0733): /* Furutech ADL Stratos */ > case USB_ID(0x16d0, 0x09db): /* NuPrime Audio DAC-9 */ > -- > 2.18.0 >
Re: [PATCH] alsa/usb-audio: Topping DX7s quirk for DSD interface
Thanks for the comment Jussi. Let's drop this patch, and I will send a new patch with this generic approach shortly. The new patch will have a different commit title and message. On Mon, Jul 23, 2018 at 1:26 AM Jussi Laako wrote: > > Hi, > > > + case USB_ID(0x152a, 0x8750): /* Topping DX7s */ > 0x152a is Thesycon's VID and if it's based on XMOS I'd recommend to try > adding the 0x152a VID to the generic DSD capability auto-detect list > instead of this old device specific list. > > I consider it very likely that it would work that way and at the same > time also cover all other devices with the same firmware and Thesycon's VID. > > > Best regards, > > - Jussi
Re: [PATCH] alsa/usb-audio: Topping DX7s quirk for DSD interface
Thanks for the comment Jussi. Let's drop this patch, and I will send a new patch with this generic approach shortly. The new patch will have a different commit title and message. On Mon, Jul 23, 2018 at 1:26 AM Jussi Laako wrote: > > Hi, > > > + case USB_ID(0x152a, 0x8750): /* Topping DX7s */ > 0x152a is Thesycon's VID and if it's based on XMOS I'd recommend to try > adding the 0x152a VID to the generic DSD capability auto-detect list > instead of this old device specific list. > > I consider it very likely that it would work that way and at the same > time also cover all other devices with the same firmware and Thesycon's VID. > > > Best regards, > > - Jussi
[PATCH] alsa/usb-audio: Generic DSD detection for Thesycon-based implementations
Thesycon provides solutions to XMOS chips, and has its own device vendor id. In this patch, we use generic method to detect DSD capability of Thesycon-based UAC2 implementations in order to support a wide range of current and future devices. The patch will enable the SNDRV_PCM_FMTBIT_DSD_U32_BE bit for the DAC hence enable native DSD playback up to DSD512 format. Signed-off-by: Yue Wang --- sound/usb/quirks.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sound/usb/quirks.c b/sound/usb/quirks.c index 02b6cc02767f..c51e2dee3075 100644 --- a/sound/usb/quirks.c +++ b/sound/usb/quirks.c @@ -1374,6 +1374,7 @@ u64 snd_usb_interface_dsd_format_quirks(struct snd_usb_audio *chip, break; case USB_ID(0x0d8c, 0x0316): /* Hegel HD12 DSD */ + case USB_ID(0x152a, 0x8750): /* Topping DX7s */ case USB_ID(0x16b0, 0x06b2): /* NuPrime DAC-10 */ case USB_ID(0x16d0, 0x0733): /* Furutech ADL Stratos */ case USB_ID(0x16d0, 0x09db): /* NuPrime Audio DAC-9 */ -- 2.18.0
[PATCH] alsa/usb-audio: Generic DSD detection for Thesycon-based implementations
Thesycon provides solutions to XMOS chips, and has its own device vendor id. In this patch, we use generic method to detect DSD capability of Thesycon-based UAC2 implementations in order to support a wide range of current and future devices. The patch will enable the SNDRV_PCM_FMTBIT_DSD_U32_BE bit for the DAC hence enable native DSD playback up to DSD512 format. Signed-off-by: Yue Wang --- sound/usb/quirks.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sound/usb/quirks.c b/sound/usb/quirks.c index 02b6cc02767f..c51e2dee3075 100644 --- a/sound/usb/quirks.c +++ b/sound/usb/quirks.c @@ -1374,6 +1374,7 @@ u64 snd_usb_interface_dsd_format_quirks(struct snd_usb_audio *chip, break; case USB_ID(0x0d8c, 0x0316): /* Hegel HD12 DSD */ + case USB_ID(0x152a, 0x8750): /* Topping DX7s */ case USB_ID(0x16b0, 0x06b2): /* NuPrime DAC-10 */ case USB_ID(0x16d0, 0x0733): /* Furutech ADL Stratos */ case USB_ID(0x16d0, 0x09db): /* NuPrime Audio DAC-9 */ -- 2.18.0
[PATCH] alsa/usb-audio: Topping DX7s quirk for DSD interface
This patch adds the support for native DSD for Topping DX7s DAC. The product description is on http://en.tpdz.net/products_detail/productId=32.html and it's available on https://www.amazon.com/Balanced-Headphone-Amplifier-Topping-2ES9038Q2M/dp/B07B4VFS21 The DAC uses XMOS chip but uses a special vendor id and product id. The patch will enable the SNDRV_PCM_FMTBIT_DSD_U32_BE bit for the DAC hence enable native DSD playback up to DSD512 format. Signed-off-by: Yue Wang --- sound/usb/quirks.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sound/usb/quirks.c b/sound/usb/quirks.c index 02b6cc02767f..c51e2dee3075 100644 --- a/sound/usb/quirks.c +++ b/sound/usb/quirks.c @@ -1374,6 +1374,7 @@ u64 snd_usb_interface_dsd_format_quirks(struct snd_usb_audio *chip, break; case USB_ID(0x0d8c, 0x0316): /* Hegel HD12 DSD */ + case USB_ID(0x152a, 0x8750): /* Topping DX7s */ case USB_ID(0x16b0, 0x06b2): /* NuPrime DAC-10 */ case USB_ID(0x16d0, 0x0733): /* Furutech ADL Stratos */ case USB_ID(0x16d0, 0x09db): /* NuPrime Audio DAC-9 */ -- 2.18.0
[PATCH] alsa/usb-audio: Topping DX7s quirk for DSD interface
This patch adds the support for native DSD for Topping DX7s DAC. The product description is on http://en.tpdz.net/products_detail/productId=32.html and it's available on https://www.amazon.com/Balanced-Headphone-Amplifier-Topping-2ES9038Q2M/dp/B07B4VFS21 The DAC uses XMOS chip but uses a special vendor id and product id. The patch will enable the SNDRV_PCM_FMTBIT_DSD_U32_BE bit for the DAC hence enable native DSD playback up to DSD512 format. Signed-off-by: Yue Wang --- sound/usb/quirks.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sound/usb/quirks.c b/sound/usb/quirks.c index 02b6cc02767f..c51e2dee3075 100644 --- a/sound/usb/quirks.c +++ b/sound/usb/quirks.c @@ -1374,6 +1374,7 @@ u64 snd_usb_interface_dsd_format_quirks(struct snd_usb_audio *chip, break; case USB_ID(0x0d8c, 0x0316): /* Hegel HD12 DSD */ + case USB_ID(0x152a, 0x8750): /* Topping DX7s */ case USB_ID(0x16b0, 0x06b2): /* NuPrime DAC-10 */ case USB_ID(0x16d0, 0x0733): /* Furutech ADL Stratos */ case USB_ID(0x16d0, 0x09db): /* NuPrime Audio DAC-9 */ -- 2.18.0
Re: [PATCH] alsa/usb-audio: Topping DX7s quirk for DSD interface
Hi Takashi My apologies, it's my first time sending a patch to the kernel, so there're quite a few things I need to improve. This patch adds the support for native DSD for Topping DX7s DAC. The product description is on http://en.tpdz.net/products_detail/productId=32.html and it's available on https://www.amazon.com/Balanced-Headphone-Amplifier-Topping-2ES9038Q2M/dp/B07B4VFS21 The DAC uses XMOS chip but uses a special vendor id and product id. The patch will enable the SNDRV_PCM_FMTBIT_DSD_U32_BE bit for the DAC hence enable native DSD playback up to DSD512 format. Thanks again. Yue On Mon, Jul 23, 2018 at 12:30 AM Takashi Iwai wrote: > > On Mon, 23 Jul 2018 09:25:34 +0200, > wrote: > > > > From: Yue Wang > > > > Signed-off-by: Yue Wang > > Please give more explanation. > No commit message already indicates that something is very wrong, no > matter what the change is. > > > thanks, > > Takashi
Re: [PATCH] alsa/usb-audio: Topping DX7s quirk for DSD interface
Hi Takashi My apologies, it's my first time sending a patch to the kernel, so there're quite a few things I need to improve. This patch adds the support for native DSD for Topping DX7s DAC. The product description is on http://en.tpdz.net/products_detail/productId=32.html and it's available on https://www.amazon.com/Balanced-Headphone-Amplifier-Topping-2ES9038Q2M/dp/B07B4VFS21 The DAC uses XMOS chip but uses a special vendor id and product id. The patch will enable the SNDRV_PCM_FMTBIT_DSD_U32_BE bit for the DAC hence enable native DSD playback up to DSD512 format. Thanks again. Yue On Mon, Jul 23, 2018 at 12:30 AM Takashi Iwai wrote: > > On Mon, 23 Jul 2018 09:25:34 +0200, > wrote: > > > > From: Yue Wang > > > > Signed-off-by: Yue Wang > > Please give more explanation. > No commit message already indicates that something is very wrong, no > matter what the change is. > > > thanks, > > Takashi
