答复: [PATCH -next] ACPI: tables: Mark acpi_init_fpdt with static keyword
Hi Rui,
You can fix it in your patch together.
-邮件原件-
发件人: Zhang Rui [mailto:rui.zh...@intel.com]
发送时间: 2021年1月29日 14:25
收件人: Zouwei (Samuel) ; r...@rjwysocki.net; l...@kernel.org
抄送: linux-a...@vger.kernel.org; linux-kernel@vger.kernel.org
主题: Re: [PATCH -next] ACPI: tables: Mark acpi_init_fpdt with static keyword
Hi, Wei,
Thanks for the patch.
Given that there are a couple of things need to be fixed in the orignal patch,
I'd prefer to refresh the patch with all the fixes included
https://patchwork.kernel.org/project/linux-acpi/patch/20210129061548.13448-1-rui.zh...@intel.com/
what do you think?
thanks,
rui
On Thu, 2021-01-28 at 19:31 +0800, Zou Wei wrote:
> Fix the following sparse warning:
>
> drivers/acpi/acpi_fpdt.c:230:6: warning: symbol 'acpi_init_fpdt' was
> not declared. Should it be static?
>
> Signed-off-by: Zou Wei
> ---
> drivers/acpi/acpi_fpdt.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/acpi/acpi_fpdt.c b/drivers/acpi/acpi_fpdt.c index
> b810811..968f9cc 100644
> --- a/drivers/acpi/acpi_fpdt.c
> +++ b/drivers/acpi/acpi_fpdt.c
> @@ -227,7 +227,7 @@ static int fpdt_process_subtable(u64 address, u32
> subtable_type)
> return 0;
> }
>
> -void acpi_init_fpdt(void)
> +static void acpi_init_fpdt(void)
> {
> acpi_status status;
> struct acpi_table_header *header;
答复: [PATCH -next] vdpa: Mark macaddr_buf with static keyword
Hi, I run this command: make allmodconfig ARCH=x86_64 CROSS_COMPILE=x86_64-linux-gnu- make C=2 drivers/vdpa/vdpa_sim/vdpa_sim_net.o ARCH=x86_64 CROSS_COMPILE=x86_64-linux-gnu- -邮件原件- 发件人: Stefano Garzarella [mailto:sgarz...@redhat.com] 发送时间: 2020年12月18日 15:57 收件人: Zouwei (Samuel) 抄送: m...@redhat.com; jasow...@redhat.com; mgurto...@nvidia.com; virtualizat...@lists.linux-foundation.org; linux-kernel@vger.kernel.org 主题: Re: [PATCH -next] vdpa: Mark macaddr_buf with static keyword On Fri, Dec 18, 2020 at 09:51:35AM +0800, Zou Wei wrote: >Fix the following sparse warning: > >drivers/vdpa/vdpa_sim/vdpa_sim_net.c:36:4: warning: symbol 'macaddr_buf' was >not declared. Should it be static? > >Reported-by: Hulk Robot >Signed-off-by: Zou Wei >--- > drivers/vdpa/vdpa_sim/vdpa_sim_net.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Stefano Garzarella I built with W=1 but I didn't have this warning. Thanks for fixing, Stefano > >diff --git a/drivers/vdpa/vdpa_sim/vdpa_sim_net.c >b/drivers/vdpa/vdpa_sim/vdpa_sim_net.c >index c10b698..f048242 100644 >--- a/drivers/vdpa/vdpa_sim/vdpa_sim_net.c >+++ b/drivers/vdpa/vdpa_sim/vdpa_sim_net.c >@@ -33,7 +33,7 @@ static char *macaddr; module_param(macaddr, charp, >0); MODULE_PARM_DESC(macaddr, "Ethernet MAC address"); > >-u8 macaddr_buf[ETH_ALEN]; >+static u8 macaddr_buf[ETH_ALEN]; > > static struct vdpasim *vdpasim_net_dev; > >-- >2.6.2 >
答复: [PATCH -next] net/mlx5_core: remove unused including
ok, I will add the Fixes line and send the v2 soon.
-邮件原件-
发件人: Leon Romanovsky [mailto:l...@kernel.org]
发送时间: 2020年12月9日 14:21
收件人: Jakub Kicinski
抄送: Zouwei (Samuel) ; sae...@nvidia.com;
da...@davemloft.net; net...@vger.kernel.org; linux-r...@vger.kernel.org;
linux-kernel@vger.kernel.org
主题: Re: [PATCH -next] net/mlx5_core: remove unused including
On Tue, Dec 08, 2020 at 11:22:26AM -0800, Jakub Kicinski wrote:
> On Mon, 7 Dec 2020 20:14:00 +0800 Zou Wei wrote:
> > Remove including that don't need it.
> >
> > Signed-off-by: Zou Wei
> > ---
> > drivers/net/ethernet/mellanox/mlx5/core/en_rep.c | 1 -
> > 1 file changed, 1 deletion(-)
> >
> > diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_rep.c
> > b/drivers/net/ethernet/mellanox/mlx5/core/en_rep.c
> > index 989c70c..82ecc161 100644
> > --- a/drivers/net/ethernet/mellanox/mlx5/core/en_rep.c
> > +++ b/drivers/net/ethernet/mellanox/mlx5/core/en_rep.c
> > @@ -30,7 +30,6 @@
> > * SOFTWARE.
> > */
> >
> > -#include
> > #include
> > #include
> > #include
Jakub,
You probably doesn't have latest net-next.
In the commit 17a7612b99e6 ("net/mlx5_core: Clean driver version and name"), I
removed "strlcpy(drvinfo->version, UTS_RELEASE, sizeof(drvinfo->version));"
line.
The patch is ok, but should have Fixes line.
Fixes: 17a7612b99e6 ("net/mlx5_core: Clean driver version and name")
Thanks
>
>
> drivers/net/ethernet/mellanox/mlx5/core/en_rep.c: In function
> ‘mlx5e_rep_get_drvinfo’:
> drivers/net/ethernet/mellanox/mlx5/core/en_rep.c:66:28: error: ‘UTS_RELEASE’
> undeclared (first use in this function); did you mean ‘CSS_RELEASED’?
>66 | strlcpy(drvinfo->version, UTS_RELEASE, sizeof(drvinfo->version));
> |^~~
> |CSS_RELEASED
> drivers/net/ethernet/mellanox/mlx5/core/en_rep.c:66:28: note: each
> undeclared identifier is reported only once for each function it
> appears in
> make[6]: *** [drivers/net/ethernet/mellanox/mlx5/core/en_rep.o] Error
> 1
> make[5]: *** [drivers/net/ethernet/mellanox/mlx5/core] Error 2
> make[4]: *** [drivers/net/ethernet/mellanox] Error 2
> make[3]: *** [drivers/net/ethernet] Error 2
> make[2]: *** [drivers/net] Error 2
> make[2]: *** Waiting for unfinished jobs
> make[1]: *** [drivers] Error 2
> make: *** [__sub-make] Error 2
答复: [PATCH -next] firmware: xilinx: Mark pm_api_features_map with static keyword
Hi all, Please ignore this patch, there is a mistake. I will send v2 soon -邮件原件- 发件人: Zouwei (Samuel) 发送时间: 2020年12月1日 19:16 收件人: michal.si...@xilinx.com; rajan.v...@xilinx.com; gre...@linuxfoundation.org; jolly.s...@xilinx.com; tejas.pa...@xilinx.com; manish.nar...@xilinx.com 抄送: linux-arm-ker...@lists.infradead.org; linux-kernel@vger.kernel.org; Zouwei (Samuel) 主题: [PATCH -next] firmware: xilinx: Mark pm_api_features_map with static keyword Fix the following sparse warning: drivers/firmware/xilinx/zynqmp.c:32:1: warning: symbol 'pm_api_features_map' was not declared. Should it be static? Signed-off-by: Zou Wei --- drivers/firmware/xilinx/zynqmp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/firmware/xilinx/zynqmp.c b/drivers/firmware/xilinx/zynqmp.c index d08ac82..943c2ac5 100644 --- a/drivers/firmware/xilinx/zynqmp.c +++ b/drivers/firmware/xilinx/zynqmp.c @@ -29,7 +29,7 @@ #define PM_API_FEATURE_CHECK_MAX_ORDER 7 static bool feature_check_enabled; -DEFINE_HASHTABLE(pm_api_features_map, PM_API_FEATURE_CHECK_MAX_ORDER); +static EFINE_HASHTABLE(pm_api_features_map, PM_API_FEATURE_CHECK_MAX_ORDER); /** * struct pm_api_feature_data - PM API Feature data -- 2.6.2
答复: [PATCH -next] x86/platform/uv: Mark some symbols with static keyword
Hi, Please help to pick it up after 5.11-rc1, thanks a lot. -邮件原件- 发件人: Hans de Goede [mailto:hdego...@redhat.com] 发送时间: 2020年11月30日 21:31 收件人: Zouwei (Samuel) ; justin.er...@hpe.com; mgr...@linux.intel.com 抄送: platform-driver-...@vger.kernel.org; linux-kernel@vger.kernel.org; x...@kernel.org 主题: Re: [PATCH -next] x86/platform/uv: Mark some symbols with static keyword Hi, +Cc x86 folks On 11/30/20 12:11 PM, Zou Wei wrote: > Fix the following sparse warnings: > > drivers/platform/x86/uv_sysfs.c:22:13: warning: symbol 'uv_pcibus_kset' was > not declared. Should it be static? > drivers/platform/x86/uv_sysfs.c:23:13: warning: symbol 'uv_hubs_kset' was not > declared. Should it be static? > > Signed-off-by: Zou Wei Since this is a fix to a series merged through the x86/tip tree, this should be merged to the x86/tip tree too (or I can pick it up after 5.11-rc1). Here is my ack for merging this through the x86/tip tree: Acked-by: Hans de Goede Regards, Hans > --- > drivers/platform/x86/uv_sysfs.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/platform/x86/uv_sysfs.c > b/drivers/platform/x86/uv_sysfs.c index 54c3425..c780a4b 100644 > --- a/drivers/platform/x86/uv_sysfs.c > +++ b/drivers/platform/x86/uv_sysfs.c > @@ -19,8 +19,8 @@ > #define INVALID_CNODE -1 > > struct kobject *sgi_uv_kobj; > -struct kset *uv_pcibus_kset; > -struct kset *uv_hubs_kset; > +static struct kset *uv_pcibus_kset; > +static struct kset *uv_hubs_kset; > static struct uv_bios_hub_info *hub_buf; static struct > uv_bios_port_info **port_buf; static struct uv_hub **uv_hubs; >
答复: [PATCH -next] sched/topology: Mark some symbols with static keyword
Quentin,
Thanks for the review. I will send the v2 soon.
-邮件原件-
发件人: Quentin Perret [mailto:qper...@google.com]
发送时间: 2020年11月24日 21:24
收件人: Zouwei (Samuel)
抄送: mi...@redhat.com; pet...@infradead.org; juri.le...@redhat.com;
vincent.guit...@linaro.org; dietmar.eggem...@arm.com; rost...@goodmis.org;
bseg...@google.com; mgor...@suse.de; bris...@redhat.com;
linux-kernel@vger.kernel.org
主题: Re: [PATCH -next] sched/topology: Mark some symbols with static keyword
On Tuesday 24 Nov 2020 at 19:52:11 (+0800), Zou Wei wrote:
> Fix the following sparse warnings:
>
> kernel/sched/topology.c:211:1: warning: symbol 'sched_energy_mutex' was not
> declared. Should it be static?
> kernel/sched/topology.c:212:6: warning: symbol 'sched_energy_update' was not
> declared. Should it be static?
>
> Signed-off-by: Zou Wei
I think this wants:
Fixes: 31f6a8c0a471 ("sched/topology,schedutil: Wrap sched domains rebuild")
But, with that:
Reviewed-by: Quentin Perret
Thanks,
Quentin
答复: [PATCH -next] ASoC: mediatek: mt8192: Make some symbols static
Hi all,
Please ignore this patch, I'll send another patch with other fixes.
-邮件原件-
发件人: Zouwei (Samuel)
发送时间: 2020年11月5日 20:02
收件人: lgirdw...@gmail.com; broo...@kernel.org; pe...@perex.cz; ti...@suse.com;
matthias@gmail.com
抄送: alsa-de...@alsa-project.org; linux-arm-ker...@lists.infradead.org;
linux-media...@lists.infradead.org; linux-kernel@vger.kernel.org; Zouwei
(Samuel)
主题: [PATCH -next] ASoC: mediatek: mt8192: Make some symbols static
Fix the following sparse warnings:
./mt8192-dai-i2s.c:2040:5: warning: symbol 'mt8192_dai_i2s_get_share' was not
declared. Should it be static?
./mt8192-dai-i2s.c:2060:5: warning: symbol 'mt8192_dai_i2s_set_priv' was not
declared. Should it be static?
Reported-by: Hulk Robot
Signed-off-by: Zou Wei
---
sound/soc/mediatek/mt8192/mt8192-dai-i2s.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/sound/soc/mediatek/mt8192/mt8192-dai-i2s.c
b/sound/soc/mediatek/mt8192/mt8192-dai-i2s.c
index 53c560e..5b29340 100644
--- a/sound/soc/mediatek/mt8192/mt8192-dai-i2s.c
+++ b/sound/soc/mediatek/mt8192/mt8192-dai-i2s.c
@@ -2037,7 +2037,7 @@ static const struct mtk_afe_i2s_priv
mt8192_i2s_priv[DAI_I2S_NUM] = {
},
};
-int mt8192_dai_i2s_get_share(struct mtk_base_afe *afe)
+static int mt8192_dai_i2s_get_share(struct mtk_base_afe *afe)
{
struct mt8192_afe_private *afe_priv = afe->platform_priv;
const struct device_node *of_node = afe->dev->of_node; @@ -2057,7
+2057,7 @@ int mt8192_dai_i2s_get_share(struct mtk_base_afe *afe)
return 0;
}
-int mt8192_dai_i2s_set_priv(struct mtk_base_afe *afe)
+static int mt8192_dai_i2s_set_priv(struct mtk_base_afe *afe)
{
int i;
int ret;
--
2.6.2
答复: [PATCH -next] drm/panfrost: Fix unused variable warning
Hi Steve,
Sorry, I didn't notice the patch earlier.
Please ignore my patch.
-邮件原件-
发件人: Steven Price [mailto:steven.pr...@arm.com]
发送时间: 2020年11月2日 17:29
收件人: Zouwei (Samuel) ; r...@kernel.org;
tomeu.viz...@collabora.com; alyssa.rosenzw...@collabora.com; airl...@linux.ie;
dan...@ffwll.ch
抄送: dri-de...@lists.freedesktop.org; linux-kernel@vger.kernel.org
主题: Re: [PATCH -next] drm/panfrost: Fix unused variable warning
On 02/11/2020 09:33, Zou Wei wrote:
> Fixes the following W=1 kernel build warning:
>
> ./panfrost_job.c:617:28: warning: unused variable ‘js’ [-Wunused-variable]
>struct panfrost_job_slot *js = pfdev->js;
> ^~
>
> Reported-by: Hulk Robot
> Signed-off-by: Zou Wei
Boris posted an identical patch earlier:
https://lore.kernel.org/r/20201101173817.831769-1-boris.brezillon%40collabora.com
Steve
> ---
> drivers/gpu/drm/panfrost/panfrost_job.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/panfrost/panfrost_job.c
> b/drivers/gpu/drm/panfrost/panfrost_job.c
> index 4902bc6..e75b7d2 100644
> --- a/drivers/gpu/drm/panfrost/panfrost_job.c
> +++ b/drivers/gpu/drm/panfrost/panfrost_job.c
> @@ -613,8 +613,6 @@ int panfrost_job_open(struct panfrost_file_priv
> *panfrost_priv)
>
> void panfrost_job_close(struct panfrost_file_priv *panfrost_priv)
> {
> - struct panfrost_device *pfdev = panfrost_priv->pfdev;
> - struct panfrost_job_slot *js = pfdev->js;
> int i;
>
> for (i = 0; i < NUM_JOB_SLOTS; i++)
>
