Re: [PATCH v4 1/2] ipvs: add READ_ONCE barrier for ipvs->sysctl_amemthresh
Hello: This series was applied to netdev/net-next.git (main) by David S. Miller : On Mon, 6 May 2024 16:14:43 +0200 you wrote: > Cc: Julian Anastasov > Cc: Simon Horman > Cc: Pablo Neira Ayuso > Cc: Jozsef Kadlecsik > Cc: Florian Westphal > Suggested-by: Julian Anastasov > Signed-off-by: Alexander Mikhalitsyn > > [...] Here is the summary with links: - [v4,1/2] ipvs: add READ_ONCE barrier for ipvs->sysctl_amemthresh https://git.kernel.org/netdev/net-next/c/643bb5dbaef7 - [v4,2/2] ipvs: allow some sysctls in non-init user namespaces https://git.kernel.org/netdev/net-next/c/2b696a2a101d You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
Re: [PATCH net-next v9 0/7] Implement reset reason mechanism to detect
Hello: This series was applied to netdev/net-next.git (main) by Paolo Abeni : On Thu, 25 Apr 2024 11:13:33 +0800 you wrote: > From: Jason Xing > > In production, there are so many cases about why the RST skb is sent but > we don't have a very convenient/fast method to detect the exact underlying > reasons. > > RST is implemented in two kinds: passive kind (like tcp_v4_send_reset()) > and active kind (like tcp_send_active_reset()). The former can be traced > carefully 1) in TCP, with the help of drop reasons, which is based on > Eric's idea[1], 2) in MPTCP, with the help of reset options defined in > RFC 8684. The latter is relatively independent, which should be > implemented on our own, such as active reset reasons which can not be > replace by skb drop reason or something like this. > > [...] Here is the summary with links: - [net-next,v9,1/7] net: introduce rstreason to detect why the RST is sent https://git.kernel.org/netdev/net-next/c/5cb2cb3cb20c - [net-next,v9,2/7] rstreason: prepare for passive reset https://git.kernel.org/netdev/net-next/c/6be49deaa095 - [net-next,v9,3/7] rstreason: prepare for active reset https://git.kernel.org/netdev/net-next/c/5691276b39da - [net-next,v9,4/7] tcp: support rstreason for passive reset https://git.kernel.org/netdev/net-next/c/120391ef9ca8 - [net-next,v9,5/7] mptcp: support rstreason for passive reset https://git.kernel.org/netdev/net-next/c/3e140491dd80 - [net-next,v9,6/7] mptcp: introducing a helper into active reset logic https://git.kernel.org/netdev/net-next/c/215d40248bde - [net-next,v9,7/7] rstreason: make it work in trace world https://git.kernel.org/netdev/net-next/c/b533fb9cf4f7 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
Re: [PATCH net-next v9] virtio_net: Support RX hash XDP hint
Hello: This patch was applied to netdev/net-next.git (main) by Paolo Abeni : On Wed, 17 Apr 2024 15:18:22 +0800 you wrote: > The RSS hash report is a feature that's part of the virtio specification. > Currently, virtio backends like qemu, vdpa (mlx5), and potentially vhost > (still a work in progress as per [1]) support this feature. While the > capability to obtain the RSS hash has been enabled in the normal path, > it's currently missing in the XDP path. Therefore, we are introducing > XDP hints through kfuncs to allow XDP programs to access the RSS hash. > > [...] Here is the summary with links: - [net-next,v9] virtio_net: Support RX hash XDP hint https://git.kernel.org/netdev/net-next/c/aa37f8916d20 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
Re: [PATCH net v4] virtio_net: Do not send RSS key if it is not supported
Hello: This patch was applied to netdev/net.git (main) by David S. Miller : On Wed, 3 Apr 2024 08:43:12 -0700 you wrote: > There is a bug when setting the RSS options in virtio_net that can break > the whole machine, getting the kernel into an infinite loop. > > Running the following command in any QEMU virtual machine with virtionet > will reproduce this problem: > > # ethtool -X eth0 hfunc toeplitz > > [...] Here is the summary with links: - [net,v4] virtio_net: Do not send RSS key if it is not supported https://git.kernel.org/netdev/net/c/059a49aa2e25 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
Re: [PATCH net-next v4 0/2] tcp: make trace of reset logic complete
Hello: This series was applied to netdev/net-next.git (main) by Jakub Kicinski : On Mon, 1 Apr 2024 15:36:03 +0800 you wrote: > From: Jason Xing > > Before this, we miss some cases where the TCP layer could send RST but > we cannot trace it. So I decided to complete it :) > > v4 > Link: > https://lore.kernel.org/all/20240329034243.7929-1-kerneljasonx...@gmail.com/ > 1. rebased against latest net-next > 2. remove {} and add skb test statement (Eric) > 3. drop v3 patch [3/3] temporarily because 1) location is not that useful > since we can use perf or something else to trace, 2) Eric said we could > use drop_reason to show why we have to RST, which is good, but this seems > not work well for those ->send_reset() logic. I need more time to > investigate this part. > > [...] Here is the summary with links: - [net-next,v4,1/2] trace: adjust TP_STORE_ADDR_PORTS_SKB() parameters https://git.kernel.org/netdev/net-next/c/9807080e2170 - [net-next,v4,2/2] trace: tcp: fully support trace_tcp_send_reset https://git.kernel.org/netdev/net-next/c/19822a980e19 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
Re: [PATCH net v2] vsock/virtio: fix packet delivery to tap device
Hello: This patch was applied to netdev/net.git (main) by Jakub Kicinski : On Fri, 29 Mar 2024 17:12:59 +0100 you wrote: > Commit 82dfb540aeb2 ("VSOCK: Add virtio vsock vsockmon hooks") added > virtio_transport_deliver_tap_pkt() for handing packets to the > vsockmon device. However, in virtio_transport_send_pkt_work(), > the function is called before actually sending the packet (i.e. > before placing it in the virtqueue with virtqueue_add_sgs() and checking > whether it returned successfully). > Queuing the packet in the virtqueue can fail even multiple times. > However, in virtio_transport_deliver_tap_pkt() we deliver the packet > to the monitoring tap interface only the first time we call it. > This certainly avoids seeing the same packet replicated multiple times > in the monitoring interface, but it can show the packet sent with the > wrong timestamp or even before we succeed to queue it in the virtqueue. > > [...] Here is the summary with links: - [net,v2] vsock/virtio: fix packet delivery to tap device https://git.kernel.org/netdev/net/c/b32a09ea7c38 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
Re: [PATCH net-next 0/3] trace: use TP_STORE_ADDRS macro
Hello: This series was applied to netdev/net-next.git (main) by Paolo Abeni : On Mon, 25 Mar 2024 11:43:44 +0800 you wrote: > From: Jason Xing > > Using the macro for other tracepoints use to be more concise. > No functional change. > > Jason Xing (3): > trace: move to TP_STORE_ADDRS related macro to net_probe_common.h > trace: use TP_STORE_ADDRS() macro in inet_sk_error_report() > trace: use TP_STORE_ADDRS() macro in inet_sock_set_state() > > [...] Here is the summary with links: - [net-next,1/3] trace: move to TP_STORE_ADDRS related macro to net_probe_common.h https://git.kernel.org/netdev/net-next/c/b3af9045b482 - [net-next,2/3] trace: use TP_STORE_ADDRS() macro in inet_sk_error_report() https://git.kernel.org/netdev/net-next/c/a24c855a5ef2 - [net-next,3/3] trace: use TP_STORE_ADDRS() macro in inet_sock_set_state() https://git.kernel.org/netdev/net-next/c/646700ce23f4 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
Re: [PATCH net-next v4] net: dqs: add NIC stall detector based on BQL
Hello: This patch was applied to netdev/net-next.git (main) by David S. Miller : On Mon, 4 Mar 2024 06:08:47 -0800 you wrote: > From: Jakub Kicinski > > softnet_data->time_squeeze is sometimes used as a proxy for > host overload or indication of scheduling problems. In practice > this statistic is very noisy and has hard to grasp units - > e.g. is 10 squeezes a second to be expected, or high? > > [...] Here is the summary with links: - [net-next,v4] net: dqs: add NIC stall detector based on BQL https://git.kernel.org/netdev/net-next/c/6025b9135f7a You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
Re: [PATCH net-next v3] tcp: Add skb addr and sock addr to arguments of tracepoint tcp_probe.
Hello: This patch was applied to netdev/net-next.git (main) by David S. Miller : On Tue, 5 Mar 2024 11:04:17 +0800 you wrote: > It is useful to expose skb addr and sock addr to user in tracepoint > tcp_probe, so that we can get more information while monitoring > receiving of tcp data, by ebpf or other ways. > > For example, we need to identify a packet by seq and end_seq when > calculate transmit latency between layer 2 and layer 4 by ebpf, but which is > not available in tcp_probe, so we can only use kprobe hooking > tcp_rcv_established to get them. But we can use tcp_probe directly if skb > addr and sock addr are available, which is more efficient. > > [...] Here is the summary with links: - [net-next,v3] tcp: Add skb addr and sock addr to arguments of tracepoint tcp_probe. https://git.kernel.org/netdev/net-next/c/caabd859c41b You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
Re: [PATCH net-next v2 0/2] tcp: add two missing addresses when using trace
Hello: This series was applied to netdev/net-next.git (main) by Paolo Abeni : On Mon, 4 Mar 2024 17:29:32 +0800 you wrote: > From: Jason Xing > > When I reviewed other people's patch [1], I noticed that similar things > also happen in tcp_event_skb class and tcp_event_sk_skb class. They > don't print those two addrs of skb/sk which already exist. > > In this patch, I just do as other trace functions do, like > trace_net_dev_start_xmit(), to know the exact flow or skb we would like > to know in case some systems doesn't support BPF programs well or we > have to use /sys/kernel/debug/tracing only for some reasons. > > [...] Here is the summary with links: - [net-next,v2,1/2] tcp: add tracing of skb/skaddr in tcp_event_sk_skb class https://git.kernel.org/netdev/net-next/c/4e441bb8aca1 - [net-next,v2,2/2] tcp: add tracing of skbaddr in tcp_event_skb class https://git.kernel.org/netdev/net-next/c/0ab544b6f055 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
Re: [PATCH net-next 1/2] net/vsockmon: Leverage core stats allocator
Hello: This series was applied to netdev/net-next.git (main) by Jakub Kicinski : On Fri, 23 Feb 2024 03:58:37 -0800 you wrote: > With commit 34d21de99cea9 ("net: Move {l,t,d}stats allocation to core and > convert veth & vrf"), stats allocation could be done on net core > instead of this driver. > > With this new approach, the driver doesn't have to bother with error > handling (allocation failure checking, making sure free happens in the > right spot, etc). This is core responsibility now. > > [...] Here is the summary with links: - [net-next,1/2] net/vsockmon: Leverage core stats allocator https://git.kernel.org/netdev/net-next/c/bcd53aff4d0c - [net-next,2/2] net/vsockmon: Do not set zeroed statistics https://git.kernel.org/netdev/net-next/c/3a25e212306c You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
Re: [PATCH net-next v1] vsock/test: print type for SOCK_SEQPACKET
Hello: This patch was applied to netdev/net-next.git (main) by Jakub Kicinski : On Wed, 24 Jan 2024 22:32:55 +0300 you wrote: > SOCK_SEQPACKET is supported for virtio transport, so do not interpret > such type of socket as unknown. > > Signed-off-by: Arseniy Krasnov > --- > tools/testing/vsock/vsock_diag_test.c | 2 ++ > 1 file changed, 2 insertions(+) Here is the summary with links: - [net-next,v1] vsock/test: print type for SOCK_SEQPACKET https://git.kernel.org/netdev/net-next/c/767ec326f985 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
Re: [PATCH net-next v2] vsock/test: add '--peer-port' input argument
Hello: This patch was applied to netdev/net-next.git (main) by Jakub Kicinski : On Tue, 23 Jan 2024 10:27:50 +0300 you wrote: > Implement port for given CID as input argument instead of using > hardcoded value '1234'. This allows to run different test instances > on a single CID. Port argument is not required parameter and if it is > not set, then default value will be '1234' - thus we preserve previous > behaviour. > > Signed-off-by: Arseniy Krasnov > > [...] Here is the summary with links: - [net-next,v2] vsock/test: add '--peer-port' input argument https://git.kernel.org/netdev/net-next/c/e18c709230cb You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
Re: [PATCH net-next v3] vsock/virtio: use skb_frag_*() helpers
Hello: This patch was applied to netdev/net-next.git (main) by Jakub Kicinski : On Tue, 2 Jan 2024 12:59:04 -0800 you wrote: > Minor fix for virtio: code wanting to access the fields inside an skb > frag should use the skb_frag_*() helpers, instead of accessing the > fields directly. This allows for extensions where the underlying > memory is not a page. > > Acked-by: Stefano Garzarella > Signed-off-by: Mina Almasry > > [...] Here is the summary with links: - [net-next,v3] vsock/virtio: use skb_frag_*() helpers https://git.kernel.org/netdev/net-next/c/06d9b446c4d4 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
Re: [PATCH V1] net: qrtr: ns: Return 0 if server port is not present
Hello: This patch was applied to netdev/net.git (main) by David S. Miller : On Thu, 21 Dec 2023 15:36:51 +0530 you wrote: > When a 'DEL_CLIENT' message is received from the remote, the corresponding > server port gets deleted. A DEL_SERVER message is then announced for this > server. As part of handling the subsequent DEL_SERVER message, the name- > server attempts to delete the server port which results in a '-ENOENT' error. > The return value from server_del() is then propagated back to qrtr_ns_worker, > causing excessive error prints. > To address this, return 0 from control_cmd_del_server() without checking the > return value of server_del(), since the above scenario is not an error case > and hence server_del() doesn't have any other error return value. > > [...] Here is the summary with links: - [V1] net: qrtr: ns: Return 0 if server port is not present https://git.kernel.org/netdev/net/c/9bf2e9165f90 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
Re: [PATCH net-next v10 0/3] send credit update during setting SO_RCVLOWAT
Hello: This series was applied to netdev/net-next.git (main) by David S. Miller : On Thu, 14 Dec 2023 15:52:27 +0300 you wrote: > Hello, > >DESCRIPTION > > This patchset fixes old problem with hungup of both rx/tx sides and adds > test for it. This happens due to non-default SO_RCVLOWAT value and > deferred credit update in virtio/vsock. Link to previous old patchset: > https://lore.kernel.org/netdev/39b2e9fd-601b-189d-39a9-914e55745...@sberdevices.ru/ > > [...] Here is the summary with links: - [net-next,v10,1/3] virtio/vsock: fix logic which reduces credit update messages https://git.kernel.org/netdev/net-next/c/93b808876682 - [net-next,v10,2/3] virtio/vsock: send credit update during setting SO_RCVLOWAT https://git.kernel.org/netdev/net-next/c/0fe179896811 - [net-next,v10,3/3] vsock/test: two tests to check credit update logic https://git.kernel.org/netdev/net-next/c/542e893fbadc You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
Re: [PATCH v2] vsock/virtio: Fix unsigned integer wrap around in virtio_transport_has_space()
Hello: This patch was applied to netdev/net.git (main) by Jakub Kicinski : On Mon, 11 Dec 2023 19:23:17 +0300 you wrote: > We need to do signed arithmetic if we expect condition > `if (bytes < 0)` to be possible > > Found by Linux Verification Center (linuxtesting.org) with SVACE > > Fixes: 06a8fc78367d ("VSOCK: Introduce virtio_vsock_common.ko") > Signed-off-by: Nikolay Kuratov > > [...] Here is the summary with links: - [v2] vsock/virtio: Fix unsigned integer wrap around in virtio_transport_has_space() https://git.kernel.org/netdev/net/c/60316d7f10b1 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
Re: [PATCH net] vsock/virtio: fix "comparison of distinct pointer types lacks a cast" warning
Hello: This patch was applied to netdev/net.git (main) by Jakub Kicinski : On Wed, 6 Dec 2023 17:41:43 +0100 you wrote: > After backporting commit 581512a6dc93 ("vsock/virtio: MSG_ZEROCOPY > flag support") in CentOS Stream 9, CI reported the following error: > > In file included from ./include/linux/kernel.h:17, > from ./include/linux/list.h:9, > from ./include/linux/preempt.h:11, > from ./include/linux/spinlock.h:56, > from net/vmw_vsock/virtio_transport_common.c:9: > net/vmw_vsock/virtio_transport_common.c: In function > ‘virtio_transport_can_zcopy‘: > ./include/linux/minmax.h:20:35: error: comparison of distinct pointer > types lacks a cast [-Werror] >20 | (!!(sizeof((typeof(x) *)1 == (typeof(y) *)1))) > | ^~ > ./include/linux/minmax.h:26:18: note: in expansion of macro ‘__typecheck‘ >26 | (__typecheck(x, y) && __no_side_effects(x, y)) > | ^~~ > ./include/linux/minmax.h:36:31: note: in expansion of macro ‘__safe_cmp‘ >36 | __builtin_choose_expr(__safe_cmp(x, y), \ > | ^~ > ./include/linux/minmax.h:45:25: note: in expansion of macro > ‘__careful_cmp‘ >45 | #define min(x, y) __careful_cmp(x, y, <) > | ^ > net/vmw_vsock/virtio_transport_common.c:63:37: note: in expansion of > macro ‘min‘ >63 | int pages_to_send = min(pages_in_iov, > MAX_SKB_FRAGS); > > [...] Here is the summary with links: - [net] vsock/virtio: fix "comparison of distinct pointer types lacks a cast" warning https://git.kernel.org/netdev/net/c/b0a930e8d90c You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
Re: [PATCH net v1] vsock/test: fix SEQPACKET message bounds test
Hello: This patch was applied to netdev/net.git (main) by Jakub Kicinski : On Wed, 22 Nov 2023 00:16:42 +0300 you wrote: > Tune message length calculation to make this test work on machines > where 'getpagesize()' returns >32KB. Now maximum message length is not > hardcoded (on machines above it was smaller than 'getpagesize()' return > value, thus we get negative value and test fails), but calculated at > runtime and always bigger than 'getpagesize()' result. Reproduced on > aarch64 with 64KB page size. > > [...] Here is the summary with links: - [net,v1] vsock/test: fix SEQPACKET message bounds test https://git.kernel.org/netdev/net/c/f0863888f6cf You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
Re: [PATCH net v2] virtio/vsock: Fix uninit-value in virtio_transport_recv_pkt()
Hello: This patch was applied to netdev/net.git (main) by Jakub Kicinski : On Sun, 5 Nov 2023 00:05:31 +0900 you wrote: > KMSAN reported the following uninit-value access issue: > > = > BUG: KMSAN: uninit-value in virtio_transport_recv_pkt+0x1dfb/0x26a0 > net/vmw_vsock/virtio_transport_common.c:1421 > virtio_transport_recv_pkt+0x1dfb/0x26a0 > net/vmw_vsock/virtio_transport_common.c:1421 > vsock_loopback_work+0x3bb/0x5a0 net/vmw_vsock/vsock_loopback.c:120 > process_one_work kernel/workqueue.c:2630 [inline] > process_scheduled_works+0xff6/0x1e60 kernel/workqueue.c:2703 > worker_thread+0xeca/0x14d0 kernel/workqueue.c:2784 > kthread+0x3cc/0x520 kernel/kthread.c:388 > ret_from_fork+0x66/0x80 arch/x86/kernel/process.c:147 > ret_from_fork_asm+0x11/0x20 arch/x86/entry/entry_64.S:304 > > [...] Here is the summary with links: - [net,v2] virtio/vsock: Fix uninit-value in virtio_transport_recv_pkt() https://git.kernel.org/netdev/net/c/34c4effacfc3 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
Re: [PATCH net 0/4] vsock: fix server prevents clients from reconnecting
Hello: This series was applied to netdev/net.git (main) by David S. Miller : On Fri, 3 Nov 2023 18:55:47 +0100 you wrote: > From: Filippo Storniolo > > This patch series introduce fix and tests for the following vsock bug: > If the same remote peer, using the same port, tries to connect > to a server on a listening port more than once, the server will > reject the connection, causing a "connection reset by peer" > error on the remote peer. This is due to the presence of a > dangling socket from a previous connection in both the connected > and bound socket lists. > The inconsistency of the above lists only occurs when the remote > peer disconnects and the server remains active. > This bug does not occur when the server socket is closed. > > [...] Here is the summary with links: - [net,1/4] vsock/virtio: remove socket from connected/bound list on shutdown https://git.kernel.org/netdev/net/c/3a5cc90a4d17 - [net,2/4] test/vsock fix: add missing check on socket creation https://git.kernel.org/netdev/net/c/bfada5a7672f - [net,3/4] test/vsock: refactor vsock_accept https://git.kernel.org/netdev/net/c/84d5fb974131 - [net,4/4] test/vsock: add dobule bind connect test https://git.kernel.org/netdev/net/c/d80f63f69025 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
Re: [PATCH] neighbor: tracing: Move pin6 inside CONFIG_IPV6=y section
Hello: This patch was applied to netdev/net.git (main) by David S. Miller : On Mon, 16 Oct 2023 14:49:04 +0200 you wrote: > When CONFIG_IPV6=n, and building with W=1: > > In file included from include/trace/define_trace.h:102, >from include/trace/events/neigh.h:255, >from net/core/net-traces.c:51: > include/trace/events/neigh.h: In function > ‘trace_event_raw_event_neigh_create’: > include/trace/events/neigh.h:42:34: error: variable ‘pin6’ set but not > used [-Werror=unused-but-set-variable] >42 | struct in6_addr *pin6; > | ^~~~ > include/trace/trace_events.h:402:11: note: in definition of macro > ‘DECLARE_EVENT_CLASS’ > 402 | { assign; } > \ > | ^~ > include/trace/trace_events.h:44:30: note: in expansion of macro ‘PARAMS’ >44 | PARAMS(assign), \ > | ^~ > include/trace/events/neigh.h:23:1: note: in expansion of macro > ‘TRACE_EVENT’ >23 | TRACE_EVENT(neigh_create, > | ^~~ > include/trace/events/neigh.h:41:9: note: in expansion of macro > ‘TP_fast_assign’ >41 | TP_fast_assign( > | ^~ > In file included from include/trace/define_trace.h:103, >from include/trace/events/neigh.h:255, >from net/core/net-traces.c:51: > include/trace/events/neigh.h: In function ‘perf_trace_neigh_create’: > include/trace/events/neigh.h:42:34: error: variable ‘pin6’ set but not > used [-Werror=unused-but-set-variable] >42 | struct in6_addr *pin6; > | ^~~~ > include/trace/perf.h:51:11: note: in definition of macro > ‘DECLARE_EVENT_CLASS’ >51 | { assign; } > \ > | ^~ > include/trace/trace_events.h:44:30: note: in expansion of macro ‘PARAMS’ >44 | PARAMS(assign), \ > | ^~ > include/trace/events/neigh.h:23:1: note: in expansion of macro > ‘TRACE_EVENT’ >23 | TRACE_EVENT(neigh_create, > | ^~~ > include/trace/events/neigh.h:41:9: note: in expansion of macro > ‘TP_fast_assign’ >41 | TP_fast_assign( > | ^~ > > [...] Here is the summary with links: - neighbor: tracing: Move pin6 inside CONFIG_IPV6=y section https://git.kernel.org/netdev/net/c/2915240eddba You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
Re: [PATCH bpf-next] bpf: change syscall_nr type to int in struct syscall_tp_t
Hello: This patch was applied to bpf/bpf-next.git (master) by Andrii Nakryiko : On Fri, 13 Oct 2023 07:42:19 +0200 you wrote: > linux-rt-devel tree contains a patch (b1773eac3f29c ("sched: Add support > for lazy preemption")) that adds an extra member to struct trace_entry. > This causes the offset of args field in struct trace_event_raw_sys_enter > be different from the one in struct syscall_trace_enter: > > struct trace_event_raw_sys_enter { > struct trace_entry ent; /* 012 */ > > [...] Here is the summary with links: - [bpf-next] bpf: change syscall_nr type to int in struct syscall_tp_t https://git.kernel.org/bpf/bpf-next/c/ba8ea72388a1 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
Re: [PATCH] net: appletalk: remove cops support
Hello: This patch was applied to netdev/net-next.git (main) by Jakub Kicinski : On Wed, 27 Sep 2023 11:00:30 +0200 you wrote: > The COPS Appletalk support is very old, never said to actually work > properly, and the firmware code for the devices are under a very suspect > license. Remove it all to clear up the license issue, if it is still > needed and actually used by anyone, we can add it back later once the > license is cleared up. > > Reported-by: Prarit Bhargava > Cc: Christoph Hellwig > Cc: Vitaly Kuznetsov > Cc: jsch...@samba.org > Signed-off-by: Greg Kroah-Hartman > > [...] Here is the summary with links: - net: appletalk: remove cops support https://git.kernel.org/netdev/net-next/c/00f3696f7555 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
Re: [PATCH] selftests/net: Improve bind_bhash.sh to accommodate predictable network interface names
Hello: This patch was applied to netdev/net.git (main) by David S. Miller : On Thu, 7 Sep 2023 00:26:03 +0800 you wrote: > Starting with v197, systemd uses predictable interface network names, > the traditional interface naming scheme (eth0) is deprecated, therefore > it cannot be assumed that the eth0 interface exists on the host. > > This modification makes the bind_bhash test program run in a separate > network namespace and no longer needs to consider the name of the > network interface on the host. > > [...] Here is the summary with links: - selftests/net: Improve bind_bhash.sh to accommodate predictable network interface names https://git.kernel.org/netdev/net/c/ced33ca07d8d You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
Re: [PATCH net] net: marvell: prestera: fix port event handling on init
Hello: This patch was applied to netdev/net.git (refs/heads/master): On Tue, 20 Apr 2021 16:31:51 +0300 you wrote: > From: Vadym Kochan > > For some reason there might be a crash during ports creation if port > events are handling at the same time because fw may send initial > port event with down state. > > The crash points to cancel_delayed_work() which is called when port went > is down. Currently I did not find out the real cause of the issue, so > fixed it by cancel port stats work only if previous port's state was up > & runnig. > > [...] Here is the summary with links: - [net] net: marvell: prestera: fix port event handling on init https://git.kernel.org/netdev/net/c/333980481b99 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
Re: [PATCH] net: davinci_emac: Fix incorrect masking of tx and rx error channel
Hello: This patch was applied to netdev/net.git (refs/heads/master): On Tue, 20 Apr 2021 18:16:14 +0100 you wrote: > From: Colin Ian King > > The bit-masks used for the TXERRCH and RXERRCH (tx and rx error channels) > are incorrect and always lead to a zero result. The mask values are > currently the incorrect post-right shifted values, fix this by setting > them to the currect values. > > [...] Here is the summary with links: - net: davinci_emac: Fix incorrect masking of tx and rx error channel https://git.kernel.org/netdev/net/c/d83b8aa5207d You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
Re: [PATCH][next] net: mana: remove redundant initialization of variable err
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Tue, 20 Apr 2021 13:27:30 +0100 you wrote: > From: Colin Ian King > > The variable err is being initialized with a value that is > never read and it is being updated later with a new value. The > initialization is redundant and can be removed > > Addresses-Coverity: ("Unused value") > Signed-off-by: Colin Ian King > > [...] Here is the summary with links: - [next] net: mana: remove redundant initialization of variable err https://git.kernel.org/netdev/net-next/c/55cdc26a91ac You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
Re: [PATCH net-next v2] net: phy: at803x: fix probe error if copper page is selected
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Tue, 20 Apr 2021 12:29:29 +0200 you wrote: > The commit c329e5afb42f ("net: phy: at803x: select correct page on > config init") selects the copper page during probe. This fails if the > copper page was already selected. In this case, the value of the copper > page (which is 1) is propagated through phy_restore_page() and is > finally returned for at803x_probe(). Fix it, by just using the > at803x_page_write() directly. > > [...] Here is the summary with links: - [net-next,v2] net: phy: at803x: fix probe error if copper page is selected https://git.kernel.org/netdev/net-next/c/8f7e876273e2 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
Re: [PATCH net] vsock/virtio: free queued packets when closing socket
Hello: This patch was applied to netdev/net.git (refs/heads/master): On Tue, 20 Apr 2021 13:07:27 +0200 you wrote: > As reported by syzbot [1], there is a memory leak while closing the > socket. We partially solved this issue with commit ac03046ece2b > ("vsock/virtio: free packets during the socket release"), but we > forgot to drain the RX queue when the socket is definitely closed by > the scheduled work. > > To avoid future issues, let's use the new virtio_transport_remove_sock() > to drain the RX queue before removing the socket from the af_vsock lists > calling vsock_remove_sock(). > > [...] Here is the summary with links: - [net] vsock/virtio: free queued packets when closing socket https://git.kernel.org/netdev/net/c/8432b8114957 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
Re: [PATCH] phy: nxp-c45-tja11xx: fix phase offset calculation
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Tue, 20 Apr 2021 16:11:33 +0300 you wrote: > Fix phase offset calculation. > > Signed-off-by: Radu Pirea (NXP OSS) > --- > drivers/net/phy/nxp-c45-tja11xx.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > [...] Here is the summary with links: - phy: nxp-c45-tja11xx: fix phase offset calculation https://git.kernel.org/netdev/net-next/c/6b3a63100ded You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
Re: [PATCH net-next] net: enetc: automatically select IERB module
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Tue, 20 Apr 2021 16:28:21 +0200 you wrote: > Now that enetc supports flow control we have to make sure the settings in > the IERB are correct. Therefore, we actually depend on the enetc-ierb > module. Previously it was possible that this module was disabled while the > enetc was enabled. Fix it by automatically select the enetc-ierb module. > > Fixes: e7d48e5fbf30 ("net: enetc: add a mini driver for the Integrated > Endpoint Register Block") > Signed-off-by: Michael Walle > > [...] Here is the summary with links: - [net-next] net: enetc: automatically select IERB module https://git.kernel.org/netdev/net-next/c/1b8caefaf4f0 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
Re: [net-next] net: dsa: felix: disable always guard band bit for TAS config
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Mon, 19 Apr 2021 18:25:30 +0800 you wrote: > ALWAYS_GUARD_BAND_SCH_Q bit in TAS config register is descripted as > this: > 0: Guard band is implemented for nonschedule queues to schedule > queues transition. > 1: Guard band is implemented for any queue to schedule queue > transition. > > [...] Here is the summary with links: - [net-next] net: dsa: felix: disable always guard band bit for TAS config https://git.kernel.org/netdev/net-next/c/316bcffe4479 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
Re: [PATCH v3 0/2] TJA1103 driver
Hello: This series was applied to netdev/net-next.git (refs/heads/master): On Mon, 19 Apr 2021 19:13:58 +0300 you wrote: > Hi, > > This small series adds the TJA1103 PHY driver. > > Changes in v3: > - use phy_read_mmd_poll_timeout instead of spin_until_cond > - changed the phy name from a generic one to something specific > - minor indentation change > > [...] Here is the summary with links: - [v3,1/2] net: phy: add genphy_c45_pma_suspend/resume https://git.kernel.org/netdev/net-next/c/da702f34e3cc - [v3,2/2] phy: nxp-c45: add driver for tja1103 https://git.kernel.org/netdev/net-next/c/b050f2f15e04 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
Re: [PATCH RESEND net-next] net: marvell: prestera: add support for AC3X 98DX3265 device
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Sat, 17 Apr 2021 02:17:51 +0300 you wrote: > From: Vadym Kochan > > Add PCI match for AC3X 98DX3265 device which is supported by the current > driver and firmware. > > Signed-off-by: Vadym Kochan > > [...] Here is the summary with links: - [RESEND,net-next] net: marvell: prestera: add support for AC3X 98DX3265 device https://git.kernel.org/netdev/net-next/c/ced97eea3974 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
Re: [PATCH v6 net-next 00/10] net: Korina improvements
Hello: This series was applied to netdev/net-next.git (refs/heads/master): On Mon, 19 Apr 2021 00:19:38 +0200 you wrote: > While converting Mikrotik RB532 support to use device tree I stumbled > over the korina ethernet driver, which used way too many MIPS specific > hacks. This series cleans this all up and adds support for device tree. > > Changes in v6: > - remove korina from resource names and adapt DT binding to it > - removed superfluous braces around of_get_mac_address > > [...] Here is the summary with links: - [v6,net-next,01/10] net: korina: Fix MDIO functions https://git.kernel.org/netdev/net-next/c/89f9d5400b53 - [v6,net-next,02/10] net: korina: Use devres functions https://git.kernel.org/netdev/net-next/c/b4cd249a8cc0 - [v6,net-next,03/10] net: korina: Remove not needed cache flushes https://git.kernel.org/netdev/net-next/c/e42f10533d7c - [v6,net-next,04/10] net: korina: Remove nested helpers https://git.kernel.org/netdev/net-next/c/0fe632471aeb - [v6,net-next,05/10] net: korina: Use DMA API https://git.kernel.org/netdev/net-next/c/0fc96939a97f - [v6,net-next,06/10] net: korina: Only pass mac address via platform data https://git.kernel.org/netdev/net-next/c/af80425e05b2 - [v6,net-next,07/10] net: korina: Add support for device tree https://git.kernel.org/netdev/net-next/c/10b26f078151 - [v6,net-next,08/10] net: korina: Get mdio input clock via common clock framework https://git.kernel.org/netdev/net-next/c/e4cd854ec487 - [v6,net-next,09/10] net: korina: Make driver COMPILE_TESTable https://git.kernel.org/netdev/net-next/c/6ef92063bf94 - [v6,net-next,10/10] dt-bindings: net: korina: Add DT bindings for IDT 79RC3243x SoCs https://git.kernel.org/netdev/net-next/c/d1a2c2315cc9 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
Re: [PATCH net-next 1/1] net: stmmac: fix memory leak during driver probe
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Mon, 19 Apr 2021 19:25:30 +0800 you wrote: > On driver probe, kmemleak reported the following memory leak which was > due to allocated bitmap that was not being freed in stmmac_dvr_probe(). > > unreferenced object 0x9276014b13c0 (size 8): > comm "systemd-udevd", pid 2143, jiffies 4294681112 (age 116.720s) > hex dump (first 8 bytes): > 00 00 00 00 00 00 00 00 > backtrace: > [] stmmac_dvr_probe+0x1c0/0x440 [stmmac] > [ ] intel_eth_pci_probe.cold+0x2b/0x14e [dwmac_intel] > [ ] pci_device_probe+0xd2/0x150 > [ ] really_probe+0xf8/0x410 > [<34128a59>] driver_probe_device+0x5d/0x150 > [<016104d5>] device_driver_attach+0x53/0x60 > [ ] __driver_attach+0x96/0x140 > [ ] bus_for_each_dev+0x7a/0xc0 > [ ] bus_add_driver+0x184/0x1f0 > [<8be5c1c5>] driver_register+0x6c/0xc0 > [<52b18a9e>] do_one_initcall+0x4d/0x210 > [<154d4f07>] do_init_module+0x5c/0x230 > [<9b648d09>] load_module+0x2a5a/0x2d40 > [<0d86b76d>] __do_sys_finit_module+0xb5/0x120 > [<2b0cef95>] do_syscall_64+0x33/0x40 > [<67b45bbb>] entry_SYSCALL_64_after_hwframe+0x44/0xa9 > > [...] Here is the summary with links: - [net-next,1/1] net: stmmac: fix memory leak during driver probe https://git.kernel.org/netdev/net-next/c/d7f576dc9836 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
Re: [PATCH v2 net-next] net: ethernet: mediatek: fix a typo bug in flow offloading
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Sat, 17 Apr 2021 15:29:04 +0800 you wrote: > Issue was traffic problems after a while with increased ping times if > flow offload is active. It turns out that key_offset with cookie is > needed in rhashtable_params but was re-assigned to head_offset. > Fix the assignment. > > Fixes: 502e84e2382d ("net: ethernet: mtk_eth_soc: add flow offloading > support") > Signed-off-by: DENG Qingfang > > [...] Here is the summary with links: - [v2,net-next] net: ethernet: mediatek: fix a typo bug in flow offloading https://git.kernel.org/netdev/net-next/c/6ecaf81d4ac6 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
Re: [PATCH net-next] net: xilinx: drivers need/depend on HAS_IOMEM
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Fri, 16 Apr 2021 23:55:54 -0700 you wrote: > kernel test robot reports build errors in 3 Xilinx ethernet drivers. > They all use ioremap functions that are only available when HAS_IOMEM > is set/enabled. If it is not enabled, they all have build errors, > so make these 3 drivers depend on HAS_IOMEM. > > ld: drivers/net/ethernet/xilinx/xilinx_emaclite.o: in function > `xemaclite_of_probe': > xilinx_emaclite.c:(.text+0x9fc): undefined reference to > `devm_ioremap_resource' > > [...] Here is the summary with links: - [net-next] net: xilinx: drivers need/depend on HAS_IOMEM https://git.kernel.org/netdev/net-next/c/46fd4471615c You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
Re: [PATCH net-next 0/2] net: ipa: allow different firmware names
Hello: This series was applied to netdev/net-next.git (refs/heads/master): On Fri, 16 Apr 2021 08:08:48 -0500 you wrote: > Add the ability to define a "firmware-name" property in the IPA DT > node, specifying an alternate name to use for the firmware file. > Used only if the AP (Trust Zone) does early IPA initialization. > > -Alex > > Alex Elder (2): > dt-bindings: net: qcom,ipa: add firmware-name property > net: ipa: optionally define firmware name via DT > > [...] Here is the summary with links: - [net-next,1/2] dt-bindings: net: qcom,ipa: add firmware-name property https://git.kernel.org/netdev/net-next/c/d8604b209e9b - [net-next,2/2] net: ipa: optionally define firmware name via DT https://git.kernel.org/netdev/net-next/c/9ce062ba6a8d You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
Re: [PATCH V2 net-next] net: mvpp2: Add parsing support for different IPv4 IHL values
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Fri, 16 Apr 2021 11:15:17 +0300 you wrote: > From: Stefan Chulski > > Add parser entries for different IPv4 IHL values. > Each entry will set the L4 header offset according to the IPv4 IHL field. > L3 header offset will set during the parsing of the IPv4 protocol. > > Because of missed parser support for IP header length > 20, RX IPv4 checksum > HW offload fails > and skb->ip_summed set to CHECKSUM_NONE(checksum done by Network stack). > This patch adds RX IPv4 checksum HW offload capability for frames with IP > header length > 20. > > [...] Here is the summary with links: - [V2,net-next] net: mvpp2: Add parsing support for different IPv4 IHL values https://git.kernel.org/netdev/net-next/c/4ad29b1a484e You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
Re: [PATCH net-next 0/6] r8152: support new chips
Hello: This series was applied to netdev/net-next.git (refs/heads/master): On Fri, 16 Apr 2021 16:04:31 +0800 you wrote: > Support new RTL8153 and RTL8156 series. > > Hayes Wang (6): > r8152: set inter fram gap time depending on speed > r8152: adjust rtl8152_check_firmware function > r8152: add help function to change mtu > r8152: support new chips > r8152: support PHY firmware for RTL8156 series > r8152: search the configuration of vendor mode > > [...] Here is the summary with links: - [net-next,1/6] r8152: set inter fram gap time depending on speed https://git.kernel.org/netdev/net-next/c/5133bcc74815 - [net-next,2/6] r8152: adjust rtl8152_check_firmware function https://git.kernel.org/netdev/net-next/c/a8a7be178e81 - [net-next,3/6] r8152: add help function to change mtu https://git.kernel.org/netdev/net-next/c/67ce1a806f16 - [net-next,4/6] r8152: support new chips https://git.kernel.org/netdev/net-next/c/195aae321c82 - [net-next,5/6] r8152: support PHY firmware for RTL8156 series https://git.kernel.org/netdev/net-next/c/4a51b0e8a014 - [net-next,6/6] r8152: search the configuration of vendor mode https://git.kernel.org/netdev/net-next/c/c2198943e33b You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
Re: [PATCH net-next,v3] net: ethernet: mediatek: ppe: fix busy wait loop
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Thu, 15 Apr 2021 17:37:48 -0700 you wrote: > The intention is for the loop to timeout if the body does not succeed. > The current logic calls time_is_before_jiffies(timeout) which is false > until after the timeout, so the loop body never executes. > > Fix by using readl_poll_timeout as a more standard and less error-prone > solution. > > [...] Here is the summary with links: - [net-next,v3] net: ethernet: mediatek: ppe: fix busy wait loop https://git.kernel.org/netdev/net-next/c/c5d66587b890 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
Re: [PATCH net-next v6] atl1c: move tx cleanup processing out of interrupt
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Wed, 14 Apr 2021 22:09:20 +0300 you wrote: > Tx queue cleanup happens in interrupt handler on same core as rx queue > processing. Both can take considerable amount of processing in high > packet-per-second scenarios. > > Sending big amounts of packets can stall the rx processing which is > unfair and also can lead to out-of-memory condition since > __dev_kfree_skb_irq queues the skbs for later kfree in softirq which > is not allowed to happen with heavy load in interrupt handler. > > [...] Here is the summary with links: - [net-next,v6] atl1c: move tx cleanup processing out of interrupt https://git.kernel.org/netdev/net-next/c/a1150a04b7e8 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
Re: [PATCH net v3] i40e: fix the panic when running bpf in xdpdrv mode
Hello: This patch was applied to netdev/net.git (refs/heads/master): On Wed, 14 Apr 2021 10:34:28 +0800 you wrote: > From: Jason Xing > > Fix this panic by adding more rules to calculate the value of @rss_size_max > which could be used in allocating the queues when bpf is loaded, which, > however, could cause the failure and then trigger the NULL pointer of > vsi->rx_rings. Prio to this fix, the machine doesn't care about how many > cpus are online and then allocates 256 queues on the machine with 32 cpus > online actually. > > [...] Here is the summary with links: - [net,v3] i40e: fix the panic when running bpf in xdpdrv mode https://git.kernel.org/netdev/net/c/4e39a072a6a0 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
Re: [PATCH net-next] net: enetc: fetch MAC address from device tree
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Wed, 14 Apr 2021 16:48:14 +0200 you wrote: > Normally, the bootloader will already initialize the MAC address > registers of the ENETC and the driver will just use them or generate a > random one, if it is not initialized. > > Add a new way to provide the MAC address: via device tree. Besides the > usual 'mac-address' property, there is also the possibility to fetch it > via a NVMEM provider. The sl28 board stores the MAC address in the SPI > NOR flash OTP region. Having this will allow linux to fetch the MAC > address from there without being dependent on the bootloader. > > [...] Here is the summary with links: - [net-next] net: enetc: fetch MAC address from device tree https://git.kernel.org/netdev/net-next/c/652d3be21dc8 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
Re: [PATCH] sfc: Remove duplicate argument
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Wed, 14 Apr 2021 19:06:45 +0800 you wrote: > Fix the following coccicheck warning: > > ./drivers/net/ethernet/sfc/enum.h:80:7-28: duplicated argument to | > > Signed-off-by: Wan Jiabing > --- > drivers/net/ethernet/sfc/enum.h | 1 - > 1 file changed, 1 deletion(-) Here is the summary with links: - sfc: Remove duplicate argument https://git.kernel.org/netdev/net-next/c/ace8d281aa71 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
Re: [PATCH] net: macb: fix the restore of cmp registers
Hello: This patch was applied to netdev/net.git (refs/heads/master): On Wed, 14 Apr 2021 14:20:29 +0300 you wrote: > Commit a14d273ba159 ("net: macb: restore cmp registers on resume path") > introduces the restore of CMP registers on resume path. In case the IP > doesn't support type 2 screeners (zero on DCFG8 register) the > struct macb::rx_fs_list::list is not initialized and thus the > list_for_each_entry(item, >rx_fs_list.list, list) loop introduced in > commit a14d273ba159 ("net: macb: restore cmp registers on resume path") > will access an uninitialized list leading to crash. Thus, initialize > the struct macb::rx_fs_list::list without taking into account if the > IP supports type 2 screeners or not. > > [...] Here is the summary with links: - net: macb: fix the restore of cmp registers https://git.kernel.org/netdev/net/c/a714e27ea8bd You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
Re: [PATCH] [net] cavium/liquidio: Fix duplicate argument
Hello: This patch was applied to netdev/net.git (refs/heads/master): On Wed, 14 Apr 2021 19:31:48 +0800 you wrote: > Fix the following coccicheck warning: > > ./drivers/net/ethernet/cavium/liquidio/cn66xx_regs.h:413:6-28: > duplicated argument to & or | > > The CN6XXX_INTR_M1UPB0_ERR here is duplicate. > Here should be CN6XXX_INTR_M1UNB0_ERR. > > [...] Here is the summary with links: - [net] cavium/liquidio: Fix duplicate argument https://git.kernel.org/netdev/net/c/416dcc5ce9d2 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
Re: [PATCH net-next v2 0/3] net: phy: marvell-88x2222: a couple of improvements
Hello: This series was applied to netdev/net-next.git (refs/heads/master): On Tue, 13 Apr 2021 23:54:49 +0300 you wrote: > First, there are some SFP modules that only uses RX_LOS for link > indication. Add check that link is operational before actual read of > line-side status. > > Second, it is invalid to set 10G speed without autonegotiation, > according to phy_ethtool_ksettings_set(). Implement switching between > 10GBase-R and 1000Base-X/SGMII if autonegotiation can't complete but > there is signal in line. > > [...] Here is the summary with links: - [net-next,v2,1/3] net: phy: marvell-88x: check that link is operational https://git.kernel.org/netdev/net-next/c/58581478a734 - [net-next,v2,2/3] net: phy: marvell-88x: move read_status after config_aneg https://git.kernel.org/netdev/net-next/c/473960a7b443 - [net-next,v2,3/3] net: phy: marvell-88x: swap 1G/10G modes on autoneg https://git.kernel.org/netdev/net-next/c/d7029f55cc46 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
Re: [PATCH net-next v4 1/1] net: stmmac: Add support for external trigger timestamping
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Wed, 14 Apr 2021 08:16:17 +0800 you wrote: > From: Tan Tee Min > > The Synopsis MAC controller supports auxiliary snapshot feature that > allows user to store a snapshot of the system time based on an external > event. > > This patch add supports to the above mentioned feature. Users will be > able to triggered capturing the time snapshot from user-space using > application such as testptp or any other applications that uses the > PTP_EXTTS_REQUEST ioctl request. > > [...] Here is the summary with links: - [net-next,v4,1/1] net: stmmac: Add support for external trigger timestamping https://git.kernel.org/netdev/net-next/c/f4da56529da6 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
Re: [PATCH net-next 0/2] net: ipa: add support for the SM8350 SoC
Hello: This series was applied to netdev/net-next.git (refs/heads/master): On Tue, 13 Apr 2021 11:38:24 -0500 you wrote: > This small series adds IPA driver support for the Qualcomm SM8350 > SoC, which implements IPA v4.9. > > The first patch updates the DT binding, and depends on a previous > patch that has already been accepted into net-next. > > The second just defines the IPA v4.9 configuration data file. > > [...] Here is the summary with links: - [net-next,1/2] dt-bindings: net: qcom,ipa: add support for SM8350 https://git.kernel.org/netdev/net-next/c/15c88e185eb9 - [net-next,2/2] net: ipa: add IPA v4.9 configuration data https://git.kernel.org/netdev/net-next/c/e557dc82418d You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
Re: [PATCH net-next v2 0/7] stmmac: add XDP ZC support
Hello: This series was applied to netdev/net-next.git (refs/heads/master): On Tue, 13 Apr 2021 17:36:19 +0800 you wrote: > Hi, > > This is the v2 patch series to add XDP ZC support to stmmac driver. > > Summary of v2 patch change:- > > 6/7: fix synchronize_rcu() is called stmmac_disable_all_queues() that is > used by ndo_setup_tc(). > > [...] Here is the summary with links: - [net-next,v2,1/7] net: stmmac: rearrange RX buffer allocation and free functions https://git.kernel.org/netdev/net-next/c/4298255f26fa - [net-next,v2,2/7] net: stmmac: introduce dma_recycle_rx_skbufs for stmmac_reinit_rx_buffers https://git.kernel.org/netdev/net-next/c/80f573c995fc - [net-next,v2,3/7] net: stmmac: refactor stmmac_init_rx_buffers for stmmac_reinit_rx_buffers https://git.kernel.org/netdev/net-next/c/da5ec7f22a0f - [net-next,v2,4/7] net: stmmac: rearrange RX and TX desc init into per-queue basis https://git.kernel.org/netdev/net-next/c/de0b90e52a11 - [net-next,v2,5/7] net: stmmac: Refactor __stmmac_xdp_run_prog for XDP ZC https://git.kernel.org/netdev/net-next/c/bba71cac680f - [net-next,v2,6/7] net: stmmac: Enable RX via AF_XDP zero-copy https://git.kernel.org/netdev/net-next/c/bba2556efad6 - [net-next,v2,7/7] net: stmmac: Add TX via XDP zero-copy socket https://git.kernel.org/netdev/net-next/c/132c32ee5bc0 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
Re: [PATCH v2] net/sctp: fix race condition in sctp_destroy_sock
Hello: This patch was applied to netdev/net.git (refs/heads/master): On Tue, 13 Apr 2021 21:10:31 +0300 you wrote: > If sctp_destroy_sock is called without sock_net(sk)->sctp.addr_wq_lock > held and sp->do_auto_asconf is true, then an element is removed > from the auto_asconf_splist without any proper locking. > > This can happen in the following functions: > 1. In sctp_accept, if sctp_sock_migrate fails. > 2. In inet_create or inet6_create, if there is a bpf program >attached to BPF_CGROUP_INET_SOCK_CREATE which denies >creation of the sctp socket. > > [...] Here is the summary with links: - [v2] net/sctp: fix race condition in sctp_destroy_sock https://git.kernel.org/netdev/net/c/b166a20b0738 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
Re: [PATCH] rsi: remove unused including
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Tue, 13 Apr 2021 17:46:12 +0800 you wrote: > Fix the following versioncheck warning: > ./drivers/net/wireless/rsi/rsi_91x_ps.c: 19 linux/version.h not needed. > > Reported-by: Abaci Robot > Signed-off-by: Yang Li > --- > drivers/net/wireless/rsi/rsi_91x_ps.c | 1 - > 1 file changed, 1 deletion(-) Here is the summary with links: - rsi: remove unused including https://git.kernel.org/netdev/net-next/c/46568170036d You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
Re: [PATCH] nfc: st-nci: remove unnecessary label
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Tue, 13 Apr 2021 17:45:30 +0800 you wrote: > From: wengjianfeng > > in st_nci_spi_write function, first assign a value to a variable then > goto exit label. return statement just follow the label and exit label > just used once, so we should directly return and remove exit label. > > Signed-off-by: wengjianfeng > > [...] Here is the summary with links: - nfc: st-nci: remove unnecessary label https://git.kernel.org/netdev/net-next/c/eba43fac8dfa You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
Re: [PATCH net-next v4 0/2] of: net: support non-platform devices in of_get_mac_address()
Hello: This series was applied to netdev/net-next.git (refs/heads/master): On Mon, 12 Apr 2021 19:47:16 +0200 you wrote: > of_get_mac_address() is commonly used to fetch the MAC address > from the device tree. It also supports reading it from a NVMEM > provider. But the latter is only possible for platform devices, > because only platform devices are searched for a matching device > node. > > Add a second method to fetch the NVMEM cell by a device tree node > instead of a "struct device". > > [...] Here is the summary with links: - [net-next,v4,1/2] of: net: pass the dst buffer to of_get_mac_address() https://git.kernel.org/netdev/net-next/c/83216e3988cd - [net-next,v4,2/2] of: net: fix of_get_mac_addr_nvmem() for non-platform devices https://git.kernel.org/netdev/net-next/c/f10843e04a07 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
Re: [PATCH bpf-next v2] libbpf: clarify flags in ringbuf helpers
Hello: This patch was applied to bpf/bpf-next.git (refs/heads/master): On Mon, 12 Apr 2021 16:24:32 -0300 you wrote: > In 'bpf_ringbuf_reserve()' we require the flag to '0' at the moment. > > For 'bpf_ringbuf_{discard,submit,output}' a flag of '0' might send a > notification to the process if needed. > > Signed-off-by: Pedro Tammela > > [...] Here is the summary with links: - [bpf-next,v2] libbpf: clarify flags in ringbuf helpers https://git.kernel.org/bpf/bpf-next/c/5c507329000e You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
Re: [PATCH v2] net: phy: marvell: fix detection of PHY on Topaz switches
Hello: This patch was applied to netdev/net.git (refs/heads/master): On Mon, 12 Apr 2021 18:57:39 +0200 you wrote: > Since commit fee2d546414d ("net: phy: marvell: mv88e6390 temperature > sensor reading"), Linux reports the temperature of Topaz hwmon as > constant -75°C. > > This is because switches from the Topaz family (88E6141 / 88E6341) have > the address of the temperature sensor register different from Peridot. > > [...] Here is the summary with links: - [v2] net: phy: marvell: fix detection of PHY on Topaz switches https://git.kernel.org/netdev/net/c/1fe976d308ac You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
Re: [PATCH V4 1/2] dt-bindings: net: renesas,etheravb: Add additional clocks
Hello: This series was applied to netdev/net-next.git (refs/heads/master): On Mon, 12 Apr 2021 08:26:18 -0500 you wrote: > The AVB driver assumes there is an external crystal, but it could > be clocked by other means. In order to enable a programmable > clock, it needs to be added to the clocks list and enabled in the > driver. Since there currently only one clock, there is no > clock-names list either. > > Update bindings to add the additional optional clock, and explicitly > name both of them. > > [...] Here is the summary with links: - [V4,1/2] dt-bindings: net: renesas,etheravb: Add additional clocks https://git.kernel.org/netdev/net-next/c/6f43735b6da6 - [V4,2/2] net: ethernet: ravb: Enable optional refclk https://git.kernel.org/netdev/net-next/c/8ef7adc6beb2 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
Re: [PATCH v2] nfc: pn533: remove redundant assignment
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Mon, 12 Apr 2021 10:20:06 +0800 you wrote: > From: wengjianfeng > > In many places,first assign a value to a variable and then return > the variable. which is redundant, we should directly return the value. > in pn533_rf_field funciton,return rc also in the if statement, so we > use return 0 to replace the last return rc. > > [...] Here is the summary with links: - [v2] nfc: pn533: remove redundant assignment https://git.kernel.org/netdev/net-next/c/a115d24a636e You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
Re: [PATCH] cxgb4: Fix unintentional sign extension issues
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Fri, 9 Apr 2021 12:08:57 +0100 you wrote: > From: Colin Ian King > > The shifting of the u8 integers f->fs.nat_lip[] by 24 bits to > the left will be promoted to a 32 bit signed int and then > sign-extended to a u64. In the event that the top bit of the u8 > is set then all then all the upper 32 bits of the u64 end up as > also being set because of the sign-extension. Fix this by > casting the u8 values to a u64 before the 24 bit left shift. > > [...] Here is the summary with links: - cxgb4: Fix unintentional sign extension issues https://git.kernel.org/netdev/net-next/c/dd2c79677375 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
Re: [PATCH][next] net: hns3: Fix potential null pointer defererence of null ae_dev
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Fri, 9 Apr 2021 17:37:26 +0100 you wrote: > From: Colin Ian King > > The reset_prepare and reset_done calls have a null pointer check > on ae_dev however ae_dev is being dereferenced via the call to > ns3_is_phys_func with the ae->pdev argument. Fix this by performing > a null pointer check on ae_dev and hence short-circuiting the > dereference to ae_dev on the call to ns3_is_phys_func. > > [...] Here is the summary with links: - [next] net: hns3: Fix potential null pointer defererence of null ae_dev https://git.kernel.org/netdev/net-next/c/d0494135f94c You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
Re: [PATCH net] net: seg6: trivial fix of a spelling mistake in comment
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Sat, 10 Apr 2021 19:46:14 +0200 you wrote: > There is a comment spelling mistake "interfarence" -> "interference" in > function parse_nla_action(). Fix it. > > Signed-off-by: Andrea Mayer > --- > net/ipv6/seg6_local.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Here is the summary with links: - [net] net: seg6: trivial fix of a spelling mistake in comment https://git.kernel.org/netdev/net-next/c/0d7703605778 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
Re: [PATCH] net: thunderx: Fix unintentional sign extension issue
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Fri, 9 Apr 2021 14:07:26 +0100 you wrote: > From: Colin Ian King > > The shifting of the u8 integers rq->caching by 26 bits to > the left will be promoted to a 32 bit signed int and then > sign-extended to a u64. In the event that rq->caching is > greater than 0x1f then all then all the upper 32 bits of > the u64 end up as also being set because of the int > sign-extension. Fix this by casting the u8 values to a > u64 before the 26 bit left shift. > > [...] Here is the summary with links: - net: thunderx: Fix unintentional sign extension issue https://git.kernel.org/netdev/net-next/c/e701a2584036 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
Re: [PATCH net-next 0/4] net: ipa: support two more platforms
Hello: This series was applied to netdev/net-next.git (refs/heads/master): On Fri, 9 Apr 2021 15:40:20 -0500 you wrote: > This series adds IPA support for two more Qualcomm SoCs. > > The first patch updates the DT binding to add compatible strings. > > The second temporarily disables checksum offload support for IPA > version 4.5 and above. Changes are required to the RMNet driver > to support the "inline" checksum offload used for IPA v4.5+, and > once those are present this capability will be enabled for IPA. > > [...] Here is the summary with links: - [net-next,1/4] dt-bindings: net: qcom,ipa: add some compatible strings https://git.kernel.org/netdev/net-next/c/c3264fee72e7 - [net-next,2/4] net: ipa: disable checksum offload for IPA v4.5+ https://git.kernel.org/netdev/net-next/c/c88c34fcf8f5 - [net-next,3/4] net: ipa: add IPA v4.5 configuration data https://git.kernel.org/netdev/net-next/c/fbb763e7e736 - [net-next,4/4] net: ipa: add IPA v4.11 configuration data https://git.kernel.org/netdev/net-next/c/927c5043459e You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
Re: [PATCH] net: geneve: check skb is large enough for IPv4/IPv6 header
Hello: This patch was applied to netdev/net.git (refs/heads/master): On Sun, 11 Apr 2021 12:28:24 +0100 you wrote: > Check within geneve_xmit_skb/geneve6_xmit_skb that sk_buff structure > is large enough to include IPv4 or IPv6 header, and reject if not. The > geneve_xmit_skb portion and overall idea was contributed by Eric Dumazet. > Fixes a KMSAN-found uninit-value bug reported by syzbot at: > https://syzkaller.appspot.com/bug?id=abe95dc3e3e9667fc23b8d81f29ecad95c6f106f > > Suggested-by: Eric Dumazet > Reported-by: syzbot+2e406a9ac75bb71d4...@syzkaller.appspotmail.com > Signed-off-by: Phillip Potter > > [...] Here is the summary with links: - net: geneve: check skb is large enough for IPv4/IPv6 header https://git.kernel.org/netdev/net/c/6628ddfec758 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
Re: [PATCH] net: davicom: Fix regulator not turned off on failed probe
Hello: This patch was applied to netdev/net.git (refs/heads/master): On Sun, 11 Apr 2021 11:02:08 +0200 you wrote: > When the probe fails, we must disable the regulator that was previously > enabled. > > This patch is a follow-up to commit ac88c531a5b3 > ("net: davicom: Fix regulator not turned off on failed probe") which missed > one case. > > [...] Here is the summary with links: - net: davicom: Fix regulator not turned off on failed probe https://git.kernel.org/netdev/net/c/31457db3750c You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
Re: [PATCH net-next 0/7] net: ipa: a few small fixes
Hello: This series was applied to netdev/net-next.git (refs/heads/master): On Fri, 9 Apr 2021 13:07:15 -0500 you wrote: > This series implements some minor bug fixes or improvements. > > The first patch removes an apparently unnecessary restriction, which > results in an error on a 32-bit ARM build. > > The second makes a definition used for SDM845 match what is used in > the downstream code. > > [...] Here is the summary with links: - [net-next,1/7] net: ipa: relax pool entry size requirement https://git.kernel.org/netdev/net-next/c/7ad3bd52cbcb - [net-next,2/7] net: ipa: update sequence type for modem TX endpoint https://git.kernel.org/netdev/net-next/c/49e76a418981 - [net-next,3/7] net: ipa: only set endpoint netdev pointer when in use https://git.kernel.org/netdev/net-next/c/57f63faf0562 - [net-next,4/7] net: ipa: ipa_stop() does not return an error https://git.kernel.org/netdev/net-next/c/077e770f2601 - [net-next,5/7] net: ipa: get rid of empty IPA functions https://git.kernel.org/netdev/net-next/c/74858b63c47c - [net-next,6/7] net: ipa: get rid of empty GSI functions https://git.kernel.org/netdev/net-next/c/57ab8ca42fa0 - [net-next,7/7] net: ipa: three small fixes https://git.kernel.org/netdev/net-next/c/602a1c76f847 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
Re: [PATCH net-next] cxgb4: remove unneeded if-null-free check
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Fri, 9 Apr 2021 19:53:39 +0800 you wrote: > Eliminate the following coccicheck warning: > > drivers/net/ethernet/chelsio/cxgb4/cxgb4_tc_u32.c:529:3-9: WARNING: > NULL check before some freeing functions is not needed. > drivers/net/ethernet/chelsio/cxgb4/cxgb4_tc_u32.c:533:2-8: WARNING: > NULL check before some freeing functions is not needed. > drivers/net/ethernet/chelsio/cxgb4/cxgb4_cudbg.c:161:2-7: WARNING: > NULL check before some freeing functions is not needed. > drivers/net/ethernet/chelsio/cxgb4/clip_tbl.c:327:3-9: WARNING: > NULL check before some freeing functions is not needed. > > [...] Here is the summary with links: - [net-next] cxgb4: remove unneeded if-null-free check https://git.kernel.org/netdev/net-next/c/524e001b7dca You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
Re: [PATCH net] net: hns3: Trivial spell fix in hns3 driver
Hello: This patch was applied to netdev/net.git (refs/heads/master): On Fri, 9 Apr 2021 08:42:23 +0100 you wrote: > Some trivial spelling mistakes which caught my eye during the > review of the code. > > Signed-off-by: Salil Mehta > --- > drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c | 2 +- > drivers/net/ethernet/hisilicon/hns3/hns3vf/hclgevf_main.c | 4 ++-- > 2 files changed, 3 insertions(+), 3 deletions(-) Here is the summary with links: - [net] net: hns3: Trivial spell fix in hns3 driver https://git.kernel.org/netdev/net/c/cd7e963d2f08 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
Re: [PATCH net v1] lan743x: fix ethernet frame cutoff issue
Hello: This patch was applied to netdev/net.git (refs/heads/master): On Thu, 8 Apr 2021 20:39:04 -0400 you wrote: > From: Sven Van Asbroeck > > The ethernet frame length is calculated incorrectly. Depending on > the value of RX_HEAD_PADDING, this may result in ethernet frames > that are too short (cut off at the end), or too long (garbage added > to the end). > > [...] Here is the summary with links: - [net,v1] lan743x: fix ethernet frame cutoff issue https://git.kernel.org/netdev/net/c/3bc41d6d2721 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
Re: [PATCH] net: ipv6: check for validity before dereferencing cfg->fc_nlinfo.nlh
Hello: This patch was applied to netdev/net.git (refs/heads/master): On Fri, 9 Apr 2021 03:01:29 +0500 you wrote: > nlh is being checked for validtity two times when it is dereferenced in > this function. Check for validity again when updating the flags through > nlh pointer to make the dereferencing safe. > > CC: > Addresses-Coverity: ("NULL pointer dereference") > Signed-off-by: Muhammad Usama Anjum > > [...] Here is the summary with links: - net: ipv6: check for validity before dereferencing cfg->fc_nlinfo.nlh https://git.kernel.org/netdev/net/c/864db232dc70 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
Re: [PATCH net v2 0/2] lantiq: GSWIP: two more fixes
Hello: This series was applied to netdev/net.git (refs/heads/master): On Thu, 8 Apr 2021 20:38:26 +0200 you wrote: > Hello, > > after my last patch got accepted and is now in net as commit > 3e6fdeb28f4c33 ("net: dsa: lantiq_gswip: Let GSWIP automatically set > the xMII clock") [0] some more people from the OpenWrt community > (many thanks to everyone involved) helped test the GSWIP driver: [1] > > [...] Here is the summary with links: - [net,v2,1/2] net: dsa: lantiq_gswip: Don't use PHY auto polling https://git.kernel.org/netdev/net/c/3e9005be8777 - [net,v2,2/2] net: dsa: lantiq_gswip: Configure all remaining GSWIP_MII_CFG bits https://git.kernel.org/netdev/net/c/4b5923249b8f You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
Re: [PATCH] net: sched: sch_teql: fix null-pointer dereference
Hello: This patch was applied to netdev/net.git (refs/heads/master): On Thu, 8 Apr 2021 18:14:31 +0300 you wrote: > Reproduce: > > modprobe sch_teql > tc qdisc add dev teql0 root teql0 > > This leads to (for instance in Centos 7 VM) OOPS: > > [...] Here is the summary with links: - net: sched: sch_teql: fix null-pointer dereference https://git.kernel.org/netdev/net/c/1ffbc7ea9160 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
Re: [PATCH v2] net: hso: fix null-ptr-deref during tty device unregistration
Hello: This patch was applied to netdev/net.git (refs/heads/master): On Wed, 7 Apr 2021 22:57:22 +0530 you wrote: > Multiple ttys try to claim the same the minor number causing a double > unregistration of the same device. The first unregistration succeeds > but the next one results in a null-ptr-deref. > > The get_free_serial_index() function returns an available minor number > but doesn't assign it immediately. The assignment is done by the caller > later. But before this assignment, calls to get_free_serial_index() > would return the same minor number. > > [...] Here is the summary with links: - [v2] net: hso: fix null-ptr-deref during tty device unregistration https://git.kernel.org/netdev/net/c/8a12f8836145 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
Re: [PATCH] xircom: remove redundant error check on variable err
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Wed, 7 Apr 2021 10:39:22 +0100 you wrote: > From: Colin Ian King > > The error check on err is always false as err is always 0 at the > port_found label. The code is redundant and can be removed. > > Addresses-Coverity: ("Logically dead code") > Signed-off-by: Colin Ian King > > [...] Here is the summary with links: - xircom: remove redundant error check on variable err https://git.kernel.org/netdev/net-next/c/7b3ae17f0f68 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
Re: [PATCH] liquidio: Fix unintented sign extension of a left shift of a u16
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Wed, 7 Apr 2021 11:12:48 +0100 you wrote: > From: Colin Ian King > > The macro CN23XX_PEM_BAR1_INDEX_REG is being used to shift oct->pcie_port > (a u16) left 24 places. There are two subtle issues here, first the > shift gets promoted to an signed int and then sign extended to a u64. > If oct->pcie_port is 0x80 or more then the upper bits get sign extended > to 1. Secondly shfiting a u16 24 bits will lead to an overflow so it > needs to be cast to a u64 for all the bits to not overflow. > > [...] Here is the summary with links: - liquidio: Fix unintented sign extension of a left shift of a u16 https://git.kernel.org/netdev/net-next/c/298b58f00c0f You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
Re: [PATCH net-next] net: wan: z85230: drop unused async state
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Wed, 7 Apr 2021 12:48:56 +0200 you wrote: > According to the changelog, asynchronous mode was dropped sometime > before v2.2. Let's get rid of the unused driver-specific async state as > well so that it doesn't show up when doing tree-wide tty work. > > Signed-off-by: Johan Hovold > --- > drivers/net/wan/z85230.h | 39 --- > 1 file changed, 39 deletions(-) Here is the summary with links: - [net-next] net: wan: z85230: drop unused async state https://git.kernel.org/netdev/net-next/c/a18f19e91201 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
Re: [PATCH v2] net: tipc: Fix spelling errors in net/tipc module
Hello: This patch was applied to netdev/net.git (refs/heads/master): On Wed, 7 Apr 2021 09:59:45 +0800 you wrote: > These patches fix a series of spelling errors in net/tipc module. > > Reported-by: Hulk Robot > Signed-off-by: Zheng Yongjun > --- > net/tipc/bearer.h | 6 +++--- > net/tipc/net.c| 2 +- > net/tipc/node.c | 2 +- > 3 files changed, 5 insertions(+), 5 deletions(-) Here is the summary with links: - [v2] net: tipc: Fix spelling errors in net/tipc module https://git.kernel.org/netdev/net/c/a79ace4b3129 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
Re: [PATCH] nfc/fdp: remove unnecessary assignment and label
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Wed, 7 Apr 2021 11:16:38 +0800 you wrote: > From: wengjianfeng > > In function fdp_nci_patch_otp and fdp_nci_patch_ram,many goto > out statements are used, and out label just return variable r. > in some places,just jump to the out label, and in other places, > assign a value to the variable r,then jump to the out label. > It is unnecessary, we just use return sentences to replace goto > sentences and delete out label. > > [...] Here is the summary with links: - nfc/fdp: remove unnecessary assignment and label https://git.kernel.org/netdev/net-next/c/872fff333fb1 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
Re: [PATCH v2 net-next] stmmac: intel: Enable SERDES PHY rx clk for PSE
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Tue, 6 Apr 2021 09:32:50 +0800 you wrote: > EHL PSE SGMII mode requires to ungate the SERDES PHY rx clk for power up > sequence and vice versa. > > Signed-off-by: Voon Weifeng > --- > Changes: > v1 -> v2 > -change subject from "net: intel" to "stmmac: intel" > > [...] Here is the summary with links: - [v2,net-next] stmmac: intel: Enable SERDES PHY rx clk for PSE https://git.kernel.org/netdev/net-next/c/017d6250ad71 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
Re: [PATCH] net/rds: Avoid potential use after free in rds_send_remove_from_sock
Hello: This patch was applied to netdev/net.git (refs/heads/master): On Tue, 6 Apr 2021 19:09:12 -0500 you wrote: > In case of rs failure in rds_send_remove_from_sock(), the 'rm' resource > is freed and later under spinlock, causing potential use-after-free. > Set the free pointer to NULL to avoid undefined behavior. > > Signed-off-by: Aditya Pakki > --- > net/rds/message.c | 1 + > net/rds/send.c| 2 +- > 2 files changed, 2 insertions(+), 1 deletion(-) Here is the summary with links: - net/rds: Avoid potential use after free in rds_send_remove_from_sock https://git.kernel.org/netdev/net/c/0c85a7e87465 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
Re: [PATCH v2 1/1] time64.h: Consolidated PSEC_PER_SEC definition
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Tue, 6 Apr 2021 13:22:51 +0300 you wrote: > We have currently three users of the PSEC_PER_SEC each of them defining it > individually. Instead, move it to time64.h to be available for everyone. > > There is a new user coming with the same constant in use. It will also > make its life easier. > > Signed-off-by: Andy Shevchenko > Acked-by: Heiko Stuebner > > [...] Here is the summary with links: - [v2,1/1] time64.h: Consolidated PSEC_PER_SEC definition https://git.kernel.org/netdev/net-next/c/a460513ed4b6 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
Re: [PATCH net-next v1 1/1] stmmac: intel: Drop duplicate ID in the list of PCI device IDs
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Tue, 6 Apr 2021 13:13:06 +0300 you wrote: > The PCI device IDs are defined with a prefix PCI_DEVICE_ID. > There is no need to repeat the ID part at the end of each definition. > > Signed-off-by: Andy Shevchenko > --- > .../net/ethernet/stmicro/stmmac/dwmac-intel.c | 60 +-- > 1 file changed, 30 insertions(+), 30 deletions(-) Here is the summary with links: - [net-next,v1,1/1] stmmac: intel: Drop duplicate ID in the list of PCI device IDs https://git.kernel.org/netdev/net-next/c/3036ec035c4d You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
Re: [PATCH v3] net: tun: set tun->dev->addr_len during TUNSETLINK processing
Hello: This patch was applied to netdev/net.git (refs/heads/master): On Tue, 6 Apr 2021 18:45:54 +0100 you wrote: > When changing type with TUNSETLINK ioctl command, set tun->dev->addr_len > to match the appropriate type, using new tun_get_addr_len utility function > which returns appropriate address length for given type. Fixes a > KMSAN-found uninit-value bug reported by syzbot at: > https://syzkaller.appspot.com/bug?id=0766d38c656abeace60621896d705743aeefed51 > > Reported-by: syzbot+001516d86dbe88862...@syzkaller.appspotmail.com > Diagnosed-by: Eric Dumazet > Signed-off-by: Phillip Potter > > [...] Here is the summary with links: - [v3] net: tun: set tun->dev->addr_len during TUNSETLINK processing https://git.kernel.org/netdev/net/c/cca8ea3b05c9 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
Re: [PATCH net v1 1/1] ethtool: fix incorrect datatype in set_eee ops
Hello: This patch was applied to netdev/net.git (refs/heads/master): On Tue, 6 Apr 2021 21:17:30 +0800 you wrote: > The member 'tx_lpi_timer' is defined with __u32 datatype in the ethtool > header file. Hence, we should use ethnl_update_u32() in set_eee ops. > > Fixes: fd77be7bd43c ("ethtool: set EEE settings with EEE_SET request") > Cc: # 5.10.x > Cc: Michal Kubecek > Signed-off-by: Wong Vee Khee > > [...] Here is the summary with links: - [net,v1,1/1] ethtool: fix incorrect datatype in set_eee ops https://git.kernel.org/netdev/net/c/63cf32389925 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
Re: [PATCH] pcnet32: Use pci_resource_len to validate PCI resource
Hello: This patch was applied to netdev/net.git (refs/heads/master): On Mon, 5 Apr 2021 21:29:22 -0700 you wrote: > pci_resource_start() is not a good indicator to determine if a PCI > resource exists or not, since the resource may start at address 0. > This is seen when trying to instantiate the driver in qemu for riscv32 > or riscv64. > > pci :00:01.0: reg 0x10: [io 0x-0x001f] > pci :00:01.0: reg 0x14: [mem 0x-0x001f] > ... > pcnet32: card has no PCI IO resources, aborting > > [...] Here is the summary with links: - pcnet32: Use pci_resource_len to validate PCI resource https://git.kernel.org/netdev/net/c/66c3f05ddc53 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
Re: [PATCH net-next] netdevsim: remove unneeded semicolon
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Tue, 6 Apr 2021 11:18:13 +0800 you wrote: > Eliminate the following coccicheck warning: > drivers/net/netdevsim/fib.c:569:2-3: Unneeded semicolon > > Signed-off-by: Qiheng Lin > --- > drivers/net/netdevsim/fib.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Here is the summary with links: - [net-next] netdevsim: remove unneeded semicolon https://git.kernel.org/netdev/net-next/c/be107538c529 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
Re: [PATCH net-next v4 0/4] usbnet: speed reporting for devices without MDIO
Hello: This series was applied to netdev/net-next.git (refs/heads/master): On Mon, 5 Apr 2021 16:13:40 -0700 you wrote: > This series introduces support for USB network devices that report > speed as a part of their protocol, not emulating an MII to be accessed > over MDIO. > > v2: rebased on recent upstream changes > v3: incorporated hints on naming and comments > v4: fix misplaced hunks; reword some commit messages; > add same change for cdc_ether > v4-repost: added "net-next" to subject and Andrew Lunn's Reviewed-by > > [...] Here is the summary with links: - [net-next,v4,1/4] usbnet: add _mii suffix to usbnet_set/get_link_ksettings https://git.kernel.org/netdev/net-next/c/77651900cede - [net-next,v4,2/4] usbnet: add method for reporting speed without MII https://git.kernel.org/netdev/net-next/c/956baa99571b - [net-next,v4,3/4] net: cdc_ncm: record speed in status method https://git.kernel.org/netdev/net-next/c/eb47c274d8c4 - [net-next,v4,4/4] net: cdc_ether: record speed in status method https://git.kernel.org/netdev/net-next/c/d42ebcbb6353 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
Re: [PATCH v2] nfc: s3fwrn5: remove unnecessary label
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Tue, 6 Apr 2021 09:59:54 +0800 you wrote: > From: wengjianfeng > > In function s3fwrn5_nci_post_setup, the variable ret is assigned then > goto out label, which just return ret, so we use return to replace it. > Other goto sentences are similar, we use return sentences to replace > goto sentences and delete out label. > > [...] Here is the summary with links: - [v2] nfc: s3fwrn5: remove unnecessary label https://git.kernel.org/netdev/net-next/c/b58c4649d94e You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
Re: [PATCH net-next] net: ethernet: mtk_eth_soc: remove unneeded semicolon
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Tue, 6 Apr 2021 11:04:33 +0800 you wrote: > Eliminate the following coccicheck warning: > drivers/net/ethernet/mediatek/mtk_ppe.c:270:2-3: Unneeded semicolon > > Signed-off-by: Qiheng Lin > --- > drivers/net/ethernet/mediatek/mtk_ppe.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Here is the summary with links: - [net-next] net: ethernet: mtk_eth_soc: remove unneeded semicolon https://git.kernel.org/netdev/net-next/c/3b2c32f96edc You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
Re: [PATCH] net: broadcom: bcm4908enet: Fix a double free in bcm4908_enet_dma_alloc
Hello: This patch was applied to netdev/net.git (refs/heads/master): On Fri, 2 Apr 2021 10:40:19 -0700 you wrote: > In bcm4908_enet_dma_alloc, if callee bcm4908_dma_alloc_buf_descs() failed, > it will free the ring->cpu_addr by dma_free_coherent() and return error. > Then bcm4908_enet_dma_free() will be called, and free the same cpu_addr > by dma_free_coherent() again. > > My patch set ring->cpu_addr to NULL after it is freed in > bcm4908_dma_alloc_buf_descs() to avoid the double free. > > [...] Here is the summary with links: - net: broadcom: bcm4908enet: Fix a double free in bcm4908_enet_dma_alloc https://git.kernel.org/netdev/net/c/b25b343db052 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
Re: [PATCH] inode: Remove second initialization of the bpf_preload_lock
Hello: This patch was applied to bpf/bpf-next.git (refs/heads/master): On Tue, 6 Apr 2021 00:49:04 +0500 you wrote: > bpf_preload_lock is already defined with DEFINE_MUTEX. There is no need > to initialize it again. Remove the extraneous initialization. > > Signed-off-by: Muhammad Usama Anjum > --- > kernel/bpf/inode.c | 2 -- > 1 file changed, 2 deletions(-) Here is the summary with links: - inode: Remove second initialization of the bpf_preload_lock https://git.kernel.org/bpf/bpf-next/c/957dca3df624 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
Re: [PATCH] net: smsc911x: skip acpi_device_id table when !CONFIG_ACPI
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Mon, 5 Apr 2021 20:15:48 +0200 you wrote: > The driver can match via multiple methods. Its acpi_device_id table is > referenced via ACPI_PTR() so it will be unused for !CONFIG_ACPI builds: > > drivers/net/ethernet/smsc/smsc911x.c:2652:36: warning: > ‘smsc911x_acpi_match’ defined but not used [-Wunused-const-variable=] > > Signed-off-by: Krzysztof Kozlowski > > [...] Here is the summary with links: - net: smsc911x: skip acpi_device_id table when !CONFIG_ACPI https://git.kernel.org/netdev/net-next/c/cc0626c2aaed You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
Re: [PATCH net] net: hns3: Limiting the scope of vector_ring_chain variable
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Mon, 5 Apr 2021 18:28:25 +0100 you wrote: > Limiting the scope of the variable vector_ring_chain to the block where it > is used. > > Fixes: 424eb834a9be ("net: hns3: Unified HNS3 {VF|PF} Ethernet Driver for > hip08 SoC") > Signed-off-by: Salil Mehta > --- > drivers/net/ethernet/hisilicon/hns3/hns3_enet.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) Here is the summary with links: - [net] net: hns3: Limiting the scope of vector_ring_chain variable https://git.kernel.org/netdev/net-next/c/d392ecd1bc29 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
Re: [PATCH V2 net 0/2] Misc. fixes for hns3 driver
Hello: This series was applied to netdev/net.git (refs/heads/master): On Mon, 5 Apr 2021 18:06:43 +0100 you wrote: > Fixes for the miscellaneous problems found during the review of the code. > > Change Summary: > Patch 1/2, Change V1->V2: >[1] Fixed comments from Leon Romanovsky >Link: https://lkml.org/lkml/2021/4/4/14 > Patch 2/2, Change V1->V2: >None > > [...] Here is the summary with links: - [V2,net,1/2] net: hns3: Remove the left over redundant check & assignment https://git.kernel.org/netdev/net/c/9a6aaf61487e - [V2,net,2/2] net: hns3: Remove un-necessary 'else-if' in the hclge_reset_event() https://git.kernel.org/netdev/net/c/0600771fa6b2 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
Re: [PATCH net] openvswitch: fix send of uninitialized stack memory in ct limit reply
Hello: This patch was applied to netdev/net.git (refs/heads/master): On Sun, 4 Apr 2021 19:50:31 +0200 you wrote: > 'struct ovs_zone_limit' has more members than initialized in > ovs_ct_limit_get_default_limit(). The rest of the memory is a random > kernel stack content that ends up being sent to userspace. > > Fix that by using designated initializer that will clear all > non-specified fields. > > [...] Here is the summary with links: - [net] openvswitch: fix send of uninitialized stack memory in ct limit reply https://git.kernel.org/netdev/net/c/4d51419d4993 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
Re: [PATCH] net: nfc: Fix spelling errors in net/nfc module
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Mon, 5 Apr 2021 18:54:35 +0800 you wrote: > These patches fix a series of spelling errors in net/nfc module. > > Reported-by: Hulk Robot > Signed-off-by: Zheng Yongjun > --- > net/nfc/digital_dep.c | 2 +- > net/nfc/nci/core.c| 2 +- > net/nfc/nci/uart.c| 4 ++-- > 3 files changed, 4 insertions(+), 4 deletions(-) Here is the summary with links: - net: nfc: Fix spelling errors in net/nfc module https://git.kernel.org/netdev/net-next/c/d3295869c40c You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
Re: [PATCH 1/2] qede: Remove a erroneous ++ in 'qede_rx_build_jumbo()'
Hello: This series was applied to netdev/net-next.git (refs/heads/master): On Sun, 4 Apr 2021 14:42:44 +0200 you wrote: > This ++ is confusing. It looks duplicated with the one already performed in > 'skb_fill_page_desc()'. > > In fact, it is harmless. 'nr_frags' is written twice with the same value. > Once, because of the nr_frags++, and once because of the 'nr_frags = i + 1' > in 'skb_fill_page_desc()'. > > [...] Here is the summary with links: - [1/2] qede: Remove a erroneous ++ in 'qede_rx_build_jumbo()' https://git.kernel.org/netdev/net-next/c/1ec3d02f9cdf - [2/2] qede: Use 'skb_add_rx_frag()' instead of hand coding it https://git.kernel.org/netdev/net-next/c/7190e9d8e131 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html