Re: + mm-slab_common-commonize-slab-merge-logic.patch added to -mm tree
On Mon, Sep 22, 2014 at 12:48:41AM -0700, Andrew Morton wrote: > On Mon, 22 Sep 2014 09:32:45 +0900 Joonsoo Kim wrote: > > > Hello, Andrew. > > > > This patch has build failure problem if CONFIG_SLUB. > > Detailed information and fix is in following patch. > > > > Pleze be careful with the email headers? I happened to see this > email on lkml, wasn't cc'ed. Opps... Sorry. Do you want to resend? > > I assume there's something in the mm-commits headers which is causing > this to happen, but I don't know what. I expect a busted email client > is involved. > > This: > > From: a...@linux-foundation.org > To: iamjoonsoo@lge.com, c...@linux.com, penb...@kernel.org, > rdun...@infradead.org, rient...@google.com, mm-comm...@vger.kernel.org > Reply-To: linux-kernel@vger.kernel.org > Subject: + mm-slab_common-commonize-slab-merge-logic.patch added to -mm tree I think that it is caused by 'Reply-To' header. There is some explanation about it on https://www.gnu.org/software/emacs/manual/html_node/emacs/Mail-Headers.html ‘Reply-to’ An address to which replies should be sent, instead of ‘From’. This is used if, for some reason, your ‘From’ address cannot receive replies. In this case, your address in 'From' doesn't disappears in my Reply-All. Thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: + mm-slab_common-commonize-slab-merge-logic.patch added to -mm tree
On Mon, 22 Sep 2014 09:32:45 +0900 Joonsoo Kim wrote: > Hello, Andrew. > > This patch has build failure problem if CONFIG_SLUB. > Detailed information and fix is in following patch. > Pleze be careful with the email headers? I happened to see this email on lkml, wasn't cc'ed. I assume there's something in the mm-commits headers which is causing this to happen, but I don't know what. I expect a busted email client is involved. This: From: a...@linux-foundation.org To: iamjoonsoo@lge.com, c...@linux.com, penb...@kernel.org, rdun...@infradead.org, rient...@google.com, mm-comm...@vger.kernel.org Reply-To: linux-kernel@vger.kernel.org Subject: + mm-slab_common-commonize-slab-merge-logic.patch added to -mm tree -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: + mm-slab_common-commonize-slab-merge-logic.patch added to -mm tree
On Mon, 22 Sep 2014 09:32:45 +0900 Joonsoo Kim iamjoonsoo@lge.com wrote: Hello, Andrew. This patch has build failure problem if CONFIG_SLUB. Detailed information and fix is in following patch. Pleze be careful with the email headers? I happened to see this email on lkml, wasn't cc'ed. I assume there's something in the mm-commits headers which is causing this to happen, but I don't know what. I expect a busted email client is involved. This: From: a...@linux-foundation.org To: iamjoonsoo@lge.com, c...@linux.com, penb...@kernel.org, rdun...@infradead.org, rient...@google.com, mm-comm...@vger.kernel.org Reply-To: linux-kernel@vger.kernel.org Subject: + mm-slab_common-commonize-slab-merge-logic.patch added to -mm tree -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: + mm-slab_common-commonize-slab-merge-logic.patch added to -mm tree
On Mon, Sep 22, 2014 at 12:48:41AM -0700, Andrew Morton wrote: On Mon, 22 Sep 2014 09:32:45 +0900 Joonsoo Kim iamjoonsoo@lge.com wrote: Hello, Andrew. This patch has build failure problem if CONFIG_SLUB. Detailed information and fix is in following patch. Pleze be careful with the email headers? I happened to see this email on lkml, wasn't cc'ed. Opps... Sorry. Do you want to resend? I assume there's something in the mm-commits headers which is causing this to happen, but I don't know what. I expect a busted email client is involved. This: From: a...@linux-foundation.org To: iamjoonsoo@lge.com, c...@linux.com, penb...@kernel.org, rdun...@infradead.org, rient...@google.com, mm-comm...@vger.kernel.org Reply-To: linux-kernel@vger.kernel.org Subject: + mm-slab_common-commonize-slab-merge-logic.patch added to -mm tree I think that it is caused by 'Reply-To' header. There is some explanation about it on https://www.gnu.org/software/emacs/manual/html_node/emacs/Mail-Headers.html ‘Reply-to’ An address to which replies should be sent, instead of ‘From’. This is used if, for some reason, your ‘From’ address cannot receive replies. In this case, your address in 'From' doesn't disappears in my Reply-All. Thanks. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: + mm-slab_common-commonize-slab-merge-logic.patch added to -mm tree
On Fri, Sep 19, 2014 at 03:37:45PM -0700, a...@linux-foundation.org wrote:
>
> The patch titled
> Subject: mm/slab_common: commonize slab merge logic
> has been added to the -mm tree. Its filename is
> mm-slab_common-commonize-slab-merge-logic.patch
>
> This patch should soon appear at
>
> http://ozlabs.org/~akpm/mmots/broken-out/mm-slab_common-commonize-slab-merge-logic.patch
> and later at
>
> http://ozlabs.org/~akpm/mmotm/broken-out/mm-slab_common-commonize-slab-merge-logic.patch
>
> Before you just go and hit "reply", please:
>a) Consider who else should be cc'ed
>b) Prefer to cc a suitable mailing list as well
>c) Ideally: find the original patch on the mailing list and do a
> reply-to-all to that, adding suitable additional cc's
>
> *** Remember to use Documentation/SubmitChecklist when testing your code ***
>
> The -mm tree is included into linux-next and is updated
> there every 3-4 working days
>
> --
> From: Joonsoo Kim
> Subject: mm/slab_common: commonize slab merge logic
>
> Slab merge is good feature to reduce fragmentation. Now, it is only
> applied to SLUB, but, it would be good to apply it to SLAB. This patch is
> preparation step to apply slab merge to SLAB by commonizing slab merge
> logic.
>
> Signed-off-by: Joonsoo Kim
> Cc: Randy Dunlap
> Cc: Christoph Lameter
> Cc: Pekka Enberg
> Cc: David Rientjes
> Signed-off-by: Andrew Morton
> ---
>
> Documentation/kernel-parameters.txt | 14 ++--
> mm/slab.h | 15
> mm/slab_common.c| 91 ++
> mm/slub.c | 91 --
> 4 files changed, 117 insertions(+), 94 deletions(-)
>
> diff -puN
> Documentation/kernel-parameters.txt~mm-slab_common-commonize-slab-merge-logic
> Documentation/kernel-parameters.txt
> ---
> a/Documentation/kernel-parameters.txt~mm-slab_common-commonize-slab-merge-logic
> +++ a/Documentation/kernel-parameters.txt
> @@ -3140,6 +3140,13 @@ bytes respectively. Such letter suffixes
>
> slram= [HW,MTD]
>
> + slab_nomerge[MM]
> + Disable merging of slabs with similar size. May be
> + necessary if there is some reason to distinguish
> + allocs to different slabs. Debug options disable
> + merging on their own.
> + For more information see Documentation/vm/slub.txt.
> +
> slab_max_order= [MM, SLAB]
> Determines the maximum allowed order for slabs.
> A high setting may cause OOMs due to memory
> @@ -3175,11 +3182,8 @@ bytes respectively. Such letter suffixes
> For more information see Documentation/vm/slub.txt.
>
> slub_nomerge[MM, SLUB]
> - Disable merging of slabs with similar size. May be
> - necessary if there is some reason to distinguish
> - allocs to different slabs. Debug options disable
> - merging on their own.
> - For more information see Documentation/vm/slub.txt.
> + Same with slab_nomerge. This is supported for legacy.
> + See slab_nomerge for more information.
>
> smart2= [HW]
> Format: [,[,...,]]
> diff -puN mm/slab.h~mm-slab_common-commonize-slab-merge-logic mm/slab.h
> --- a/mm/slab.h~mm-slab_common-commonize-slab-merge-logic
> +++ a/mm/slab.h
> @@ -88,15 +88,30 @@ extern void create_boot_cache(struct kme
> size_t size, unsigned long flags);
>
> struct mem_cgroup;
> +
> +int slab_unmergeable(struct kmem_cache *s);
> +struct kmem_cache *find_mergeable(size_t size, size_t align,
> + unsigned long flags, const char *name, void (*ctor)(void *));
> #ifdef CONFIG_SLUB
> struct kmem_cache *
> __kmem_cache_alias(const char *name, size_t size, size_t align,
> unsigned long flags, void (*ctor)(void *));
> +
> +unsigned long kmem_cache_flags(unsigned long object_size,
> + unsigned long flags, const char *name,
> + void (*ctor)(void *));
> #else
> static inline struct kmem_cache *
> __kmem_cache_alias(const char *name, size_t size, size_t align,
> unsigned long flags, void (*ctor)(void *))
> { return NULL; }
> +
> +static inline unsigned long kmem_cache_flags(unsigned long object_size,
> + unsigned long flags, const char *name,
> + void (*ctor)(void *))
> +{
> + return flags;
> +}
> #endif
>
>
> diff -puN mm/slab_common.c~mm-slab_common-commonize-slab-merge-logic
> mm/slab_common.c
> --- a/mm/slab_common.c~mm-slab_common-commonize-slab-merge-logic
> +++ a/mm/slab_common.c
> @@ -31,6 +31,34 @@ DEFINE_MUTEX(slab_mutex);
> struct kmem_cache *kmem_cache;
>
> /*
> + * Set of flags that will prevent slab merging
>
Re: + mm-slab_common-commonize-slab-merge-logic.patch added to -mm tree
On Fri, Sep 19, 2014 at 03:37:45PM -0700, a...@linux-foundation.org wrote:
The patch titled
Subject: mm/slab_common: commonize slab merge logic
has been added to the -mm tree. Its filename is
mm-slab_common-commonize-slab-merge-logic.patch
This patch should soon appear at
http://ozlabs.org/~akpm/mmots/broken-out/mm-slab_common-commonize-slab-merge-logic.patch
and later at
http://ozlabs.org/~akpm/mmotm/broken-out/mm-slab_common-commonize-slab-merge-logic.patch
Before you just go and hit reply, please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c) Ideally: find the original patch on the mailing list and do a
reply-to-all to that, adding suitable additional cc's
*** Remember to use Documentation/SubmitChecklist when testing your code ***
The -mm tree is included into linux-next and is updated
there every 3-4 working days
--
From: Joonsoo Kim iamjoonsoo@lge.com
Subject: mm/slab_common: commonize slab merge logic
Slab merge is good feature to reduce fragmentation. Now, it is only
applied to SLUB, but, it would be good to apply it to SLAB. This patch is
preparation step to apply slab merge to SLAB by commonizing slab merge
logic.
Signed-off-by: Joonsoo Kim iamjoonsoo@lge.com
Cc: Randy Dunlap rdun...@infradead.org
Cc: Christoph Lameter c...@linux.com
Cc: Pekka Enberg penb...@kernel.org
Cc: David Rientjes rient...@google.com
Signed-off-by: Andrew Morton a...@linux-foundation.org
---
Documentation/kernel-parameters.txt | 14 ++--
mm/slab.h | 15
mm/slab_common.c| 91 ++
mm/slub.c | 91 --
4 files changed, 117 insertions(+), 94 deletions(-)
diff -puN
Documentation/kernel-parameters.txt~mm-slab_common-commonize-slab-merge-logic
Documentation/kernel-parameters.txt
---
a/Documentation/kernel-parameters.txt~mm-slab_common-commonize-slab-merge-logic
+++ a/Documentation/kernel-parameters.txt
@@ -3140,6 +3140,13 @@ bytes respectively. Such letter suffixes
slram= [HW,MTD]
+ slab_nomerge[MM]
+ Disable merging of slabs with similar size. May be
+ necessary if there is some reason to distinguish
+ allocs to different slabs. Debug options disable
+ merging on their own.
+ For more information see Documentation/vm/slub.txt.
+
slab_max_order= [MM, SLAB]
Determines the maximum allowed order for slabs.
A high setting may cause OOMs due to memory
@@ -3175,11 +3182,8 @@ bytes respectively. Such letter suffixes
For more information see Documentation/vm/slub.txt.
slub_nomerge[MM, SLUB]
- Disable merging of slabs with similar size. May be
- necessary if there is some reason to distinguish
- allocs to different slabs. Debug options disable
- merging on their own.
- For more information see Documentation/vm/slub.txt.
+ Same with slab_nomerge. This is supported for legacy.
+ See slab_nomerge for more information.
smart2= [HW]
Format: io1[,io2[,...,io8]]
diff -puN mm/slab.h~mm-slab_common-commonize-slab-merge-logic mm/slab.h
--- a/mm/slab.h~mm-slab_common-commonize-slab-merge-logic
+++ a/mm/slab.h
@@ -88,15 +88,30 @@ extern void create_boot_cache(struct kme
size_t size, unsigned long flags);
struct mem_cgroup;
+
+int slab_unmergeable(struct kmem_cache *s);
+struct kmem_cache *find_mergeable(size_t size, size_t align,
+ unsigned long flags, const char *name, void (*ctor)(void *));
#ifdef CONFIG_SLUB
struct kmem_cache *
__kmem_cache_alias(const char *name, size_t size, size_t align,
unsigned long flags, void (*ctor)(void *));
+
+unsigned long kmem_cache_flags(unsigned long object_size,
+ unsigned long flags, const char *name,
+ void (*ctor)(void *));
#else
static inline struct kmem_cache *
__kmem_cache_alias(const char *name, size_t size, size_t align,
unsigned long flags, void (*ctor)(void *))
{ return NULL; }
+
+static inline unsigned long kmem_cache_flags(unsigned long object_size,
+ unsigned long flags, const char *name,
+ void (*ctor)(void *))
+{
+ return flags;
+}
#endif
diff -puN mm/slab_common.c~mm-slab_common-commonize-slab-merge-logic
mm/slab_common.c
--- a/mm/slab_common.c~mm-slab_common-commonize-slab-merge-logic
+++ a/mm/slab_common.c
@@ -31,6 +31,34 @@ DEFINE_MUTEX(slab_mutex);
struct kmem_cache *kmem_cache;
/*
+ * Set of flags that will
