[ 125/135] hwmon: (twl4030-madc-hwmon) Initialize uninitialized structure elements
3.2-stable review patch. If anyone has any objections, please let me know.
--
From: Guenter Roeck
commit 73d7c119255615a26070f9d6cdb722a166a29015 upstream.
twl4030_madc_conversion uses do_avg and type structure elements of
twl4030_madc_request. Initialize structure to avoid random operation.
Fix for: Coverity CID 200794 Uninitialized scalar variable.
Cc: Keerthy
Signed-off-by: Guenter Roeck
Acked-by: Jean Delvare
Acked-by: Keerthy
Signed-off-by: Ben Hutchings
---
drivers/hwmon/twl4030-madc-hwmon.c |9 +
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/drivers/hwmon/twl4030-madc-hwmon.c
b/drivers/hwmon/twl4030-madc-hwmon.c
index 0018c7d..1a174f0 100644
--- a/drivers/hwmon/twl4030-madc-hwmon.c
+++ b/drivers/hwmon/twl4030-madc-hwmon.c
@@ -44,12 +44,13 @@ static ssize_t madc_read(struct device *dev,
struct device_attribute *devattr, char *buf)
{
struct sensor_device_attribute *attr = to_sensor_dev_attr(devattr);
- struct twl4030_madc_request req;
+ struct twl4030_madc_request req = {
+ .channels = 1 << attr->index,
+ .method = TWL4030_MADC_SW2,
+ .type = TWL4030_MADC_WAIT,
+ };
long val;
- req.channels = (1 << attr->index);
- req.method = TWL4030_MADC_SW2;
- req.func_cb = NULL;
val = twl4030_madc_conversion();
if (val < 0)
return val;
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[ 125/135] hwmon: (twl4030-madc-hwmon) Initialize uninitialized structure elements
3.2-stable review patch. If anyone has any objections, please let me know.
--
From: Guenter Roeck li...@roeck-us.net
commit 73d7c119255615a26070f9d6cdb722a166a29015 upstream.
twl4030_madc_conversion uses do_avg and type structure elements of
twl4030_madc_request. Initialize structure to avoid random operation.
Fix for: Coverity CID 200794 Uninitialized scalar variable.
Cc: Keerthy j-keer...@ti.com
Signed-off-by: Guenter Roeck li...@roeck-us.net
Acked-by: Jean Delvare kh...@linux-fr.org
Acked-by: Keerthy j-keer...@ti.com
Signed-off-by: Ben Hutchings b...@decadent.org.uk
---
drivers/hwmon/twl4030-madc-hwmon.c |9 +
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/drivers/hwmon/twl4030-madc-hwmon.c
b/drivers/hwmon/twl4030-madc-hwmon.c
index 0018c7d..1a174f0 100644
--- a/drivers/hwmon/twl4030-madc-hwmon.c
+++ b/drivers/hwmon/twl4030-madc-hwmon.c
@@ -44,12 +44,13 @@ static ssize_t madc_read(struct device *dev,
struct device_attribute *devattr, char *buf)
{
struct sensor_device_attribute *attr = to_sensor_dev_attr(devattr);
- struct twl4030_madc_request req;
+ struct twl4030_madc_request req = {
+ .channels = 1 attr-index,
+ .method = TWL4030_MADC_SW2,
+ .type = TWL4030_MADC_WAIT,
+ };
long val;
- req.channels = (1 attr-index);
- req.method = TWL4030_MADC_SW2;
- req.func_cb = NULL;
val = twl4030_madc_conversion(req);
if (val 0)
return val;
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
