Re: [02/12] net: hns3: Destroy a mutex after initialisation failure in hclge_init_ae_dev()

2020-05-29 Thread Markus Elfring
>> Would you like to add the tag “Fixes” to the commit message?
>
> Since it seems not a very urgent issue, so i send it to the -next

I suggest to take another look at the prioritisation for another
completion of the exception handling.


> and make it as a code optimization.

I propose to reconsider also such a view.

Regards,
Markus


Re: [02/12] net: hns3: Destroy a mutex after initialisation failure in hclge_init_ae_dev()

2020-05-28 Thread Markus Elfring
>>> Add a mutex destroy call in hclge_init_ae_dev() when fails.
>>
>> How do you think about a wording variant like the following?
…
> It looks better. I will try to improve the skill of patch description
> and make as many as people can understand the patch.

Thanks for your positive feedback.

I suggest to avoid also a typo in the function name of the patch subject.

Regards,
Markus