Re: [2.6 patch] __inet6_csk_dst_store(): fix check-after-use

2007-10-15 Thread David Miller 
From: Noriaki TAKAMIYA <[EMAIL PROTECTED]>
Date: Mon, 15 Oct 2007 12:37:49 +0900 (JST)

> > 
> > On Sun, 14 Oct 2007 19:52:12 +0200
> > Adrian Bunk <[EMAIL PROTECTED]> wrote:
> > 
> > > The Coverity checker spotted that we have already oops'ed if "dst"
> > > was NULL.
> > > 
> > > Since "dst" being NULL doesn't seem to be possible at this point this 
> > > patch removes the NULL check.
> > > 
> > > Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>
> > 
> > Agreed.
> > 
> > Acked-by: Masahide NAKAMURA <[EMAIL PROTECTED]>
> 
>   I also agreed.
>   
> Acked-by: Noriaki TAKAMIYA <[EMAIL PROTECTED]>

Patch applied, thanks everyone!
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [2.6 patch] __inet6_csk_dst_store(): fix check-after-use

2007-10-15 Thread David Miller 
From: Noriaki TAKAMIYA [EMAIL PROTECTED]
Date: Mon, 15 Oct 2007 12:37:49 +0900 (JST)

  
  On Sun, 14 Oct 2007 19:52:12 +0200
  Adrian Bunk [EMAIL PROTECTED] wrote:
  
   The Coverity checker spotted that we have already oops'ed if dst
   was NULL.
   
   Since dst being NULL doesn't seem to be possible at this point this 
   patch removes the NULL check.
   
   Signed-off-by: Adrian Bunk [EMAIL PROTECTED]
  
  Agreed.
  
  Acked-by: Masahide NAKAMURA [EMAIL PROTECTED]
 
   I also agreed.
   
 Acked-by: Noriaki TAKAMIYA [EMAIL PROTECTED]

Patch applied, thanks everyone!
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [2.6 patch] __inet6_csk_dst_store(): fix check-after-use

2007-10-14 Thread Noriaki TAKAMIYA 
Hi,

>> Mon, 15 Oct 2007 11:45:10 +0900
>> [Subject: Re: [2.6 patch] __inet6_csk_dst_store(): fix check-after-use]
>> Masahide NAKAMURA <[EMAIL PROTECTED]> wrote...

> 
> On Sun, 14 Oct 2007 19:52:12 +0200
> Adrian Bunk <[EMAIL PROTECTED]> wrote:
> 
> > The Coverity checker spotted that we have already oops'ed if "dst"
> > was NULL.
> > 
> > Since "dst" being NULL doesn't seem to be possible at this point this 
> > patch removes the NULL check.
> > 
> > Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>
> 
> Agreed.
> 
> Acked-by: Masahide NAKAMURA <[EMAIL PROTECTED]>

  I also agreed.
  
Acked-by: Noriaki TAKAMIYA <[EMAIL PROTECTED]>

--
Noriaki TAKAMIYA
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [2.6 patch] __inet6_csk_dst_store(): fix check-after-use

2007-10-14 Thread Masahide NAKAMURA 

On Sun, 14 Oct 2007 19:52:12 +0200
Adrian Bunk <[EMAIL PROTECTED]> wrote:

> The Coverity checker spotted that we have already oops'ed if "dst"
> was NULL.
> 
> Since "dst" being NULL doesn't seem to be possible at this point this 
> patch removes the NULL check.
> 
> Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>

Agreed.

Acked-by: Masahide NAKAMURA <[EMAIL PROTECTED]>

-- 
Masahide NAKAMURA

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[2.6 patch] __inet6_csk_dst_store(): fix check-after-use

2007-10-14 Thread Adrian Bunk 
The Coverity checker spotted that we have already oops'ed if "dst"
was NULL.

Since "dst" being NULL doesn't seem to be possible at this point this 
patch removes the NULL check.

Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>

---
eeb6009cf3ef5f6993ced359330d877680617a70 
diff --git a/net/ipv6/inet6_connection_sock.c b/net/ipv6/inet6_connection_sock.c
index 25b9317..78de42a 100644
--- a/net/ipv6/inet6_connection_sock.c
+++ b/net/ipv6/inet6_connection_sock.c
@@ -146,7 +146,7 @@ void __inet6_csk_dst_store(struct sock *sk, struct 
dst_entry *dst,
__ip6_dst_store(sk, dst, daddr, saddr);
 
 #ifdef CONFIG_XFRM
-   if (dst) {
+   {
struct rt6_info *rt = (struct rt6_info  *)dst;
rt->rt6i_flow_cache_genid = atomic_read(_cache_genid);
}
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[2.6 patch] __inet6_csk_dst_store(): fix check-after-use

2007-10-14 Thread Adrian Bunk 
The Coverity checker spotted that we have already oops'ed if dst
was NULL.

Since dst being NULL doesn't seem to be possible at this point this 
patch removes the NULL check.

Signed-off-by: Adrian Bunk [EMAIL PROTECTED]

---
eeb6009cf3ef5f6993ced359330d877680617a70 
diff --git a/net/ipv6/inet6_connection_sock.c b/net/ipv6/inet6_connection_sock.c
index 25b9317..78de42a 100644
--- a/net/ipv6/inet6_connection_sock.c
+++ b/net/ipv6/inet6_connection_sock.c
@@ -146,7 +146,7 @@ void __inet6_csk_dst_store(struct sock *sk, struct 
dst_entry *dst,
__ip6_dst_store(sk, dst, daddr, saddr);
 
 #ifdef CONFIG_XFRM
-   if (dst) {
+   {
struct rt6_info *rt = (struct rt6_info  *)dst;
rt-rt6i_flow_cache_genid = atomic_read(flow_cache_genid);
}
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [2.6 patch] __inet6_csk_dst_store(): fix check-after-use

2007-10-14 Thread Masahide NAKAMURA 

On Sun, 14 Oct 2007 19:52:12 +0200
Adrian Bunk [EMAIL PROTECTED] wrote:

 The Coverity checker spotted that we have already oops'ed if dst
 was NULL.
 
 Since dst being NULL doesn't seem to be possible at this point this 
 patch removes the NULL check.
 
 Signed-off-by: Adrian Bunk [EMAIL PROTECTED]

Agreed.

Acked-by: Masahide NAKAMURA [EMAIL PROTECTED]

-- 
Masahide NAKAMURA

-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [2.6 patch] __inet6_csk_dst_store(): fix check-after-use

2007-10-14 Thread Noriaki TAKAMIYA 
Hi,

 Mon, 15 Oct 2007 11:45:10 +0900
 [Subject: Re: [2.6 patch] __inet6_csk_dst_store(): fix check-after-use]
 Masahide NAKAMURA [EMAIL PROTECTED] wrote...

 
 On Sun, 14 Oct 2007 19:52:12 +0200
 Adrian Bunk [EMAIL PROTECTED] wrote:
 
  The Coverity checker spotted that we have already oops'ed if dst
  was NULL.
  
  Since dst being NULL doesn't seem to be possible at this point this 
  patch removes the NULL check.
  
  Signed-off-by: Adrian Bunk [EMAIL PROTECTED]
 
 Agreed.
 
 Acked-by: Masahide NAKAMURA [EMAIL PROTECTED]

  I also agreed.
  
Acked-by: Noriaki TAKAMIYA [EMAIL PROTECTED]

--
Noriaki TAKAMIYA
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/