Re: [2.6 patch] drivers/pnp/pnpbios/rsparser.c: fix an array overflow

2005-04-10 Thread Adam Belay 
On Sat, Apr 09, 2005 at 08:03:52PM +0200, Adrian Bunk wrote:
> This patch fixes an array overflow found by the Coverity checker.
> 
> Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>
> 

Looks good.

Thanks,
Adam
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [2.6 patch] drivers/pnp/pnpbios/rsparser.c: fix an array overflow

2005-04-10 Thread Adam Belay 
On Sat, Apr 09, 2005 at 08:03:52PM +0200, Adrian Bunk wrote:
 This patch fixes an array overflow found by the Coverity checker.
 
 Signed-off-by: Adrian Bunk [EMAIL PROTECTED]
 

Looks good.

Thanks,
Adam
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[2.6 patch] drivers/pnp/pnpbios/rsparser.c: fix an array overflow

2005-04-09 Thread Adrian Bunk 
This patch fixes an array overflow found by the Coverity checker.

Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>

---

This patch was already sent on:
- 27 Mar 2005

--- linux-2.6.12-rc1-mm1-full/drivers/pnp/pnpbios/rsparser.c.old
2005-03-23 03:04:17.0 +0100
+++ linux-2.6.12-rc1-mm1-full/drivers/pnp/pnpbios/rsparser.c2005-03-23 
03:05:21.0 +0100
@@ -72,7 +72,9 @@
 pnpbios_parse_allocated_dmaresource(struct pnp_resource_table * res, int dma)
 {
int i = 0;
-   while (!(res->dma_resource[i].flags & IORESOURCE_UNSET) && i < 
PNP_MAX_DMA) i++;
+   while (i < PNP_MAX_DMA && 
+   !(res->dma_resource[i].flags & IORESOURCE_UNSET))
+   i++;
if (i < PNP_MAX_DMA) {
res->dma_resource[i].flags = IORESOURCE_DMA;  // Also clears 
_UNSET flag
if (dma == -1) {

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[2.6 patch] drivers/pnp/pnpbios/rsparser.c: fix an array overflow

2005-04-09 Thread Adrian Bunk 
This patch fixes an array overflow found by the Coverity checker.

Signed-off-by: Adrian Bunk [EMAIL PROTECTED]

---

This patch was already sent on:
- 27 Mar 2005

--- linux-2.6.12-rc1-mm1-full/drivers/pnp/pnpbios/rsparser.c.old
2005-03-23 03:04:17.0 +0100
+++ linux-2.6.12-rc1-mm1-full/drivers/pnp/pnpbios/rsparser.c2005-03-23 
03:05:21.0 +0100
@@ -72,7 +72,9 @@
 pnpbios_parse_allocated_dmaresource(struct pnp_resource_table * res, int dma)
 {
int i = 0;
-   while (!(res-dma_resource[i].flags  IORESOURCE_UNSET)  i  
PNP_MAX_DMA) i++;
+   while (i  PNP_MAX_DMA  
+   !(res-dma_resource[i].flags  IORESOURCE_UNSET))
+   i++;
if (i  PNP_MAX_DMA) {
res-dma_resource[i].flags = IORESOURCE_DMA;  // Also clears 
_UNSET flag
if (dma == -1) {

-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[2.6 patch] drivers/pnp/pnpbios/rsparser.c: fix an array overflow

2005-03-27 Thread Adrian Bunk 
This patch fixes an array overflow found by the Coverity checker.

Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>

--- linux-2.6.12-rc1-mm1-full/drivers/pnp/pnpbios/rsparser.c.old
2005-03-23 03:04:17.0 +0100
+++ linux-2.6.12-rc1-mm1-full/drivers/pnp/pnpbios/rsparser.c2005-03-23 
03:05:21.0 +0100
@@ -72,7 +72,9 @@
 pnpbios_parse_allocated_dmaresource(struct pnp_resource_table * res, int dma)
 {
int i = 0;
-   while (!(res->dma_resource[i].flags & IORESOURCE_UNSET) && i < 
PNP_MAX_DMA) i++;
+   while (i < PNP_MAX_DMA && 
+   !(res->dma_resource[i].flags & IORESOURCE_UNSET))
+   i++;
if (i < PNP_MAX_DMA) {
res->dma_resource[i].flags = IORESOURCE_DMA;  // Also clears 
_UNSET flag
if (dma == -1) {

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[2.6 patch] drivers/pnp/pnpbios/rsparser.c: fix an array overflow

2005-03-27 Thread Adrian Bunk 
This patch fixes an array overflow found by the Coverity checker.

Signed-off-by: Adrian Bunk [EMAIL PROTECTED]

--- linux-2.6.12-rc1-mm1-full/drivers/pnp/pnpbios/rsparser.c.old
2005-03-23 03:04:17.0 +0100
+++ linux-2.6.12-rc1-mm1-full/drivers/pnp/pnpbios/rsparser.c2005-03-23 
03:05:21.0 +0100
@@ -72,7 +72,9 @@
 pnpbios_parse_allocated_dmaresource(struct pnp_resource_table * res, int dma)
 {
int i = 0;
-   while (!(res-dma_resource[i].flags  IORESOURCE_UNSET)  i  
PNP_MAX_DMA) i++;
+   while (i  PNP_MAX_DMA  
+   !(res-dma_resource[i].flags  IORESOURCE_UNSET))
+   i++;
if (i  PNP_MAX_DMA) {
res-dma_resource[i].flags = IORESOURCE_DMA;  // Also clears 
_UNSET flag
if (dma == -1) {

-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/