Re: [2.6 patch] i386/mach-default/topology.c: make cpu_devices static
Looks good to me! Acked-by: Matthew Dobson <[EMAIL PROTECTED]> Adrian Bunk wrote: This patch makes a needlessly global struct static. Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> --- arch/i386/mach-default/topology.c |2 +- include/asm-i386/cpu.h|1 - 2 files changed, 1 insertion(+), 2 deletions(-) This patch was already sent on: - 16 Jan 2005 --- linux-2.6.11-rc1-mm1-full/include/asm-i386/cpu.h.old2005-01-16 05:41:55.0 +0100 +++ linux-2.6.11-rc1-mm1-full/include/asm-i386/cpu.h2005-01-16 05:42:09.0 +0100 @@ -12,7 +12,6 @@ struct i386_cpu { struct cpu cpu; }; -extern struct i386_cpu cpu_devices[NR_CPUS]; extern int arch_register_cpu(int num); #ifdef CONFIG_HOTPLUG_CPU extern void arch_unregister_cpu(int); --- linux-2.6.11-rc1-mm1-full/arch/i386/mach-default/topology.c.old 2005-01-16 05:42:18.0 +0100 +++ linux-2.6.11-rc1-mm1-full/arch/i386/mach-default/topology.c 2005-01-16 05:42:43.0 +0100 @@ -30,7 +30,7 @@ #include #include -struct i386_cpu cpu_devices[NR_CPUS]; +static struct i386_cpu cpu_devices[NR_CPUS]; int arch_register_cpu(int num){ struct node *parent = NULL; - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [2.6 patch] i386/mach-default/topology.c: make cpu_devices static
Looks good to me! Acked-by: Matthew Dobson [EMAIL PROTECTED] Adrian Bunk wrote: This patch makes a needlessly global struct static. Signed-off-by: Adrian Bunk [EMAIL PROTECTED] --- arch/i386/mach-default/topology.c |2 +- include/asm-i386/cpu.h|1 - 2 files changed, 1 insertion(+), 2 deletions(-) This patch was already sent on: - 16 Jan 2005 --- linux-2.6.11-rc1-mm1-full/include/asm-i386/cpu.h.old2005-01-16 05:41:55.0 +0100 +++ linux-2.6.11-rc1-mm1-full/include/asm-i386/cpu.h2005-01-16 05:42:09.0 +0100 @@ -12,7 +12,6 @@ struct i386_cpu { struct cpu cpu; }; -extern struct i386_cpu cpu_devices[NR_CPUS]; extern int arch_register_cpu(int num); #ifdef CONFIG_HOTPLUG_CPU extern void arch_unregister_cpu(int); --- linux-2.6.11-rc1-mm1-full/arch/i386/mach-default/topology.c.old 2005-01-16 05:42:18.0 +0100 +++ linux-2.6.11-rc1-mm1-full/arch/i386/mach-default/topology.c 2005-01-16 05:42:43.0 +0100 @@ -30,7 +30,7 @@ #include linux/nodemask.h #include asm/cpu.h -struct i386_cpu cpu_devices[NR_CPUS]; +static struct i386_cpu cpu_devices[NR_CPUS]; int arch_register_cpu(int num){ struct node *parent = NULL; - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[2.6 patch] i386/mach-default/topology.c: make cpu_devices static
This patch makes a needlessly global struct static. Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> --- arch/i386/mach-default/topology.c |2 +- include/asm-i386/cpu.h|1 - 2 files changed, 1 insertion(+), 2 deletions(-) This patch was already sent on: - 16 Jan 2005 --- linux-2.6.11-rc1-mm1-full/include/asm-i386/cpu.h.old2005-01-16 05:41:55.0 +0100 +++ linux-2.6.11-rc1-mm1-full/include/asm-i386/cpu.h2005-01-16 05:42:09.0 +0100 @@ -12,7 +12,6 @@ struct i386_cpu { struct cpu cpu; }; -extern struct i386_cpu cpu_devices[NR_CPUS]; extern int arch_register_cpu(int num); #ifdef CONFIG_HOTPLUG_CPU extern void arch_unregister_cpu(int); --- linux-2.6.11-rc1-mm1-full/arch/i386/mach-default/topology.c.old 2005-01-16 05:42:18.0 +0100 +++ linux-2.6.11-rc1-mm1-full/arch/i386/mach-default/topology.c 2005-01-16 05:42:43.0 +0100 @@ -30,7 +30,7 @@ #include #include -struct i386_cpu cpu_devices[NR_CPUS]; +static struct i386_cpu cpu_devices[NR_CPUS]; int arch_register_cpu(int num){ struct node *parent = NULL; - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[2.6 patch] i386/mach-default/topology.c: make cpu_devices static
This patch makes a needlessly global struct static. Signed-off-by: Adrian Bunk [EMAIL PROTECTED] --- arch/i386/mach-default/topology.c |2 +- include/asm-i386/cpu.h|1 - 2 files changed, 1 insertion(+), 2 deletions(-) This patch was already sent on: - 16 Jan 2005 --- linux-2.6.11-rc1-mm1-full/include/asm-i386/cpu.h.old2005-01-16 05:41:55.0 +0100 +++ linux-2.6.11-rc1-mm1-full/include/asm-i386/cpu.h2005-01-16 05:42:09.0 +0100 @@ -12,7 +12,6 @@ struct i386_cpu { struct cpu cpu; }; -extern struct i386_cpu cpu_devices[NR_CPUS]; extern int arch_register_cpu(int num); #ifdef CONFIG_HOTPLUG_CPU extern void arch_unregister_cpu(int); --- linux-2.6.11-rc1-mm1-full/arch/i386/mach-default/topology.c.old 2005-01-16 05:42:18.0 +0100 +++ linux-2.6.11-rc1-mm1-full/arch/i386/mach-default/topology.c 2005-01-16 05:42:43.0 +0100 @@ -30,7 +30,7 @@ #include linux/nodemask.h #include asm/cpu.h -struct i386_cpu cpu_devices[NR_CPUS]; +static struct i386_cpu cpu_devices[NR_CPUS]; int arch_register_cpu(int num){ struct node *parent = NULL; - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[2.6 patch] i386/mach-default/topology.c: make cpu_devices static
The patch below makes a needlessly global struct static. diffstat output: arch/i386/mach-default/topology.c |2 +- include/asm-i386/cpu.h|1 - 2 files changed, 1 insertion(+), 2 deletions(-) Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> --- linux-2.6.11-rc1-mm1-full/include/asm-i386/cpu.h.old2005-01-16 05:41:55.0 +0100 +++ linux-2.6.11-rc1-mm1-full/include/asm-i386/cpu.h2005-01-16 05:42:09.0 +0100 @@ -12,7 +12,6 @@ struct i386_cpu { struct cpu cpu; }; -extern struct i386_cpu cpu_devices[NR_CPUS]; extern int arch_register_cpu(int num); #ifdef CONFIG_HOTPLUG_CPU extern void arch_unregister_cpu(int); --- linux-2.6.11-rc1-mm1-full/arch/i386/mach-default/topology.c.old 2005-01-16 05:42:18.0 +0100 +++ linux-2.6.11-rc1-mm1-full/arch/i386/mach-default/topology.c 2005-01-16 05:42:43.0 +0100 @@ -30,7 +30,7 @@ #include #include -struct i386_cpu cpu_devices[NR_CPUS]; +static struct i386_cpu cpu_devices[NR_CPUS]; int arch_register_cpu(int num){ struct node *parent = NULL; - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[2.6 patch] i386/mach-default/topology.c: make cpu_devices static
The patch below makes a needlessly global struct static. diffstat output: arch/i386/mach-default/topology.c |2 +- include/asm-i386/cpu.h|1 - 2 files changed, 1 insertion(+), 2 deletions(-) Signed-off-by: Adrian Bunk [EMAIL PROTECTED] --- linux-2.6.11-rc1-mm1-full/include/asm-i386/cpu.h.old2005-01-16 05:41:55.0 +0100 +++ linux-2.6.11-rc1-mm1-full/include/asm-i386/cpu.h2005-01-16 05:42:09.0 +0100 @@ -12,7 +12,6 @@ struct i386_cpu { struct cpu cpu; }; -extern struct i386_cpu cpu_devices[NR_CPUS]; extern int arch_register_cpu(int num); #ifdef CONFIG_HOTPLUG_CPU extern void arch_unregister_cpu(int); --- linux-2.6.11-rc1-mm1-full/arch/i386/mach-default/topology.c.old 2005-01-16 05:42:18.0 +0100 +++ linux-2.6.11-rc1-mm1-full/arch/i386/mach-default/topology.c 2005-01-16 05:42:43.0 +0100 @@ -30,7 +30,7 @@ #include linux/nodemask.h #include asm/cpu.h -struct i386_cpu cpu_devices[NR_CPUS]; +static struct i386_cpu cpu_devices[NR_CPUS]; int arch_register_cpu(int num){ struct node *parent = NULL; - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/