Re: [2.6 patch] remove drivers/usb/image/hpusbscsi.c

2005-03-17 Thread Greg KH 
On Thu, Mar 03, 2005 at 02:38:56PM +0100, Adrian Bunk wrote:
> USB_HPUSBSCSI was marked as BROKEN in 2.6.11 since libsane is the 
> preferred way to access these devices.
> 
> Unless someone plans to resurrect this driver, I'm therefore proposing 
> this patch to completely remove it.
> 
> Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>

Applied, thanks.

greg k-h

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [2.6 patch] remove drivers/usb/image/hpusbscsi.c

2005-03-17 Thread Greg KH 
On Thu, Mar 03, 2005 at 02:38:56PM +0100, Adrian Bunk wrote:
 USB_HPUSBSCSI was marked as BROKEN in 2.6.11 since libsane is the 
 preferred way to access these devices.
 
 Unless someone plans to resurrect this driver, I'm therefore proposing 
 this patch to completely remove it.
 
 Signed-off-by: Adrian Bunk [EMAIL PROTECTED]

Applied, thanks.

greg k-h

-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [linux-usb-devel] [2.6 patch] remove drivers/usb/image/hpusbscsi.c

2005-03-03 Thread Oliver Neukum 
Am Donnerstag, 3. März 2005 20:48 schrieb Pasi Savolainen:
> * Oliver Neukum <[EMAIL PROTECTED]>:
> > Am Donnerstag, 3. März 2005 14:38 schrieb Adrian Bunk:
> >> USB_HPUSBSCSI was marked as BROKEN in 2.6.11 since libsane is the 
> >> preferred way to access these devices.
> >
> > That is true only if you limit yourself to users of SANE.
> > Other, rarer scan systems like VueScan use it. At least last time
> > somebody mentioned them.
> 
> Vuescan uses libusb these days, didn't need hpusbscsi last time I used
> it.
> I don't know about other (program-) users.

OK. That should solve the issue. It can go.

Regards
Oliver
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [linux-usb-devel] [2.6 patch] remove drivers/usb/image/hpusbscsi.c

2005-03-03 Thread Pasi Savolainen 
* Oliver Neukum <[EMAIL PROTECTED]>:
> Am Donnerstag, 3. März 2005 14:38 schrieb Adrian Bunk:
>> USB_HPUSBSCSI was marked as BROKEN in 2.6.11 since libsane is the 
>> preferred way to access these devices.
>
> That is true only if you limit yourself to users of SANE.
> Other, rarer scan systems like VueScan use it. At least last time
> somebody mentioned them.

Vuescan uses libusb these days, didn't need hpusbscsi last time I used
it.
I don't know about other (program-) users.


-- 
   Psi -- 

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [linux-usb-devel] [2.6 patch] remove drivers/usb/image/hpusbscsi.c

2005-03-03 Thread Oliver Neukum 
Am Donnerstag, 3. März 2005 14:38 schrieb Adrian Bunk:
> USB_HPUSBSCSI was marked as BROKEN in 2.6.11 since libsane is the 
> preferred way to access these devices.

That is true only if you limit yourself to users of SANE.
Other, rarer scan systems like VueScan use it. At least last time
somebody mentioned them. Do you have any hard evidence that
it is unused? 2.6.11 is out less than three days, which is not enough
for people to complain.

Regards
Oliver
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[2.6 patch] remove drivers/usb/image/hpusbscsi.c

2005-03-03 Thread Adrian Bunk 
USB_HPUSBSCSI was marked as BROKEN in 2.6.11 since libsane is the 
preferred way to access these devices.

Unless someone plans to resurrect this driver, I'm therefore proposing 
this patch to completely remove it.

Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>

---

 drivers/usb/Makefile  |1 
 drivers/usb/image/Kconfig |   11 
 drivers/usb/image/Makefile|1 
 drivers/usb/image/hpusbscsi.c |  523 --
 drivers/usb/image/hpusbscsi.h |   73 
 5 files changed, 609 deletions(-)

--- linux-2.6.11-rc5-mm1-full/drivers/usb/image/Kconfig.old 2005-03-02 
15:59:34.0 +0100
+++ linux-2.6.11-rc5-mm1-full/drivers/usb/image/Kconfig 2005-03-03 
14:24:33.0 +0100
@@ -28,14 +28,3 @@
  The scanner will appear as a scsi generic device to the rest
  of the system. Scsi support is required.
  This driver can be compiled as a module, called microtek.
-
-config USB_HPUSBSCSI
-   tristate "HP53xx USB scanner support"
-   depends on USB && SCSI && BROKEN
-   help
- Say Y here if you want support for the HP 53xx series of scanners
- and the Minolta Scan Dual.
- The scanner will be accessible as a SCSI device.
- Please note that recent versions of SANE use usbfs, not this driver.
- This can be compiled as a module, called hpusbscsi.
-
--- linux-2.6.11-rc5-mm1-full/drivers/usb/Makefile.old  2005-03-02 
16:02:10.0 +0100
+++ linux-2.6.11-rc5-mm1-full/drivers/usb/Makefile  2005-03-02 
16:02:18.0 +0100
@@ -51,7 +51,6 @@
 obj-$(CONFIG_USB_RTL8150)  += net/
 obj-$(CONFIG_USB_USBNET)   += net/
 
-obj-$(CONFIG_USB_HPUSBSCSI)+= image/
 obj-$(CONFIG_USB_MDC800)   += image/
 obj-$(CONFIG_USB_MICROTEK) += image/
 
--- linux-2.6.11-rc5-mm1-full/drivers/usb/image/Makefile.old2005-03-02 
16:02:26.0 +0100
+++ linux-2.6.11-rc5-mm1-full/drivers/usb/image/Makefile2005-03-02 
16:02:30.0 +0100
@@ -3,5 +3,4 @@
 #
 
 obj-$(CONFIG_USB_MDC800)   += mdc800.o
-obj-$(CONFIG_USB_HPUSBSCSI)+= hpusbscsi.o
 obj-$(CONFIG_USB_MICROTEK) += microtek.o
--- linux-2.6.11-rc5-mm1-full/drivers/usb/image/hpusbscsi.h 2004-12-24 
22:33:59.0 +0100
+++ /dev/null   2004-11-25 03:16:25.0 +0100
@@ -1,73 +0,0 @@
-/* Header file for the hpusbscsi driver */
-/* (C) Copyright 2001 Oliver Neukum */
-/* sponsored by the Linux Usb Project */
-/* large parts based on or taken from code by John Fremlin and Matt Dharm */
-/* this file is licensed under the GPL */
-
-/* A big thanks to Jose for untiring testing */
-
-typedef void (*scsi_callback)(Scsi_Cmnd *);
-
-#define SENSE_COMMAND_SIZE 6
-#define HPUSBSCSI_SENSE_LENGTH 0x16
-
-struct hpusbscsi
-{
-struct usb_device *dev; /* NULL indicates unplugged device */
-int ep_out;
-int ep_in;
-int ep_int;
-int interrupt_interval;
-   int number;
-   int fragment;
-struct Scsi_Host *host;
-
-   scsi_callback scallback;
-   Scsi_Cmnd *srb;
-
-
-wait_queue_head_t pending;
-wait_queue_head_t deathrow;
-
-struct urb *dataurb;
-struct urb *controlurb;
-
-
-int state;
-int current_data_pipe;
-   u8 sense_command[SENSE_COMMAND_SIZE];
-u8 scsi_state_byte;
-};
-
-#define SCSI_ERR_MASK ~0x3fu
-
-static const unsigned char scsi_command_direction[256/8] = {
-   0x28, 0x81, 0x14, 0x14, 0x20, 0x01, 0x90, 0x77,
-   0x0C, 0x20, 0x00, 0x04, 0x00, 0x00, 0x00, 0x00,
-   0x00, 0x00, 0x00, 0x00, 0x00, 0x01, 0x00, 0x01,
-   0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00
-};
-
-#define DIRECTION_IS_IN(x) ((scsi_command_direction[x>>3] >> (x & 7)) & 1)
-
-static void simple_command_callback(struct urb *u, struct pt_regs *regs);
-static void scatter_gather_callback(struct urb *u, struct pt_regs *regs);
-static void simple_payload_callback (struct urb *u, struct pt_regs *regs);
-static void request_sense_callback (struct urb *u, struct pt_regs *regs);
-static void control_interrupt_callback (struct urb *u, struct pt_regs *regs);
-static void simple_done (struct urb *u, struct pt_regs *regs);
-static int hpusbscsi_scsi_queuecommand (Scsi_Cmnd *srb, scsi_callback 
callback);
-static int hpusbscsi_scsi_host_reset (Scsi_Cmnd *srb);
-static int hpusbscsi_scsi_abort (Scsi_Cmnd *srb);
-static void issue_request_sense (struct hpusbscsi *hpusbscsi);
-
-/* defines for internal driver state */
-#define HP_STATE_FREE 0  /*ready for next request */
-#define HP_STATE_BEGINNING  1  /*command being transferred */
-#define HP_STATE_WORKING 2  /* data transfer stage */
-#define HP_STATE_ERROR 3  /* error has been reported */
-#define HP_STATE_WAIT 4  /* waiting for status transfer */
-#define HP_STATE_PREMATURE  5 /* status prematurely reported */
-
-
-
--- linux-2.6.11-rc5-mm1-full/drivers/usb/image/hpusbscsi.c 2004-12-24

[2.6 patch] remove drivers/usb/image/hpusbscsi.c

2005-03-03 Thread Adrian Bunk 
USB_HPUSBSCSI was marked as BROKEN in 2.6.11 since libsane is the 
preferred way to access these devices.

Unless someone plans to resurrect this driver, I'm therefore proposing 
this patch to completely remove it.

Signed-off-by: Adrian Bunk [EMAIL PROTECTED]

---

 drivers/usb/Makefile  |1 
 drivers/usb/image/Kconfig |   11 
 drivers/usb/image/Makefile|1 
 drivers/usb/image/hpusbscsi.c |  523 --
 drivers/usb/image/hpusbscsi.h |   73 
 5 files changed, 609 deletions(-)

--- linux-2.6.11-rc5-mm1-full/drivers/usb/image/Kconfig.old 2005-03-02 
15:59:34.0 +0100
+++ linux-2.6.11-rc5-mm1-full/drivers/usb/image/Kconfig 2005-03-03 
14:24:33.0 +0100
@@ -28,14 +28,3 @@
  The scanner will appear as a scsi generic device to the rest
  of the system. Scsi support is required.
  This driver can be compiled as a module, called microtek.
-
-config USB_HPUSBSCSI
-   tristate HP53xx USB scanner support
-   depends on USB  SCSI  BROKEN
-   help
- Say Y here if you want support for the HP 53xx series of scanners
- and the Minolta Scan Dual.
- The scanner will be accessible as a SCSI device.
- Please note that recent versions of SANE use usbfs, not this driver.
- This can be compiled as a module, called hpusbscsi.
-
--- linux-2.6.11-rc5-mm1-full/drivers/usb/Makefile.old  2005-03-02 
16:02:10.0 +0100
+++ linux-2.6.11-rc5-mm1-full/drivers/usb/Makefile  2005-03-02 
16:02:18.0 +0100
@@ -51,7 +51,6 @@
 obj-$(CONFIG_USB_RTL8150)  += net/
 obj-$(CONFIG_USB_USBNET)   += net/
 
-obj-$(CONFIG_USB_HPUSBSCSI)+= image/
 obj-$(CONFIG_USB_MDC800)   += image/
 obj-$(CONFIG_USB_MICROTEK) += image/
 
--- linux-2.6.11-rc5-mm1-full/drivers/usb/image/Makefile.old2005-03-02 
16:02:26.0 +0100
+++ linux-2.6.11-rc5-mm1-full/drivers/usb/image/Makefile2005-03-02 
16:02:30.0 +0100
@@ -3,5 +3,4 @@
 #
 
 obj-$(CONFIG_USB_MDC800)   += mdc800.o
-obj-$(CONFIG_USB_HPUSBSCSI)+= hpusbscsi.o
 obj-$(CONFIG_USB_MICROTEK) += microtek.o
--- linux-2.6.11-rc5-mm1-full/drivers/usb/image/hpusbscsi.h 2004-12-24 
22:33:59.0 +0100
+++ /dev/null   2004-11-25 03:16:25.0 +0100
@@ -1,73 +0,0 @@
-/* Header file for the hpusbscsi driver */
-/* (C) Copyright 2001 Oliver Neukum */
-/* sponsored by the Linux Usb Project */
-/* large parts based on or taken from code by John Fremlin and Matt Dharm */
-/* this file is licensed under the GPL */
-
-/* A big thanks to Jose for untiring testing */
-
-typedef void (*scsi_callback)(Scsi_Cmnd *);
-
-#define SENSE_COMMAND_SIZE 6
-#define HPUSBSCSI_SENSE_LENGTH 0x16
-
-struct hpusbscsi
-{
-struct usb_device *dev; /* NULL indicates unplugged device */
-int ep_out;
-int ep_in;
-int ep_int;
-int interrupt_interval;
-   int number;
-   int fragment;
-struct Scsi_Host *host;
-
-   scsi_callback scallback;
-   Scsi_Cmnd *srb;
-
-
-wait_queue_head_t pending;
-wait_queue_head_t deathrow;
-
-struct urb *dataurb;
-struct urb *controlurb;
-
-
-int state;
-int current_data_pipe;
-   u8 sense_command[SENSE_COMMAND_SIZE];
-u8 scsi_state_byte;
-};
-
-#define SCSI_ERR_MASK ~0x3fu
-
-static const unsigned char scsi_command_direction[256/8] = {
-   0x28, 0x81, 0x14, 0x14, 0x20, 0x01, 0x90, 0x77,
-   0x0C, 0x20, 0x00, 0x04, 0x00, 0x00, 0x00, 0x00,
-   0x00, 0x00, 0x00, 0x00, 0x00, 0x01, 0x00, 0x01,
-   0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00
-};
-
-#define DIRECTION_IS_IN(x) ((scsi_command_direction[x3]  (x  7))  1)
-
-static void simple_command_callback(struct urb *u, struct pt_regs *regs);
-static void scatter_gather_callback(struct urb *u, struct pt_regs *regs);
-static void simple_payload_callback (struct urb *u, struct pt_regs *regs);
-static void request_sense_callback (struct urb *u, struct pt_regs *regs);
-static void control_interrupt_callback (struct urb *u, struct pt_regs *regs);
-static void simple_done (struct urb *u, struct pt_regs *regs);
-static int hpusbscsi_scsi_queuecommand (Scsi_Cmnd *srb, scsi_callback 
callback);
-static int hpusbscsi_scsi_host_reset (Scsi_Cmnd *srb);
-static int hpusbscsi_scsi_abort (Scsi_Cmnd *srb);
-static void issue_request_sense (struct hpusbscsi *hpusbscsi);
-
-/* defines for internal driver state */
-#define HP_STATE_FREE 0  /*ready for next request */
-#define HP_STATE_BEGINNING  1  /*command being transferred */
-#define HP_STATE_WORKING 2  /* data transfer stage */
-#define HP_STATE_ERROR 3  /* error has been reported */
-#define HP_STATE_WAIT 4  /* waiting for status transfer */
-#define HP_STATE_PREMATURE  5 /* status prematurely reported */
-
-
-
--- linux-2.6.11-rc5-mm1-full/drivers/usb/image/hpusbscsi.c 2004-12-24 
22:35:40.0 +0100

Re: [linux-usb-devel] [2.6 patch] remove drivers/usb/image/hpusbscsi.c

2005-03-03 Thread Oliver Neukum 
Am Donnerstag, 3. März 2005 14:38 schrieb Adrian Bunk:
 USB_HPUSBSCSI was marked as BROKEN in 2.6.11 since libsane is the 
 preferred way to access these devices.

That is true only if you limit yourself to users of SANE.
Other, rarer scan systems like VueScan use it. At least last time
somebody mentioned them. Do you have any hard evidence that
it is unused? 2.6.11 is out less than three days, which is not enough
for people to complain.

Regards
Oliver
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [linux-usb-devel] [2.6 patch] remove drivers/usb/image/hpusbscsi.c

2005-03-03 Thread Pasi Savolainen 
* Oliver Neukum [EMAIL PROTECTED]:
 Am Donnerstag, 3. März 2005 14:38 schrieb Adrian Bunk:
 USB_HPUSBSCSI was marked as BROKEN in 2.6.11 since libsane is the 
 preferred way to access these devices.

 That is true only if you limit yourself to users of SANE.
 Other, rarer scan systems like VueScan use it. At least last time
 somebody mentioned them.

Vuescan uses libusb these days, didn't need hpusbscsi last time I used
it.
I don't know about other (program-) users.


-- 
   Psi -- http://www.iki.fi/pasi.savolainen

-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [linux-usb-devel] [2.6 patch] remove drivers/usb/image/hpusbscsi.c

2005-03-03 Thread Oliver Neukum 
Am Donnerstag, 3. März 2005 20:48 schrieb Pasi Savolainen:
 * Oliver Neukum [EMAIL PROTECTED]:
  Am Donnerstag, 3. März 2005 14:38 schrieb Adrian Bunk:
  USB_HPUSBSCSI was marked as BROKEN in 2.6.11 since libsane is the 
  preferred way to access these devices.
 
  That is true only if you limit yourself to users of SANE.
  Other, rarer scan systems like VueScan use it. At least last time
  somebody mentioned them.
 
 Vuescan uses libusb these days, didn't need hpusbscsi last time I used
 it.
 I don't know about other (program-) users.

OK. That should solve the issue. It can go.

Regards
Oliver
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/