Re: [PATCH][ASoC]fsl_ssi: fix of_property_read_u32_array return value check
On Wed, Mar 04, 2015 at 10:48:30PM +0100, Maciej S. Szmigiero wrote: > of_property_read_u32_array returns 0 on success, > so the return value shouldn't be inverted twice, > first on assignment then in condition expression. > > Signed-off-by: Maciej Szmigiero Applied, thanks. signature.asc Description: Digital signature
[PATCH][ASoC]fsl_ssi: fix of_property_read_u32_array return value check
of_property_read_u32_array returns 0 on success,
so the return value shouldn't be inverted twice,
first on assignment then in condition expression.
Signed-off-by: Maciej Szmigiero
--- a/sound/soc/fsl/fsl_ssi.c
+++ b/sound/soc/fsl/fsl_ssi.c
@@ -1227,7 +1227,7 @@ static int fsl_ssi_imx_probe(struct platform_device *pdev,
ssi_private->dma_params_tx.addr = ssi_private->ssi_phys + CCSR_SSI_STX0;
ssi_private->dma_params_rx.addr = ssi_private->ssi_phys + CCSR_SSI_SRX0;
- ret = !of_property_read_u32_array(np, "dmas", dmas, 4);
+ ret = of_property_read_u32_array(np, "dmas", dmas, 4);
if (ssi_private->use_dma && !ret && dmas[2] == IMX_DMATYPE_SSI_DUAL) {
ssi_private->use_dual_fifo = true;
/* When using dual fifo mode, we need to keep watermark
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [ASoC]fsl_ssi: fix of_property_read_u32_array return value check
On Wed, Mar 04, 2015 at 02:07:21PM +0100, Maciej S. Szmigiero wrote: > Against which tree/branch patches for ASoC should be generated? MAINTAINERS says: SOUND - SOC LAYER / DYNAMIC AUDIO POWER MANAGEMENT (ASoC) M: Liam Girdwood M: Mark Brown T: git git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git mainly the for-next branch, though bugfixes go on for-linus. signature.asc Description: Digital signature
Re: [ASoC]fsl_ssi: fix of_property_read_u32_array return value check
W dniu 24.02.2015 09:24, Mark Brown pisze: > On Sun, Feb 15, 2015 at 11:11:43PM +0100, Maciej S. Szmigiero wrote: >> of_property_read_u32_array returns 0 on success, so the return value >> shouldn't be inverted twice, >> first on assignment then in condition expression. > > This doesn't apply to current code, please check and resend. Please > also keep your changelog under 80 columns as covered in > SubmittingPatches. > Thanks for looking into it, Against which tree/branch patches for ASoC should be generated? Best regards, Maciej Szmigiero -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [ASoC]fsl_ssi: fix of_property_read_u32_array return value check
On Wed, Mar 04, 2015 at 02:07:21PM +0100, Maciej S. Szmigiero wrote: Against which tree/branch patches for ASoC should be generated? MAINTAINERS says: SOUND - SOC LAYER / DYNAMIC AUDIO POWER MANAGEMENT (ASoC) M: Liam Girdwood lgirdw...@gmail.com M: Mark Brown broo...@kernel.org T: git git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git mainly the for-next branch, though bugfixes go on for-linus. signature.asc Description: Digital signature
[PATCH][ASoC]fsl_ssi: fix of_property_read_u32_array return value check
of_property_read_u32_array returns 0 on success,
so the return value shouldn't be inverted twice,
first on assignment then in condition expression.
Signed-off-by: Maciej Szmigiero m...@maciej.szmigiero.name
--- a/sound/soc/fsl/fsl_ssi.c
+++ b/sound/soc/fsl/fsl_ssi.c
@@ -1227,7 +1227,7 @@ static int fsl_ssi_imx_probe(struct platform_device *pdev,
ssi_private-dma_params_tx.addr = ssi_private-ssi_phys + CCSR_SSI_STX0;
ssi_private-dma_params_rx.addr = ssi_private-ssi_phys + CCSR_SSI_SRX0;
- ret = !of_property_read_u32_array(np, dmas, dmas, 4);
+ ret = of_property_read_u32_array(np, dmas, dmas, 4);
if (ssi_private-use_dma !ret dmas[2] == IMX_DMATYPE_SSI_DUAL) {
ssi_private-use_dual_fifo = true;
/* When using dual fifo mode, we need to keep watermark
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH][ASoC]fsl_ssi: fix of_property_read_u32_array return value check
On Wed, Mar 04, 2015 at 10:48:30PM +0100, Maciej S. Szmigiero wrote: of_property_read_u32_array returns 0 on success, so the return value shouldn't be inverted twice, first on assignment then in condition expression. Signed-off-by: Maciej Szmigiero m...@maciej.szmigiero.name Applied, thanks. signature.asc Description: Digital signature
Re: [ASoC]fsl_ssi: fix of_property_read_u32_array return value check
W dniu 24.02.2015 09:24, Mark Brown pisze: On Sun, Feb 15, 2015 at 11:11:43PM +0100, Maciej S. Szmigiero wrote: of_property_read_u32_array returns 0 on success, so the return value shouldn't be inverted twice, first on assignment then in condition expression. This doesn't apply to current code, please check and resend. Please also keep your changelog under 80 columns as covered in SubmittingPatches. Thanks for looking into it, Against which tree/branch patches for ASoC should be generated? Best regards, Maciej Szmigiero -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [ASoC]fsl_ssi: fix of_property_read_u32_array return value check
On Sun, Feb 15, 2015 at 11:11:43PM +0100, Maciej S. Szmigiero wrote: > of_property_read_u32_array returns 0 on success, so the return value > shouldn't be inverted twice, > first on assignment then in condition expression. This doesn't apply to current code, please check and resend. Please also keep your changelog under 80 columns as covered in SubmittingPatches. signature.asc Description: Digital signature
Re: [ASoC]fsl_ssi: fix of_property_read_u32_array return value check
On Sun, Feb 15, 2015 at 11:11:43PM +0100, Maciej S. Szmigiero wrote: of_property_read_u32_array returns 0 on success, so the return value shouldn't be inverted twice, first on assignment then in condition expression. This doesn't apply to current code, please check and resend. Please also keep your changelog under 80 columns as covered in SubmittingPatches. signature.asc Description: Digital signature
[ASoC]fsl_ssi: fix of_property_read_u32_array return value check
of_property_read_u32_array returns 0 on success, so the return value shouldn't
be inverted twice,
first on assignment then in condition expression.
Signed-off-by: Maciej Szmigiero
diff --git a/sound/soc/fsl/fsl_ssi.c b/sound/soc/fsl/fsl_ssi.c
index d7365c5..134388f 100644
--- a/sound/soc/fsl/fsl_ssi.c
+++ b/sound/soc/fsl/fsl_ssi.c
@@ -1227,7 +1227,7 @@ static int fsl_ssi_imx_probe(struct platform_device *pdev,
ssi_private->dma_params_tx.addr = ssi_private->ssi_phys + CCSR_SSI_STX0;
ssi_private->dma_params_rx.addr = ssi_private->ssi_phys + CCSR_SSI_SRX0;
-ret = !of_property_read_u32_array(np, "dmas", dmas, 4);
+ret = of_property_read_u32_array(np, "dmas", dmas, 4);
if (ssi_private->use_dma && !ret && dmas[2] == IMX_DMATYPE_SSI_DUAL) {
ssi_private->use_dual_fifo = true;
/* When using dual fifo mode, we need to keep watermark
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[ASoC]fsl_ssi: fix of_property_read_u32_array return value check
of_property_read_u32_array returns 0 on success, so the return value shouldn't
be inverted twice,
first on assignment then in condition expression.
Signed-off-by: Maciej Szmigiero m...@maciej.szmigiero.name
diff --git a/sound/soc/fsl/fsl_ssi.c b/sound/soc/fsl/fsl_ssi.c
index d7365c5..134388f 100644
--- a/sound/soc/fsl/fsl_ssi.c
+++ b/sound/soc/fsl/fsl_ssi.c
@@ -1227,7 +1227,7 @@ static int fsl_ssi_imx_probe(struct platform_device *pdev,
ssi_private-dma_params_tx.addr = ssi_private-ssi_phys + CCSR_SSI_STX0;
ssi_private-dma_params_rx.addr = ssi_private-ssi_phys + CCSR_SSI_SRX0;
-ret = !of_property_read_u32_array(np, dmas, dmas, 4);
+ret = of_property_read_u32_array(np, dmas, dmas, 4);
if (ssi_private-use_dma !ret dmas[2] == IMX_DMATYPE_SSI_DUAL) {
ssi_private-use_dual_fifo = true;
/* When using dual fifo mode, we need to keep watermark
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
