subject:"\[BUG\] net\: stmmac\: dwmac\-sun8i broken in linux\-next"

Re: [BUG] net: stmmac: dwmac-sun8i broken in linux-next

2018-05-17 Thread Jose Abreu

Hi Corentin,

On 16-05-2018 19:32, Corentin Labbe wrote:
> Hello
>
> The dwmac-sun8i driver is broken in next-20180515, symptom are no RX and TX 
> errors as shown by ifconfig:
> eth0: flags=4163  mtu 1500
> inet 192.168.1.204  netmask 255.255.255.0  broadcast 192.168.1.255
> ether 96:75:ff:0d:f6:d8  txqueuelen 1000  (Ethernet)
> RX packets 0  bytes 0 (0.0 B)
> RX errors 0  dropped 0  overruns 0  frame 0
> TX packets 0  bytes 4956 (4.8 KiB)
> TX errors 118  dropped 0 overruns 0  carrier 0  collisions 0
>
> Reverting the following commit made the driver working:
> 4dbbe8dde8485b89bce8bbbe7564337fd7eed69f ("net: stmmac: Add support for U32 
> TC filter using Flexible RX Parser")
> 5f0456b43140af9413397cc11d03d18b9f2fc2fc ("net: stmmac: Implement logic to 
> automatically select HW Interface")
>
> Note that reverting only 4dbbe8dde8485b89bce8bbbe7564337fd7eed69f lead to 
> crash:
> [   31.385110] Backtrace: 
> [   31.387576] [] (stmmac_open) from [] 
> (__dev_open+0xe4/0x180)
> [   31.394972]  r10:ed447d04 r9:edc5d010 r8:ef02002c r7:c08670a4 r6: 
> r5:c0c08488
> [   31.402793]  r4:ef02
> [   31.405335] [] (__dev_open) from [] 
> (__dev_change_flags+0x190/0x1e8)
> [   31.413421]  r8:1002 r7:c0c08488 r6:1003 r5:0001 r4:ef02
> [   31.420122] [] (__dev_change_flags) from [] 
> (dev_change_flags+0x20/0x50)
> [   31.428555]  r9:edc5d010 r8:ed447c18 r7:ef020134 r6: r5:1002 
> r4:ef02
> [   31.436300] [] (dev_change_flags) from [] 
> (do_setlink+0x28c/0xbdc)
> [   31.444213]  r9:edc5d010 r8:ed447c18 r7: r6:c0c08488 r5:ed447b50 
> r4:ef02
> [   31.451955] [] (do_setlink) from [] 
> (rtnl_newlink+0x54c/0x7a8)
> [   31.459522]  r10:ed447d04 r9: r8: r7: r6: 
> r5:
> [   31.467343]  r4:ef02
> [   31.469885] [] (rtnl_newlink) from [] 
> (rtnetlink_rcv_msg+0x38c/0x544)
> [   31.478058]  r10:ed447d04 r9: r8:ee242840 r7: r6:edc5d000 
> r5:c0c08488
> [   31.485879]  r4:
> [   31.488422] [] (rtnetlink_rcv_msg) from [] 
> (netlink_rcv_skb+0xc0/0x118)
> [   31.496768]  r10:c0c08488 r9: r8:0020 r7:edc5d000 r6:c064466c 
> r5:c0c08488
> [   31.504589]  r4:ee242840
> [   31.507129] [] (netlink_rcv_skb) from [] 
> (rtnetlink_rcv+0x18/0x1c)
> [   31.515042]  r8:ed447d60 r7:ee242840 r6:0020 r5:ee37d800 r4:ee5fac00
> [   31.521742] [] (rtnetlink_rcv) from [] 
> (netlink_unicast+0x190/0x1fc)
> [   31.529829] [] (netlink_unicast) from [] 
> (netlink_sendmsg+0x3cc/0x410)
> [   31.538089]  r10: r9:0020 r8:014000c0 r7:ee242840 r6:ee37d800 
> r5:c0c08488
> [   31.545910]  r4:ed447f44
> [   31.548452] [] (netlink_sendmsg) from [] 
> (sock_sendmsg+0x1c/0x2c)
> [   31.556279]  r10: r9:ed447edc r8: r7:eefce640 r6: 
> r5:c0c08488
> [   31.564100]  r4:ed447f44
> [   31.566640] [] (sock_sendmsg) from [] 
> (___sys_sendmsg+0x250/0x264)
> [   31.574555] [] (___sys_sendmsg) from [] 
> (__sys_sendmsg+0x58/0x94)
> [   31.582382]  r10: r9:ed446000 r8:c01011c4 r7:eefce640 r6: 
> r5:bec25150
> [   31.590203]  r4:c0c08488
> [   31.592743] [] (__sys_sendmsg) from [] 
> (sys_sendmsg+0x14/0x18)
> [   31.600307]  r7:0128 r6:bec2d17c r5:bec25144 r4:00093ee0
> [   31.605969] [] (sys_sendmsg) from [] 
> (ret_fast_syscall+0x0/0x28)
> [   31.613704] Exception stack(0xed447fa8 to 0xed447ff0)
> [   31.618756] 7fa0:   00093ee0 bec25144 0003 bec25150 
>  85ce
> [   31.626929] 7fc0: 00093ee0 bec25144 bec2d17c 0128 000942a8 5afc783a 
> 00094000 bec25150
> [   31.635099] 7fe0:  bec250f0 012c b6e10b5c
> [   31.640152] Code: e59a261c e59a013c e50b306c e592300c (e593300c) 
> [   31.646632] ---[ end trace 407964b7deb937bf ]---
>
> For the moment, I stil didnt find the issue.
> What to we do now ? do you want that I send revert patchs ?

No need for revert. I checked the patch and dwmac-sun8i
implementation and I think I found the problem. I will send you a
patch to test.

Thanks and Best Regards,
Jose Miguel Abreu

>
> Regards

Re: [BUG] net: stmmac: dwmac-sun8i broken in linux-next

2018-05-17 Thread Jose Abreu

Hi Corentin,

On 16-05-2018 19:32, Corentin Labbe wrote:
> Hello
>
> The dwmac-sun8i driver is broken in next-20180515, symptom are no RX and TX 
> errors as shown by ifconfig:
> eth0: flags=4163  mtu 1500
> inet 192.168.1.204  netmask 255.255.255.0  broadcast 192.168.1.255
> ether 96:75:ff:0d:f6:d8  txqueuelen 1000  (Ethernet)
> RX packets 0  bytes 0 (0.0 B)
> RX errors 0  dropped 0  overruns 0  frame 0
> TX packets 0  bytes 4956 (4.8 KiB)
> TX errors 118  dropped 0 overruns 0  carrier 0  collisions 0
>
> Reverting the following commit made the driver working:
> 4dbbe8dde8485b89bce8bbbe7564337fd7eed69f ("net: stmmac: Add support for U32 
> TC filter using Flexible RX Parser")
> 5f0456b43140af9413397cc11d03d18b9f2fc2fc ("net: stmmac: Implement logic to 
> automatically select HW Interface")
>
> Note that reverting only 4dbbe8dde8485b89bce8bbbe7564337fd7eed69f lead to 
> crash:
> [   31.385110] Backtrace: 
> [   31.387576] [] (stmmac_open) from [] 
> (__dev_open+0xe4/0x180)
> [   31.394972]  r10:ed447d04 r9:edc5d010 r8:ef02002c r7:c08670a4 r6: 
> r5:c0c08488
> [   31.402793]  r4:ef02
> [   31.405335] [] (__dev_open) from [] 
> (__dev_change_flags+0x190/0x1e8)
> [   31.413421]  r8:1002 r7:c0c08488 r6:1003 r5:0001 r4:ef02
> [   31.420122] [] (__dev_change_flags) from [] 
> (dev_change_flags+0x20/0x50)
> [   31.428555]  r9:edc5d010 r8:ed447c18 r7:ef020134 r6: r5:1002 
> r4:ef02
> [   31.436300] [] (dev_change_flags) from [] 
> (do_setlink+0x28c/0xbdc)
> [   31.444213]  r9:edc5d010 r8:ed447c18 r7: r6:c0c08488 r5:ed447b50 
> r4:ef02
> [   31.451955] [] (do_setlink) from [] 
> (rtnl_newlink+0x54c/0x7a8)
> [   31.459522]  r10:ed447d04 r9: r8: r7: r6: 
> r5:
> [   31.467343]  r4:ef02
> [   31.469885] [] (rtnl_newlink) from [] 
> (rtnetlink_rcv_msg+0x38c/0x544)
> [   31.478058]  r10:ed447d04 r9: r8:ee242840 r7: r6:edc5d000 
> r5:c0c08488
> [   31.485879]  r4:
> [   31.488422] [] (rtnetlink_rcv_msg) from [] 
> (netlink_rcv_skb+0xc0/0x118)
> [   31.496768]  r10:c0c08488 r9: r8:0020 r7:edc5d000 r6:c064466c 
> r5:c0c08488
> [   31.504589]  r4:ee242840
> [   31.507129] [] (netlink_rcv_skb) from [] 
> (rtnetlink_rcv+0x18/0x1c)
> [   31.515042]  r8:ed447d60 r7:ee242840 r6:0020 r5:ee37d800 r4:ee5fac00
> [   31.521742] [] (rtnetlink_rcv) from [] 
> (netlink_unicast+0x190/0x1fc)
> [   31.529829] [] (netlink_unicast) from [] 
> (netlink_sendmsg+0x3cc/0x410)
> [   31.538089]  r10: r9:0020 r8:014000c0 r7:ee242840 r6:ee37d800 
> r5:c0c08488
> [   31.545910]  r4:ed447f44
> [   31.548452] [] (netlink_sendmsg) from [] 
> (sock_sendmsg+0x1c/0x2c)
> [   31.556279]  r10: r9:ed447edc r8: r7:eefce640 r6: 
> r5:c0c08488
> [   31.564100]  r4:ed447f44
> [   31.566640] [] (sock_sendmsg) from [] 
> (___sys_sendmsg+0x250/0x264)
> [   31.574555] [] (___sys_sendmsg) from [] 
> (__sys_sendmsg+0x58/0x94)
> [   31.582382]  r10: r9:ed446000 r8:c01011c4 r7:eefce640 r6: 
> r5:bec25150
> [   31.590203]  r4:c0c08488
> [   31.592743] [] (__sys_sendmsg) from [] 
> (sys_sendmsg+0x14/0x18)
> [   31.600307]  r7:0128 r6:bec2d17c r5:bec25144 r4:00093ee0
> [   31.605969] [] (sys_sendmsg) from [] 
> (ret_fast_syscall+0x0/0x28)
> [   31.613704] Exception stack(0xed447fa8 to 0xed447ff0)
> [   31.618756] 7fa0:   00093ee0 bec25144 0003 bec25150 
>  85ce
> [   31.626929] 7fc0: 00093ee0 bec25144 bec2d17c 0128 000942a8 5afc783a 
> 00094000 bec25150
> [   31.635099] 7fe0:  bec250f0 012c b6e10b5c
> [   31.640152] Code: e59a261c e59a013c e50b306c e592300c (e593300c) 
> [   31.646632] ---[ end trace 407964b7deb937bf ]---
>
> For the moment, I stil didnt find the issue.
> What to we do now ? do you want that I send revert patchs ?

No need for revert. I checked the patch and dwmac-sun8i
implementation and I think I found the problem. I will send you a
patch to test.

Thanks and Best Regards,
Jose Miguel Abreu

>
> Regards

[BUG] net: stmmac: dwmac-sun8i broken in linux-next

2018-05-16 Thread Corentin Labbe

Hello

The dwmac-sun8i driver is broken in next-20180515, symptom are no RX and TX 
errors as shown by ifconfig:
eth0: flags=4163  mtu 1500
inet 192.168.1.204  netmask 255.255.255.0  broadcast 192.168.1.255
ether 96:75:ff:0d:f6:d8  txqueuelen 1000  (Ethernet)
RX packets 0  bytes 0 (0.0 B)
RX errors 0  dropped 0  overruns 0  frame 0
TX packets 0  bytes 4956 (4.8 KiB)
TX errors 118  dropped 0 overruns 0  carrier 0  collisions 0

Reverting the following commit made the driver working:
4dbbe8dde8485b89bce8bbbe7564337fd7eed69f ("net: stmmac: Add support for U32 TC 
filter using Flexible RX Parser")
5f0456b43140af9413397cc11d03d18b9f2fc2fc ("net: stmmac: Implement logic to 
automatically select HW Interface")

Note that reverting only 4dbbe8dde8485b89bce8bbbe7564337fd7eed69f lead to crash:
[   31.385110] Backtrace: 
[   31.387576] [] (stmmac_open) from [] 
(__dev_open+0xe4/0x180)
[   31.394972]  r10:ed447d04 r9:edc5d010 r8:ef02002c r7:c08670a4 r6: 
r5:c0c08488
[   31.402793]  r4:ef02
[   31.405335] [] (__dev_open) from [] 
(__dev_change_flags+0x190/0x1e8)
[   31.413421]  r8:1002 r7:c0c08488 r6:1003 r5:0001 r4:ef02
[   31.420122] [] (__dev_change_flags) from [] 
(dev_change_flags+0x20/0x50)
[   31.428555]  r9:edc5d010 r8:ed447c18 r7:ef020134 r6: r5:1002 
r4:ef02
[   31.436300] [] (dev_change_flags) from [] 
(do_setlink+0x28c/0xbdc)
[   31.444213]  r9:edc5d010 r8:ed447c18 r7: r6:c0c08488 r5:ed447b50 
r4:ef02
[   31.451955] [] (do_setlink) from [] 
(rtnl_newlink+0x54c/0x7a8)
[   31.459522]  r10:ed447d04 r9: r8: r7: r6: 
r5:
[   31.467343]  r4:ef02
[   31.469885] [] (rtnl_newlink) from [] 
(rtnetlink_rcv_msg+0x38c/0x544)
[   31.478058]  r10:ed447d04 r9: r8:ee242840 r7: r6:edc5d000 
r5:c0c08488
[   31.485879]  r4:
[   31.488422] [] (rtnetlink_rcv_msg) from [] 
(netlink_rcv_skb+0xc0/0x118)
[   31.496768]  r10:c0c08488 r9: r8:0020 r7:edc5d000 r6:c064466c 
r5:c0c08488
[   31.504589]  r4:ee242840
[   31.507129] [] (netlink_rcv_skb) from [] 
(rtnetlink_rcv+0x18/0x1c)
[   31.515042]  r8:ed447d60 r7:ee242840 r6:0020 r5:ee37d800 r4:ee5fac00
[   31.521742] [] (rtnetlink_rcv) from [] 
(netlink_unicast+0x190/0x1fc)
[   31.529829] [] (netlink_unicast) from [] 
(netlink_sendmsg+0x3cc/0x410)
[   31.538089]  r10: r9:0020 r8:014000c0 r7:ee242840 r6:ee37d800 
r5:c0c08488
[   31.545910]  r4:ed447f44
[   31.548452] [] (netlink_sendmsg) from [] 
(sock_sendmsg+0x1c/0x2c)
[   31.556279]  r10: r9:ed447edc r8: r7:eefce640 r6: 
r5:c0c08488
[   31.564100]  r4:ed447f44
[   31.566640] [] (sock_sendmsg) from [] 
(___sys_sendmsg+0x250/0x264)
[   31.574555] [] (___sys_sendmsg) from [] 
(__sys_sendmsg+0x58/0x94)
[   31.582382]  r10: r9:ed446000 r8:c01011c4 r7:eefce640 r6: 
r5:bec25150
[   31.590203]  r4:c0c08488
[   31.592743] [] (__sys_sendmsg) from [] 
(sys_sendmsg+0x14/0x18)
[   31.600307]  r7:0128 r6:bec2d17c r5:bec25144 r4:00093ee0
[   31.605969] [] (sys_sendmsg) from [] 
(ret_fast_syscall+0x0/0x28)
[   31.613704] Exception stack(0xed447fa8 to 0xed447ff0)
[   31.618756] 7fa0:   00093ee0 bec25144 0003 bec25150 
 85ce
[   31.626929] 7fc0: 00093ee0 bec25144 bec2d17c 0128 000942a8 5afc783a 
00094000 bec25150
[   31.635099] 7fe0:  bec250f0 012c b6e10b5c
[   31.640152] Code: e59a261c e59a013c e50b306c e592300c (e593300c) 
[   31.646632] ---[ end trace 407964b7deb937bf ]---

For the moment, I stil didnt find the issue.
What to we do now ? do you want that I send revert patchs ?

Regards

[BUG] net: stmmac: dwmac-sun8i broken in linux-next

2018-05-16 Thread Corentin Labbe

Hello

The dwmac-sun8i driver is broken in next-20180515, symptom are no RX and TX 
errors as shown by ifconfig:
eth0: flags=4163  mtu 1500
inet 192.168.1.204  netmask 255.255.255.0  broadcast 192.168.1.255
ether 96:75:ff:0d:f6:d8  txqueuelen 1000  (Ethernet)
RX packets 0  bytes 0 (0.0 B)
RX errors 0  dropped 0  overruns 0  frame 0
TX packets 0  bytes 4956 (4.8 KiB)
TX errors 118  dropped 0 overruns 0  carrier 0  collisions 0

Reverting the following commit made the driver working:
4dbbe8dde8485b89bce8bbbe7564337fd7eed69f ("net: stmmac: Add support for U32 TC 
filter using Flexible RX Parser")
5f0456b43140af9413397cc11d03d18b9f2fc2fc ("net: stmmac: Implement logic to 
automatically select HW Interface")

Note that reverting only 4dbbe8dde8485b89bce8bbbe7564337fd7eed69f lead to crash:
[   31.385110] Backtrace: 
[   31.387576] [] (stmmac_open) from [] 
(__dev_open+0xe4/0x180)
[   31.394972]  r10:ed447d04 r9:edc5d010 r8:ef02002c r7:c08670a4 r6: 
r5:c0c08488
[   31.402793]  r4:ef02
[   31.405335] [] (__dev_open) from [] 
(__dev_change_flags+0x190/0x1e8)
[   31.413421]  r8:1002 r7:c0c08488 r6:1003 r5:0001 r4:ef02
[   31.420122] [] (__dev_change_flags) from [] 
(dev_change_flags+0x20/0x50)
[   31.428555]  r9:edc5d010 r8:ed447c18 r7:ef020134 r6: r5:1002 
r4:ef02
[   31.436300] [] (dev_change_flags) from [] 
(do_setlink+0x28c/0xbdc)
[   31.444213]  r9:edc5d010 r8:ed447c18 r7: r6:c0c08488 r5:ed447b50 
r4:ef02
[   31.451955] [] (do_setlink) from [] 
(rtnl_newlink+0x54c/0x7a8)
[   31.459522]  r10:ed447d04 r9: r8: r7: r6: 
r5:
[   31.467343]  r4:ef02
[   31.469885] [] (rtnl_newlink) from [] 
(rtnetlink_rcv_msg+0x38c/0x544)
[   31.478058]  r10:ed447d04 r9: r8:ee242840 r7: r6:edc5d000 
r5:c0c08488
[   31.485879]  r4:
[   31.488422] [] (rtnetlink_rcv_msg) from [] 
(netlink_rcv_skb+0xc0/0x118)
[   31.496768]  r10:c0c08488 r9: r8:0020 r7:edc5d000 r6:c064466c 
r5:c0c08488
[   31.504589]  r4:ee242840
[   31.507129] [] (netlink_rcv_skb) from [] 
(rtnetlink_rcv+0x18/0x1c)
[   31.515042]  r8:ed447d60 r7:ee242840 r6:0020 r5:ee37d800 r4:ee5fac00
[   31.521742] [] (rtnetlink_rcv) from [] 
(netlink_unicast+0x190/0x1fc)
[   31.529829] [] (netlink_unicast) from [] 
(netlink_sendmsg+0x3cc/0x410)
[   31.538089]  r10: r9:0020 r8:014000c0 r7:ee242840 r6:ee37d800 
r5:c0c08488
[   31.545910]  r4:ed447f44
[   31.548452] [] (netlink_sendmsg) from [] 
(sock_sendmsg+0x1c/0x2c)
[   31.556279]  r10: r9:ed447edc r8: r7:eefce640 r6: 
r5:c0c08488
[   31.564100]  r4:ed447f44
[   31.566640] [] (sock_sendmsg) from [] 
(___sys_sendmsg+0x250/0x264)
[   31.574555] [] (___sys_sendmsg) from [] 
(__sys_sendmsg+0x58/0x94)
[   31.582382]  r10: r9:ed446000 r8:c01011c4 r7:eefce640 r6: 
r5:bec25150
[   31.590203]  r4:c0c08488
[   31.592743] [] (__sys_sendmsg) from [] 
(sys_sendmsg+0x14/0x18)
[   31.600307]  r7:0128 r6:bec2d17c r5:bec25144 r4:00093ee0
[   31.605969] [] (sys_sendmsg) from [] 
(ret_fast_syscall+0x0/0x28)
[   31.613704] Exception stack(0xed447fa8 to 0xed447ff0)
[   31.618756] 7fa0:   00093ee0 bec25144 0003 bec25150 
 85ce
[   31.626929] 7fc0: 00093ee0 bec25144 bec2d17c 0128 000942a8 5afc783a 
00094000 bec25150
[   31.635099] 7fe0:  bec250f0 012c b6e10b5c
[   31.640152] Code: e59a261c e59a013c e50b306c e592300c (e593300c) 
[   31.646632] ---[ end trace 407964b7deb937bf ]---

For the moment, I stil didnt find the issue.
What to we do now ? do you want that I send revert patchs ?

Regards

Re: [BUG] net: stmmac: dwmac-sun8i broken in linux-next

Re: [BUG] net: stmmac: dwmac-sun8i broken in linux-next

[BUG] net: stmmac: dwmac-sun8i broken in linux-next

[BUG] net: stmmac: dwmac-sun8i broken in linux-next

4 matches

Site Navigation

Mail list logo

Footer information