Re: [EXT] [PATCH v2 2/4] dt-bindings: spi: add compatible entry for imx8mp in FlexSPI controller
Hello Kuldeep, On 09.03.21 07:29, Kuldeep Singh wrote: >> Hi! >> >> On 09.03.21 06:56, Kuldeep Singh wrote: >>> Hi Heiko, >>> >>>> -Original Message- >>>> From: Heiko Schocher >>>> Sent: Tuesday, March 9, 2021 11:01 AM >>>> To: linux-arm-ker...@lists.infradead.org >>>> Cc: Heiko Schocher ; Ashish Kumar ; >>>> Mark Brown ; Rob Herring ; >>>> Yogesh Gaur ; devicet...@vger.kernel.org; >>>> linux- ker...@vger.kernel.org; linux-...@vger.kernel.org >>>> Subject: [EXT] [PATCH v2 2/4] dt-bindings: spi: add compatible entry >>>> for imx8mp in FlexSPI controller >>>> >>>> Caution: EXT Email >>>> >>>> add compatible entry "nxp,imx8mp-fspi" in NXP FlexSPI controller >>>> >>>> Signed-off-by: Heiko Schocher >>>> --- >>>> >>>> (no changes since v1) >>>> >>>> Documentation/devicetree/bindings/spi/spi-nxp-fspi.txt | 1 + >>>> 1 file changed, 1 insertion(+) >>>> >>>> diff --git a/Documentation/devicetree/bindings/spi/spi-nxp-fspi.txt >>>> b/Documentation/devicetree/bindings/spi/spi-nxp-fspi.txt >>>> index 7ac60d9fe3571..fd5f081f6d91b 100644 >>>> --- a/Documentation/devicetree/bindings/spi/spi-nxp-fspi.txt >>>> +++ b/Documentation/devicetree/bindings/spi/spi-nxp-fspi.txt >>>> @@ -4,6 +4,7 @@ Required properties: >>>>- compatible : Should be "nxp,lx2160a-fspi" >>>> "nxp,imx8qxp-fspi" >>>> "nxp,imx8mm-fspi" >>>> + "nxp,imx8mp-fspi" >>> >>> It seems the changes are not on top of tree. Please see[1] for latest >>> changes >> including imx8dxl entry. >>> Snippet below: >>> >>> Required properties: >>> - compatible : Should be "nxp,lx2160a-fspi" >>> "nxp,imx8qxp-fspi" >>> "nxp,imx8mm-fspi" >>> "nxp,imx8dxl-fspi" >> >> My patches are based on mainline.. >> * 144c79ef33536 - (origin/master, origin/HEAD) Merge tag >> 'perf-tools-fixes-for- >> v5.12-2020-03-07' >> of git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux (vor 32 Stunden) >> >> >> Should I post this patch rebased on [1] or may all patches rebased on [1] ? > > Hi Heiko, > > As per cover letter, I can identify that first two are driver/Documentation > patches and other two are device-tree patches. > Device-tree patches(3/4 and 4/4) will go via Shawn tree > (git://git.kernel.org/pub/scm/linux/kernel/git/shawnguo/linux.git) > And initial two driver patches(1/4 and 2/4) will go via Mark's tree > (git://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git) > > One approach I can think of is to send driver patches first and later send > device-tree patches mentioning dependency on first two patches. Yep, seems a good approach to me. > Maybe Mark can comment here if he has any other opinion. Yep, will wait for more comments, and if all is fine with this patchset, I can split it into 2 series. Thanks! bye, Heiko -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-52 Fax: +49-8142-66989-80 Email: h...@denx.de
RE: [EXT] [PATCH v2 2/4] dt-bindings: spi: add compatible entry for imx8mp in FlexSPI controller
> Hi! > > On 09.03.21 06:56, Kuldeep Singh wrote: > > Hi Heiko, > > > >> -Original Message- > >> From: Heiko Schocher > >> Sent: Tuesday, March 9, 2021 11:01 AM > >> To: linux-arm-ker...@lists.infradead.org > >> Cc: Heiko Schocher ; Ashish Kumar ; > >> Mark Brown ; Rob Herring ; > >> Yogesh Gaur ; devicet...@vger.kernel.org; > >> linux- ker...@vger.kernel.org; linux-...@vger.kernel.org > >> Subject: [EXT] [PATCH v2 2/4] dt-bindings: spi: add compatible entry > >> for imx8mp in FlexSPI controller > >> > >> Caution: EXT Email > >> > >> add compatible entry "nxp,imx8mp-fspi" in NXP FlexSPI controller > >> > >> Signed-off-by: Heiko Schocher > >> --- > >> > >> (no changes since v1) > >> > >> Documentation/devicetree/bindings/spi/spi-nxp-fspi.txt | 1 + > >> 1 file changed, 1 insertion(+) > >> > >> diff --git a/Documentation/devicetree/bindings/spi/spi-nxp-fspi.txt > >> b/Documentation/devicetree/bindings/spi/spi-nxp-fspi.txt > >> index 7ac60d9fe3571..fd5f081f6d91b 100644 > >> --- a/Documentation/devicetree/bindings/spi/spi-nxp-fspi.txt > >> +++ b/Documentation/devicetree/bindings/spi/spi-nxp-fspi.txt > >> @@ -4,6 +4,7 @@ Required properties: > >>- compatible : Should be "nxp,lx2160a-fspi" > >> "nxp,imx8qxp-fspi" > >> "nxp,imx8mm-fspi" > >> + "nxp,imx8mp-fspi" > > > > It seems the changes are not on top of tree. Please see[1] for latest > > changes > including imx8dxl entry. > > Snippet below: > > > > Required properties: > > - compatible : Should be "nxp,lx2160a-fspi" > > "nxp,imx8qxp-fspi" > > "nxp,imx8mm-fspi" > > "nxp,imx8dxl-fspi" > > My patches are based on mainline.. > * 144c79ef33536 - (origin/master, origin/HEAD) Merge tag > 'perf-tools-fixes-for- > v5.12-2020-03-07' > of git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux (vor 32 Stunden) > > > Should I post this patch rebased on [1] or may all patches rebased on [1] ? Hi Heiko, As per cover letter, I can identify that first two are driver/Documentation patches and other two are device-tree patches. Device-tree patches(3/4 and 4/4) will go via Shawn tree (git://git.kernel.org/pub/scm/linux/kernel/git/shawnguo/linux.git) And initial two driver patches(1/4 and 2/4) will go via Mark's tree (git://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git) One approach I can think of is to send driver patches first and later send device-tree patches mentioning dependency on first two patches. Maybe Mark can comment here if he has any other opinion. Thanks Kuldeep
Re: [EXT] [PATCH v2 2/4] dt-bindings: spi: add compatible entry for imx8mp in FlexSPI controller
Hi! On 09.03.21 06:56, Kuldeep Singh wrote: > Hi Heiko, > >> -Original Message- >> From: Heiko Schocher >> Sent: Tuesday, March 9, 2021 11:01 AM >> To: linux-arm-ker...@lists.infradead.org >> Cc: Heiko Schocher ; Ashish Kumar ; >> Mark Brown ; Rob Herring ; Yogesh >> Gaur ; devicet...@vger.kernel.org; linux- >> ker...@vger.kernel.org; linux-...@vger.kernel.org >> Subject: [EXT] [PATCH v2 2/4] dt-bindings: spi: add compatible entry for >> imx8mp in >> FlexSPI controller >> >> Caution: EXT Email >> >> add compatible entry "nxp,imx8mp-fspi" in NXP FlexSPI controller >> >> Signed-off-by: Heiko Schocher >> --- >> >> (no changes since v1) >> >> Documentation/devicetree/bindings/spi/spi-nxp-fspi.txt | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/Documentation/devicetree/bindings/spi/spi-nxp-fspi.txt >> b/Documentation/devicetree/bindings/spi/spi-nxp-fspi.txt >> index 7ac60d9fe3571..fd5f081f6d91b 100644 >> --- a/Documentation/devicetree/bindings/spi/spi-nxp-fspi.txt >> +++ b/Documentation/devicetree/bindings/spi/spi-nxp-fspi.txt >> @@ -4,6 +4,7 @@ Required properties: >>- compatible : Should be "nxp,lx2160a-fspi" >> "nxp,imx8qxp-fspi" >> "nxp,imx8mm-fspi" >> + "nxp,imx8mp-fspi" > > It seems the changes are not on top of tree. Please see[1] for latest changes > including imx8dxl entry. > Snippet below: > > Required properties: > - compatible : Should be "nxp,lx2160a-fspi" > "nxp,imx8qxp-fspi" > "nxp,imx8mm-fspi" > "nxp,imx8dxl-fspi" My patches are based on mainline.. * 144c79ef33536 - (origin/master, origin/HEAD) Merge tag 'perf-tools-fixes-for-v5.12-2020-03-07' of git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux (vor 32 Stunden) Should I post this patch rebased on [1] or may all patches rebased on [1] ? Thanks! bye, Heiko > > Thanks > Kuldeep > [1] > https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git/tree/Documentation/devicetree/bindings/spi/spi-nxp-fspi.txt > -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-52 Fax: +49-8142-66989-80 Email: h...@denx.de
RE: [EXT] [PATCH v2 2/4] dt-bindings: spi: add compatible entry for imx8mp in FlexSPI controller
Hi Heiko, > -Original Message- > From: Heiko Schocher > Sent: Tuesday, March 9, 2021 11:01 AM > To: linux-arm-ker...@lists.infradead.org > Cc: Heiko Schocher ; Ashish Kumar ; > Mark Brown ; Rob Herring ; Yogesh > Gaur ; devicet...@vger.kernel.org; linux- > ker...@vger.kernel.org; linux-...@vger.kernel.org > Subject: [EXT] [PATCH v2 2/4] dt-bindings: spi: add compatible entry for > imx8mp in > FlexSPI controller > > Caution: EXT Email > > add compatible entry "nxp,imx8mp-fspi" in NXP FlexSPI controller > > Signed-off-by: Heiko Schocher > --- > > (no changes since v1) > > Documentation/devicetree/bindings/spi/spi-nxp-fspi.txt | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Documentation/devicetree/bindings/spi/spi-nxp-fspi.txt > b/Documentation/devicetree/bindings/spi/spi-nxp-fspi.txt > index 7ac60d9fe3571..fd5f081f6d91b 100644 > --- a/Documentation/devicetree/bindings/spi/spi-nxp-fspi.txt > +++ b/Documentation/devicetree/bindings/spi/spi-nxp-fspi.txt > @@ -4,6 +4,7 @@ Required properties: >- compatible : Should be "nxp,lx2160a-fspi" > "nxp,imx8qxp-fspi" > "nxp,imx8mm-fspi" > + "nxp,imx8mp-fspi" It seems the changes are not on top of tree. Please see[1] for latest changes including imx8dxl entry. Snippet below: Required properties: - compatible : Should be "nxp,lx2160a-fspi" "nxp,imx8qxp-fspi" "nxp,imx8mm-fspi" "nxp,imx8dxl-fspi" Thanks Kuldeep [1] https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git/tree/Documentation/devicetree/bindings/spi/spi-nxp-fspi.txt
