Re: [GFS2 & DLM] Guide to -nmw tree patches
On Thu, 2006-11-30 at 13:21 +0100, Arjan van de Ven wrote: > On Thu, 2006-11-30 at 12:12 +, Steven Whitehouse wrote: > > Hi, > > > > Below is a summary diffstat of all the changes in the GFS2 & DLM -nmw > > (next merge window) git tree. Since merge time is once again upon us, > > the following patches are the current complete content of the tree. > > > Hi, > > can you please make sure your patch series is in reply to your first > message, so that your mails properly thread in mail clients? > > (everyone else seems to manage this, I bet the git or quilt patch series > send stuff has this built in somehow..) I agree. I would also continue to urge for internal reviews (since this is the first I have seen any of these changes) before spamming lkml with 70 loosely related patches. > > Greetings, > Arjan van de Ven > > - > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to [EMAIL PROTECTED] > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ -- Russell Cattelan <[EMAIL PROTECTED]> signature.asc Description: This is a digitally signed message part
Re: [GFS2 DLM] Guide to -nmw tree patches
On Thu, 2006-11-30 at 13:21 +0100, Arjan van de Ven wrote: On Thu, 2006-11-30 at 12:12 +, Steven Whitehouse wrote: Hi, Below is a summary diffstat of all the changes in the GFS2 DLM -nmw (next merge window) git tree. Since merge time is once again upon us, the following patches are the current complete content of the tree. Hi, can you please make sure your patch series is in reply to your first message, so that your mails properly thread in mail clients? (everyone else seems to manage this, I bet the git or quilt patch series send stuff has this built in somehow..) I agree. I would also continue to urge for internal reviews (since this is the first I have seen any of these changes) before spamming lkml with 70 loosely related patches. Greetings, Arjan van de Ven - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ -- Russell Cattelan [EMAIL PROTECTED] signature.asc Description: This is a digitally signed message part
Re: [GFS2 & DLM] Guide to -nmw tree patches
Proper email threading is important for web ML archives too... How does the attached read to a native english speaker ? Suggestions to put that elsewhere, or better phrasing... Or maybe, as per akpm's tpp document suggest, this introductory emails should be forbidden^wdiscouraged, and the text properly dispatched in the apropriate changelogs ? P.S.: I'm not subscribed, and couldn't find a way to do a proper reply to Arjan's message, so, sorry to break the proposed rule myself... -- Vincent Legoll Add a suggestion to properly thread patch series Discussion started in thread form 2006-11-30: Re: [GFS2 & DLM] Guide to -nmw tree patches --- commit dbdb1b56acc95508e720ba6fb04ebf8c4a5089fd tree 6ef01b1ae85c24cb2643ef4c1de541fbfb9b583d parent 0215ffb08ce99e2bb59eca114a99499a4d06e704 author Vincent Legoll <[EMAIL PROTECTED]> Fri, 01 Dec 2006 00:03:46 +0100 committer Vincent Legoll <[EMAIL PROTECTED]> Fri, 01 Dec 2006 00:03:46 +0100 Documentation/SubmittingPatches |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/Documentation/SubmittingPatches b/Documentation/SubmittingPatches index 302d148..00f96c7 100644 --- a/Documentation/SubmittingPatches +++ b/Documentation/SubmittingPatches @@ -116,6 +116,9 @@ in your patch description. If you cannot condense your patch set into a smaller set of patches, then only post say 15 or so at a time and wait for review and integration. +If your patch set is not trivial, and you want to introduce the series +with a presentation email, please post all the patches as a reply to that +introduction, so that the whole email set is properly threaded. 4) Select e-mail destination.
Re: [GFS2 & DLM] Guide to -nmw tree patches
Hi, On Thu, 2006-11-30 at 13:21 +0100, Arjan van de Ven wrote: > On Thu, 2006-11-30 at 12:12 +, Steven Whitehouse wrote: > > Hi, > > > > Below is a summary diffstat of all the changes in the GFS2 & DLM -nmw > > (next merge window) git tree. Since merge time is once again upon us, > > the following patches are the current complete content of the tree. > > > Hi, > > can you please make sure your patch series is in reply to your first > message, so that your mails properly thread in mail clients? > > (everyone else seems to manage this, I bet the git or quilt patch series > send stuff has this built in somehow..) > > Greetings, > Arjan van de Ven > Ah, sorry, I didn't realise that I should be doing that. I guess its because my desktop doesn't have the git tree on it, so I tend to copy them over & send by hand. I need to look into automating the send process anyway as its taking me too much time with large patch sets, so I'll try and have that fixed for next time, Steve. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[GFS2 & DLM] Guide to -nmw tree patches
Hi, Below is a summary diffstat of all the changes in the GFS2 & DLM -nmw (next merge window) git tree. Since merge time is once again upon us, the following patches are the current complete content of the tree. Although there are quite a few patches, there are relatively few major changes. There is one new feature and thats the DLM TCP communications layer. This existed before the (current upstream) TCP communications layer and has received more testing over its lifetime, so its a kind of old new feature :-) Also 9 of these patches have been posted before as part of the -fixes tree, so there are here again as Linus didn't pull that tree last week and this is a superset therefore of the -fixes tree. I've marked the patches that have been posted before with a * in the list below. Also I've classified the patches into new=N, cleanup=C and bugfix=B to help make more sense of them. Of the remaining patches, 15 of them are from Al Viro and relate to endianess annotation. A similar number of follow up patches from myself build on that work by removing duplicated fields in the GFS2 in-core inode, thus shrinking it and removing some extra copying that we were doing. Assuming that no major objections are raised, I'll send Linus a pull request for these patches shortly. If any minor points are raised, then hopefully they can be resolved with a follow up patch. These patches have mostly (aside from the last few) been in -mm for some time now. The patches do not touch anything outside the GFS2/DLM code. Many thanks to all those who have sent bug reports & patches, Steve. --- The following changes since commit 0215ffb08ce99e2bb59eca114a99499a4d06e704: Linus Torvalds: Linux 2.6.19 are found in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/steve/gfs2-2.6-nmw.git Al Viro: [GFS2] split gfs2_dinode into on-disk and host variants [C] [GFS2] gfs2_dinode_host fields are host-endian[C] [GFS2] split gfs2_sb [C] [GFS2] fields of gfs2_sb_host are host-endian [C] [GFS2] split and annotate gfs2_rgrp [C] [GFS2] split and annotate gfs2_inum_range [C] [GFS2] split and annotate gfs2_log_head [C] [GFS2] split and annotate gfs2_meta_header[C] [GFS2] split and annotate gfs_rindex [C] [GFS2] split and annotate gfs2_inum [C] [GFS2] split and annotate gfs2_quota [C] [GFS2] split and annotate gfs2_statfs_change [C] [GFS2] split and annotate gfs2_quota_change [C] [GFS2] gfs2 misc endianness annotations [C] [GFS2] gfs2 __user misannotation fix [C] David Teigland: [DLM] res_recover_locks_count not reset when recover_locks is aborted [B, *] [DLM] status messages ping-pong between unmounted nodes [B, *] [DLM] fix requestqueue race [B, *] [DLM] fix aborted recovery during node removal[B, *] [DLM] fix stopping unstarted recovery [B, *] [DLM] do full recover_locks barrier [B, *] [DLM] clear sbflags on lock master[B, *] [DLM] fix add_requestqueue checking nodes list[B] [DLM] fix size of STATUS_REPLY message[B] [DLM] don't accept replies to old recovery messages [B] Patrick Caulfield: [DLM] Add support for tcp communications [N] [DLM] Fix DLM config [B] Randy Dunlap: [GFS2] lock function parameter[B] Russell Cattelan: [GFS2] Fix race in logging code [B] [GFS2] Remove unused zero_readpage from stuffed_readpage [B] Ryusuke Konishi: [GFS2] fs/gfs2/log.c:log_bmap() fix printk format warning [C] [DLM] fix format warnings in rcom.c and recoverd.c[C] Srinivasa Ds: [GFS2] Mount problem with the GFS2 code [B] Steven Whitehouse: [GFS2] Fix crc32 calculation in recovery.c[B] [GFS2] Change argument of gfs2_dinode_out [C] [GFS2] Change argument to gfs2_dinode_in [C] [GFS2] Move gfs2_dinode_in to inode.c
Re: [GFS2 & DLM] Guide to -nmw tree patches
On Thu, 2006-11-30 at 12:12 +, Steven Whitehouse wrote: > Hi, > > Below is a summary diffstat of all the changes in the GFS2 & DLM -nmw > (next merge window) git tree. Since merge time is once again upon us, > the following patches are the current complete content of the tree. Hi, can you please make sure your patch series is in reply to your first message, so that your mails properly thread in mail clients? (everyone else seems to manage this, I bet the git or quilt patch series send stuff has this built in somehow..) Greetings, Arjan van de Ven - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [GFS2 DLM] Guide to -nmw tree patches
On Thu, 2006-11-30 at 12:12 +, Steven Whitehouse wrote: Hi, Below is a summary diffstat of all the changes in the GFS2 DLM -nmw (next merge window) git tree. Since merge time is once again upon us, the following patches are the current complete content of the tree. Hi, can you please make sure your patch series is in reply to your first message, so that your mails properly thread in mail clients? (everyone else seems to manage this, I bet the git or quilt patch series send stuff has this built in somehow..) Greetings, Arjan van de Ven - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[GFS2 DLM] Guide to -nmw tree patches
Hi, Below is a summary diffstat of all the changes in the GFS2 DLM -nmw (next merge window) git tree. Since merge time is once again upon us, the following patches are the current complete content of the tree. Although there are quite a few patches, there are relatively few major changes. There is one new feature and thats the DLM TCP communications layer. This existed before the (current upstream) TCP communications layer and has received more testing over its lifetime, so its a kind of old new feature :-) Also 9 of these patches have been posted before as part of the -fixes tree, so there are here again as Linus didn't pull that tree last week and this is a superset therefore of the -fixes tree. I've marked the patches that have been posted before with a * in the list below. Also I've classified the patches into new=N, cleanup=C and bugfix=B to help make more sense of them. Of the remaining patches, 15 of them are from Al Viro and relate to endianess annotation. A similar number of follow up patches from myself build on that work by removing duplicated fields in the GFS2 in-core inode, thus shrinking it and removing some extra copying that we were doing. Assuming that no major objections are raised, I'll send Linus a pull request for these patches shortly. If any minor points are raised, then hopefully they can be resolved with a follow up patch. These patches have mostly (aside from the last few) been in -mm for some time now. The patches do not touch anything outside the GFS2/DLM code. Many thanks to all those who have sent bug reports patches, Steve. --- The following changes since commit 0215ffb08ce99e2bb59eca114a99499a4d06e704: Linus Torvalds: Linux 2.6.19 are found in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/steve/gfs2-2.6-nmw.git Al Viro: [GFS2] split gfs2_dinode into on-disk and host variants [C] [GFS2] gfs2_dinode_host fields are host-endian[C] [GFS2] split gfs2_sb [C] [GFS2] fields of gfs2_sb_host are host-endian [C] [GFS2] split and annotate gfs2_rgrp [C] [GFS2] split and annotate gfs2_inum_range [C] [GFS2] split and annotate gfs2_log_head [C] [GFS2] split and annotate gfs2_meta_header[C] [GFS2] split and annotate gfs_rindex [C] [GFS2] split and annotate gfs2_inum [C] [GFS2] split and annotate gfs2_quota [C] [GFS2] split and annotate gfs2_statfs_change [C] [GFS2] split and annotate gfs2_quota_change [C] [GFS2] gfs2 misc endianness annotations [C] [GFS2] gfs2 __user misannotation fix [C] David Teigland: [DLM] res_recover_locks_count not reset when recover_locks is aborted [B, *] [DLM] status messages ping-pong between unmounted nodes [B, *] [DLM] fix requestqueue race [B, *] [DLM] fix aborted recovery during node removal[B, *] [DLM] fix stopping unstarted recovery [B, *] [DLM] do full recover_locks barrier [B, *] [DLM] clear sbflags on lock master[B, *] [DLM] fix add_requestqueue checking nodes list[B] [DLM] fix size of STATUS_REPLY message[B] [DLM] don't accept replies to old recovery messages [B] Patrick Caulfield: [DLM] Add support for tcp communications [N] [DLM] Fix DLM config [B] Randy Dunlap: [GFS2] lock function parameter[B] Russell Cattelan: [GFS2] Fix race in logging code [B] [GFS2] Remove unused zero_readpage from stuffed_readpage [B] Ryusuke Konishi: [GFS2] fs/gfs2/log.c:log_bmap() fix printk format warning [C] [DLM] fix format warnings in rcom.c and recoverd.c[C] Srinivasa Ds: [GFS2] Mount problem with the GFS2 code [B] Steven Whitehouse: [GFS2] Fix crc32 calculation in recovery.c[B] [GFS2] Change argument of gfs2_dinode_out [C] [GFS2] Change argument to gfs2_dinode_in [C] [GFS2] Move gfs2_dinode_in to inode.c
Re: [GFS2 DLM] Guide to -nmw tree patches
Hi, On Thu, 2006-11-30 at 13:21 +0100, Arjan van de Ven wrote: On Thu, 2006-11-30 at 12:12 +, Steven Whitehouse wrote: Hi, Below is a summary diffstat of all the changes in the GFS2 DLM -nmw (next merge window) git tree. Since merge time is once again upon us, the following patches are the current complete content of the tree. Hi, can you please make sure your patch series is in reply to your first message, so that your mails properly thread in mail clients? (everyone else seems to manage this, I bet the git or quilt patch series send stuff has this built in somehow..) Greetings, Arjan van de Ven Ah, sorry, I didn't realise that I should be doing that. I guess its because my desktop doesn't have the git tree on it, so I tend to copy them over send by hand. I need to look into automating the send process anyway as its taking me too much time with large patch sets, so I'll try and have that fixed for next time, Steve. - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [GFS2 DLM] Guide to -nmw tree patches
Proper email threading is important for web ML archives too... How does the attached read to a native english speaker ? Suggestions to put that elsewhere, or better phrasing... Or maybe, as per akpm's tpp document suggest, this introductory emails should be forbidden^wdiscouraged, and the text properly dispatched in the apropriate changelogs ? P.S.: I'm not subscribed, and couldn't find a way to do a proper reply to Arjan's message, so, sorry to break the proposed rule myself... -- Vincent Legoll Add a suggestion to properly thread patch series Discussion started in thread form 2006-11-30: Re: [GFS2 DLM] Guide to -nmw tree patches --- commit dbdb1b56acc95508e720ba6fb04ebf8c4a5089fd tree 6ef01b1ae85c24cb2643ef4c1de541fbfb9b583d parent 0215ffb08ce99e2bb59eca114a99499a4d06e704 author Vincent Legoll [EMAIL PROTECTED] Fri, 01 Dec 2006 00:03:46 +0100 committer Vincent Legoll [EMAIL PROTECTED] Fri, 01 Dec 2006 00:03:46 +0100 Documentation/SubmittingPatches |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/Documentation/SubmittingPatches b/Documentation/SubmittingPatches index 302d148..00f96c7 100644 --- a/Documentation/SubmittingPatches +++ b/Documentation/SubmittingPatches @@ -116,6 +116,9 @@ in your patch description. If you cannot condense your patch set into a smaller set of patches, then only post say 15 or so at a time and wait for review and integration. +If your patch set is not trivial, and you want to introduce the series +with a presentation email, please post all the patches as a reply to that +introduction, so that the whole email set is properly threaded. 4) Select e-mail destination.
