Re: [GIT PULL] AF_RXRPC fixes and development
David Miller wrote: > > Here are some AF_RXRPC fixes (to tag rxrpc-20140226): > > You really need to post the patch series along with the pull > request so that netdev can review your changes. Okay. Fengguang's magic box reported some warnings with one of the patches, which I'll get fixed up first. Turns out it doesn't like a bunch of __be values being added together to make a hash value without casts:-/ David -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [GIT PULL] AF_RXRPC fixes and development
David Miller da...@davemloft.net wrote: Here are some AF_RXRPC fixes (to tag rxrpc-20140226): You really need to post the patch series along with the pull request so that netdev can review your changes. Okay. Fengguang's magic box reported some warnings with one of the patches, which I'll get fixed up first. Turns out it doesn't like a bunch of __be values being added together to make a hash value without casts:-/ David -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [GIT PULL] AF_RXRPC fixes and development
From: David Howells Date: Wed, 26 Feb 2014 17:41:45 + > Here are some AF_RXRPC fixes (to tag rxrpc-20140226): You really need to post the patch series along with the pull request so that netdev can review your changes. Thank you. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[GIT PULL] AF_RXRPC fixes and development
Here are some AF_RXRPC fixes (to tag rxrpc-20140226): (1) Fix to remove incorrect checksum calculation made during recvmsg(). It's unnecessary to try to do this there since we check the checksum before reading the RxRPC header from the packet. (2) Fix to prevent the sending of an ABORT packet in response to another ABORT packet and inducing a storm. (3) Fix UDP MTU calculation from parsing ICMP_FRAG_NEEDED packets where we don't handle the ICMP packet not specifying an MTU size. And development patches (to tag rxrpc-devel-20140226): (4) Add sysctls for configuring RxRPC parameters, specifically various delays pertaining to ACK generation, the time before we resend a packet for which we don't receive an ACK, the maximum time a call is permitted to live and the amount of time transport, connection and dead call information is cached. (5) Improve ACK packet production by adjusting the handling of ACK_REQUESTED packets, ignoring the MORE_PACKETS flag, delaying the production of otherwise immediate ACK_IDLE packets and delaying all ACK_IDLE production (barring the call termination) to half a second. (6) Add more sysctl parameters to expose the Rx window size, the maximum packet size that we're willing to receive and the number of jumbo rxrpc packets we're willing to handle in a single UDP packet. (7) Request ACKs on alternate DATA packets so that the other side doesn't wait till we fill up the Tx window. (8) Use a RCU hash table to look up the rxrpc_call for an incoming packet rather than stepping through a hierarchy involving several spinlocks. Would you rather these were separate pull requests? David --- The following changes since commit 38dbfb59d1175ef458d006556061adeaa8751b72: Linus 3.14-rc1 (2014-02-02 16:42:13 -0800) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git tags/rxrpc-devel-20140226 for you to fetch changes up to 224c577c412f620a600c15c86afe82157161d7e7: af_rxrpc: Keep rxrpc_call pointers in a hashtable (2014-02-26 17:25:07 +) (from the branch description for rxrpc local branch) RxRPC development RxRPC development David Howells (5): af_rxrpc: Fix UDP MTU calculation from ICMP_FRAG_NEEDED af_rxrpc: Add sysctls for configuring RxRPC parameters af_rxrpc: Improve ACK production af_rxrpc: Expose more RxRPC parameters via sysctls af_rxrpc: Request an ACK for every alternate DATA packet Tim Smith (3): af_rxrpc: Remove incorrect checksum calculation from rxrpc_recvmsg() af_rxrpc: Prevent RxRPC peers from ABORT-storming one another af_rxrpc: Keep rxrpc_call pointers in a hashtable Documentation/networking/rxrpc.txt | 81 +++ net/rxrpc/Makefile | 5 +- net/rxrpc/af_rxrpc.c | 9 ++ net/rxrpc/ar-ack.c | 61 +-- net/rxrpc/ar-call.c| 202 +++-- net/rxrpc/ar-connection.c | 10 +- net/rxrpc/ar-error.c | 1 + net/rxrpc/ar-input.c | 190 +++--- net/rxrpc/ar-internal.h| 40 +++- net/rxrpc/ar-output.c | 15 ++- net/rxrpc/ar-recvmsg.c | 25 + net/rxrpc/ar-skbuff.c | 7 +- net/rxrpc/ar-transport.c | 10 +- net/rxrpc/sysctl.c | 146 +++ 14 files changed, 636 insertions(+), 166 deletions(-) create mode 100644 net/rxrpc/sysctl.c -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[GIT PULL] AF_RXRPC fixes and development
Here are some AF_RXRPC fixes (to tag rxrpc-20140226): (1) Fix to remove incorrect checksum calculation made during recvmsg(). It's unnecessary to try to do this there since we check the checksum before reading the RxRPC header from the packet. (2) Fix to prevent the sending of an ABORT packet in response to another ABORT packet and inducing a storm. (3) Fix UDP MTU calculation from parsing ICMP_FRAG_NEEDED packets where we don't handle the ICMP packet not specifying an MTU size. And development patches (to tag rxrpc-devel-20140226): (4) Add sysctls for configuring RxRPC parameters, specifically various delays pertaining to ACK generation, the time before we resend a packet for which we don't receive an ACK, the maximum time a call is permitted to live and the amount of time transport, connection and dead call information is cached. (5) Improve ACK packet production by adjusting the handling of ACK_REQUESTED packets, ignoring the MORE_PACKETS flag, delaying the production of otherwise immediate ACK_IDLE packets and delaying all ACK_IDLE production (barring the call termination) to half a second. (6) Add more sysctl parameters to expose the Rx window size, the maximum packet size that we're willing to receive and the number of jumbo rxrpc packets we're willing to handle in a single UDP packet. (7) Request ACKs on alternate DATA packets so that the other side doesn't wait till we fill up the Tx window. (8) Use a RCU hash table to look up the rxrpc_call for an incoming packet rather than stepping through a hierarchy involving several spinlocks. Would you rather these were separate pull requests? David --- The following changes since commit 38dbfb59d1175ef458d006556061adeaa8751b72: Linus 3.14-rc1 (2014-02-02 16:42:13 -0800) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git tags/rxrpc-devel-20140226 for you to fetch changes up to 224c577c412f620a600c15c86afe82157161d7e7: af_rxrpc: Keep rxrpc_call pointers in a hashtable (2014-02-26 17:25:07 +) (from the branch description for rxrpc local branch) RxRPC development RxRPC development David Howells (5): af_rxrpc: Fix UDP MTU calculation from ICMP_FRAG_NEEDED af_rxrpc: Add sysctls for configuring RxRPC parameters af_rxrpc: Improve ACK production af_rxrpc: Expose more RxRPC parameters via sysctls af_rxrpc: Request an ACK for every alternate DATA packet Tim Smith (3): af_rxrpc: Remove incorrect checksum calculation from rxrpc_recvmsg() af_rxrpc: Prevent RxRPC peers from ABORT-storming one another af_rxrpc: Keep rxrpc_call pointers in a hashtable Documentation/networking/rxrpc.txt | 81 +++ net/rxrpc/Makefile | 5 +- net/rxrpc/af_rxrpc.c | 9 ++ net/rxrpc/ar-ack.c | 61 +-- net/rxrpc/ar-call.c| 202 +++-- net/rxrpc/ar-connection.c | 10 +- net/rxrpc/ar-error.c | 1 + net/rxrpc/ar-input.c | 190 +++--- net/rxrpc/ar-internal.h| 40 +++- net/rxrpc/ar-output.c | 15 ++- net/rxrpc/ar-recvmsg.c | 25 + net/rxrpc/ar-skbuff.c | 7 +- net/rxrpc/ar-transport.c | 10 +- net/rxrpc/sysctl.c | 146 +++ 14 files changed, 636 insertions(+), 166 deletions(-) create mode 100644 net/rxrpc/sysctl.c -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [GIT PULL] AF_RXRPC fixes and development
From: David Howells dhowe...@redhat.com Date: Wed, 26 Feb 2014 17:41:45 + Here are some AF_RXRPC fixes (to tag rxrpc-20140226): You really need to post the patch series along with the pull request so that netdev can review your changes. Thank you. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [GIT PULL] AF_RXRPC fixes
From: David Howells Date: Tue, 28 Jan 2014 17:07:36 + > Here are some small AF_RXRPC fixes. > > (1) Fix a place where a spinlock is taken conditionally but is released > unconditionally. > > (2) Fix a double-free that happens when cleaning up on a checksum error. > > (3) Fix handling of CHECKSUM_PARTIAL whilst delivering messages to userspace. Pulled, thanks David. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[GIT PULL] AF_RXRPC fixes
Here are some small AF_RXRPC fixes. (1) Fix a place where a spinlock is taken conditionally but is released unconditionally. (2) Fix a double-free that happens when cleaning up on a checksum error. (3) Fix handling of CHECKSUM_PARTIAL whilst delivering messages to userspace. David --- The following changes since commit d8ec26d7f8287f5788a494f56e8814210f0e64be: Linux 3.13 (2014-01-19 18:40:07 -0800) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git tags/rxrpc-20140126 for you to fetch changes up to 1ea427359dde1573815e19c411ce08fdf0c42cfe: af_rxrpc: Handle frames delivered from another VM (2014-01-26 11:45:04 +) RxRPC fixes Alexey Khoroshilov (1): RxRPC: do not unlock unheld spinlock in rxrpc_connect_exclusive() Tim Smith (2): af_rxrpc: Avoid setting up double-free on checksum error af_rxrpc: Handle frames delivered from another VM net/rxrpc/ar-connection.c | 2 ++ net/rxrpc/ar-recvmsg.c| 7 ++- 2 files changed, 8 insertions(+), 1 deletion(-) -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[GIT PULL] AF_RXRPC fixes
Here are some small AF_RXRPC fixes. (1) Fix a place where a spinlock is taken conditionally but is released unconditionally. (2) Fix a double-free that happens when cleaning up on a checksum error. (3) Fix handling of CHECKSUM_PARTIAL whilst delivering messages to userspace. David --- The following changes since commit d8ec26d7f8287f5788a494f56e8814210f0e64be: Linux 3.13 (2014-01-19 18:40:07 -0800) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git tags/rxrpc-20140126 for you to fetch changes up to 1ea427359dde1573815e19c411ce08fdf0c42cfe: af_rxrpc: Handle frames delivered from another VM (2014-01-26 11:45:04 +) RxRPC fixes Alexey Khoroshilov (1): RxRPC: do not unlock unheld spinlock in rxrpc_connect_exclusive() Tim Smith (2): af_rxrpc: Avoid setting up double-free on checksum error af_rxrpc: Handle frames delivered from another VM net/rxrpc/ar-connection.c | 2 ++ net/rxrpc/ar-recvmsg.c| 7 ++- 2 files changed, 8 insertions(+), 1 deletion(-) -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [GIT PULL] AF_RXRPC fixes
From: David Howells dhowe...@redhat.com Date: Tue, 28 Jan 2014 17:07:36 + Here are some small AF_RXRPC fixes. (1) Fix a place where a spinlock is taken conditionally but is released unconditionally. (2) Fix a double-free that happens when cleaning up on a checksum error. (3) Fix handling of CHECKSUM_PARTIAL whilst delivering messages to userspace. Pulled, thanks David. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
