Re: [GIT PULL] arm64: dts: TI K3 updates for v5.13
On 22:13-20210408, Arnd Bergmann wrote:
> On Thu, Apr 8, 2021 at 6:34 PM Nishanth Menon wrote:
> > On 17:24-20210408, Arnd Bergmann wrote:
> > >
> > > ti/k3-am64-main.dtsi:376.40-385.4: Warning (simple_bus_reg):
> > > /bus@f4000/interrupt-controller0: missing or empty reg/ranges property
> > > ti/k3-am64-main.dtsi:45.13-135.4: Warning (simple_bus_reg):
> > > /bus@f4000/dmss: missing or empty reg/ranges property
> > > ti/k3-am64-mcu.dtsi:77.39-86.4: Warning (simple_bus_reg):
> > > /bus@f4000/bus@400/interrupt-controller1: missing or empty reg/ranges
> > > property
> > >
> > > ti/k3-am642-evm.dt.yaml: bus@400: interrupt-controller1: {'type':
> > > 'object'} is not allowed for {'compatible': ['ti,sci-intr'],
> > > 'ti,intr-trigger-type': [[1]], 'interrupt-controller': True,
> > > 'interrupt-parent': [[1]], '#interrupt-cells': [[1]], 'ti,sci': [[4]],
> > > 'ti,sci-dev-id': [[5]], 'ti,interrupt-ranges': [[0, 104, 4]], 'phandle':
> > > [[5]]}
> > > ti/k3-am642-evm.dt.yaml: bus@f4000: dmss: {'type': 'object'} is not
> > > allowed for {'compatible': ['simple-mfd'], '#address-cells': [[2]],
> > > '#size-cells': [[2]], 'dma-ranges': True, 'ranges': 'phandle': [[7]]}}
> > > ti/k3-am642-evm.dt.yaml: bus@f4000: interrupt-controller0: {'type':
> > > 'object'} is not allowed for {'compatible': ['ti,sci-intr'],
> > > 'ti,intr-trigger-type': [[1]], 'interrupt-controller': True,
> > > 'interrupt-parent': [[1]], '#interrupt-cells': [[1]], 'ti,sci': [[4]],
> > > 'ti,sci-dev-id': [[3]], 'ti,interrupt-ranges': [[0, 32, 16]], 'phandle':
> > > [[15]]}
> > > ti/k3-am642-evm.dt.yaml: flash@0: 'cdns,read-delay', 'cdns,tchsh-ns',
> > > 'cdns,tsd2d-ns', 'cdns,tshsl-ns', 'cdns,tslch-ns' do not match any of the
> > > regexes: '^partition@', 'pinctrl-[0-9]+'
> > > ti/k3-am642-sk.dt.yaml: bus@400: interrupt-controller1: {'type':
> > > 'object'} is not allowed for {'compatible': ['ti,sci-intr'],
> > > 'ti,intr-trigger-type': [[1]], ...
> > > ti/k3-am642-sk.dt.yaml: bus@f4000: dmss: {'type': 'object'} is not
> > > allowed for {'compatible': ['simple-mfd'], ...
> > > ti/k3-am642-sk.dt.yaml: bus@f4000: interrupt-controller0: {'type':
> > > 'object'} is not allowed for {'compatible': ['ti,sci-intr'],
> > > 'ti,intr-trigger-type': [[1]], 'interrupt-controller': True,
> > > 'interrupt-parent': [[1]], '#interrupt-cells': [[1]], 'ti,sci': [[4]],
> > > 'ti,sci-dev-id': [[3]], 'ti,interrupt-ranges': [[0, 32, 16]], 'phandle':
> > > [[11]]}
> > > ti/k3-am642-sk.dt.yaml: flash@0: 'cdns,read-delay', 'cdns,tchsh-ns',
> > > 'cdns,tsd2d-ns', 'cdns,tshsl-ns', 'cdns,tslch-ns' do not match any of the
> > > regexes: '^partition@', 'pinctrl-[0-9]+'
> > > ti/k3-j7200-common-proc-board.dt.yaml: flash@0: 'cdns,read-delay',
> > > 'cdns,tchsh-ns', 'cdns,tsd2d-ns', 'cdns,tshsl-ns', 'cdns,tslch-ns' do not
> > > match any of the regexes: '^partition@', 'pinctrl-[0-9]+'
> > >
> > >
> > > merge commit: 4b8cf90637f295ff1cb1f4bdfde134dab1196296
> >
> >
> > We have a bunch of problems with interrupt controller definitions -
> > attempts in [1] [2] did'nt seem to come to any form of conclusion yet.
> >
> > Cdns is a convert from txt to yaml and is queued on Marks' tree[3]
>
> Ok, thanks for taking a look
>
Apologies on not flagging in my PR itself.
> > These issues pre-existed in existing definitions and/or convertion
> > from txt and we are already working to make sure we try and reach a
> > conclusion soon[4]. I am guessing from your note that it is high time we
> > put our foot down on txt bindings and clean yamls, I will ensure we
> > follow up on that.
>
> I'm still trying to figure out how to best script it, my intention was to
> only list issues that got introduced in the latest patches rather than
> the existing problems.
I had done a bit of scripting around this already in my checker:
https://github.com/nmenon/kernel_patch_verify/blob/master/kernel_patch_verify#L212
Though it never works quite right all the time.. So, i do run explicit
checks afterwards to try and catch these.. and containerizing them
helped deployment aspects(developers having different schema package
versions) in control as well.
but yeah, a clean way of doing things still eludes me.
>
> On the other hand, it would indeed help to address any issues that
> are going to come up in every newly added board first, and then
> eventually get to all the remaining warnings for issues with the
> yaml bindings.
yep, some of the troubles I had has relation to schema checks getting
stricter after I had queued things up, and then having to make a
choice :(. But internally, I am tracking those in our tracking system
and team has been given a headsup that we cleanup yamls before we add
any further nodes.
>
The following also need to be converted to yaml (internal
JIRA tracking already done).
Documentation/devicetree/bindings/arm/keystone/ti,sci.txt
Documentation/devicetree/bindings/gpio/gpio-davinci.txt
Documentation/devicetree/bindings/i2c/i2c-omap.txt
Re: [GIT PULL] arm64: dts: TI K3 updates for v5.13
On 17:24-20210408, Arnd Bergmann wrote:
> From: Arnd Bergmann
>
> On Mon, 5 Apr 2021 10:53:36 -0500, Nishanth Menon wrote:
> > Please pull the following device tree changes for v5.13 cycle.
> >
> > The following changes since commit a38fd8748464831584a19438cbb3082b5a2dab15:
> >
> > Linux 5.12-rc2 (2021-03-05 17:33:41 -0800)
> >
> > are available in the Git repository at:
> >
> > [...]
>
> Merged into arm/dt, thanks!
Thanks.
>
> There are a couple added warnings from 'make W=1 dtbs_check' though:
>
> ti/k3-am64-main.dtsi:376.40-385.4: Warning (simple_bus_reg):
> /bus@f4000/interrupt-controller0: missing or empty reg/ranges property
> ti/k3-am64-main.dtsi:45.13-135.4: Warning (simple_bus_reg): /bus@f4000/dmss:
> missing or empty reg/ranges property
> ti/k3-am64-mcu.dtsi:77.39-86.4: Warning (simple_bus_reg):
> /bus@f4000/bus@400/interrupt-controller1: missing or empty reg/ranges
> property
>
> ti/k3-am642-evm.dt.yaml: bus@400: interrupt-controller1: {'type':
> 'object'} is not allowed for {'compatible': ['ti,sci-intr'],
> 'ti,intr-trigger-type': [[1]], 'interrupt-controller': True,
> 'interrupt-parent': [[1]], '#interrupt-cells': [[1]], 'ti,sci': [[4]],
> 'ti,sci-dev-id': [[5]], 'ti,interrupt-ranges': [[0, 104, 4]], 'phandle':
> [[5]]}
> ti/k3-am642-evm.dt.yaml: bus@f4000: dmss: {'type': 'object'} is not allowed
> for {'compatible': ['simple-mfd'], '#address-cells': [[2]], '#size-cells':
> [[2]], 'dma-ranges': True, 'ranges': 'phandle': [[7]]}}
> ti/k3-am642-evm.dt.yaml: bus@f4000: interrupt-controller0: {'type': 'object'}
> is not allowed for {'compatible': ['ti,sci-intr'], 'ti,intr-trigger-type':
> [[1]], 'interrupt-controller': True, 'interrupt-parent': [[1]],
> '#interrupt-cells': [[1]], 'ti,sci': [[4]], 'ti,sci-dev-id': [[3]],
> 'ti,interrupt-ranges': [[0, 32, 16]], 'phandle': [[15]]}
> ti/k3-am642-evm.dt.yaml: flash@0: 'cdns,read-delay', 'cdns,tchsh-ns',
> 'cdns,tsd2d-ns', 'cdns,tshsl-ns', 'cdns,tslch-ns' do not match any of the
> regexes: '^partition@', 'pinctrl-[0-9]+'
> ti/k3-am642-sk.dt.yaml: bus@400: interrupt-controller1: {'type':
> 'object'} is not allowed for {'compatible': ['ti,sci-intr'],
> 'ti,intr-trigger-type': [[1]], ...
> ti/k3-am642-sk.dt.yaml: bus@f4000: dmss: {'type': 'object'} is not allowed
> for {'compatible': ['simple-mfd'], ...
> ti/k3-am642-sk.dt.yaml: bus@f4000: interrupt-controller0: {'type': 'object'}
> is not allowed for {'compatible': ['ti,sci-intr'], 'ti,intr-trigger-type':
> [[1]], 'interrupt-controller': True, 'interrupt-parent': [[1]],
> '#interrupt-cells': [[1]], 'ti,sci': [[4]], 'ti,sci-dev-id': [[3]],
> 'ti,interrupt-ranges': [[0, 32, 16]], 'phandle': [[11]]}
> ti/k3-am642-sk.dt.yaml: flash@0: 'cdns,read-delay', 'cdns,tchsh-ns',
> 'cdns,tsd2d-ns', 'cdns,tshsl-ns', 'cdns,tslch-ns' do not match any of the
> regexes: '^partition@', 'pinctrl-[0-9]+'
> ti/k3-j7200-common-proc-board.dt.yaml: flash@0: 'cdns,read-delay',
> 'cdns,tchsh-ns', 'cdns,tsd2d-ns', 'cdns,tshsl-ns', 'cdns,tslch-ns' do not
> match any of the regexes: '^partition@', 'pinctrl-[0-9]+'
>
>
> merge commit: 4b8cf90637f295ff1cb1f4bdfde134dab1196296
We have a bunch of problems with interrupt controller definitions -
attempts in [1] [2] did'nt seem to come to any form of conclusion yet.
Cdns is a convert from txt to yaml and is queued on Marks' tree[3]
These issues pre-existed in existing definitions and/or convertion
from txt and we are already working to make sure we try and reach a
conclusion soon[4]. I am guessing from your note that it is high time we
put our foot down on txt bindings and clean yamls, I will ensure we
follow up on that.
[1]
https://lore.kernel.org/linux-devicetree/cal_jsq++dyikg9smqgx9fapdjnvrezcxnb0y5uh-5_2gbzt...@mail.gmail.com/#t
[2]
https://lore.kernel.org/linux-arm-kernel/20210311215914.pgpz2yymmfqlainl@episode/
[3]
https://lore.kernel.org/linux-arm-kernel/161726952255.2486.16196604421904035265.b4...@kernel.org/
[4]
https://lore.kernel.org/linux-arm-kernel/20210311134908.jsh2lywtwzvlyvbc@finally/
--
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5
849D 1736 249D
[GIT PULL] arm64: dts: TI K3 updates for v5.13
Hi, Please pull the following device tree changes for v5.13 cycle. The following changes since commit a38fd8748464831584a19438cbb3082b5a2dab15: Linux 5.12-rc2 (2021-03-05 17:33:41 -0800) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/nmenon/linux.git tags/ti-k3-dt-for-v5.13 for you to fetch changes up to 112e5934ff3a7505e583365213a27f990922b76b: arm64: dts: ti: k3-am64-main: Fix ospi compatible (2021-04-01 08:50:33 -0500) Devicetree changes for TI K3 platforms for v5.13 merge window: * New SoCs: - AM642 mean for industrial control, motor control, remote IO, IoT gateway etc. * New Boards: - AM65: Siemens SIMATIC IOT2050 advanced and basic boards - AM64: EVM and SK boards * New peripherals: - AM65: watchdog - AM65,J721E: ICSSG - J7200: OSPI, GPIO * Fixes: - AM65: pcie node fixup, ospi speed updates - J721e, J7200: MMC speed updates, ospi speed updates and compatibles fixups. Aswath Govindraju (7): arm64: dts: ti: k3-j721e-main: Update the speed modes supported and their itap delay values for MMCSD subsystems arm64: dts: ti: k3-am642-evm: Add support for SPI EEPROM arm64: dts: ti: k3-am64-main: Add DT node for USB subsystem arm64: dts: ti: k3-am642-evm: Add USB support arm64: dts: ti: k3-am64: Add GPIO DT nodes arm64: dts: ti: k3-am642: reserve gpio in mcu domain for firmware usage arm64: dts: ti: k3-j7200: Add support for higher speed modes and update delay select values for MMCSD subsystems Dave Gerlach (4): dt-bindings: arm: ti: Add bindings for AM642 SoC dt-bindings: pinctrl: k3: Introduce pinmux definitions for AM64 arm64: dts: ti: Add support for AM642 SoC arm64: dts: ti: Add support for AM642 EVM Faiz Abbas (2): arm64: dts: ti: k3-j7200: Add gpio nodes arm64: dts: ti: k3-j7200-common-proc-board: Disable unused gpio modules Grygorii Strashko (1): arm64: dts: ti: k3-am64-main: add main CPTS entry Jan Kiszka (5): arm64: dts: ti: k3-am65-main: Add device_type to pcie*_rc nodes arm64: dts: ti: k3-am65-mcu: Add RTI watchdog entry dt-bindings: Add Siemens vendor prefix dt-bindings: arm: ti: Add bindings for Siemens IOT2050 boards arm64: dts: ti: Add support for Siemens IOT2050 boards Lokesh Vutla (2): dt-bindings: arm: ti: Add bindings for AM642 SK arm64: dts: ti: Add support for AM642 SK Peter Ujfalusi (1): arm64: dts: ti: k3-am64-main: Enable DMA support Pratyush Yadav (6): arm64: dts: ti: k3-j721e-som-p0: Enable 8D-8D-8D mode on OSPI arm64: dts: ti: am654-base-board: Enable 8D-8D-8D mode on OSPI arm64: dts: ti: k3-j7200-som-p0: Add nodes for OSPI0 arm64: dts: ti: k3-j721e-mcu: Fix ospi compatible arm64: dts: ti: k3-j7200-mcu: Fix ospi compatible arm64: dts: ti: k3-am64-main: Fix ospi compatible Suman Anna (5): arm64: dts: ti: k3-am65-main: Add ICSSG nodes arm64: dts: ti: k3-j721e-main: Add ICSSG nodes arm64: dts: ti: k3-am64-main: Add hwspinlock node arm64: dts: ti: k3-am64-main: Add mailbox cluster nodes arm64: dts: ti: k3-am642-evm/sk: Add IPC sub-mailbox nodes Vignesh Raghavendra (6): arm64: dts: ti: k3-am64-main: Add CPSW DT node arm64: dts: ti: k3-am642-evm: add CPSW3g DT nodes arm64: dts: ti: k3-am642-sk: Add CPSW DT nodes arm64: dts: ti: k3-am64-main: Add ADC nodes arm64: dts: ti: k3-am64-main: Add OSPI node arm64: dts: ti: k3-am64-evm/sk: Add OSPI flash DT node Documentation/devicetree/bindings/arm/ti/k3.yaml | 9 + .../devicetree/bindings/vendor-prefixes.yaml | 2 + arch/arm64/boot/dts/ti/Makefile| 8 +- arch/arm64/boot/dts/ti/k3-am64-main.dtsi | 675 + arch/arm64/boot/dts/ti/k3-am64-mcu.dtsi| 103 arch/arm64/boot/dts/ti/k3-am64.dtsi| 105 arch/arm64/boot/dts/ti/k3-am642-evm.dts| 468 ++ arch/arm64/boot/dts/ti/k3-am642-sk.dts | 334 ++ arch/arm64/boot/dts/ti/k3-am642.dtsi | 65 ++ arch/arm64/boot/dts/ti/k3-am65-iot2050-common.dtsi | 655 arch/arm64/boot/dts/ti/k3-am65-main.dtsi | 395 arch/arm64/boot/dts/ti/k3-am65-mcu.dtsi| 9 + arch/arm64/boot/dts/ti/k3-am6528-iot2050-basic.dts | 61 ++ arch/arm64/boot/dts/ti/k3-am654-base-board.dts | 4 +- .../boot/dts/ti/k3-am6548-iot2050-advanced.dts | 60 ++ .../boot/dts/ti/k3-j7200-common-proc-board.dts | 94 +++ arch/arm64/boot/dts/ti/k3-j7200-main.dtsi | 86 ++- arch/arm64/boot/dts/ti/k3-j7200-mcu-wakeup.dtsi| 51 ++ arch/arm64/boot/dts/ti/k3-j7200-som-p0.dtsi| 36 ++ arch/arm64/boot/dts/ti/k3-j721e-main.dtsi | 279 -
