Re: [GIT PULL 00/12] perf/urgent fixes and improvements
* Arnaldo Carvalho de Melo wrote: > Hi Ingo, > > Please consider pulling, > > - Arnaldo > > Test results at the end of this message, as usual. > > The following changes since commit 2696ec4566f598ab483a6bebc4ec841b2efb88ec: > > Merge tag 'perf-core-for-mingo-4.18-20180606' of > git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux into perf/urgent > (2018-06-07 07:18:51 +0200) > > are available in the Git repository at: > > git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git > tags/perf-urgent-for-mingo-4.18-20180611 > > for you to fetch changes up to fad76d4333fe73cf3f73704aa34d4ce523b1c458: > > perf script: Show hw-cache events (2018-06-08 13:41:30 -0300) > > > perf/urgent fixes and improvements: > > perf stat: > > . Add --interval-clear option, to provide a 'watch' like printing (Jiri Olsa) > > . Fix metric column header display alignment (Jiri Olsa) > > . Improve error messages for default attributes, providing better output > for error in command lines such as: > > $ perf stat -T > Cannot set up transaction events > event syntax error: > '..cycles,cpu/cycles-t/,cpu/tx-start/,cpu/el-start/,cpu/cycles-ct/}' > \___ unknown term > > Where the "event syntax error" line now appears (Jiri Olsa) > > perf script: > > . Show hw-cache events too (Seeteena Thoufeek) > > perf c2c: > > . Fix data dependency problem in layout of 'struct c2c_hist_entry', where > its member 'struct hist_entry' must be at the end because it has a ZLA > as its last member, that gets space when handling callchains (Jiri Olsa) > > Core: > > - We cannot assume that a 'struct perf_evsel' is to be obtained from a > container_of operation on a 'struct hists' as there are tools, such as > 'perf c2c' that uses 'struct hist' instances without having them in > container structs that also have 'struct perf_evsel' in a particular > layout, so provide a different way of figuring out if a 'struct hists' > and 'struct hist_entry' have callchains (Arnaldo Carvalho de Melo) > > - Fix error index in the PMU event parser, so that error messages can > point to the problematic token (Jiri Olsa) > > Signed-off-by: Arnaldo Carvalho de Melo > > > Arnaldo Carvalho de Melo (4): > perf hists: Save the callchain_size in struct hist_entry > perf hists: Make hist_entry__has_callchains() work with 'perf c2c' > perf hists browser gtk: Use hist_entry__has_callchains() > perf hists: Reimplement hists__has_callchains() > > Jiri Olsa (7): > perf tools: Fix error index for pmu event parser > perf stat: Add --interval-clear option > perf stat: Use only color_fprintf call in print_metric_only > perf stat: Fix metric column header display alignment > perf stat: Allow to specify specific metric column len > perf stat: Add event parsing error handling to add_default_attributes > perf c2c: Keep struct hist_entry at the end of struct c2c_hist_entry > > Seeteena Thoufeek (1): > perf script: Show hw-cache events > > tools/perf/Documentation/perf-stat.txt | 3 +++ > tools/perf/builtin-c2c.c | 10 +++ > tools/perf/builtin-script.c| 12 + > tools/perf/builtin-stat.c | 48 > -- > tools/perf/ui/gtk/hists.c | 2 +- > tools/perf/util/hist.c | 12 ++--- > tools/perf/util/hist.h | 4 +-- > tools/perf/util/parse-events.y | 5 > tools/perf/util/sort.h | 4 ++- > 9 files changed, 67 insertions(+), 33 deletions(-) Pulled, thanks a lot Arnaldo! Ingo
[GIT PULL 00/12] perf/urgent fixes and improvements
Hi Ingo,
Please consider pulling,
- Arnaldo
Test results at the end of this message, as usual.
The following changes since commit 2696ec4566f598ab483a6bebc4ec841b2efb88ec:
Merge tag 'perf-core-for-mingo-4.18-20180606' of
git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux into perf/urgent
(2018-06-07 07:18:51 +0200)
are available in the Git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git
tags/perf-urgent-for-mingo-4.18-20180611
for you to fetch changes up to fad76d4333fe73cf3f73704aa34d4ce523b1c458:
perf script: Show hw-cache events (2018-06-08 13:41:30 -0300)
perf/urgent fixes and improvements:
perf stat:
. Add --interval-clear option, to provide a 'watch' like printing (Jiri Olsa)
. Fix metric column header display alignment (Jiri Olsa)
. Improve error messages for default attributes, providing better output
for error in command lines such as:
$ perf stat -T
Cannot set up transaction events
event syntax error:
'..cycles,cpu/cycles-t/,cpu/tx-start/,cpu/el-start/,cpu/cycles-ct/}'
\___ unknown term
Where the "event syntax error" line now appears (Jiri Olsa)
perf script:
. Show hw-cache events too (Seeteena Thoufeek)
perf c2c:
. Fix data dependency problem in layout of 'struct c2c_hist_entry', where
its member 'struct hist_entry' must be at the end because it has a ZLA
as its last member, that gets space when handling callchains (Jiri Olsa)
Core:
- We cannot assume that a 'struct perf_evsel' is to be obtained from a
container_of operation on a 'struct hists' as there are tools, such as
'perf c2c' that uses 'struct hist' instances without having them in
container structs that also have 'struct perf_evsel' in a particular
layout, so provide a different way of figuring out if a 'struct hists'
and 'struct hist_entry' have callchains (Arnaldo Carvalho de Melo)
- Fix error index in the PMU event parser, so that error messages can
point to the problematic token (Jiri Olsa)
Signed-off-by: Arnaldo Carvalho de Melo
Arnaldo Carvalho de Melo (4):
perf hists: Save the callchain_size in struct hist_entry
perf hists: Make hist_entry__has_callchains() work with 'perf c2c'
perf hists browser gtk: Use hist_entry__has_callchains()
perf hists: Reimplement hists__has_callchains()
Jiri Olsa (7):
perf tools: Fix error index for pmu event parser
perf stat: Add --interval-clear option
perf stat: Use only color_fprintf call in print_metric_only
perf stat: Fix metric column header display alignment
perf stat: Allow to specify specific metric column len
perf stat: Add event parsing error handling to add_default_attributes
perf c2c: Keep struct hist_entry at the end of struct c2c_hist_entry
Seeteena Thoufeek (1):
perf script: Show hw-cache events
tools/perf/Documentation/perf-stat.txt | 3 +++
tools/perf/builtin-c2c.c | 10 +++
tools/perf/builtin-script.c| 12 +
tools/perf/builtin-stat.c | 48 --
tools/perf/ui/gtk/hists.c | 2 +-
tools/perf/util/hist.c | 12 ++---
tools/perf/util/hist.h | 4 +--
tools/perf/util/parse-events.y | 5
tools/perf/util/sort.h | 4 ++-
9 files changed, 67 insertions(+), 33 deletions(-)
Test results:
The first ones are container (docker) based builds of tools/perf with
and without libelf support. Where clang is available, it is also used
to build perf with/without libelf, and building with LIBCLANGLLVM=1
(built-in clang) with gcc and clang when clang and its devel libraries
are installed.
The objtool and samples/bpf/ builds are disabled now that I'm switching from
using the sources in a local volume to fetching them from a http server to
build it inside the container, to make it easier to build in a container
cluster.
Those will come back later.
Several are cross builds, the ones with -x-ARCH and the android one, and those
may not have all the features built, due to lack of multi-arch devel packages,
available and being used so far on just a few, like
debian:experimental-x-{arm64,mipsel}.
The 'perf test' one will perform a variety of tests exercising
tools/perf/util/, tools/lib/{bpf,traceevent,etc}, as well as run perf commands
with a variety of command line event specifications to then intercept the
sys_perf_event syscall to check that the perf_event_attr fields are set up as
expected, among a variety of other unit tests.
Then there is the 'make -C tools/perf build-test' ones, that build tools/perf/
with a variety of feature sets, exercising the build with an incomplete set of
features as well as with a complete one. It is planned to have it run on each
of the containers mentioned above, using some c
Re: [GIT PULL 00/12] perf/urgent fixes
* Arnaldo Carvalho de Melo wrote:
> Hi Ingo,
>
> Please consider pulling,
>
> - Arnaldo
>
> Test results at the end of this message, as usual.
>
> The following changes since commit c042f7e9bb6ad9429ea0f2c9138dc06413198967:
>
> Merge tag 'perf-urgent-for-mingo-4.17-20180420' of
> git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux into perf/urgent
> (2018-04-21 09:38:33 +0200)
>
> are available in the Git repository at:
>
> git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git
> tags/perf-urgent-for-mingo-4.17-20180425
>
> for you to fetch changes up to 80ee8c588afde077cb0439e15129579a267916c4:
>
> perf stat: Fix duplicate PMU name for interval print (2018-04-24 16:12:00
> -0300)
>
>
> perf/urgent fixes:
>
> perf stat:
>
> - Keep the '/' event modifier separator in fallback, for example when
> fallbacking from 'cpu/cpu-cycles/' to user level only, where it should
> become 'cpu/cpu-cycles/u' and not 'cpu/cpu-cycles/:u' (Jiri Olsa)
>
> - Fix PMU events parsing rule, improving error reporting for
> invalid events (Jiri Olsa)
>
> - Disable write_backward and other event attributes for !group
> events in a group, fixing, for instance this group: '{cycles,msr/aperf/}:S'
> that has leader sampling (:S) and where just the 'cycles',
> the leader event, should have the write_backward attribute
> set, in this case it all fails because the PMU where 'msr/aperf/'
> lives doesn't accepts write_backward style sampling (Jiri Olsa)
>
> - Only fall back group read for leader (Kan Liang)
>
> - Fix core PMU alias list for X86 platform (Kan Liang)
>
> - Print out hint for mixed PMU group error (Kan Liang)
>
> - Fix duplicate PMU name for interval print (Kan Liang)
>
> Core:
>
> - Set main kernel end address properly when reading kernel and
> module maps (Namhyung Kim)
>
> perf mem:
>
> - Fix incorrect entries and add missing man options (Sangwon Hong)
>
> s/390:
>
> - Remove s390 specific strcmp_cpuid_cmp function (Thomas Richter)
>
> - Adapt 'perf test' case record+probe_libc_inet_pton.sh for s390
>
> - Fix s390 undefined record__auxtrace_init() return value in
> 'perf record' (Thomas Richter)
>
> Signed-off-by: Arnaldo Carvalho de Melo
>
>
> Jiri Olsa (3):
> perf stat: Keep the / modifier separator in fallback
> perf pmu: Fix pmu events parsing rule
> perf evsel: Disable write_backward for leader sampling group events
>
> Kan Liang (4):
> perf pmu: Fix core PMU alias list for X86 platform
> perf stat: Print out hint for mixed PMU group error
> perf evsel: Only fall back group read for leader
> perf stat: Fix duplicate PMU name for interval print
>
> Namhyung Kim (1):
> perf machine: Set main kernel end address properly
>
> Sangwon Hong (1):
> perf mem: Document incorrect and missing options
>
> Thomas Richter (3):
> perf list: Remove s390 specific strcmp_cpuid_cmp function
> perf test: Adapt test case record+probe_libc_inet_pton.sh for s390
> perf record: Fix s390 undefined record__auxtrace_init() return value
>
> tools/perf/Documentation/perf-mem.txt | 41
> +++---
> tools/perf/arch/s390/util/auxtrace.c | 1 +
> tools/perf/arch/s390/util/header.c | 18 --
> tools/perf/builtin-stat.c | 40 +++--
> tools/perf/pmu-events/arch/s390/mapfile.csv| 10 +++---
> tools/perf/tests/attr/test-record-group-sampling | 3 ++
> .../tests/shell/record+probe_libc_inet_pton.sh | 6 ++--
> tools/perf/util/evsel.c| 18 +++---
> tools/perf/util/evsel.h| 1 +
> tools/perf/util/machine.c | 30 +---
> tools/perf/util/parse-events.y | 8 ++---
> tools/perf/util/pmu.c | 22 +---
> 12 files changed, 123 insertions(+), 75 deletions(-)
Pulled, thanks a lot Arnaldo!
Ingo
[GIT PULL 00/12] perf/urgent fixes
Hi Ingo,
Please consider pulling,
- Arnaldo
Test results at the end of this message, as usual.
The following changes since commit c042f7e9bb6ad9429ea0f2c9138dc06413198967:
Merge tag 'perf-urgent-for-mingo-4.17-20180420' of
git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux into perf/urgent
(2018-04-21 09:38:33 +0200)
are available in the Git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git
tags/perf-urgent-for-mingo-4.17-20180425
for you to fetch changes up to 80ee8c588afde077cb0439e15129579a267916c4:
perf stat: Fix duplicate PMU name for interval print (2018-04-24 16:12:00
-0300)
perf/urgent fixes:
perf stat:
- Keep the '/' event modifier separator in fallback, for example when
fallbacking from 'cpu/cpu-cycles/' to user level only, where it should
become 'cpu/cpu-cycles/u' and not 'cpu/cpu-cycles/:u' (Jiri Olsa)
- Fix PMU events parsing rule, improving error reporting for
invalid events (Jiri Olsa)
- Disable write_backward and other event attributes for !group
events in a group, fixing, for instance this group: '{cycles,msr/aperf/}:S'
that has leader sampling (:S) and where just the 'cycles',
the leader event, should have the write_backward attribute
set, in this case it all fails because the PMU where 'msr/aperf/'
lives doesn't accepts write_backward style sampling (Jiri Olsa)
- Only fall back group read for leader (Kan Liang)
- Fix core PMU alias list for X86 platform (Kan Liang)
- Print out hint for mixed PMU group error (Kan Liang)
- Fix duplicate PMU name for interval print (Kan Liang)
Core:
- Set main kernel end address properly when reading kernel and
module maps (Namhyung Kim)
perf mem:
- Fix incorrect entries and add missing man options (Sangwon Hong)
s/390:
- Remove s390 specific strcmp_cpuid_cmp function (Thomas Richter)
- Adapt 'perf test' case record+probe_libc_inet_pton.sh for s390
- Fix s390 undefined record__auxtrace_init() return value in
'perf record' (Thomas Richter)
Signed-off-by: Arnaldo Carvalho de Melo
Jiri Olsa (3):
perf stat: Keep the / modifier separator in fallback
perf pmu: Fix pmu events parsing rule
perf evsel: Disable write_backward for leader sampling group events
Kan Liang (4):
perf pmu: Fix core PMU alias list for X86 platform
perf stat: Print out hint for mixed PMU group error
perf evsel: Only fall back group read for leader
perf stat: Fix duplicate PMU name for interval print
Namhyung Kim (1):
perf machine: Set main kernel end address properly
Sangwon Hong (1):
perf mem: Document incorrect and missing options
Thomas Richter (3):
perf list: Remove s390 specific strcmp_cpuid_cmp function
perf test: Adapt test case record+probe_libc_inet_pton.sh for s390
perf record: Fix s390 undefined record__auxtrace_init() return value
tools/perf/Documentation/perf-mem.txt | 41 +++---
tools/perf/arch/s390/util/auxtrace.c | 1 +
tools/perf/arch/s390/util/header.c | 18 --
tools/perf/builtin-stat.c | 40 +++--
tools/perf/pmu-events/arch/s390/mapfile.csv| 10 +++---
tools/perf/tests/attr/test-record-group-sampling | 3 ++
.../tests/shell/record+probe_libc_inet_pton.sh | 6 ++--
tools/perf/util/evsel.c| 18 +++---
tools/perf/util/evsel.h| 1 +
tools/perf/util/machine.c | 30 +---
tools/perf/util/parse-events.y | 8 ++---
tools/perf/util/pmu.c | 22 +---
12 files changed, 123 insertions(+), 75 deletions(-)
Test results:
The first ones are container (docker) based builds of tools/perf with
and without libelf support. Where clang is available, it is also used
to build perf with/without libelf, and building with LIBCLANGLLVM=1
(built-in clang) with gcc and clang when clang and its devel libraries
are installed.
The objtool and samples/bpf/ builds are disabled now that I'm switching from
using the sources in a local volume to fetching them from a http server to
build it inside the container, to make it easier to build in a container
cluster.
Those will come back later.
Several are cross builds, the ones with -x-ARCH and the android one, and those
may not have all the features built, due to lack of multi-arch devel packages,
available and being used so far on just a few, like
debian:experimental-x-{arm64,mipsel}.
The 'perf test' one will perform a variety of tests exercising
tools/perf/util/, tools/lib/{bpf,traceevent,etc}, as well as run perf commands
with a variety of command line event specifications to then intercept the
sys_perf_event syscall to check that the perf_event_attr fields are set up as
expected,
Re: [GIT PULL 00/12] perf/urgent fixes
Em Thu, Jan 05, 2017 at 08:36:36AM +0100, Ingo Molnar escreveu: > > * Arnaldo Carvalho de Melo wrote: > > > Hi Ingo, > > > > Please consider pulling, > > > > - Arnaldo > > > > Test results at the end of this message, as usual, news about it: > > > > Has two new targets, debian:experimental-x-mipsel and > > debian:experimental-x-arm64. > > > > Those use debian's multi-arch packages allowing cross building more than > > with > > the other crossbuild containers. > > > > This still doesn't generate a full featured tool, as there are some buggy > > multi-arch packages, such as the devel packages for perl, gtk2, etc. > > > > The following changes since commit 3705b97505bcbf6440f38119c0e7d6058f585b54: > > > > Merge tag 'perf-urgent-for-mingo-20161222' of > > git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux into perf/urgent > > (2016-12-23 20:23:29 +0100) > > > > are available in the git repository at: > > > > git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git > > tags/perf-urgent-for-mingo-4.10-20170104 > > > > for you to fetch changes up to 8a937a25a7e3c19d5fb3f9d92f605cf5fda219d8: > > > > perf probe: Fix to probe on gcc generated symbols for offline kernel > > (2017-01-04 11:44:22 -0300) > > > > > > perf/urgent fixes and one improvement: > > > > Fixes: > > > > - Fix prev/next_prio formatting for deadline tasks in libtraceevent (Daniel > > Bristot de Oliveira) > > > > - Robustify reading of build-ids from /sys/kernel/note (Arnaldo Carvalho de > > Melo) > > > > - Fix building some sample/bpf in Alpine Linux 3.4 (Arnaldo Carvalho de > > Melo) > > > > - Fix 'make install-bin' to install libtraceevent plugins (Arnaldo Carvalho > > de Melo) > > > > - Fix 'perf record --switch-output' documentation and comment (Jiri Olsa) > > > > - 'perf probe' fixes for cross arch probing (Masami Hiramatsu) > > > > Improvement: > > > > - Show total scheduling time in 'perf sched timehist' (Namhyumg Kim) > > > > Signed-off-by: Arnaldo Carvalho de Melo > > > > > > Arnaldo Carvalho de Melo (4): > > samples/bpf sock_example: Avoid getting ethhdr from two includes > > samples/bpf trace_output_user: Remove duplicate sys/ioctl.h include > > perf tools: Install tools/lib/traceevent plugins with install-bin > > perf symbols: Robustify reading of build-id from sysfs > > > > Daniel Bristot de Oliveira (1): > > tools lib traceevent: Fix prev/next_prio for deadline tasks > > > > Jiri Olsa (3): > > tools lib subcmd: Add OPT_STRING_OPTARG_SET option > > perf record: Make __record_options static > > perf record: Fix --switch-output documentation and comment > > > > Masami Hiramatsu (3): > > perf probe: Fix to get correct modname from elf header > > perf probe: Fix --funcs to show correct symbols for offline module > > perf probe: Fix to probe on gcc generated symbols for offline kernel > > > > Namhyung Kim (1): > > perf sched timehist: Show total scheduling time > > > > samples/bpf/sock_example.h | 2 +- > > samples/bpf/trace_output_user.c| 1 - > > tools/lib/subcmd/parse-options.c | 3 + > > tools/lib/subcmd/parse-options.h | 5 ++ > > tools/lib/traceevent/plugin_sched_switch.c | 4 +- > > tools/perf/Documentation/perf-record.txt | 4 ++ > > tools/perf/Makefile.perf | 4 +- > > tools/perf/builtin-record.c| 4 +- > > tools/perf/builtin-sched.c | 17 - > > tools/perf/util/probe-event.c | 105 > > +++-- > > tools/perf/util/symbol-elf.c | 6 ++ > > 11 files changed, 108 insertions(+), 47 deletions(-) > > Pulled, thanks a lot Arnaldo! > > JFYI, I noticed these new warnings in the build log, we should probably take > care > of these out of sync headers eventually: > > Warning: arch/x86/include/asm/cpufeatures.h differs from kernel > Warning: arch/x86/include/uapi/asm/vmx.h differs from kernel > Warning: arch/powerpc/include/uapi/asm/kvm.h differs from kernel > Warning: arch/arm/include/uapi/asm/kvm.h differs from kernel > > ... but it's not a showstopper. Right, one has to look at the changes, see if they should trigger changes in tools, do it if needed, then do the copy, checking that all continues to work as expected. I've been doing that, and in some cases some other people as well, like Joe Stringer did for the bpf headers when making samples/bpf/ use tools/bpf/. - Arnaldo
Re: [GIT PULL 00/12] perf/urgent fixes
* Arnaldo Carvalho de Melo wrote: > Hi Ingo, > > Please consider pulling, > > - Arnaldo > > Test results at the end of this message, as usual, news about it: > > Has two new targets, debian:experimental-x-mipsel and > debian:experimental-x-arm64. > > Those use debian's multi-arch packages allowing cross building more than with > the other crossbuild containers. > > This still doesn't generate a full featured tool, as there are some buggy > multi-arch packages, such as the devel packages for perl, gtk2, etc. > > The following changes since commit 3705b97505bcbf6440f38119c0e7d6058f585b54: > > Merge tag 'perf-urgent-for-mingo-20161222' of > git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux into perf/urgent > (2016-12-23 20:23:29 +0100) > > are available in the git repository at: > > git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git > tags/perf-urgent-for-mingo-4.10-20170104 > > for you to fetch changes up to 8a937a25a7e3c19d5fb3f9d92f605cf5fda219d8: > > perf probe: Fix to probe on gcc generated symbols for offline kernel > (2017-01-04 11:44:22 -0300) > > > perf/urgent fixes and one improvement: > > Fixes: > > - Fix prev/next_prio formatting for deadline tasks in libtraceevent (Daniel > Bristot de Oliveira) > > - Robustify reading of build-ids from /sys/kernel/note (Arnaldo Carvalho de > Melo) > > - Fix building some sample/bpf in Alpine Linux 3.4 (Arnaldo Carvalho de Melo) > > - Fix 'make install-bin' to install libtraceevent plugins (Arnaldo Carvalho > de Melo) > > - Fix 'perf record --switch-output' documentation and comment (Jiri Olsa) > > - 'perf probe' fixes for cross arch probing (Masami Hiramatsu) > > Improvement: > > - Show total scheduling time in 'perf sched timehist' (Namhyumg Kim) > > Signed-off-by: Arnaldo Carvalho de Melo > > > Arnaldo Carvalho de Melo (4): > samples/bpf sock_example: Avoid getting ethhdr from two includes > samples/bpf trace_output_user: Remove duplicate sys/ioctl.h include > perf tools: Install tools/lib/traceevent plugins with install-bin > perf symbols: Robustify reading of build-id from sysfs > > Daniel Bristot de Oliveira (1): > tools lib traceevent: Fix prev/next_prio for deadline tasks > > Jiri Olsa (3): > tools lib subcmd: Add OPT_STRING_OPTARG_SET option > perf record: Make __record_options static > perf record: Fix --switch-output documentation and comment > > Masami Hiramatsu (3): > perf probe: Fix to get correct modname from elf header > perf probe: Fix --funcs to show correct symbols for offline module > perf probe: Fix to probe on gcc generated symbols for offline kernel > > Namhyung Kim (1): > perf sched timehist: Show total scheduling time > > samples/bpf/sock_example.h | 2 +- > samples/bpf/trace_output_user.c| 1 - > tools/lib/subcmd/parse-options.c | 3 + > tools/lib/subcmd/parse-options.h | 5 ++ > tools/lib/traceevent/plugin_sched_switch.c | 4 +- > tools/perf/Documentation/perf-record.txt | 4 ++ > tools/perf/Makefile.perf | 4 +- > tools/perf/builtin-record.c| 4 +- > tools/perf/builtin-sched.c | 17 - > tools/perf/util/probe-event.c | 105 > +++-- > tools/perf/util/symbol-elf.c | 6 ++ > 11 files changed, 108 insertions(+), 47 deletions(-) Pulled, thanks a lot Arnaldo! JFYI, I noticed these new warnings in the build log, we should probably take care of these out of sync headers eventually: Warning: arch/x86/include/asm/cpufeatures.h differs from kernel Warning: arch/x86/include/uapi/asm/vmx.h differs from kernel Warning: arch/powerpc/include/uapi/asm/kvm.h differs from kernel Warning: arch/arm/include/uapi/asm/kvm.h differs from kernel ... but it's not a showstopper. Thanks, Ingo
[GIT PULL 00/12] perf/urgent fixes
Hi Ingo, Please consider pulling, - Arnaldo Test results at the end of this message, as usual, news about it: Has two new targets, debian:experimental-x-mipsel and debian:experimental-x-arm64. Those use debian's multi-arch packages allowing cross building more than with the other crossbuild containers. This still doesn't generate a full featured tool, as there are some buggy multi-arch packages, such as the devel packages for perl, gtk2, etc. The following changes since commit 3705b97505bcbf6440f38119c0e7d6058f585b54: Merge tag 'perf-urgent-for-mingo-20161222' of git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux into perf/urgent (2016-12-23 20:23:29 +0100) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-urgent-for-mingo-4.10-20170104 for you to fetch changes up to 8a937a25a7e3c19d5fb3f9d92f605cf5fda219d8: perf probe: Fix to probe on gcc generated symbols for offline kernel (2017-01-04 11:44:22 -0300) perf/urgent fixes and one improvement: Fixes: - Fix prev/next_prio formatting for deadline tasks in libtraceevent (Daniel Bristot de Oliveira) - Robustify reading of build-ids from /sys/kernel/note (Arnaldo Carvalho de Melo) - Fix building some sample/bpf in Alpine Linux 3.4 (Arnaldo Carvalho de Melo) - Fix 'make install-bin' to install libtraceevent plugins (Arnaldo Carvalho de Melo) - Fix 'perf record --switch-output' documentation and comment (Jiri Olsa) - 'perf probe' fixes for cross arch probing (Masami Hiramatsu) Improvement: - Show total scheduling time in 'perf sched timehist' (Namhyumg Kim) Signed-off-by: Arnaldo Carvalho de Melo Arnaldo Carvalho de Melo (4): samples/bpf sock_example: Avoid getting ethhdr from two includes samples/bpf trace_output_user: Remove duplicate sys/ioctl.h include perf tools: Install tools/lib/traceevent plugins with install-bin perf symbols: Robustify reading of build-id from sysfs Daniel Bristot de Oliveira (1): tools lib traceevent: Fix prev/next_prio for deadline tasks Jiri Olsa (3): tools lib subcmd: Add OPT_STRING_OPTARG_SET option perf record: Make __record_options static perf record: Fix --switch-output documentation and comment Masami Hiramatsu (3): perf probe: Fix to get correct modname from elf header perf probe: Fix --funcs to show correct symbols for offline module perf probe: Fix to probe on gcc generated symbols for offline kernel Namhyung Kim (1): perf sched timehist: Show total scheduling time samples/bpf/sock_example.h | 2 +- samples/bpf/trace_output_user.c| 1 - tools/lib/subcmd/parse-options.c | 3 + tools/lib/subcmd/parse-options.h | 5 ++ tools/lib/traceevent/plugin_sched_switch.c | 4 +- tools/perf/Documentation/perf-record.txt | 4 ++ tools/perf/Makefile.perf | 4 +- tools/perf/builtin-record.c| 4 +- tools/perf/builtin-sched.c | 17 - tools/perf/util/probe-event.c | 105 +++-- tools/perf/util/symbol-elf.c | 6 ++ 11 files changed, 108 insertions(+), 47 deletions(-) # uname -a Linux jouet 4.9.0+ #2 SMP Wed Dec 21 11:54:44 BRT 2016 x86_64 x86_64 x86_64 GNU/Linux # perf test 1: vmlinux symtab matches kallsyms: Ok 2: Detect openat syscall event: Ok 3: Detect openat syscall event on all cpus: Ok 4: Read samples using the mmap interface : Ok 5: Parse event definition strings : Ok 6: PERF_RECORD_* events & perf_sample fields : Ok 7: Parse perf pmu format : Ok 8: DSO data read : Ok 9: DSO data cache : Ok 10: DSO data reopen: Ok 11: Roundtrip evsel->name : Ok 12: Parse sched tracepoints fields : Ok 13: syscalls:sys_enter_openat event fields : Ok 14: Setup struct perf_event_attr : Ok 15: Match and link multiple hists : Ok 16: 'import perf' in python: Ok 17: Breakpoint overflow signal handler : Ok 18: Breakpoint overflow sampling : Ok 19: Number of exit events of a simple workload : Ok 20: Software clock events period values: Ok 21: Object code reading: Ok 22: Sample parsing : Ok 23: Use a dummy software event to keep tracking: Ok 24: Parse with no sample_id_all bit set: Ok 25: Filter hist entries: Ok 26: Lookup mmap thread : Ok 27: Share thread mg: Ok 28: Sort output of hist entries: Ok
Re: [GIT PULL 00/12] perf/urgent fixes
* Arnaldo Carvalho de Melo wrote: > From: Arnaldo Carvalho de Melo > > Hi Ingo, > > Please consider pulling, > > - Arnaldo > > The following changes since commit 0d4dd797564cddc1f71ab0b239e9ea50ddd40b2a: > > perf/doc: Remove mention of non-existent set_perf_event_pending() from > design.txt (2014-01-26 09:37:48 +0100) > > are available in the git repository at: > > git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux > tags/perf-urgent-for-mingo > > for you to fetch changes up to d3b70220292c40d3b499797fd2f33f608fc35edb: > > perf buildid-cache: Check relocation when checking for existing kcore > (2014-01-31 17:21:54 -0300) > > > perf/urgent fixes: > > . Fix annotation for relocated kernel (Adrian Hunter) > > . Fix demangling of symbols in kernel and kernel modules (Avi Kivity) > > . Fix include for non x86 architectures (Francesco Fusco) > > . Fix ARM64 memory barriers (Peter Zijlstra) > > Signed-off-by: Arnaldo Carvalho de Melo > > > Adrian Hunter (9): > perf symbols: Fix symbol annotation for relocated kernel > perf tools: Add kallsyms__get_function_start() > perf machine: Add machine__get_kallsyms_filename() > perf machine: Set up ref_reloc_sym in machine__create_kernel_maps() > perf record: Get ref_reloc_sym from kernel map > perf symbols: Prevent the use of kcore if the kernel has moved > perf tests: No need to set up ref_reloc_sym > perf tools: Adjust kallsyms for relocated kernel > perf buildid-cache: Check relocation when checking for existing kcore > > Avi Kivity (1): > perf tools: Demangle kernel and kernel module symbols too > > Francesco Fusco (1): > perf tools: Fix include for non x86 architectures > > Peter Zijlstra (1): > perf tools: Fix ARGH64 memory barriers > > tools/perf/builtin-buildid-cache.c | 33 --- > tools/perf/builtin-record.c | 10 ++ > tools/perf/perf.h | 4 +-- > tools/perf/tests/vmlinux-kallsyms.c | 10 -- > tools/perf/util/event.c | 36 ++-- > tools/perf/util/event.h | 6 ++-- > tools/perf/util/include/asm/hash.h | 6 > tools/perf/util/machine.c | 42 +++- > tools/perf/util/machine.h | 2 ++ > tools/perf/util/map.c | 5 +-- > tools/perf/util/map.h | 1 + > tools/perf/util/symbol-elf.c| 4 ++- > tools/perf/util/symbol.c| 65 > + > 13 files changed, 162 insertions(+), 62 deletions(-) > create mode 100644 tools/perf/util/include/asm/hash.h Pulled, thanks a lot Arnaldo! Ingo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[GIT PULL 00/12] perf/urgent fixes
From: Arnaldo Carvalho de Melo Hi Ingo, Please consider pulling, - Arnaldo The following changes since commit 0d4dd797564cddc1f71ab0b239e9ea50ddd40b2a: perf/doc: Remove mention of non-existent set_perf_event_pending() from design.txt (2014-01-26 09:37:48 +0100) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux tags/perf-urgent-for-mingo for you to fetch changes up to d3b70220292c40d3b499797fd2f33f608fc35edb: perf buildid-cache: Check relocation when checking for existing kcore (2014-01-31 17:21:54 -0300) perf/urgent fixes: . Fix annotation for relocated kernel (Adrian Hunter) . Fix demangling of symbols in kernel and kernel modules (Avi Kivity) . Fix include for non x86 architectures (Francesco Fusco) . Fix ARM64 memory barriers (Peter Zijlstra) Signed-off-by: Arnaldo Carvalho de Melo Adrian Hunter (9): perf symbols: Fix symbol annotation for relocated kernel perf tools: Add kallsyms__get_function_start() perf machine: Add machine__get_kallsyms_filename() perf machine: Set up ref_reloc_sym in machine__create_kernel_maps() perf record: Get ref_reloc_sym from kernel map perf symbols: Prevent the use of kcore if the kernel has moved perf tests: No need to set up ref_reloc_sym perf tools: Adjust kallsyms for relocated kernel perf buildid-cache: Check relocation when checking for existing kcore Avi Kivity (1): perf tools: Demangle kernel and kernel module symbols too Francesco Fusco (1): perf tools: Fix include for non x86 architectures Peter Zijlstra (1): perf tools: Fix ARGH64 memory barriers tools/perf/builtin-buildid-cache.c | 33 --- tools/perf/builtin-record.c | 10 ++ tools/perf/perf.h | 4 +-- tools/perf/tests/vmlinux-kallsyms.c | 10 -- tools/perf/util/event.c | 36 ++-- tools/perf/util/event.h | 6 ++-- tools/perf/util/include/asm/hash.h | 6 tools/perf/util/machine.c | 42 +++- tools/perf/util/machine.h | 2 ++ tools/perf/util/map.c | 5 +-- tools/perf/util/map.h | 1 + tools/perf/util/symbol-elf.c| 4 ++- tools/perf/util/symbol.c| 65 + 13 files changed, 162 insertions(+), 62 deletions(-) create mode 100644 tools/perf/util/include/asm/hash.h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
