Re: [Ksummit-discuss] [RFC PATCH 2/3] MAINTAINERS, Handbook: Subsystem Profile
On Fri, 16 Nov 2018, Joe Perches wrote: > On Fri, 2018-11-16 at 14:44 +0200, Jani Nikula wrote: >> I quickly cooked up this script to produce the top-5 commit prefixes for >> the given files over the arbitrary last 200 commits. It'll give you a >> pretty good idea if you're even close. >> >> --- >> #!/bin/sh >> # usage: subject-prefix FILE [...] >> # show top 5 subject prefixes for FILEs >> >> git log --format=%s -n 200 -- "$@" |\ >> grep -v "^Merge " |\ >> sed 's/\(.*\):.*/\1/' |\ >> sort | uniq -c | sort -nr | sed 's/ *[0-9]\+ //' |\ >> head -n 5 >> --- >> >> Someone who knows perl could turn that into a checkpatch check: See if >> the patch subject prefix is one of the top-5 for all files changed by >> the patch, and ask the user to double check if it isn't. Or some >> heuristics thereof. > > This won't work when a patch contains multiple files > from different paths, or even multiple files from a > single driver. *shrug* You can give it multiple files as argument, and it'll give you an approximation of what the prefix could be, whether you're way off or not. Close enough at least for the single driver case. Obviously not perfect, but hey, it took me all of five minutes to write that. ;) BR, Jani. -- Jani Nikula, Intel Open Source Graphics Center
Re: [Ksummit-discuss] [RFC PATCH 2/3] MAINTAINERS, Handbook: Subsystem Profile
On Fri, 16 Nov 2018, Joe Perches wrote: > On Fri, 2018-11-16 at 14:44 +0200, Jani Nikula wrote: >> I quickly cooked up this script to produce the top-5 commit prefixes for >> the given files over the arbitrary last 200 commits. It'll give you a >> pretty good idea if you're even close. >> >> --- >> #!/bin/sh >> # usage: subject-prefix FILE [...] >> # show top 5 subject prefixes for FILEs >> >> git log --format=%s -n 200 -- "$@" |\ >> grep -v "^Merge " |\ >> sed 's/\(.*\):.*/\1/' |\ >> sort | uniq -c | sort -nr | sed 's/ *[0-9]\+ //' |\ >> head -n 5 >> --- >> >> Someone who knows perl could turn that into a checkpatch check: See if >> the patch subject prefix is one of the top-5 for all files changed by >> the patch, and ask the user to double check if it isn't. Or some >> heuristics thereof. > > This won't work when a patch contains multiple files > from different paths, or even multiple files from a > single driver. *shrug* You can give it multiple files as argument, and it'll give you an approximation of what the prefix could be, whether you're way off or not. Close enough at least for the single driver case. Obviously not perfect, but hey, it took me all of five minutes to write that. ;) BR, Jani. -- Jani Nikula, Intel Open Source Graphics Center
Re: [Ksummit-discuss] [RFC PATCH 2/3] MAINTAINERS, Handbook: Subsystem Profile
Em Sun, 18 Nov 2018 09:34:01 -0800 Dan Williams escreveu: > On Sun, Nov 18, 2018 at 9:31 AM Dan Williams wrote: > > On Sun, Nov 18, 2018 at 9:31 AM Dan Williams > > wrote: > [..] > > > True, will remove. What's the point of stating daily active hours when we > > > already have "Resubmit Cadence" (I think I'll rename it "Follow Cadence") > > > measured in multiple days / weeks. > > Apologies, fumble-fingered that last mail. I meant to say "Follow-up > Cadence", and that include a maintainer preference for private pings, > or full patch set to be sent again to the list. Yeah, "Follow-up Cadence" sounds a way better. Thanks, Mauro
Re: [Ksummit-discuss] [RFC PATCH 2/3] MAINTAINERS, Handbook: Subsystem Profile
Em Sun, 18 Nov 2018 09:34:01 -0800 Dan Williams escreveu: > On Sun, Nov 18, 2018 at 9:31 AM Dan Williams wrote: > > On Sun, Nov 18, 2018 at 9:31 AM Dan Williams > > wrote: > [..] > > > True, will remove. What's the point of stating daily active hours when we > > > already have "Resubmit Cadence" (I think I'll rename it "Follow Cadence") > > > measured in multiple days / weeks. > > Apologies, fumble-fingered that last mail. I meant to say "Follow-up > Cadence", and that include a maintainer preference for private pings, > or full patch set to be sent again to the list. Yeah, "Follow-up Cadence" sounds a way better. Thanks, Mauro
