Re: [LKP] [xfs] a5949d3fae: aim7.jobs-per-min -33.6% regression
On 7/7/2020 2:30 AM, Darrick J. Wong wrote:
On Wed, Jul 01, 2020 at 03:49:52PM +0800, Xing Zhengjun wrote:
On 6/10/2020 11:07 AM, Xing Zhengjun wrote:
Hi Darrick,
Do you have time to take a look at this? Thanks.
Ping...
Yes, that decrease is the expected end result of making the write path
take a longer route to avoid a file corruption vector.
--D
Thanks for the explanation, We will stop tracking it.
On 6/6/2020 11:48 PM, kernel test robot wrote:
Greeting,
FYI, we noticed a -33.6% regression of aim7.jobs-per-min due to commit:
commit: a5949d3faedf492fa7863b914da408047ab46eb0 ("xfs: force writes
to delalloc regions to unwritten")
https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git master
in testcase: aim7
on test machine: 48 threads Intel(R) Xeon(R) CPU E5-2697 v2 @
2.70GHz with 64G memory
with following parameters:
disk: 1BRD_48G
fs: xfs
test: sync_disk_rw
load: 600
cpufreq_governor: performance
ucode: 0x42e
test-description: AIM7 is a traditional UNIX system level benchmark
suite which is used to test and measure the performance of multiuser
system.
test-url: https://sourceforge.net/projects/aimbench/files/aim-suite7/
If you fix the issue, kindly add following tag
Reported-by: kernel test robot
Details are as below:
-->
To reproduce:
git clone https://github.com/intel/lkp-tests.git
cd lkp-tests
bin/lkp install job.yaml # job file is attached in this email
bin/lkp run job.yaml
=
compiler/cpufreq_governor/disk/fs/kconfig/load/rootfs/tbox_group/test/testcase/ucode:
gcc-9/performance/1BRD_48G/xfs/x86_64-rhel-7.6/600/debian-x86_64-20191114.cgz/lkp-ivb-2ep1/sync_disk_rw/aim7/0x42e
commit:
590b16516e ("xfs: refactor xfs_iomap_prealloc_size")
a5949d3fae ("xfs: force writes to delalloc regions to unwritten")
590b16516ef38e2e a5949d3faedf492fa7863b914da
---
fail:runs %reproduction fail:runs
| | |
:4 50% 2:4
dmesg.WARNING:at#for_ip_swapgs_restore_regs_and_return_to_usermode/0x
%stddev %change %stddev
\ | \
35272 -33.6% 23430 aim7.jobs-per-min
102.13 +50.5% 153.75 aim7.time.elapsed_time
102.13 +50.5% 153.75 aim7.time.elapsed_time.max
1388038 +40.2% 1945838
aim7.time.involuntary_context_switches
43420 ± 2% +13.4% 49255 ± 2%
aim7.time.minor_page_faults
3123 +44.2% 4504 ± 2% aim7.time.system_time
59.31 +6.5% 63.18 aim7.time.user_time
48595108 +58.6% 77064959
aim7.time.voluntary_context_switches
1.44 -28.8% 1.02 iostat.cpu.user
0.07 ± 6% +0.4 0.44 ± 7% mpstat.cpu.all.iowait%
1.44 -0.4 1.02 mpstat.cpu.all.usr%
8632 ± 50% +75.6% 15156 ± 34%
numa-meminfo.node0.KernelStack
6583 ±136% +106.0% 13562 ± 82%
numa-meminfo.node0.PageTables
63325 ± 11% +14.3% 72352 ± 12%
numa-meminfo.node0.SUnreclaim
8647 ± 50% +75.3% 15156 ± 34%
numa-vmstat.node0.nr_kernel_stack
1656 ±136% +104.6% 3389 ± 82%
numa-vmstat.node0.nr_page_table_pages
15831 ± 11% +14.3% 18087 ± 12%
numa-vmstat.node0.nr_slab_unreclaimable
93640 ± 3% +41.2% 132211 ± 2% meminfo.AnonHugePages
21641 +39.9% 30271 ± 4% meminfo.KernelStack
129269 +12.3% 145114 meminfo.SUnreclaim
28000 -31.2% 19275 meminfo.max_used_kB
1269307 -26.9% 927657 vmstat.io.bo
149.75 ± 3% -17.4% 123.75 ± 4% vmstat.procs.r
718992 +13.3% 814567 vmstat.system.cs
231397 -9.3% 209881 ± 2% vmstat.system.in
6.774e+08 +70.0% 1.152e+09 cpuidle.C1.time
18203372 +60.4% 29198744 cpuidle.C1.usage
2.569e+08 ± 18% +81.8% 4.672e+08 ± 5% cpuidle.C1E.time
2691402 ± 13% +98.7% 5346901 ± 3% cpuidle.C1E.usage
990350 +95.0% 1931226 ± 2% cpuidle.POLL.time
520061 +97.7% 1028004 ± 2% cpuidle.POLL.usage
77231 +1.8% 78602 proc-vmstat.nr_active_anon
19868 +3.8% 20615 proc-vmstat.nr_dirty
381302 +1.0% 384969 proc-vmstat.nr_file_pages
4388 -2.7% 4270
proc-vmstat.nr_inactive_anon
69865 +4.7% 73155
Re: [LKP] [xfs] a5949d3fae: aim7.jobs-per-min -33.6% regression
On Wed, Jul 01, 2020 at 03:49:52PM +0800, Xing Zhengjun wrote:
>
>
> On 6/10/2020 11:07 AM, Xing Zhengjun wrote:
> > Hi Darrick,
> >
> > Do you have time to take a look at this? Thanks.
> >
>
>
> Ping...
Yes, that decrease is the expected end result of making the write path
take a longer route to avoid a file corruption vector.
--D
>
>
> > On 6/6/2020 11:48 PM, kernel test robot wrote:
> > > Greeting,
> > >
> > > FYI, we noticed a -33.6% regression of aim7.jobs-per-min due to commit:
> > >
> > >
> > > commit: a5949d3faedf492fa7863b914da408047ab46eb0 ("xfs: force writes
> > > to delalloc regions to unwritten")
> > > https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git master
> > >
> > > in testcase: aim7
> > > on test machine: 48 threads Intel(R) Xeon(R) CPU E5-2697 v2 @
> > > 2.70GHz with 64G memory
> > > with following parameters:
> > >
> > > disk: 1BRD_48G
> > > fs: xfs
> > > test: sync_disk_rw
> > > load: 600
> > > cpufreq_governor: performance
> > > ucode: 0x42e
> > >
> > > test-description: AIM7 is a traditional UNIX system level benchmark
> > > suite which is used to test and measure the performance of multiuser
> > > system.
> > > test-url: https://sourceforge.net/projects/aimbench/files/aim-suite7/
> > >
> > >
> > >
> > > If you fix the issue, kindly add following tag
> > > Reported-by: kernel test robot
> > >
> > >
> > > Details are as below:
> > > -->
> > >
> > >
> > >
> > > To reproduce:
> > >
> > > git clone https://github.com/intel/lkp-tests.git
> > > cd lkp-tests
> > > bin/lkp install job.yaml # job file is attached in this email
> > > bin/lkp run job.yaml
> > >
> > > =
> > >
> > > compiler/cpufreq_governor/disk/fs/kconfig/load/rootfs/tbox_group/test/testcase/ucode:
> > >
> > >
> > > gcc-9/performance/1BRD_48G/xfs/x86_64-rhel-7.6/600/debian-x86_64-20191114.cgz/lkp-ivb-2ep1/sync_disk_rw/aim7/0x42e
> > >
> > >
> > > commit:
> > > 590b16516e ("xfs: refactor xfs_iomap_prealloc_size")
> > > a5949d3fae ("xfs: force writes to delalloc regions to unwritten")
> > >
> > > 590b16516ef38e2e a5949d3faedf492fa7863b914da
> > > ---
> > > fail:runs %reproduction fail:runs
> > > | | |
> > > :4 50% 2:4
> > > dmesg.WARNING:at#for_ip_swapgs_restore_regs_and_return_to_usermode/0x
> > > %stddev %change %stddev
> > > \ | \
> > > 35272 -33.6% 23430 aim7.jobs-per-min
> > > 102.13 +50.5% 153.75 aim7.time.elapsed_time
> > > 102.13 +50.5% 153.75 aim7.time.elapsed_time.max
> > > 1388038 +40.2% 1945838
> > > aim7.time.involuntary_context_switches
> > > 43420 ± 2% +13.4% 49255 ± 2%
> > > aim7.time.minor_page_faults
> > > 3123 +44.2% 4504 ± 2% aim7.time.system_time
> > > 59.31 +6.5% 63.18 aim7.time.user_time
> > > 48595108 +58.6% 77064959
> > > aim7.time.voluntary_context_switches
> > > 1.44 -28.8% 1.02 iostat.cpu.user
> > > 0.07 ± 6% +0.4 0.44 ± 7% mpstat.cpu.all.iowait%
> > > 1.44 -0.4 1.02 mpstat.cpu.all.usr%
> > > 8632 ± 50% +75.6% 15156 ± 34%
> > > numa-meminfo.node0.KernelStack
> > > 6583 ±136% +106.0% 13562 ± 82%
> > > numa-meminfo.node0.PageTables
> > > 63325 ± 11% +14.3% 72352 ± 12%
> > > numa-meminfo.node0.SUnreclaim
> > > 8647 ± 50% +75.3% 15156 ± 34%
> > > numa-vmstat.node0.nr_kernel_stack
> > > 1656 ±136% +104.6% 3389 ± 82%
> > > numa-vmstat.node0.nr_page_table_pages
> > > 15831 ± 11% +14.3% 18087 ± 12%
> > > numa-vmstat.node0.nr_slab_unreclaimable
> > > 93640 ± 3% +41.2% 132211 ± 2% meminfo.AnonHugePages
> > > 21641 +39.9% 30271 ± 4% meminfo.KernelStack
> > > 129269 +12.3% 145114 meminfo.SUnreclaim
> > > 28000 -31.2% 19275 meminfo.max_used_kB
> > > 1269307 -26.9% 927657 vmstat.io.bo
> > > 149.75 ± 3% -17.4% 123.75 ± 4% vmstat.procs.r
> > > 718992 +13.3% 814567 vmstat.system.cs
> > > 231397 -9.3% 209881 ± 2% vmstat.system.in
> > > 6.774e+08 +70.0% 1.152e+09 cpuidle.C1.time
> > > 18203372 +60.4% 29198744 cpuidle.C1.usage
> > > 2.569e+08 ± 18% +81.8% 4.672e+08 ± 5% cpuidle.C1E.time
> > > 2691402 ± 13% +98.7% 5346901 ± 3% cpuidle.C1E.usage
Re: [LKP] [xfs] a5949d3fae: aim7.jobs-per-min -33.6% regression
On 6/10/2020 11:07 AM, Xing Zhengjun wrote:
Hi Darrick,
Do you have time to take a look at this? Thanks.
Ping...
On 6/6/2020 11:48 PM, kernel test robot wrote:
Greeting,
FYI, we noticed a -33.6% regression of aim7.jobs-per-min due to commit:
commit: a5949d3faedf492fa7863b914da408047ab46eb0 ("xfs: force writes
to delalloc regions to unwritten")
https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git master
in testcase: aim7
on test machine: 48 threads Intel(R) Xeon(R) CPU E5-2697 v2 @ 2.70GHz
with 64G memory
with following parameters:
disk: 1BRD_48G
fs: xfs
test: sync_disk_rw
load: 600
cpufreq_governor: performance
ucode: 0x42e
test-description: AIM7 is a traditional UNIX system level benchmark
suite which is used to test and measure the performance of multiuser
system.
test-url: https://sourceforge.net/projects/aimbench/files/aim-suite7/
If you fix the issue, kindly add following tag
Reported-by: kernel test robot
Details are as below:
-->
To reproduce:
git clone https://github.com/intel/lkp-tests.git
cd lkp-tests
bin/lkp install job.yaml # job file is attached in this email
bin/lkp run job.yaml
=
compiler/cpufreq_governor/disk/fs/kconfig/load/rootfs/tbox_group/test/testcase/ucode:
gcc-9/performance/1BRD_48G/xfs/x86_64-rhel-7.6/600/debian-x86_64-20191114.cgz/lkp-ivb-2ep1/sync_disk_rw/aim7/0x42e
commit:
590b16516e ("xfs: refactor xfs_iomap_prealloc_size")
a5949d3fae ("xfs: force writes to delalloc regions to unwritten")
590b16516ef38e2e a5949d3faedf492fa7863b914da
---
fail:runs %reproduction fail:runs
| | |
:4 50% 2:4
dmesg.WARNING:at#for_ip_swapgs_restore_regs_and_return_to_usermode/0x
%stddev %change %stddev
\ | \
35272 -33.6% 23430 aim7.jobs-per-min
102.13 +50.5% 153.75 aim7.time.elapsed_time
102.13 +50.5% 153.75 aim7.time.elapsed_time.max
1388038 +40.2% 1945838
aim7.time.involuntary_context_switches
43420 ± 2% +13.4% 49255 ± 2%
aim7.time.minor_page_faults
3123 +44.2% 4504 ± 2% aim7.time.system_time
59.31 +6.5% 63.18 aim7.time.user_time
48595108 +58.6% 77064959
aim7.time.voluntary_context_switches
1.44 -28.8% 1.02 iostat.cpu.user
0.07 ± 6% +0.4 0.44 ± 7% mpstat.cpu.all.iowait%
1.44 -0.4 1.02 mpstat.cpu.all.usr%
8632 ± 50% +75.6% 15156 ± 34%
numa-meminfo.node0.KernelStack
6583 ±136% +106.0% 13562 ± 82%
numa-meminfo.node0.PageTables
63325 ± 11% +14.3% 72352 ± 12%
numa-meminfo.node0.SUnreclaim
8647 ± 50% +75.3% 15156 ± 34%
numa-vmstat.node0.nr_kernel_stack
1656 ±136% +104.6% 3389 ± 82%
numa-vmstat.node0.nr_page_table_pages
15831 ± 11% +14.3% 18087 ± 12%
numa-vmstat.node0.nr_slab_unreclaimable
93640 ± 3% +41.2% 132211 ± 2% meminfo.AnonHugePages
21641 +39.9% 30271 ± 4% meminfo.KernelStack
129269 +12.3% 145114 meminfo.SUnreclaim
28000 -31.2% 19275 meminfo.max_used_kB
1269307 -26.9% 927657 vmstat.io.bo
149.75 ± 3% -17.4% 123.75 ± 4% vmstat.procs.r
718992 +13.3% 814567 vmstat.system.cs
231397 -9.3% 209881 ± 2% vmstat.system.in
6.774e+08 +70.0% 1.152e+09 cpuidle.C1.time
18203372 +60.4% 29198744 cpuidle.C1.usage
2.569e+08 ± 18% +81.8% 4.672e+08 ± 5% cpuidle.C1E.time
2691402 ± 13% +98.7% 5346901 ± 3% cpuidle.C1E.usage
990350 +95.0% 1931226 ± 2% cpuidle.POLL.time
520061 +97.7% 1028004 ± 2% cpuidle.POLL.usage
77231 +1.8% 78602 proc-vmstat.nr_active_anon
19868 +3.8% 20615 proc-vmstat.nr_dirty
381302 +1.0% 384969 proc-vmstat.nr_file_pages
4388 -2.7% 4270
proc-vmstat.nr_inactive_anon
69865 +4.7% 73155
proc-vmstat.nr_inactive_file
21615 +40.0% 30251 ± 4%
proc-vmstat.nr_kernel_stack
7363 -3.2% 7127 proc-vmstat.nr_mapped
12595 ± 3% +5.2% 13255 ± 4% proc-vmstat.nr_shmem
19619 +3.2% 20247
Re: [LKP] [xfs] a5949d3fae: aim7.jobs-per-min -33.6% regression
Hi Darrick,
Do you have time to take a look at this? Thanks.
On 6/6/2020 11:48 PM, kernel test robot wrote:
Greeting,
FYI, we noticed a -33.6% regression of aim7.jobs-per-min due to commit:
commit: a5949d3faedf492fa7863b914da408047ab46eb0 ("xfs: force writes to delalloc
regions to unwritten")
https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git master
in testcase: aim7
on test machine: 48 threads Intel(R) Xeon(R) CPU E5-2697 v2 @ 2.70GHz with 64G
memory
with following parameters:
disk: 1BRD_48G
fs: xfs
test: sync_disk_rw
load: 600
cpufreq_governor: performance
ucode: 0x42e
test-description: AIM7 is a traditional UNIX system level benchmark suite which
is used to test and measure the performance of multiuser system.
test-url: https://sourceforge.net/projects/aimbench/files/aim-suite7/
If you fix the issue, kindly add following tag
Reported-by: kernel test robot
Details are as below:
-->
To reproduce:
git clone https://github.com/intel/lkp-tests.git
cd lkp-tests
bin/lkp install job.yaml # job file is attached in this email
bin/lkp run job.yaml
=
compiler/cpufreq_governor/disk/fs/kconfig/load/rootfs/tbox_group/test/testcase/ucode:
gcc-9/performance/1BRD_48G/xfs/x86_64-rhel-7.6/600/debian-x86_64-20191114.cgz/lkp-ivb-2ep1/sync_disk_rw/aim7/0x42e
commit:
590b16516e ("xfs: refactor xfs_iomap_prealloc_size")
a5949d3fae ("xfs: force writes to delalloc regions to unwritten")
590b16516ef38e2e a5949d3faedf492fa7863b914da
---
fail:runs %reproductionfail:runs
| | |
:4 50% 2:4
dmesg.WARNING:at#for_ip_swapgs_restore_regs_and_return_to_usermode/0x
%stddev %change %stddev
\ |\
35272 -33.6% 23430aim7.jobs-per-min
102.13 +50.5% 153.75aim7.time.elapsed_time
102.13 +50.5% 153.75aim7.time.elapsed_time.max
1388038 +40.2%1945838
aim7.time.involuntary_context_switches
43420 ± 2% +13.4% 49255 ± 2% aim7.time.minor_page_faults
3123 +44.2% 4504 ± 2% aim7.time.system_time
59.31+6.5% 63.18aim7.time.user_time
48595108 +58.6% 77064959
aim7.time.voluntary_context_switches
1.44 -28.8% 1.02iostat.cpu.user
0.07 ± 6% +0.40.44 ± 7% mpstat.cpu.all.iowait%
1.44-0.41.02mpstat.cpu.all.usr%
8632 ± 50% +75.6% 15156 ± 34% numa-meminfo.node0.KernelStack
6583 ±136%+106.0% 13562 ± 82% numa-meminfo.node0.PageTables
63325 ± 11% +14.3% 72352 ± 12% numa-meminfo.node0.SUnreclaim
8647 ± 50% +75.3% 15156 ± 34% numa-vmstat.node0.nr_kernel_stack
1656 ±136%+104.6% 3389 ± 82%
numa-vmstat.node0.nr_page_table_pages
15831 ± 11% +14.3% 18087 ± 12%
numa-vmstat.node0.nr_slab_unreclaimable
93640 ± 3% +41.2% 132211 ± 2% meminfo.AnonHugePages
21641 +39.9% 30271 ± 4% meminfo.KernelStack
129269 +12.3% 145114meminfo.SUnreclaim
28000 -31.2% 19275meminfo.max_used_kB
1269307 -26.9% 927657vmstat.io.bo
149.75 ± 3% -17.4% 123.75 ± 4% vmstat.procs.r
718992 +13.3% 814567vmstat.system.cs
231397-9.3% 209881 ± 2% vmstat.system.in
6.774e+08 +70.0% 1.152e+09cpuidle.C1.time
18203372 +60.4% 29198744cpuidle.C1.usage
2.569e+08 ± 18% +81.8% 4.672e+08 ± 5% cpuidle.C1E.time
2691402 ± 13% +98.7%5346901 ± 3% cpuidle.C1E.usage
990350 +95.0%1931226 ± 2% cpuidle.POLL.time
520061 +97.7%1028004 ± 2% cpuidle.POLL.usage
77231+1.8% 78602proc-vmstat.nr_active_anon
19868+3.8% 20615proc-vmstat.nr_dirty
381302+1.0% 384969proc-vmstat.nr_file_pages
4388-2.7% 4270proc-vmstat.nr_inactive_anon
69865+4.7% 73155proc-vmstat.nr_inactive_file
21615 +40.0% 30251 ± 4% proc-vmstat.nr_kernel_stack
7363-3.2% 7127proc-vmstat.nr_mapped
12595 ± 3% +5.2% 13255 ± 4% proc-vmstat.nr_shmem
19619+3.2% 20247proc-vmstat.nr_slab_reclaimable
32316 +12.3% 36280
