Re: [Nouveau] [PATCH 2/6] drm/nouveau/core: make use of new strtolower() function

2016-07-03 Thread Alexandre Courbot 
On Mon, Jul 4, 2016 at 10:37 AM, Alexandre Courbot  wrote:
> On Sun, Jul 3, 2016 at 12:21 AM, Markus Mayer  
> wrote:
>> On 1 July 2016 at 18:18, Alexandre Courbot  wrote:
>>> On Fri, Jul 1, 2016 at 8:50 AM, Markus Mayer  wrote:
 Call strtolower() rather than walking the string explicitly to convert
 it to lowercase.

 Signed-off-by: Markus Mayer 
 ---
  drivers/gpu/drm/nouveau/nvkm/core/firmware.c | 7 +--
  1 file changed, 1 insertion(+), 6 deletions(-)

 diff --git a/drivers/gpu/drm/nouveau/nvkm/core/firmware.c 
 b/drivers/gpu/drm/nouveau/nvkm/core/firmware.c
 index 34ecd4a..c50594c 100644
 --- a/drivers/gpu/drm/nouveau/nvkm/core/firmware.c
 +++ b/drivers/gpu/drm/nouveau/nvkm/core/firmware.c
 @@ -36,16 +36,11 @@ nvkm_firmware_get(struct nvkm_device *device, const 
 char *fwname,
  {
 char f[64];
 char cname[16];
 -   int i;

 /* Convert device name to lowercase */
 strncpy(cname, device->chip->name, sizeof(cname));
 cname[sizeof(cname) - 1] = '\0';
 -   i = strlen(cname);
 -   while (i) {
 -   --i;
 -   cname[i] = tolower(cname[i]);
 -   }
 +   strtolower(cname);
>>>
>>> This function doesn't seem to exist as of next-20160701, where have
>>> you found it?
>>
>> I didn't find it. I wrote it, because it didn't exist and I needed it.
>> See: https://lkml.org/lkml/2016/6/30/727 and
>> https://lkml.org/lkml/2016/6/30/733 (cover letter and first patch in
>> series).
>
> Ah, right - would have been easier to understand if you had sent the
> whole series (or at least patches 0 to 2) to us as well. Please do
> that for the next version.

... found patches 0 and 1 in my spam folder, for some weird reason.
Apologies for jumping to conclusions.

Re: [Nouveau] [PATCH 2/6] drm/nouveau/core: make use of new strtolower() function

2016-07-03 Thread Alexandre Courbot 
On Mon, Jul 4, 2016 at 10:37 AM, Alexandre Courbot  wrote:
> On Sun, Jul 3, 2016 at 12:21 AM, Markus Mayer  
> wrote:
>> On 1 July 2016 at 18:18, Alexandre Courbot  wrote:
>>> On Fri, Jul 1, 2016 at 8:50 AM, Markus Mayer  wrote:
 Call strtolower() rather than walking the string explicitly to convert
 it to lowercase.

 Signed-off-by: Markus Mayer 
 ---
  drivers/gpu/drm/nouveau/nvkm/core/firmware.c | 7 +--
  1 file changed, 1 insertion(+), 6 deletions(-)

 diff --git a/drivers/gpu/drm/nouveau/nvkm/core/firmware.c 
 b/drivers/gpu/drm/nouveau/nvkm/core/firmware.c
 index 34ecd4a..c50594c 100644
 --- a/drivers/gpu/drm/nouveau/nvkm/core/firmware.c
 +++ b/drivers/gpu/drm/nouveau/nvkm/core/firmware.c
 @@ -36,16 +36,11 @@ nvkm_firmware_get(struct nvkm_device *device, const 
 char *fwname,
  {
 char f[64];
 char cname[16];
 -   int i;

 /* Convert device name to lowercase */
 strncpy(cname, device->chip->name, sizeof(cname));
 cname[sizeof(cname) - 1] = '\0';
 -   i = strlen(cname);
 -   while (i) {
 -   --i;
 -   cname[i] = tolower(cname[i]);
 -   }
 +   strtolower(cname);
>>>
>>> This function doesn't seem to exist as of next-20160701, where have
>>> you found it?
>>
>> I didn't find it. I wrote it, because it didn't exist and I needed it.
>> See: https://lkml.org/lkml/2016/6/30/727 and
>> https://lkml.org/lkml/2016/6/30/733 (cover letter and first patch in
>> series).
>
> Ah, right - would have been easier to understand if you had sent the
> whole series (or at least patches 0 to 2) to us as well. Please do
> that for the next version.

... found patches 0 and 1 in my spam folder, for some weird reason.
Apologies for jumping to conclusions.

Re: [Nouveau] [PATCH 2/6] drm/nouveau/core: make use of new strtolower() function

2016-07-03 Thread Alexandre Courbot 
On Sun, Jul 3, 2016 at 12:21 AM, Markus Mayer  wrote:
> On 1 July 2016 at 18:18, Alexandre Courbot  wrote:
>> On Fri, Jul 1, 2016 at 8:50 AM, Markus Mayer  wrote:
>>> Call strtolower() rather than walking the string explicitly to convert
>>> it to lowercase.
>>>
>>> Signed-off-by: Markus Mayer 
>>> ---
>>>  drivers/gpu/drm/nouveau/nvkm/core/firmware.c | 7 +--
>>>  1 file changed, 1 insertion(+), 6 deletions(-)
>>>
>>> diff --git a/drivers/gpu/drm/nouveau/nvkm/core/firmware.c 
>>> b/drivers/gpu/drm/nouveau/nvkm/core/firmware.c
>>> index 34ecd4a..c50594c 100644
>>> --- a/drivers/gpu/drm/nouveau/nvkm/core/firmware.c
>>> +++ b/drivers/gpu/drm/nouveau/nvkm/core/firmware.c
>>> @@ -36,16 +36,11 @@ nvkm_firmware_get(struct nvkm_device *device, const 
>>> char *fwname,
>>>  {
>>> char f[64];
>>> char cname[16];
>>> -   int i;
>>>
>>> /* Convert device name to lowercase */
>>> strncpy(cname, device->chip->name, sizeof(cname));
>>> cname[sizeof(cname) - 1] = '\0';
>>> -   i = strlen(cname);
>>> -   while (i) {
>>> -   --i;
>>> -   cname[i] = tolower(cname[i]);
>>> -   }
>>> +   strtolower(cname);
>>
>> This function doesn't seem to exist as of next-20160701, where have
>> you found it?
>
> I didn't find it. I wrote it, because it didn't exist and I needed it.
> See: https://lkml.org/lkml/2016/6/30/727 and
> https://lkml.org/lkml/2016/6/30/733 (cover letter and first patch in
> series).

Ah, right - would have been easier to understand if you had sent the
whole series (or at least patches 0 to 2) to us as well. Please do
that for the next version.

Re: [Nouveau] [PATCH 2/6] drm/nouveau/core: make use of new strtolower() function

2016-07-03 Thread Alexandre Courbot 
On Sun, Jul 3, 2016 at 12:21 AM, Markus Mayer  wrote:
> On 1 July 2016 at 18:18, Alexandre Courbot  wrote:
>> On Fri, Jul 1, 2016 at 8:50 AM, Markus Mayer  wrote:
>>> Call strtolower() rather than walking the string explicitly to convert
>>> it to lowercase.
>>>
>>> Signed-off-by: Markus Mayer 
>>> ---
>>>  drivers/gpu/drm/nouveau/nvkm/core/firmware.c | 7 +--
>>>  1 file changed, 1 insertion(+), 6 deletions(-)
>>>
>>> diff --git a/drivers/gpu/drm/nouveau/nvkm/core/firmware.c 
>>> b/drivers/gpu/drm/nouveau/nvkm/core/firmware.c
>>> index 34ecd4a..c50594c 100644
>>> --- a/drivers/gpu/drm/nouveau/nvkm/core/firmware.c
>>> +++ b/drivers/gpu/drm/nouveau/nvkm/core/firmware.c
>>> @@ -36,16 +36,11 @@ nvkm_firmware_get(struct nvkm_device *device, const 
>>> char *fwname,
>>>  {
>>> char f[64];
>>> char cname[16];
>>> -   int i;
>>>
>>> /* Convert device name to lowercase */
>>> strncpy(cname, device->chip->name, sizeof(cname));
>>> cname[sizeof(cname) - 1] = '\0';
>>> -   i = strlen(cname);
>>> -   while (i) {
>>> -   --i;
>>> -   cname[i] = tolower(cname[i]);
>>> -   }
>>> +   strtolower(cname);
>>
>> This function doesn't seem to exist as of next-20160701, where have
>> you found it?
>
> I didn't find it. I wrote it, because it didn't exist and I needed it.
> See: https://lkml.org/lkml/2016/6/30/727 and
> https://lkml.org/lkml/2016/6/30/733 (cover letter and first patch in
> series).

Ah, right - would have been easier to understand if you had sent the
whole series (or at least patches 0 to 2) to us as well. Please do
that for the next version.

Re: [Nouveau] [PATCH 2/6] drm/nouveau/core: make use of new strtolower() function

2016-07-02 Thread Markus Mayer 
On 1 July 2016 at 18:18, Alexandre Courbot  wrote:
> On Fri, Jul 1, 2016 at 8:50 AM, Markus Mayer  wrote:
>> Call strtolower() rather than walking the string explicitly to convert
>> it to lowercase.
>>
>> Signed-off-by: Markus Mayer 
>> ---
>>  drivers/gpu/drm/nouveau/nvkm/core/firmware.c | 7 +--
>>  1 file changed, 1 insertion(+), 6 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/nouveau/nvkm/core/firmware.c 
>> b/drivers/gpu/drm/nouveau/nvkm/core/firmware.c
>> index 34ecd4a..c50594c 100644
>> --- a/drivers/gpu/drm/nouveau/nvkm/core/firmware.c
>> +++ b/drivers/gpu/drm/nouveau/nvkm/core/firmware.c
>> @@ -36,16 +36,11 @@ nvkm_firmware_get(struct nvkm_device *device, const char 
>> *fwname,
>>  {
>> char f[64];
>> char cname[16];
>> -   int i;
>>
>> /* Convert device name to lowercase */
>> strncpy(cname, device->chip->name, sizeof(cname));
>> cname[sizeof(cname) - 1] = '\0';
>> -   i = strlen(cname);
>> -   while (i) {
>> -   --i;
>> -   cname[i] = tolower(cname[i]);
>> -   }
>> +   strtolower(cname);
>
> This function doesn't seem to exist as of next-20160701, where have
> you found it?

I didn't find it. I wrote it, because it didn't exist and I needed it.
See: https://lkml.org/lkml/2016/6/30/727 and
https://lkml.org/lkml/2016/6/30/733 (cover letter and first patch in
series).

Re: [Nouveau] [PATCH 2/6] drm/nouveau/core: make use of new strtolower() function

2016-07-02 Thread Markus Mayer 
On 1 July 2016 at 18:18, Alexandre Courbot  wrote:
> On Fri, Jul 1, 2016 at 8:50 AM, Markus Mayer  wrote:
>> Call strtolower() rather than walking the string explicitly to convert
>> it to lowercase.
>>
>> Signed-off-by: Markus Mayer 
>> ---
>>  drivers/gpu/drm/nouveau/nvkm/core/firmware.c | 7 +--
>>  1 file changed, 1 insertion(+), 6 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/nouveau/nvkm/core/firmware.c 
>> b/drivers/gpu/drm/nouveau/nvkm/core/firmware.c
>> index 34ecd4a..c50594c 100644
>> --- a/drivers/gpu/drm/nouveau/nvkm/core/firmware.c
>> +++ b/drivers/gpu/drm/nouveau/nvkm/core/firmware.c
>> @@ -36,16 +36,11 @@ nvkm_firmware_get(struct nvkm_device *device, const char 
>> *fwname,
>>  {
>> char f[64];
>> char cname[16];
>> -   int i;
>>
>> /* Convert device name to lowercase */
>> strncpy(cname, device->chip->name, sizeof(cname));
>> cname[sizeof(cname) - 1] = '\0';
>> -   i = strlen(cname);
>> -   while (i) {
>> -   --i;
>> -   cname[i] = tolower(cname[i]);
>> -   }
>> +   strtolower(cname);
>
> This function doesn't seem to exist as of next-20160701, where have
> you found it?

I didn't find it. I wrote it, because it didn't exist and I needed it.
See: https://lkml.org/lkml/2016/6/30/727 and
https://lkml.org/lkml/2016/6/30/733 (cover letter and first patch in
series).

Re: [Nouveau] [PATCH 2/6] drm/nouveau/core: make use of new strtolower() function

2016-07-01 Thread Alexandre Courbot 
On Fri, Jul 1, 2016 at 8:50 AM, Markus Mayer  wrote:
> Call strtolower() rather than walking the string explicitly to convert
> it to lowercase.
>
> Signed-off-by: Markus Mayer 
> ---
>  drivers/gpu/drm/nouveau/nvkm/core/firmware.c | 7 +--
>  1 file changed, 1 insertion(+), 6 deletions(-)
>
> diff --git a/drivers/gpu/drm/nouveau/nvkm/core/firmware.c 
> b/drivers/gpu/drm/nouveau/nvkm/core/firmware.c
> index 34ecd4a..c50594c 100644
> --- a/drivers/gpu/drm/nouveau/nvkm/core/firmware.c
> +++ b/drivers/gpu/drm/nouveau/nvkm/core/firmware.c
> @@ -36,16 +36,11 @@ nvkm_firmware_get(struct nvkm_device *device, const char 
> *fwname,
>  {
> char f[64];
> char cname[16];
> -   int i;
>
> /* Convert device name to lowercase */
> strncpy(cname, device->chip->name, sizeof(cname));
> cname[sizeof(cname) - 1] = '\0';
> -   i = strlen(cname);
> -   while (i) {
> -   --i;
> -   cname[i] = tolower(cname[i]);
> -   }
> +   strtolower(cname);

This function doesn't seem to exist as of next-20160701, where have
you found it?

Re: [Nouveau] [PATCH 2/6] drm/nouveau/core: make use of new strtolower() function

2016-07-01 Thread Alexandre Courbot 
On Fri, Jul 1, 2016 at 8:50 AM, Markus Mayer  wrote:
> Call strtolower() rather than walking the string explicitly to convert
> it to lowercase.
>
> Signed-off-by: Markus Mayer 
> ---
>  drivers/gpu/drm/nouveau/nvkm/core/firmware.c | 7 +--
>  1 file changed, 1 insertion(+), 6 deletions(-)
>
> diff --git a/drivers/gpu/drm/nouveau/nvkm/core/firmware.c 
> b/drivers/gpu/drm/nouveau/nvkm/core/firmware.c
> index 34ecd4a..c50594c 100644
> --- a/drivers/gpu/drm/nouveau/nvkm/core/firmware.c
> +++ b/drivers/gpu/drm/nouveau/nvkm/core/firmware.c
> @@ -36,16 +36,11 @@ nvkm_firmware_get(struct nvkm_device *device, const char 
> *fwname,
>  {
> char f[64];
> char cname[16];
> -   int i;
>
> /* Convert device name to lowercase */
> strncpy(cname, device->chip->name, sizeof(cname));
> cname[sizeof(cname) - 1] = '\0';
> -   i = strlen(cname);
> -   while (i) {
> -   --i;
> -   cname[i] = tolower(cname[i]);
> -   }
> +   strtolower(cname);

This function doesn't seem to exist as of next-20160701, where have
you found it?