Re: [PATCH][crypto-next] crypto: inside-secure - make function safexcel_try_push_requests static
Hi Colin, On Tue, Jan 02, 2018 at 02:34:10PM +, Colin King wrote: > > /* Called with ring's lock taken */ > -int safexcel_try_push_requests(struct safexcel_crypto_priv *priv, int ring, > -int reqs) > +static int safexcel_try_push_requests(struct safexcel_crypto_priv *priv, > + int ring, int reqs) Alignment should match open parenthesis, one space is missing. Otherwise, looks good to me. Thanks! Antoine -- Antoine Ténart, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com
Re: [PATCH][crypto-next] crypto: inside-secure - make function safexcel_try_push_requests static
Hi Colin, On Tue, Jan 02, 2018 at 02:34:10PM +, Colin King wrote: > > /* Called with ring's lock taken */ > -int safexcel_try_push_requests(struct safexcel_crypto_priv *priv, int ring, > -int reqs) > +static int safexcel_try_push_requests(struct safexcel_crypto_priv *priv, > + int ring, int reqs) Alignment should match open parenthesis, one space is missing. Otherwise, looks good to me. Thanks! Antoine -- Antoine Ténart, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com
[PATCH][crypto-next] crypto: inside-secure - make function safexcel_try_push_requests static
From: Colin Ian KingThe function safexcel_try_push_requests is local to the source and does not need to be in global scope, so make it static. Cleans up sparse warning: symbol 'safexcel_try_push_requests' was not declared. Should it be static? Signed-off-by: Colin Ian King --- drivers/crypto/inside-secure/safexcel.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/crypto/inside-secure/safexcel.c b/drivers/crypto/inside-secure/safexcel.c index 0d685be75241..e3745139644b 100644 --- a/drivers/crypto/inside-secure/safexcel.c +++ b/drivers/crypto/inside-secure/safexcel.c @@ -432,8 +432,8 @@ static int safexcel_hw_init(struct safexcel_crypto_priv *priv) } /* Called with ring's lock taken */ -int safexcel_try_push_requests(struct safexcel_crypto_priv *priv, int ring, - int reqs) +static int safexcel_try_push_requests(struct safexcel_crypto_priv *priv, +int ring, int reqs) { int coal = min_t(int, reqs, EIP197_MAX_BATCH_SZ); -- 2.14.1
[PATCH][crypto-next] crypto: inside-secure - make function safexcel_try_push_requests static
From: Colin Ian King The function safexcel_try_push_requests is local to the source and does not need to be in global scope, so make it static. Cleans up sparse warning: symbol 'safexcel_try_push_requests' was not declared. Should it be static? Signed-off-by: Colin Ian King --- drivers/crypto/inside-secure/safexcel.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/crypto/inside-secure/safexcel.c b/drivers/crypto/inside-secure/safexcel.c index 0d685be75241..e3745139644b 100644 --- a/drivers/crypto/inside-secure/safexcel.c +++ b/drivers/crypto/inside-secure/safexcel.c @@ -432,8 +432,8 @@ static int safexcel_hw_init(struct safexcel_crypto_priv *priv) } /* Called with ring's lock taken */ -int safexcel_try_push_requests(struct safexcel_crypto_priv *priv, int ring, - int reqs) +static int safexcel_try_push_requests(struct safexcel_crypto_priv *priv, +int ring, int reqs) { int coal = min_t(int, reqs, EIP197_MAX_BATCH_SZ); -- 2.14.1