Re: [PATCH][net-next] net/mlxfw: remove redundant goto on error check

2017-06-06 Thread David Miller 
From: Colin King 
Date: Tue,  6 Jun 2017 11:47:40 +0100

> From: Colin Ian King 
> 
> The check to see of err is set and the subsequent goto is extraneous
> as the next statement is where the goto is jumping to. Remove this
> redundant check and goto.
> 
> Detected by CoverityScan, CID#1437734 ("Identical code for
> different branches")
> 
> Signed-off-by: Colin Ian King 

Applied, thanks.

Re: [PATCH][net-next] net/mlxfw: remove redundant goto on error check

2017-06-06 Thread David Miller 
From: Colin King 
Date: Tue,  6 Jun 2017 11:47:40 +0100

> From: Colin Ian King 
> 
> The check to see of err is set and the subsequent goto is extraneous
> as the next statement is where the goto is jumping to. Remove this
> redundant check and goto.
> 
> Detected by CoverityScan, CID#1437734 ("Identical code for
> different branches")
> 
> Signed-off-by: Colin Ian King 

Applied, thanks.

Re: [PATCH][net-next] net/mlxfw: remove redundant goto on error check

2017-06-06 Thread Yotam Gigi 
On 06/06/2017 01:47 PM, Colin King wrote:
> From: Colin Ian King 
>
> The check to see of err is set and the subsequent goto is extraneous
> as the next statement is where the goto is jumping to. Remove this
> redundant check and goto.
>
> Detected by CoverityScan, CID#1437734 ("Identical code for
> different branches")
>
> Signed-off-by: Colin Ian King 
> ---
>  drivers/net/ethernet/mellanox/mlxfw/mlxfw_mfa2.c | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/drivers/net/ethernet/mellanox/mlxfw/mlxfw_mfa2.c 
> b/drivers/net/ethernet/mellanox/mlxfw/mlxfw_mfa2.c
> index 7e9589061d30..628150d28061 100644
> --- a/drivers/net/ethernet/mellanox/mlxfw/mlxfw_mfa2.c
> +++ b/drivers/net/ethernet/mellanox/mlxfw/mlxfw_mfa2.c
> @@ -492,8 +492,6 @@ static int mlxfw_mfa2_file_cb_offset_xz(const struct 
> mlxfw_mfa2_file *mfa2_file,
>   dec_buf.out_pos = 0;
>   dec_buf.out_size = size;
>   err = mlxfw_mfa2_xz_dec_run(xz_dec, _buf, );
> - if (err)
> - goto out;
>  out:
>   xz_dec_end(xz_dec);
>   return err;


Thanks!

Acked-by: Yotam Gigi

Re: [PATCH][net-next] net/mlxfw: remove redundant goto on error check

2017-06-06 Thread Yotam Gigi 
On 06/06/2017 01:47 PM, Colin King wrote:
> From: Colin Ian King 
>
> The check to see of err is set and the subsequent goto is extraneous
> as the next statement is where the goto is jumping to. Remove this
> redundant check and goto.
>
> Detected by CoverityScan, CID#1437734 ("Identical code for
> different branches")
>
> Signed-off-by: Colin Ian King 
> ---
>  drivers/net/ethernet/mellanox/mlxfw/mlxfw_mfa2.c | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/drivers/net/ethernet/mellanox/mlxfw/mlxfw_mfa2.c 
> b/drivers/net/ethernet/mellanox/mlxfw/mlxfw_mfa2.c
> index 7e9589061d30..628150d28061 100644
> --- a/drivers/net/ethernet/mellanox/mlxfw/mlxfw_mfa2.c
> +++ b/drivers/net/ethernet/mellanox/mlxfw/mlxfw_mfa2.c
> @@ -492,8 +492,6 @@ static int mlxfw_mfa2_file_cb_offset_xz(const struct 
> mlxfw_mfa2_file *mfa2_file,
>   dec_buf.out_pos = 0;
>   dec_buf.out_size = size;
>   err = mlxfw_mfa2_xz_dec_run(xz_dec, _buf, );
> - if (err)
> - goto out;
>  out:
>   xz_dec_end(xz_dec);
>   return err;


Thanks!

Acked-by: Yotam Gigi

[PATCH][net-next] net/mlxfw: remove redundant goto on error check

2017-06-06 Thread Colin King 
From: Colin Ian King 

The check to see of err is set and the subsequent goto is extraneous
as the next statement is where the goto is jumping to. Remove this
redundant check and goto.

Detected by CoverityScan, CID#1437734 ("Identical code for
different branches")

Signed-off-by: Colin Ian King 
---
 drivers/net/ethernet/mellanox/mlxfw/mlxfw_mfa2.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/net/ethernet/mellanox/mlxfw/mlxfw_mfa2.c 
b/drivers/net/ethernet/mellanox/mlxfw/mlxfw_mfa2.c
index 7e9589061d30..628150d28061 100644
--- a/drivers/net/ethernet/mellanox/mlxfw/mlxfw_mfa2.c
+++ b/drivers/net/ethernet/mellanox/mlxfw/mlxfw_mfa2.c
@@ -492,8 +492,6 @@ static int mlxfw_mfa2_file_cb_offset_xz(const struct 
mlxfw_mfa2_file *mfa2_file,
dec_buf.out_pos = 0;
dec_buf.out_size = size;
err = mlxfw_mfa2_xz_dec_run(xz_dec, _buf, );
-   if (err)
-   goto out;
 out:
xz_dec_end(xz_dec);
return err;
-- 
2.11.0

[PATCH][net-next] net/mlxfw: remove redundant goto on error check

2017-06-06 Thread Colin King 
From: Colin Ian King 

The check to see of err is set and the subsequent goto is extraneous
as the next statement is where the goto is jumping to. Remove this
redundant check and goto.

Detected by CoverityScan, CID#1437734 ("Identical code for
different branches")

Signed-off-by: Colin Ian King 
---
 drivers/net/ethernet/mellanox/mlxfw/mlxfw_mfa2.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/net/ethernet/mellanox/mlxfw/mlxfw_mfa2.c 
b/drivers/net/ethernet/mellanox/mlxfw/mlxfw_mfa2.c
index 7e9589061d30..628150d28061 100644
--- a/drivers/net/ethernet/mellanox/mlxfw/mlxfw_mfa2.c
+++ b/drivers/net/ethernet/mellanox/mlxfw/mlxfw_mfa2.c
@@ -492,8 +492,6 @@ static int mlxfw_mfa2_file_cb_offset_xz(const struct 
mlxfw_mfa2_file *mfa2_file,
dec_buf.out_pos = 0;
dec_buf.out_size = size;
err = mlxfw_mfa2_xz_dec_run(xz_dec, _buf, );
-   if (err)
-   goto out;
 out:
xz_dec_end(xz_dec);
return err;
-- 
2.11.0