Re: [PATCH] [media] include/media: fix missing | operator when setting cfg
On 04/18/2018 05:24 PM, Colin Ian King wrote: > Oops, shall I re-send? There is no need to, thanks.
Re: [PATCH] [media] include/media: fix missing | operator when setting cfg
On 04/18/2018 05:24 PM, Colin Ian King wrote: > Oops, shall I re-send? There is no need to, thanks.
Re: [PATCH] [media] include/media: fix missing | operator when setting cfg
On 18/04/18 16:23, Sylwester Nawrocki wrote: > On 04/18/2018 05:20 PM, Sylwester Nawrocki wrote: >> On 04/18/2018 05:06 PM, Colin King wrote: >>> From: Colin Ian King>>> >>> The value from a readl is being masked with ITE_REG_CIOCAN_MASK however >>> this is not being used and cfg is being re-assigned. I believe the >>> assignment operator should actually be instead the |= operator. >>> >>> Detected by CoverityScan, CID#1467987 ("Unused value") >>> >>> Signed-off-by: Colin Ian King >> Thanks for the patch. >> >> Acked-by: Sylwester Nawrocki > > I forgot to mention that the subject should rather looks something > like: > > "exynos4-is: fimc-lite: : fix missing | operator when setting cfg" > Oops, shall I re-send?
Re: [PATCH] [media] include/media: fix missing | operator when setting cfg
On 18/04/18 16:23, Sylwester Nawrocki wrote: > On 04/18/2018 05:20 PM, Sylwester Nawrocki wrote: >> On 04/18/2018 05:06 PM, Colin King wrote: >>> From: Colin Ian King >>> >>> The value from a readl is being masked with ITE_REG_CIOCAN_MASK however >>> this is not being used and cfg is being re-assigned. I believe the >>> assignment operator should actually be instead the |= operator. >>> >>> Detected by CoverityScan, CID#1467987 ("Unused value") >>> >>> Signed-off-by: Colin Ian King >> Thanks for the patch. >> >> Acked-by: Sylwester Nawrocki > > I forgot to mention that the subject should rather looks something > like: > > "exynos4-is: fimc-lite: : fix missing | operator when setting cfg" > Oops, shall I re-send?
Re: [PATCH] [media] include/media: fix missing | operator when setting cfg
On 04/18/2018 05:20 PM, Sylwester Nawrocki wrote: > On 04/18/2018 05:06 PM, Colin King wrote: >> From: Colin Ian King>> >> The value from a readl is being masked with ITE_REG_CIOCAN_MASK however >> this is not being used and cfg is being re-assigned. I believe the >> assignment operator should actually be instead the |= operator. >> >> Detected by CoverityScan, CID#1467987 ("Unused value") >> >> Signed-off-by: Colin Ian King > Thanks for the patch. > > Acked-by: Sylwester Nawrocki I forgot to mention that the subject should rather looks something like: "exynos4-is: fimc-lite: : fix missing | operator when setting cfg" -- Regards, Sylwester
Re: [PATCH] [media] include/media: fix missing | operator when setting cfg
On 04/18/2018 05:20 PM, Sylwester Nawrocki wrote: > On 04/18/2018 05:06 PM, Colin King wrote: >> From: Colin Ian King >> >> The value from a readl is being masked with ITE_REG_CIOCAN_MASK however >> this is not being used and cfg is being re-assigned. I believe the >> assignment operator should actually be instead the |= operator. >> >> Detected by CoverityScan, CID#1467987 ("Unused value") >> >> Signed-off-by: Colin Ian King > Thanks for the patch. > > Acked-by: Sylwester Nawrocki I forgot to mention that the subject should rather looks something like: "exynos4-is: fimc-lite: : fix missing | operator when setting cfg" -- Regards, Sylwester
Re: [PATCH] [media] include/media: fix missing | operator when setting cfg
On 04/18/2018 05:06 PM, Colin King wrote: > From: Colin Ian King> > The value from a readl is being masked with ITE_REG_CIOCAN_MASK however > this is not being used and cfg is being re-assigned. I believe the > assignment operator should actually be instead the |= operator. > > Detected by CoverityScan, CID#1467987 ("Unused value") > > Signed-off-by: Colin Ian King Thanks for the patch. Acked-by: Sylwester Nawrocki
Re: [PATCH] [media] include/media: fix missing | operator when setting cfg
On 04/18/2018 05:06 PM, Colin King wrote: > From: Colin Ian King > > The value from a readl is being masked with ITE_REG_CIOCAN_MASK however > this is not being used and cfg is being re-assigned. I believe the > assignment operator should actually be instead the |= operator. > > Detected by CoverityScan, CID#1467987 ("Unused value") > > Signed-off-by: Colin Ian King Thanks for the patch. Acked-by: Sylwester Nawrocki
[PATCH] [media] include/media: fix missing | operator when setting cfg
From: Colin Ian KingThe value from a readl is being masked with ITE_REG_CIOCAN_MASK however this is not being used and cfg is being re-assigned. I believe the assignment operator should actually be instead the |= operator. Detected by CoverityScan, CID#1467987 ("Unused value") Signed-off-by: Colin Ian King --- drivers/media/platform/exynos4-is/fimc-lite-reg.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/platform/exynos4-is/fimc-lite-reg.c b/drivers/media/platform/exynos4-is/fimc-lite-reg.c index f0acc550d065..16565a0b4bf1 100644 --- a/drivers/media/platform/exynos4-is/fimc-lite-reg.c +++ b/drivers/media/platform/exynos4-is/fimc-lite-reg.c @@ -254,7 +254,7 @@ void flite_hw_set_dma_window(struct fimc_lite *dev, struct flite_frame *f) /* Maximum output pixel size */ cfg = readl(dev->regs + FLITE_REG_CIOCAN); cfg &= ~FLITE_REG_CIOCAN_MASK; - cfg = (f->f_height << 16) | f->f_width; + cfg |= (f->f_height << 16) | f->f_width; writel(cfg, dev->regs + FLITE_REG_CIOCAN); /* DMA offsets */ -- 2.17.0
[PATCH] [media] include/media: fix missing | operator when setting cfg
From: Colin Ian King The value from a readl is being masked with ITE_REG_CIOCAN_MASK however this is not being used and cfg is being re-assigned. I believe the assignment operator should actually be instead the |= operator. Detected by CoverityScan, CID#1467987 ("Unused value") Signed-off-by: Colin Ian King --- drivers/media/platform/exynos4-is/fimc-lite-reg.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/platform/exynos4-is/fimc-lite-reg.c b/drivers/media/platform/exynos4-is/fimc-lite-reg.c index f0acc550d065..16565a0b4bf1 100644 --- a/drivers/media/platform/exynos4-is/fimc-lite-reg.c +++ b/drivers/media/platform/exynos4-is/fimc-lite-reg.c @@ -254,7 +254,7 @@ void flite_hw_set_dma_window(struct fimc_lite *dev, struct flite_frame *f) /* Maximum output pixel size */ cfg = readl(dev->regs + FLITE_REG_CIOCAN); cfg &= ~FLITE_REG_CIOCAN_MASK; - cfg = (f->f_height << 16) | f->f_width; + cfg |= (f->f_height << 16) | f->f_width; writel(cfg, dev->regs + FLITE_REG_CIOCAN); /* DMA offsets */ -- 2.17.0