Re: [PATCH] [perf]: update makefile message for installing required libs
Em Mon, Jun 27, 2016 at 06:59:57AM -0700, neerajbadl...@gmail.com escreveu: > From: Neeraj Badlani > > In case of missing library (libslang), give hint to install library > (libslang2-dev) > Since libslang-dev is not provided by Ubuntu's apt-package > > Signed-off-by: Neeraj Badlani > --- > tools/perf/config/Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/perf/config/Makefile b/tools/perf/config/Makefile > index 5ad0255..e57d4d7 100644 > --- a/tools/perf/config/Makefile > +++ b/tools/perf/config/Makefile > @@ -437,7 +437,7 @@ endif > > ifndef NO_SLANG >ifneq ($(feature-libslang), 1) > -msg := $(warning slang not found, disables TUI support. Please install > slang-devel or libslang-dev); > +msg := $(warning slang not found, disables TUI support. Please install > slang-devel or libslang-dev or libslang2-dev); Too many 'or', I'll apply it as: +msg := $(warning slang not found, disables TUI support. Please install slang-devel, libslang-dev or libslang2-dev); Thanks, - Arnaldo > NO_SLANG := 1 >else > # Fedora has /usr/include/slang/slang.h, but ubuntu /usr/include/slang.h > -- > 2.7.4
[PATCH] [perf]: update makefile message for installing required libs
From: Neeraj Badlani In case of missing library (libslang), give hint to install library (libslang2-dev) Since libslang-dev is not provided by Ubuntu's apt-package Signed-off-by: Neeraj Badlani --- tools/perf/config/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/perf/config/Makefile b/tools/perf/config/Makefile index 5ad0255..e57d4d7 100644 --- a/tools/perf/config/Makefile +++ b/tools/perf/config/Makefile @@ -437,7 +437,7 @@ endif ifndef NO_SLANG ifneq ($(feature-libslang), 1) -msg := $(warning slang not found, disables TUI support. Please install slang-devel or libslang-dev); +msg := $(warning slang not found, disables TUI support. Please install slang-devel or libslang-dev or libslang2-dev); NO_SLANG := 1 else # Fedora has /usr/include/slang/slang.h, but ubuntu /usr/include/slang.h -- 2.7.4
Re: [PATCH] [perf]: update makefile message for installing required libs
On Mon, Jun 27, 2016 at 12:10:52AM -0700, neerajbadl...@gmail.com wrote: > From: Neeraj Badlani > > In case of missing library (libslang), give hint to install library > (libslang2-dev) > Since libslang-dev is not provided by Ubuntu's apt-package > > Signed-off-by: Neeraj Badlani > --- > tools/perf/config/Makefile | 2 +- You're still very much not Cc'ing the right people here..
[PATCH] [perf]: update makefile message for installing required libs
From: Neeraj Badlani In case of missing library (libslang), give hint to install library (libslang2-dev) Since libslang-dev is not provided by Ubuntu's apt-package Signed-off-by: Neeraj Badlani --- tools/perf/config/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/perf/config/Makefile b/tools/perf/config/Makefile index 5ad0255..e57d4d7 100644 --- a/tools/perf/config/Makefile +++ b/tools/perf/config/Makefile @@ -437,7 +437,7 @@ endif ifndef NO_SLANG ifneq ($(feature-libslang), 1) -msg := $(warning slang not found, disables TUI support. Please install slang-devel or libslang-dev); +msg := $(warning slang not found, disables TUI support. Please install slang-devel or libslang-dev or libslang2-dev); NO_SLANG := 1 else # Fedora has /usr/include/slang/slang.h, but ubuntu /usr/include/slang.h -- 2.7.4
Re: [PATCH] [perf]: update makefile message for installing required libs
On Sun, Jun 26, 2016 at 09:49:56PM -0700, neerajbadl...@gmail.com wrote: > From: Neeraj Badlani > > In case of missing library (libslang), give hint to install library > (libslang2-dev) > Since libslang-dev is not provided by Ubuntu's apt-package No Signed-off-by:, so I (or in reality acme) cannot actually do anything with this patch. Please see Documentation/SubmittingPatches. > --- > tools/perf/config/Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/perf/config/Makefile b/tools/perf/config/Makefile > index 5ad0255..e57d4d7 100644 > --- a/tools/perf/config/Makefile > +++ b/tools/perf/config/Makefile > @@ -437,7 +437,7 @@ endif > > ifndef NO_SLANG >ifneq ($(feature-libslang), 1) > -msg := $(warning slang not found, disables TUI support. Please install > slang-devel or libslang-dev); > +msg := $(warning slang not found, disables TUI support. Please install > slang-devel or libslang-dev or libslang2-dev); > NO_SLANG := 1 >else > # Fedora has /usr/include/slang/slang.h, but ubuntu /usr/include/slang.h > -- > 2.7.4 >
[PATCH] [perf]: update makefile message for installing required libs
From: Neeraj Badlani In case of missing library (libslang), give hint to install library (libslang2-dev) Since libslang-dev is not provided by Ubuntu's apt-package --- tools/perf/config/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/perf/config/Makefile b/tools/perf/config/Makefile index 5ad0255..e57d4d7 100644 --- a/tools/perf/config/Makefile +++ b/tools/perf/config/Makefile @@ -437,7 +437,7 @@ endif ifndef NO_SLANG ifneq ($(feature-libslang), 1) -msg := $(warning slang not found, disables TUI support. Please install slang-devel or libslang-dev); +msg := $(warning slang not found, disables TUI support. Please install slang-devel or libslang-dev or libslang2-dev); NO_SLANG := 1 else # Fedora has /usr/include/slang/slang.h, but ubuntu /usr/include/slang.h -- 2.7.4
