Re: [PATCH] [stable, netdev 4.4+] lan78xx: make sure RX_ADDRL & RX_ADDRH regs are always up to date
On Thu, Nov 08, 2018 at 10:49:04AM -0500, Sasha Levin wrote: > On Thu, Nov 08, 2018 at 12:01:27PM +0100, Paolo Pisati wrote: > > On Wed, Nov 07, 2018 at 07:17:51PM -0500, Sasha Levin wrote: > > > So why not just take 760db29bdc completely? It looks safer than taking a > > > partial backport, and will make applying future patches easier. > > > > > > I tried to do it and it doesn't look like there are any dependencies > > > that would cause an issue. > > > > Somehow i was convinced it didn't build on 4.4.x... can you pick it up? > > > > commit 760db29bdc97b73ff60b091315ad787b1deb5cf5 > > Author: Phil Elwell > > Date: Thu Apr 19 17:59:38 2018 +0100 > > > >lan78xx: Read MAC address from DT if present > > > >There is a standard mechanism for locating and using a MAC address from > >the Device Tree. Use this facility in the lan78xx driver to support > >applications without programmed EEPROM or OTP. At the same time, > >regularise the handling of the different address sources. > > > >Signed-off-by: Phil Elwell > >Signed-off-by: David S. Miller > > Can you confirm it actually works on 4.4? It does not build on 4.4, so I'm dropping it :( greg k-h
Re: [PATCH] [stable, netdev 4.4+] lan78xx: make sure RX_ADDRL & RX_ADDRH regs are always up to date
On Thu, Nov 08, 2018 at 10:49:04AM -0500, Sasha Levin wrote: > On Thu, Nov 08, 2018 at 12:01:27PM +0100, Paolo Pisati wrote: > > On Wed, Nov 07, 2018 at 07:17:51PM -0500, Sasha Levin wrote: > > > So why not just take 760db29bdc completely? It looks safer than taking a > > > partial backport, and will make applying future patches easier. > > > > > > I tried to do it and it doesn't look like there are any dependencies > > > that would cause an issue. > > > > Somehow i was convinced it didn't build on 4.4.x... can you pick it up? > > > > commit 760db29bdc97b73ff60b091315ad787b1deb5cf5 > > Author: Phil Elwell > > Date: Thu Apr 19 17:59:38 2018 +0100 > > > >lan78xx: Read MAC address from DT if present > > > >There is a standard mechanism for locating and using a MAC address from > >the Device Tree. Use this facility in the lan78xx driver to support > >applications without programmed EEPROM or OTP. At the same time, > >regularise the handling of the different address sources. > > > >Signed-off-by: Phil Elwell > >Signed-off-by: David S. Miller > > Can you confirm it actually works on 4.4? It does not build on 4.4, so I'm dropping it :( greg k-h
Re: [PATCH] [stable, netdev 4.4+] lan78xx: make sure RX_ADDRL & RX_ADDRH regs are always up to date
On Thu, Nov 08, 2018 at 10:49:04AM -0500, Sasha Levin wrote: > > Can you confirm it actually works on 4.4? Yes, built and tested on 4.4.y: Tested-by: Paolo Pisati -- bye, p.
Re: [PATCH] [stable, netdev 4.4+] lan78xx: make sure RX_ADDRL & RX_ADDRH regs are always up to date
On Thu, Nov 08, 2018 at 10:49:04AM -0500, Sasha Levin wrote: > > Can you confirm it actually works on 4.4? Yes, built and tested on 4.4.y: Tested-by: Paolo Pisati -- bye, p.
Re: [PATCH] [stable, netdev 4.4+] lan78xx: make sure RX_ADDRL & RX_ADDRH regs are always up to date
On Thu, Nov 08, 2018 at 12:01:27PM +0100, Paolo Pisati wrote: On Wed, Nov 07, 2018 at 07:17:51PM -0500, Sasha Levin wrote: So why not just take 760db29bdc completely? It looks safer than taking a partial backport, and will make applying future patches easier. I tried to do it and it doesn't look like there are any dependencies that would cause an issue. Somehow i was convinced it didn't build on 4.4.x... can you pick it up? commit 760db29bdc97b73ff60b091315ad787b1deb5cf5 Author: Phil Elwell Date: Thu Apr 19 17:59:38 2018 +0100 lan78xx: Read MAC address from DT if present There is a standard mechanism for locating and using a MAC address from the Device Tree. Use this facility in the lan78xx driver to support applications without programmed EEPROM or OTP. At the same time, regularise the handling of the different address sources. Signed-off-by: Phil Elwell Signed-off-by: David S. Miller Can you confirm it actually works on 4.4? -- Thanks, Sasha
Re: [PATCH] [stable, netdev 4.4+] lan78xx: make sure RX_ADDRL & RX_ADDRH regs are always up to date
On Thu, Nov 08, 2018 at 12:01:27PM +0100, Paolo Pisati wrote: On Wed, Nov 07, 2018 at 07:17:51PM -0500, Sasha Levin wrote: So why not just take 760db29bdc completely? It looks safer than taking a partial backport, and will make applying future patches easier. I tried to do it and it doesn't look like there are any dependencies that would cause an issue. Somehow i was convinced it didn't build on 4.4.x... can you pick it up? commit 760db29bdc97b73ff60b091315ad787b1deb5cf5 Author: Phil Elwell Date: Thu Apr 19 17:59:38 2018 +0100 lan78xx: Read MAC address from DT if present There is a standard mechanism for locating and using a MAC address from the Device Tree. Use this facility in the lan78xx driver to support applications without programmed EEPROM or OTP. At the same time, regularise the handling of the different address sources. Signed-off-by: Phil Elwell Signed-off-by: David S. Miller Can you confirm it actually works on 4.4? -- Thanks, Sasha
