Re: [PATCH] 2.2.18pre13: USB tweak for VAIO
On Mon, Oct 02, 2000, Chip Salzenberg <[EMAIL PROTECTED]> wrote:
> Patch: usbdock-1
> From: Geoff Harrison <[EMAIL PROTECTED]>
>
> Allow short report frames via USB ... apparently they are normal for
> some Sony VAIOs when docked.
This is actually a hack to get a specific PS/2 to USB device to work.
The reports that get sent back are short by one byte which doesn't seem
to cause problems, but apparentely are illegal per the spec.
The cause and real fix are still under investigation.
> Index: linux/drivers/usb/hid.c
> diff -u linux/drivers/usb/hid.c:1.2 linux/drivers/usb/hid.c:1.2.2.1
> --- linux/drivers/usb/hid.c:1.2 Wed Sep 27 23:44:24 2000
> +++ linux/drivers/usb/hid.c Thu Sep 28 11:51:32 2000
> @@ -1096,10 +1096,12 @@
> return;
> }
>
> +#if 0
> if (len < ((report->size - 1) >> 3) + 1) {
> dbg("report %d is too short, (%d < %d)", report->id, len,
>((report->size - 1) >> 3) + 1);
> return;
> }
> +#endif
>
> for (n = 0; n < report->maxfield; n++)
> hid_input_field(device, report->field[n], data);
JE
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
Please read the FAQ at http://www.tux.org/lkml/
RE: [PATCH] 2.2.18pre13: USB tweak for VAIO
How about not running your kernel at KERN_DEBUG level <7> ?
That would also eliminate this message.
~Randy
> -Original Message-
> From: Chip Salzenberg [mailto:[EMAIL PROTECTED]]
> Sent: Monday, October 02, 2000 2:12 PM
> To: Alan Cox
> Cc: Linux Kernel
> Subject: [PATCH] 2.2.18pre13: USB tweak for VAIO
>
>
> Patch: usbdock-1
> From: Geoff Harrison <[EMAIL PROTECTED]>
>
> Allow short report frames via USB ... apparently they are normal for
> some Sony VAIOs when docked.
>
> Index: linux/drivers/usb/hid.c
> diff -u linux/drivers/usb/hid.c:1.2 linux/drivers/usb/hid.c:1.2.2.1
> --- linux/drivers/usb/hid.c:1.2 Wed Sep 27 23:44:24 2000
> +++ linux/drivers/usb/hid.c Thu Sep 28 11:51:32 2000
> @@ -1096,10 +1096,12 @@
> return;
> }
>
> +#if 0
> if (len < ((report->size - 1) >> 3) + 1) {
> dbg("report %d is too short, (%d < %d)",
> report->id, len, ((report->size - 1) >> 3) + 1);
> return;
> }
> +#endif
>
> for (n = 0; n < report->maxfield; n++)
> hid_input_field(device, report->field[n], data);
>
> --
> Chip Salzenberg - a.k.a. -
> <[EMAIL PROTECTED]>
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
Please read the FAQ at http://www.tux.org/lkml/
[PATCH] 2.2.18pre13: USB tweak for VAIO
Patch: usbdock-1
From: Geoff Harrison <[EMAIL PROTECTED]>
Allow short report frames via USB ... apparently they are normal for
some Sony VAIOs when docked.
Index: linux/drivers/usb/hid.c
diff -u linux/drivers/usb/hid.c:1.2 linux/drivers/usb/hid.c:1.2.2.1
--- linux/drivers/usb/hid.c:1.2 Wed Sep 27 23:44:24 2000
+++ linux/drivers/usb/hid.c Thu Sep 28 11:51:32 2000
@@ -1096,10 +1096,12 @@
return;
}
+#if 0
if (len < ((report->size - 1) >> 3) + 1) {
dbg("report %d is too short, (%d < %d)", report->id, len,
((report->size - 1) >> 3) + 1);
return;
}
+#endif
for (n = 0; n < report->maxfield; n++)
hid_input_field(device, report->field[n], data);
--
Chip Salzenberg - a.k.a. - <[EMAIL PROTECTED]>
"I wanted to play hopscotch with the impenetrable mystery of existence,
but he stepped in a wormhole and had to go in early." // MST3K
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
Please read the FAQ at http://www.tux.org/lkml/
[PATCH] 2.2.18pre13: USB tweak for VAIO
Patch: usbdock-1
From: Geoff Harrison [EMAIL PROTECTED]
Allow short report frames via USB ... apparently they are normal for
some Sony VAIOs when docked.
Index: linux/drivers/usb/hid.c
diff -u linux/drivers/usb/hid.c:1.2 linux/drivers/usb/hid.c:1.2.2.1
--- linux/drivers/usb/hid.c:1.2 Wed Sep 27 23:44:24 2000
+++ linux/drivers/usb/hid.c Thu Sep 28 11:51:32 2000
@@ -1096,10 +1096,12 @@
return;
}
+#if 0
if (len ((report-size - 1) 3) + 1) {
dbg("report %d is too short, (%d %d)", report-id, len,
((report-size - 1) 3) + 1);
return;
}
+#endif
for (n = 0; n report-maxfield; n++)
hid_input_field(device, report-field[n], data);
--
Chip Salzenberg - a.k.a. - [EMAIL PROTECTED]
"I wanted to play hopscotch with the impenetrable mystery of existence,
but he stepped in a wormhole and had to go in early." // MST3K
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
Please read the FAQ at http://www.tux.org/lkml/
RE: [PATCH] 2.2.18pre13: USB tweak for VAIO
How about not running your kernel at KERN_DEBUG level 7 ?
That would also eliminate this message.
~Randy
-Original Message-
From: Chip Salzenberg [mailto:[EMAIL PROTECTED]]
Sent: Monday, October 02, 2000 2:12 PM
To: Alan Cox
Cc: Linux Kernel
Subject: [PATCH] 2.2.18pre13: USB tweak for VAIO
Patch: usbdock-1
From: Geoff Harrison [EMAIL PROTECTED]
Allow short report frames via USB ... apparently they are normal for
some Sony VAIOs when docked.
Index: linux/drivers/usb/hid.c
diff -u linux/drivers/usb/hid.c:1.2 linux/drivers/usb/hid.c:1.2.2.1
--- linux/drivers/usb/hid.c:1.2 Wed Sep 27 23:44:24 2000
+++ linux/drivers/usb/hid.c Thu Sep 28 11:51:32 2000
@@ -1096,10 +1096,12 @@
return;
}
+#if 0
if (len ((report-size - 1) 3) + 1) {
dbg("report %d is too short, (%d %d)",
report-id, len, ((report-size - 1) 3) + 1);
return;
}
+#endif
for (n = 0; n report-maxfield; n++)
hid_input_field(device, report-field[n], data);
--
Chip Salzenberg - a.k.a. -
[EMAIL PROTECTED]
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] 2.2.18pre13: USB tweak for VAIO
On Mon, Oct 02, 2000, Chip Salzenberg [EMAIL PROTECTED] wrote:
Patch: usbdock-1
From: Geoff Harrison [EMAIL PROTECTED]
Allow short report frames via USB ... apparently they are normal for
some Sony VAIOs when docked.
This is actually a hack to get a specific PS/2 to USB device to work.
The reports that get sent back are short by one byte which doesn't seem
to cause problems, but apparentely are illegal per the spec.
The cause and real fix are still under investigation.
Index: linux/drivers/usb/hid.c
diff -u linux/drivers/usb/hid.c:1.2 linux/drivers/usb/hid.c:1.2.2.1
--- linux/drivers/usb/hid.c:1.2 Wed Sep 27 23:44:24 2000
+++ linux/drivers/usb/hid.c Thu Sep 28 11:51:32 2000
@@ -1096,10 +1096,12 @@
return;
}
+#if 0
if (len ((report-size - 1) 3) + 1) {
dbg("report %d is too short, (%d %d)", report-id, len,
((report-size - 1) 3) + 1);
return;
}
+#endif
for (n = 0; n report-maxfield; n++)
hid_input_field(device, report-field[n], data);
JE
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
Please read the FAQ at http://www.tux.org/lkml/
