Re: [PATCH] ARM: dts: exynos4412-trats2: remove regulator-compatible usage

[Javier Martinez Canillas]

Hello Anand,

On 09/28/2015 12:10 PM, Anand Moon wrote:
> Hi Javier,
> 

[snip]

>>
>> -   ldo10_reg: ldo10 {
>> -   regulator-compatible = "LDO10";
> Missing the node name 'LDO10'
>> +   ldo10_reg: DO10 {

Thanks for pointing out, I had to look twice to understand what you were
saying. Isn't that the LDO10 is missing but that was mistyped as "DO10".

I posted a v2 fixing it.

Best regards,
-- 
Javier Martinez Canillas
Open Source Group
Samsung Research America
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH] ARM: dts: exynos4412-trats2: remove regulator-compatible usage

[Anand Moon]

Hi Javier,

On 25 September 2015 at 19:14, Javier Martinez Canillas
 wrote:
> The regulator-compatible property from the regulator DT binding was
> deprecated and the correct approach is to use the node's name.
>
> This patch has no functional changes but by not using a deprecated
> property, new DTS based on this one will not carry the same issue.
>
> Signed-off-by: Javier Martinez Canillas 
>
> ---
>
>  arch/arm/boot/dts/exynos4412-trats2.dts | 105 
> +++-
>  1 file changed, 35 insertions(+), 70 deletions(-)
>
> diff --git a/arch/arm/boot/dts/exynos4412-trats2.dts 
> b/arch/arm/boot/dts/exynos4412-trats2.dts
> index 2a1ebb76ebe0..9ee55119e7d2 100644
> --- a/arch/arm/boot/dts/exynos4412-trats2.dts
> +++ b/arch/arm/boot/dts/exynos4412-trats2.dts
> @@ -564,16 +564,14 @@
> #clock-cells = <1>;
>
> voltage-regulators {
> -   ldo1_reg: ldo1 {
> -   regulator-compatible = "LDO1";
> +   ldo1_reg: LDO1 {
> regulator-name = "VALIVE_1.0V_AP";
> regulator-min-microvolt = <100>;
> regulator-max-microvolt = <100>;
> regulator-always-on;
> };
>
> -   ldo2_reg: ldo2 {
> -   regulator-compatible = "LDO2";
> +   ldo2_reg: LDO2 {
> regulator-name = "VM1M2_1.2V_AP";
> regulator-min-microvolt = <120>;
> regulator-max-microvolt = <120>;
> @@ -583,32 +581,28 @@
> };
> };
>
> -   ldo3_reg: ldo3 {
> -   regulator-compatible = "LDO3";
> +   ldo3_reg: LDO3 {
> regulator-name = "VCC_1.8V_AP";
> regulator-min-microvolt = <180>;
> regulator-max-microvolt = <180>;
> regulator-always-on;
> };
>
> -   ldo4_reg: ldo4 {
> -   regulator-compatible = "LDO4";
> +   ldo4_reg: LDO4 {
> regulator-name = "VCC_2.8V_AP";
> regulator-min-microvolt = <280>;
> regulator-max-microvolt = <280>;
> regulator-always-on;
> };
>
> -   ldo5_reg: ldo5 {
> -   regulator-compatible = "LDO5";
> +   ldo5_reg: LDO5 {
> regulator-name = "VCC_1.8V_IO";
> regulator-min-microvolt = <180>;
> regulator-max-microvolt = <180>;
> regulator-always-on;
> };
>
> -   ldo6_reg: ldo6 {
> -   regulator-compatible = "LDO6";
> +   ldo6_reg: LDO6 {
> regulator-name = "VMPLL_1.0V_AP";
> regulator-min-microvolt = <100>;
> regulator-max-microvolt = <100>;
> @@ -618,8 +612,7 @@
> };
> };
>
> -   ldo7_reg: ldo7 {
> -   regulator-compatible = "LDO7";
> +   ldo7_reg: LDO7 {
> regulator-name = "VPLL_1.0V_AP";
> regulator-min-microvolt = <100>;
> regulator-max-microvolt = <100>;
> @@ -629,8 +622,7 @@
> };
> };
>
> -   ldo8_reg: ldo8 {
> -   regulator-compatible = "LDO8";
> +   ldo8_reg: LDO8 {
> regulator-name = "VMIPI_1.0V";
> regulator-min-microvolt = <100>;
> regulator-max-microvolt = <100>;
> @@ -639,15 +631,13 @@
> };
> };
>
> -   ldo9_reg: ldo9 {
> -   regulator-compatible = "LDO9";
> +   ldo9_reg: LDO9 {
> regulator-name = "CAM_ISP_MIPI_1.2V";
> regulator-min-microvolt = <120>;
> regulator-max-microvolt = <120>;
> };
>
> -   ldo10_reg: ldo10 {
> -   regulator-compatible = "LDO10";
Missing the node 

Re: [PATCH] ARM: dts: exynos4412-trats2: remove regulator-compatible usage

[Javier Martinez Canillas]

Hello Anand,

On 09/28/2015 12:10 PM, Anand Moon wrote:
> Hi Javier,
> 

[snip]

>>
>> -   ldo10_reg: ldo10 {
>> -   regulator-compatible = "LDO10";
> Missing the node name 'LDO10'
>> +   ldo10_reg: DO10 {

Thanks for pointing out, I had to look twice to understand what you were
saying. Isn't that the LDO10 is missing but that was mistyped as "DO10".

I posted a v2 fixing it.

Best regards,
-- 
Javier Martinez Canillas
Open Source Group
Samsung Research America
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH] ARM: dts: exynos4412-trats2: remove regulator-compatible usage

[Anand Moon]

Hi Javier,

On 25 September 2015 at 19:14, Javier Martinez Canillas
 wrote:
> The regulator-compatible property from the regulator DT binding was
> deprecated and the correct approach is to use the node's name.
>
> This patch has no functional changes but by not using a deprecated
> property, new DTS based on this one will not carry the same issue.
>
> Signed-off-by: Javier Martinez Canillas 
>
> ---
>
>  arch/arm/boot/dts/exynos4412-trats2.dts | 105 
> +++-
>  1 file changed, 35 insertions(+), 70 deletions(-)
>
> diff --git a/arch/arm/boot/dts/exynos4412-trats2.dts 
> b/arch/arm/boot/dts/exynos4412-trats2.dts
> index 2a1ebb76ebe0..9ee55119e7d2 100644
> --- a/arch/arm/boot/dts/exynos4412-trats2.dts
> +++ b/arch/arm/boot/dts/exynos4412-trats2.dts
> @@ -564,16 +564,14 @@
> #clock-cells = <1>;
>
> voltage-regulators {
> -   ldo1_reg: ldo1 {
> -   regulator-compatible = "LDO1";
> +   ldo1_reg: LDO1 {
> regulator-name = "VALIVE_1.0V_AP";
> regulator-min-microvolt = <100>;
> regulator-max-microvolt = <100>;
> regulator-always-on;
> };
>
> -   ldo2_reg: ldo2 {
> -   regulator-compatible = "LDO2";
> +   ldo2_reg: LDO2 {
> regulator-name = "VM1M2_1.2V_AP";
> regulator-min-microvolt = <120>;
> regulator-max-microvolt = <120>;
> @@ -583,32 +581,28 @@
> };
> };
>
> -   ldo3_reg: ldo3 {
> -   regulator-compatible = "LDO3";
> +   ldo3_reg: LDO3 {
> regulator-name = "VCC_1.8V_AP";
> regulator-min-microvolt = <180>;
> regulator-max-microvolt = <180>;
> regulator-always-on;
> };
>
> -   ldo4_reg: ldo4 {
> -   regulator-compatible = "LDO4";
> +   ldo4_reg: LDO4 {
> regulator-name = "VCC_2.8V_AP";
> regulator-min-microvolt = <280>;
> regulator-max-microvolt = <280>;
> regulator-always-on;
> };
>
> -   ldo5_reg: ldo5 {
> -   regulator-compatible = "LDO5";
> +   ldo5_reg: LDO5 {
> regulator-name = "VCC_1.8V_IO";
> regulator-min-microvolt = <180>;
> regulator-max-microvolt = <180>;
> regulator-always-on;
> };
>
> -   ldo6_reg: ldo6 {
> -   regulator-compatible = "LDO6";
> +   ldo6_reg: LDO6 {
> regulator-name = "VMPLL_1.0V_AP";
> regulator-min-microvolt = <100>;
> regulator-max-microvolt = <100>;
> @@ -618,8 +612,7 @@
> };
> };
>
> -   ldo7_reg: ldo7 {
> -   regulator-compatible = "LDO7";
> +   ldo7_reg: LDO7 {
> regulator-name = "VPLL_1.0V_AP";
> regulator-min-microvolt = <100>;
> regulator-max-microvolt = <100>;
> @@ -629,8 +622,7 @@
> };
> };
>
> -   ldo8_reg: ldo8 {
> -   regulator-compatible = "LDO8";
> +   ldo8_reg: LDO8 {
> regulator-name = "VMIPI_1.0V";
> regulator-min-microvolt = <100>;
> regulator-max-microvolt = <100>;
> @@ -639,15 +631,13 @@
> };
> };
>
> -   ldo9_reg: ldo9 {
> -   regulator-compatible = "LDO9";
> +   ldo9_reg: LDO9 {
> regulator-name = "CAM_ISP_MIPI_1.2V";
> regulator-min-microvolt = <120>;
> regulator-max-microvolt = <120>;
> };
>
> -   ldo10_reg: ldo10 {
> -   

[PATCH] ARM: dts: exynos4412-trats2: remove regulator-compatible usage

[Javier Martinez Canillas]

The regulator-compatible property from the regulator DT binding was
deprecated and the correct approach is to use the node's name.

This patch has no functional changes but by not using a deprecated
property, new DTS based on this one will not carry the same issue.

Signed-off-by: Javier Martinez Canillas 

---

 arch/arm/boot/dts/exynos4412-trats2.dts | 105 +++-
 1 file changed, 35 insertions(+), 70 deletions(-)

diff --git a/arch/arm/boot/dts/exynos4412-trats2.dts 
b/arch/arm/boot/dts/exynos4412-trats2.dts
index 2a1ebb76ebe0..9ee55119e7d2 100644
--- a/arch/arm/boot/dts/exynos4412-trats2.dts
+++ b/arch/arm/boot/dts/exynos4412-trats2.dts
@@ -564,16 +564,14 @@
#clock-cells = <1>;
 
voltage-regulators {
-   ldo1_reg: ldo1 {
-   regulator-compatible = "LDO1";
+   ldo1_reg: LDO1 {
regulator-name = "VALIVE_1.0V_AP";
regulator-min-microvolt = <100>;
regulator-max-microvolt = <100>;
regulator-always-on;
};
 
-   ldo2_reg: ldo2 {
-   regulator-compatible = "LDO2";
+   ldo2_reg: LDO2 {
regulator-name = "VM1M2_1.2V_AP";
regulator-min-microvolt = <120>;
regulator-max-microvolt = <120>;
@@ -583,32 +581,28 @@
};
};
 
-   ldo3_reg: ldo3 {
-   regulator-compatible = "LDO3";
+   ldo3_reg: LDO3 {
regulator-name = "VCC_1.8V_AP";
regulator-min-microvolt = <180>;
regulator-max-microvolt = <180>;
regulator-always-on;
};
 
-   ldo4_reg: ldo4 {
-   regulator-compatible = "LDO4";
+   ldo4_reg: LDO4 {
regulator-name = "VCC_2.8V_AP";
regulator-min-microvolt = <280>;
regulator-max-microvolt = <280>;
regulator-always-on;
};
 
-   ldo5_reg: ldo5 {
-   regulator-compatible = "LDO5";
+   ldo5_reg: LDO5 {
regulator-name = "VCC_1.8V_IO";
regulator-min-microvolt = <180>;
regulator-max-microvolt = <180>;
regulator-always-on;
};
 
-   ldo6_reg: ldo6 {
-   regulator-compatible = "LDO6";
+   ldo6_reg: LDO6 {
regulator-name = "VMPLL_1.0V_AP";
regulator-min-microvolt = <100>;
regulator-max-microvolt = <100>;
@@ -618,8 +612,7 @@
};
};
 
-   ldo7_reg: ldo7 {
-   regulator-compatible = "LDO7";
+   ldo7_reg: LDO7 {
regulator-name = "VPLL_1.0V_AP";
regulator-min-microvolt = <100>;
regulator-max-microvolt = <100>;
@@ -629,8 +622,7 @@
};
};
 
-   ldo8_reg: ldo8 {
-   regulator-compatible = "LDO8";
+   ldo8_reg: LDO8 {
regulator-name = "VMIPI_1.0V";
regulator-min-microvolt = <100>;
regulator-max-microvolt = <100>;
@@ -639,15 +631,13 @@
};
};
 
-   ldo9_reg: ldo9 {
-   regulator-compatible = "LDO9";
+   ldo9_reg: LDO9 {
regulator-name = "CAM_ISP_MIPI_1.2V";
regulator-min-microvolt = <120>;
regulator-max-microvolt = <120>;
};
 
-   ldo10_reg: ldo10 {
-   regulator-compatible = "LDO10";
+   ldo10_reg: DO10 {
regulator-name = "VMIPI_1.8V";
regulator-min-microvolt = <180>;
regulator-max-microvolt = <180>;
@@ -656,8 +646,7 @@
 

[PATCH] ARM: dts: exynos4412-trats2: remove regulator-compatible usage

[Javier Martinez Canillas]

The regulator-compatible property from the regulator DT binding was
deprecated and the correct approach is to use the node's name.

This patch has no functional changes but by not using a deprecated
property, new DTS based on this one will not carry the same issue.

Signed-off-by: Javier Martinez Canillas 

---

 arch/arm/boot/dts/exynos4412-trats2.dts | 105 +++-
 1 file changed, 35 insertions(+), 70 deletions(-)

diff --git a/arch/arm/boot/dts/exynos4412-trats2.dts 
b/arch/arm/boot/dts/exynos4412-trats2.dts
index 2a1ebb76ebe0..9ee55119e7d2 100644
--- a/arch/arm/boot/dts/exynos4412-trats2.dts
+++ b/arch/arm/boot/dts/exynos4412-trats2.dts
@@ -564,16 +564,14 @@
#clock-cells = <1>;
 
voltage-regulators {
-   ldo1_reg: ldo1 {
-   regulator-compatible = "LDO1";
+   ldo1_reg: LDO1 {
regulator-name = "VALIVE_1.0V_AP";
regulator-min-microvolt = <100>;
regulator-max-microvolt = <100>;
regulator-always-on;
};
 
-   ldo2_reg: ldo2 {
-   regulator-compatible = "LDO2";
+   ldo2_reg: LDO2 {
regulator-name = "VM1M2_1.2V_AP";
regulator-min-microvolt = <120>;
regulator-max-microvolt = <120>;
@@ -583,32 +581,28 @@
};
};
 
-   ldo3_reg: ldo3 {
-   regulator-compatible = "LDO3";
+   ldo3_reg: LDO3 {
regulator-name = "VCC_1.8V_AP";
regulator-min-microvolt = <180>;
regulator-max-microvolt = <180>;
regulator-always-on;
};
 
-   ldo4_reg: ldo4 {
-   regulator-compatible = "LDO4";
+   ldo4_reg: LDO4 {
regulator-name = "VCC_2.8V_AP";
regulator-min-microvolt = <280>;
regulator-max-microvolt = <280>;
regulator-always-on;
};
 
-   ldo5_reg: ldo5 {
-   regulator-compatible = "LDO5";
+   ldo5_reg: LDO5 {
regulator-name = "VCC_1.8V_IO";
regulator-min-microvolt = <180>;
regulator-max-microvolt = <180>;
regulator-always-on;
};
 
-   ldo6_reg: ldo6 {
-   regulator-compatible = "LDO6";
+   ldo6_reg: LDO6 {
regulator-name = "VMPLL_1.0V_AP";
regulator-min-microvolt = <100>;
regulator-max-microvolt = <100>;
@@ -618,8 +612,7 @@
};
};
 
-   ldo7_reg: ldo7 {
-   regulator-compatible = "LDO7";
+   ldo7_reg: LDO7 {
regulator-name = "VPLL_1.0V_AP";
regulator-min-microvolt = <100>;
regulator-max-microvolt = <100>;
@@ -629,8 +622,7 @@
};
};
 
-   ldo8_reg: ldo8 {
-   regulator-compatible = "LDO8";
+   ldo8_reg: LDO8 {
regulator-name = "VMIPI_1.0V";
regulator-min-microvolt = <100>;
regulator-max-microvolt = <100>;
@@ -639,15 +631,13 @@
};
};
 
-   ldo9_reg: ldo9 {
-   regulator-compatible = "LDO9";
+   ldo9_reg: LDO9 {
regulator-name = "CAM_ISP_MIPI_1.2V";
regulator-min-microvolt = <120>;
regulator-max-microvolt = <120>;
};
 
-   ldo10_reg: ldo10 {
-   regulator-compatible = "LDO10";
+   ldo10_reg: DO10 {
regulator-name = "VMIPI_1.8V";
regulator-min-microvolt = <180>;
regulator-max-microvolt = <180>;
@@ -656,8 +646,7 @@