Re: [PATCH] ARM: dts: qcom: sdx55: add IPA information

2021-04-09 Thread kernel test robot
Hi Alex,

I love your patch! Yet something to improve:

[auto build test ERROR on robh/for-next]
[also build test ERROR on v5.12-rc6 next-20210409]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:
https://github.com/0day-ci/linux/commits/Alex-Elder/ARM-dts-qcom-sdx55-add-IPA-information/20210409-235428
base:   https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next
config: arm-defconfig (attached as .config)
compiler: arm-linux-gnueabi-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget 
https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O 
~/bin/make.cross
chmod +x ~/bin/make.cross
# 
https://github.com/0day-ci/linux/commit/4959ac1221ccc663aa1034ec56186ec36ce45b45
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review 
Alex-Elder/ARM-dts-qcom-sdx55-add-IPA-information/20210409-235428
git checkout 4959ac1221ccc663aa1034ec56186ec36ce45b45
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=arm 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot 

All errors (new ones prefixed by >>):

>> Error: arch/arm/boot/dts/qcom-sdx55.dtsi:242.33-34 syntax error
   FATAL ERROR: Unable to parse input tree

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org


.config.gz
Description: application/gzip


[PATCH] ARM: dts: qcom: sdx55: add IPA information

2021-04-09 Thread Alex Elder
Add IPA-related nodes and definitions to "sdx55.dtsi".  The SMP2P
nodes (ipa_smp2p_out and ipa_smp2p_in) are already present.

Signed-off-by: Alex Elder 
---
Note: This depends on this series posted by Mani Sadhasivam:
  
https://lore.kernel.org/linux-arm-msm/20210408170457.91409-1-manivannan.sadhasi...@linaro.org

 arch/arm/boot/dts/qcom-sdx55.dtsi | 41 +++
 1 file changed, 41 insertions(+)

diff --git a/arch/arm/boot/dts/qcom-sdx55.dtsi 
b/arch/arm/boot/dts/qcom-sdx55.dtsi
index e4180bbc46555..0dc515dc5750d 100644
--- a/arch/arm/boot/dts/qcom-sdx55.dtsi
+++ b/arch/arm/boot/dts/qcom-sdx55.dtsi
@@ -215,6 +215,47 @@ qpic_nand: nand@1b3 {
status = "disabled";
};
 
+   ipa: ipa@1e4 {
+   compatible = "qcom,sdx55-ipa";
+
+   iommus = <&apps_smmu 0x5e0 0x0>,
+<&apps_smmu 0x5e2 0x0>;
+   reg = <0x1e4 0x7000>,
+ <0x1e5 0x4b20>,
+ <0x1e04000 0x2c000>;
+   reg-names = "ipa-reg",
+   "ipa-shared",
+   "gsi";
+
+   interrupts-extended = <&intc GIC_SPI 241 
IRQ_TYPE_EDGE_RISING>,
+ <&intc GIC_SPI 47 
IRQ_TYPE_LEVEL_HIGH>,
+ <&ipa_smp2p_in 0 
IRQ_TYPE_EDGE_RISING>,
+ <&ipa_smp2p_in 1 
IRQ_TYPE_EDGE_RISING>;
+   interrupt-names = "ipa",
+ "gsi",
+ "ipa-clock-query",
+ "ipa-setup-ready";
+
+   clocks = <&rpmhcc RPMH_IPA_CLK>;
+   clock-names = "core";
+
+   interconnects = <&system_noc MASTER_IPA &system_noc 
SLAVE_SNOC_MEM_NOC_GC>,
+   <&mem_noc MASTER_SNOC_GC_MEM_NOC 
&mc_virt SLAVE_EBI_CH0>,
+   <&system_noc MASTER_IPA &system_noc 
SLAVE_OCIMEM>,
+   <&mem_noc MASTER_AMPSS_M0 &system_noc 
SLAVE_IPA_CFG>;
+   interconnect-names = "memory-a",
+"memory-b",
+"imem",
+"config";
+
+   qcom,smem-states = <&ipa_smp2p_out 0>,
+  <&ipa_smp2p_out 1>;
+   qcom,smem-state-names = "ipa-clock-enabled-valid",
+   "ipa-clock-enabled";
+
+   status = "disabled";
+   };
+
tcsr_mutex: hwlock@1f4 {
compatible = "qcom,tcsr-mutex";
reg = <0x01f4 0x4>;
-- 
2.27.0