Re: [PATCH] ARM: lpc32xx: stop overwriting TEST_CLK_SEL

[Vladimir Zapolskiy]

Hi Alexandre, Gregory,

On 04/15/2019 10:59 AM, gregory.clem...@bootlin.com wrote:
> On 2019-04-11 16:12, Alexandre Belloni wrote:
>> While the UDA1380 is described in some lpc3250 device trees, there is
>> currently no real user of that codec. Anyway, if the codec needs a 
>> clock,
>> it should take it explicitly.
>>
>> lpc3250_machine_init is called for all the lpc32xx machines and some 
>> are
>> using test1_clk (for example to strobe an HW watchdog). Overwriting
>> TEST_CLK_SEL prevents booting those platforms.
>>
>> Signed-off-by: Alexandre Belloni 
> 
> Tested-by: Gregory CLEMENT 

I've applied the change to my tree, hopefully it will be included into v5.2.

Thank you!

--
Best wishes,
Vladimir

Re: [PATCH] ARM: lpc32xx: stop overwriting TEST_CLK_SEL

[gregory . clement]

On 2019-04-11 16:12, Alexandre Belloni wrote:

While the UDA1380 is described in some lpc3250 device trees, there is
currently no real user of that codec. Anyway, if the codec needs a 
clock,

it should take it explicitly.

lpc3250_machine_init is called for all the lpc32xx machines and some 
are

using test1_clk (for example to strobe an HW watchdog). Overwriting
TEST_CLK_SEL prevents booting those platforms.

Signed-off-by: Alexandre Belloni 



Tested-by: Gregory CLEMENT 



---
 arch/arm/mach-lpc32xx/phy3250.c | 5 -
 1 file changed, 5 deletions(-)

diff --git a/arch/arm/mach-lpc32xx/phy3250.c 
b/arch/arm/mach-lpc32xx/phy3250.c

index fdbb1409c32b..1db8508493a5 100644
--- a/arch/arm/mach-lpc32xx/phy3250.c
+++ b/arch/arm/mach-lpc32xx/phy3250.c
@@ -128,11 +128,6 @@ static void __init lpc3250_machine_init(void)
 {
lpc32xx_serial_init();

-   /* Test clock needed for UDA1380 initial init */
-   __raw_writel(LPC32XX_CLKPWR_TESTCLK2_SEL_MOSC |
-   LPC32XX_CLKPWR_TESTCLK_TESTCLK2_EN,
-   LPC32XX_CLKPWR_TEST_CLK_SEL);
-
of_platform_default_populate(NULL, lpc32xx_auxdata_lookup, NULL);
 }

[PATCH] ARM: lpc32xx: stop overwriting TEST_CLK_SEL

[Alexandre Belloni]

While the UDA1380 is described in some lpc3250 device trees, there is
currently no real user of that codec. Anyway, if the codec needs a clock,
it should take it explicitly.

lpc3250_machine_init is called for all the lpc32xx machines and some are
using test1_clk (for example to strobe an HW watchdog). Overwriting
TEST_CLK_SEL prevents booting those platforms.

Signed-off-by: Alexandre Belloni 
---
 arch/arm/mach-lpc32xx/phy3250.c | 5 -
 1 file changed, 5 deletions(-)

diff --git a/arch/arm/mach-lpc32xx/phy3250.c b/arch/arm/mach-lpc32xx/phy3250.c
index fdbb1409c32b..1db8508493a5 100644
--- a/arch/arm/mach-lpc32xx/phy3250.c
+++ b/arch/arm/mach-lpc32xx/phy3250.c
@@ -128,11 +128,6 @@ static void __init lpc3250_machine_init(void)
 {
lpc32xx_serial_init();
 
-   /* Test clock needed for UDA1380 initial init */
-   __raw_writel(LPC32XX_CLKPWR_TESTCLK2_SEL_MOSC |
-   LPC32XX_CLKPWR_TESTCLK_TESTCLK2_EN,
-   LPC32XX_CLKPWR_TEST_CLK_SEL);
-
of_platform_default_populate(NULL, lpc32xx_auxdata_lookup, NULL);
 }
 
-- 
2.20.1