Re: [PATCH] ASoC: AMD: Use mixer control to switch between DMICs

[Agrawal, Akshu]

On 5/27/2020 4:57 PM, Mark Brown wrote:

On Wed, May 27, 2020 at 07:10:16AM +0530, Akshu Agrawal wrote:


+   SOC_SINGLE_BOOL_EXT("Front Mic", 0, front_mic_get, front_mic_set),

This should probably be a mux with two labelled options, or if it's a
boolean control it should end in Switch.  A mux definitely seems like a
better option though.


Actually it's a dmic switch, so will change it to boolean control named 
"DMIC switch". Front or rear mic might change with variants.


Thanks,

Akshu

Re: [PATCH] ASoC: AMD: Use mixer control to switch between DMICs

[Mark Brown]

On Wed, May 27, 2020 at 07:10:16AM +0530, Akshu Agrawal wrote:

> + SOC_SINGLE_BOOL_EXT("Front Mic", 0, front_mic_get, front_mic_set),

This should probably be a mux with two labelled options, or if it's a
boolean control it should end in Switch.  A mux definitely seems like a
better option though.


signature.asc
Description: PGP signature

[PATCH] ASoC: AMD: Use mixer control to switch between DMICs

[Akshu Agrawal]

Having mixer control to switch between DMICs prevents user to
initiate capture simultaneously on both the DMIcs.
Earlier 2 separate devices, one for each DMIC, gave an option of
using them simultaneously, which is not supported.

Signed-off-by: Akshu Agrawal 
---
 sound/soc/amd/acp3x-rt5682-max9836.c | 43 +++-
 1 file changed, 16 insertions(+), 27 deletions(-)

diff --git a/sound/soc/amd/acp3x-rt5682-max9836.c 
b/sound/soc/amd/acp3x-rt5682-max9836.c
index e499c00e0c66..19f55a814547 100644
--- a/sound/soc/amd/acp3x-rt5682-max9836.c
+++ b/sound/soc/amd/acp3x-rt5682-max9836.c
@@ -188,25 +188,27 @@ static int acp3x_ec_dmic0_startup(struct 
snd_pcm_substream *substream)
 
machine->cap_i2s_instance = I2S_BT_INSTANCE;
snd_soc_dai_set_bclk_ratio(codec_dai, 64);
-   if (dmic_sel)
-   gpiod_set_value(dmic_sel, 0);
 
return rt5682_clk_enable(substream);
 }
 
-static int acp3x_ec_dmic1_startup(struct snd_pcm_substream *substream)
-{
-   struct snd_soc_pcm_runtime *rtd = substream->private_data;
-   struct snd_soc_card *card = rtd->card;
-   struct snd_soc_dai *codec_dai = asoc_rtd_to_codec(rtd, 0);
-   struct acp3x_platform_info *machine = snd_soc_card_get_drvdata(card);
+static int front_mic_enabled;
 
-   machine->cap_i2s_instance = I2S_BT_INSTANCE;
-   snd_soc_dai_set_bclk_ratio(codec_dai, 64);
-   if (dmic_sel)
-   gpiod_set_value(dmic_sel, 1);
+static int front_mic_get(struct snd_kcontrol *kcontrol,
+struct snd_ctl_elem_value *ucontrol)
+{
+   ucontrol->value.integer.value[0] = front_mic_enabled;
+   return 0;
+}
 
-   return rt5682_clk_enable(substream);
+static int front_mic_set(struct snd_kcontrol *kcontrol,
+struct snd_ctl_elem_value *ucontrol)
+{
+   if (dmic_sel) {
+   front_mic_enabled = ucontrol->value.integer.value[0];
+   gpiod_set_value(dmic_sel, !front_mic_enabled);
+   }
+   return 0;
 }
 
 static void rt5682_shutdown(struct snd_pcm_substream *substream)
@@ -229,11 +231,6 @@ static const struct snd_soc_ops acp3x_ec_cap0_ops = {
.shutdown = rt5682_shutdown,
 };
 
-static const struct snd_soc_ops acp3x_ec_cap1_ops = {
-   .startup = acp3x_ec_dmic1_startup,
-   .shutdown = rt5682_shutdown,
-};
-
 SND_SOC_DAILINK_DEF(acp3x_i2s,
DAILINK_COMP_ARRAY(COMP_CPU("acp3x_i2s_playcap.0")));
 SND_SOC_DAILINK_DEF(acp3x_bt,
@@ -279,15 +276,6 @@ static struct snd_soc_dai_link acp3x_dai_5682_98357[] = {
.ops = _ec_cap0_ops,
SND_SOC_DAILINK_REG(acp3x_bt, cros_ec, platform),
},
-   {
-   .name = "acp3x-ec-dmic1-capture",
-   .stream_name = "Capture DMIC1",
-   .dai_fmt = SND_SOC_DAIFMT_I2S | SND_SOC_DAIFMT_NB_NF
-   | SND_SOC_DAIFMT_CBS_CFS,
-   .dpcm_capture = 1,
-   .ops = _ec_cap1_ops,
-   SND_SOC_DAILINK_REG(acp3x_bt, cros_ec, platform),
-   },
 };
 
 static const struct snd_soc_dapm_widget acp3x_widgets[] = {
@@ -307,6 +295,7 @@ static const struct snd_kcontrol_new acp3x_mc_controls[] = {
SOC_DAPM_PIN_SWITCH("Headphone Jack"),
SOC_DAPM_PIN_SWITCH("Spk"),
SOC_DAPM_PIN_SWITCH("Headset Mic"),
+   SOC_SINGLE_BOOL_EXT("Front Mic", 0, front_mic_get, front_mic_set),
 };
 
 static struct snd_soc_card acp3x_card = {
-- 
2.20.1