Re: [PATCH] ASoC: cs35l35: trivial fix to indentation

2017-03-12 Thread walter harms 


Am 11.03.2017 20:19, schrieb Colin King:
> From: Colin Ian King 
> 
> Remove extraneous tab to correct the nesting level indentation
> 
> Detected by CoverityScan, CID#1416584 ("Nesting level does
> not match indentation")
> 
> Signed-off-by: Colin Ian King 
> ---
>  sound/soc/codecs/cs35l35.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/sound/soc/codecs/cs35l35.c b/sound/soc/codecs/cs35l35.c
> index 260ed42..43d33f4 100644
> --- a/sound/soc/codecs/cs35l35.c
> +++ b/sound/soc/codecs/cs35l35.c
> @@ -1370,7 +1370,8 @@ static int cs35l35_i2c_probe(struct i2c_client 
> *i2c_client,
>  
>   for (i = 0; i < ARRAY_SIZE(cs35l35_supplies); i++)
>   cs35l35->supplies[i].supply = cs35l35_supplies[i];
> - cs35l35->num_supplies = ARRAY_SIZE(cs35l35_supplies);
> +
> + cs35l35->num_supplies = ARRAY_SIZE(cs35l35_supplies);
>  


I have the feeling is better before the loop:

cs35l35->num_supplies = ARRAY_SIZE(cs35l35_supplies);

for (i = 0; i < cs35l35->num_supplies; i++)
 cs35l35->supplies[i].supply = cs35l35_supplies[i];

re,
 wh

>   ret = devm_regulator_bulk_get(_client->dev,
>   cs35l35->num_supplies,

Re: [PATCH] ASoC: cs35l35: trivial fix to indentation

2017-03-12 Thread walter harms 


Am 11.03.2017 20:19, schrieb Colin King:
> From: Colin Ian King 
> 
> Remove extraneous tab to correct the nesting level indentation
> 
> Detected by CoverityScan, CID#1416584 ("Nesting level does
> not match indentation")
> 
> Signed-off-by: Colin Ian King 
> ---
>  sound/soc/codecs/cs35l35.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/sound/soc/codecs/cs35l35.c b/sound/soc/codecs/cs35l35.c
> index 260ed42..43d33f4 100644
> --- a/sound/soc/codecs/cs35l35.c
> +++ b/sound/soc/codecs/cs35l35.c
> @@ -1370,7 +1370,8 @@ static int cs35l35_i2c_probe(struct i2c_client 
> *i2c_client,
>  
>   for (i = 0; i < ARRAY_SIZE(cs35l35_supplies); i++)
>   cs35l35->supplies[i].supply = cs35l35_supplies[i];
> - cs35l35->num_supplies = ARRAY_SIZE(cs35l35_supplies);
> +
> + cs35l35->num_supplies = ARRAY_SIZE(cs35l35_supplies);
>  


I have the feeling is better before the loop:

cs35l35->num_supplies = ARRAY_SIZE(cs35l35_supplies);

for (i = 0; i < cs35l35->num_supplies; i++)
 cs35l35->supplies[i].supply = cs35l35_supplies[i];

re,
 wh

>   ret = devm_regulator_bulk_get(_client->dev,
>   cs35l35->num_supplies,

[PATCH] ASoC: cs35l35: trivial fix to indentation

2017-03-11 Thread Colin King 
From: Colin Ian King 

Remove extraneous tab to correct the nesting level indentation

Detected by CoverityScan, CID#1416584 ("Nesting level does
not match indentation")

Signed-off-by: Colin Ian King 
---
 sound/soc/codecs/cs35l35.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/sound/soc/codecs/cs35l35.c b/sound/soc/codecs/cs35l35.c
index 260ed42..43d33f4 100644
--- a/sound/soc/codecs/cs35l35.c
+++ b/sound/soc/codecs/cs35l35.c
@@ -1370,7 +1370,8 @@ static int cs35l35_i2c_probe(struct i2c_client 
*i2c_client,
 
for (i = 0; i < ARRAY_SIZE(cs35l35_supplies); i++)
cs35l35->supplies[i].supply = cs35l35_supplies[i];
-   cs35l35->num_supplies = ARRAY_SIZE(cs35l35_supplies);
+
+   cs35l35->num_supplies = ARRAY_SIZE(cs35l35_supplies);
 
ret = devm_regulator_bulk_get(_client->dev,
cs35l35->num_supplies,
-- 
2.10.2

[PATCH] ASoC: cs35l35: trivial fix to indentation

2017-03-11 Thread Colin King 
From: Colin Ian King 

Remove extraneous tab to correct the nesting level indentation

Detected by CoverityScan, CID#1416584 ("Nesting level does
not match indentation")

Signed-off-by: Colin Ian King 
---
 sound/soc/codecs/cs35l35.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/sound/soc/codecs/cs35l35.c b/sound/soc/codecs/cs35l35.c
index 260ed42..43d33f4 100644
--- a/sound/soc/codecs/cs35l35.c
+++ b/sound/soc/codecs/cs35l35.c
@@ -1370,7 +1370,8 @@ static int cs35l35_i2c_probe(struct i2c_client 
*i2c_client,
 
for (i = 0; i < ARRAY_SIZE(cs35l35_supplies); i++)
cs35l35->supplies[i].supply = cs35l35_supplies[i];
-   cs35l35->num_supplies = ARRAY_SIZE(cs35l35_supplies);
+
+   cs35l35->num_supplies = ARRAY_SIZE(cs35l35_supplies);
 
ret = devm_regulator_bulk_get(_client->dev,
cs35l35->num_supplies,
-- 
2.10.2