Re: [PATCH] ASoC: dapm: Modify widget stream name according to prefix

2015-05-12 Thread Mark Brown
On Mon, May 11, 2015 at 10:36:53AM +0800, Koro Chen wrote:
> When there is prefix specified, currently we will add this prefix in
> widget->name, but not in widget->sname.
> it causes failure at snd_soc_dapm_link_dai_widgets:

Applied, thanks.


signature.asc
Description: Digital signature


[PATCH] ASoC: dapm: Modify widget stream name according to prefix

2015-05-10 Thread Koro Chen
When there is prefix specified, currently we will add this prefix in
widget->name, but not in widget->sname.
it causes failure at snd_soc_dapm_link_dai_widgets:

if (!w->sname || !strstr(w->sname, dai_w->name))

because dai_w->name has prefix added, but w->sname does not.
We should also add prefix for stream name

Signed-off-by: Koro Chen 
---
 sound/soc/soc-dapm.c | 11 ---
 1 file changed, 8 insertions(+), 3 deletions(-)

diff --git a/sound/soc/soc-dapm.c b/sound/soc/soc-dapm.c
index defe0f0..158204d 100644
--- a/sound/soc/soc-dapm.c
+++ b/sound/soc/soc-dapm.c
@@ -3100,11 +3100,16 @@ snd_soc_dapm_new_control(struct snd_soc_dapm_context 
*dapm,
}
 
prefix = soc_dapm_prefix(dapm);
-   if (prefix)
+   if (prefix) {
w->name = kasprintf(GFP_KERNEL, "%s %s", prefix, widget->name);
-   else
+   if (widget->sname)
+   w->sname = kasprintf(GFP_KERNEL, "%s %s", prefix,
+widget->sname);
+   } else {
w->name = kasprintf(GFP_KERNEL, "%s", widget->name);
-
+   if (widget->sname)
+   w->sname = kasprintf(GFP_KERNEL, "%s", widget->sname);
+   }
if (w->name == NULL) {
kfree(w);
return NULL;
-- 
1.8.1.1.dirty

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/