Re: [PATCH] ASoC: rt5651: Convert rt5651 micbias1 to a supply widget

2017-10-21 Thread Carlo Caione 
On Sat, Oct 21, 2017 at 11:09 AM, Mark Brown  wrote:
> On Wed, Oct 18, 2017 at 06:06:31PM +0100, Carlo Caione wrote:
>> From: Carlo Caione 
>>
>> MICBIAS widget type has been deprecated. Convert it to a SUPPLY widget.
>
> Do we have any machine drivers using this?  If it was just a simple
> substitution then we'd have just done the conversion but the routing for
> MICBIAS was funky, requiring that it be looped into the path.

We have bytcr_rt5651.c already using it as a supply (source) widget.
Also this change is required to have the jack detection working fine
using the set of patches posted in [0]

thanks,

[0] https://www.spinics.net/lists/kernel/msg2630096.html

-- 
Carlo Caione  |  +39.340.80.30.096  |  Endless

Re: [PATCH] ASoC: rt5651: Convert rt5651 micbias1 to a supply widget

2017-10-21 Thread Carlo Caione 
On Sat, Oct 21, 2017 at 11:09 AM, Mark Brown  wrote:
> On Wed, Oct 18, 2017 at 06:06:31PM +0100, Carlo Caione wrote:
>> From: Carlo Caione 
>>
>> MICBIAS widget type has been deprecated. Convert it to a SUPPLY widget.
>
> Do we have any machine drivers using this?  If it was just a simple
> substitution then we'd have just done the conversion but the routing for
> MICBIAS was funky, requiring that it be looped into the path.

We have bytcr_rt5651.c already using it as a supply (source) widget.
Also this change is required to have the jack detection working fine
using the set of patches posted in [0]

thanks,

[0] https://www.spinics.net/lists/kernel/msg2630096.html

-- 
Carlo Caione  |  +39.340.80.30.096  |  Endless

Re: [PATCH] ASoC: rt5651: Convert rt5651 micbias1 to a supply widget

2017-10-21 Thread Mark Brown 
On Wed, Oct 18, 2017 at 06:06:31PM +0100, Carlo Caione wrote:
> From: Carlo Caione 
> 
> MICBIAS widget type has been deprecated. Convert it to a SUPPLY widget.

Do we have any machine drivers using this?  If it was just a simple
substitution then we'd have just done the conversion but the routing for
MICBIAS was funky, requiring that it be looped into the path.


signature.asc
Description: PGP signature

Re: [PATCH] ASoC: rt5651: Convert rt5651 micbias1 to a supply widget

2017-10-21 Thread Mark Brown 
On Wed, Oct 18, 2017 at 06:06:31PM +0100, Carlo Caione wrote:
> From: Carlo Caione 
> 
> MICBIAS widget type has been deprecated. Convert it to a SUPPLY widget.

Do we have any machine drivers using this?  If it was just a simple
substitution then we'd have just done the conversion but the routing for
MICBIAS was funky, requiring that it be looped into the path.


signature.asc
Description: PGP signature

[PATCH] ASoC: rt5651: Convert rt5651 micbias1 to a supply widget

2017-10-18 Thread Carlo Caione 
From: Carlo Caione 

MICBIAS widget type has been deprecated. Convert it to a SUPPLY widget.

Signed-off-by: Carlo Caione 
---
 sound/soc/codecs/rt5651.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/sound/soc/codecs/rt5651.c b/sound/soc/codecs/rt5651.c
index da60b28ba3df..28f7210cec91 100644
--- a/sound/soc/codecs/rt5651.c
+++ b/sound/soc/codecs/rt5651.c
@@ -883,8 +883,8 @@ static const struct snd_soc_dapm_widget 
rt5651_dapm_widgets[] = {
/* micbias */
SND_SOC_DAPM_SUPPLY("LDO", RT5651_PWR_ANLG1,
RT5651_PWR_LDO_BIT, 0, NULL, 0),
-   SND_SOC_DAPM_MICBIAS("micbias1", RT5651_PWR_ANLG2,
-   RT5651_PWR_MB1_BIT, 0),
+   SND_SOC_DAPM_SUPPLY("micbias1", RT5651_PWR_ANLG2,
+   RT5651_PWR_MB1_BIT, 0, NULL, 0),
/* Input Lines */
SND_SOC_DAPM_INPUT("MIC1"),
SND_SOC_DAPM_INPUT("MIC2"),
-- 
2.14.2

[PATCH] ASoC: rt5651: Convert rt5651 micbias1 to a supply widget

2017-10-18 Thread Carlo Caione 
From: Carlo Caione 

MICBIAS widget type has been deprecated. Convert it to a SUPPLY widget.

Signed-off-by: Carlo Caione 
---
 sound/soc/codecs/rt5651.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/sound/soc/codecs/rt5651.c b/sound/soc/codecs/rt5651.c
index da60b28ba3df..28f7210cec91 100644
--- a/sound/soc/codecs/rt5651.c
+++ b/sound/soc/codecs/rt5651.c
@@ -883,8 +883,8 @@ static const struct snd_soc_dapm_widget 
rt5651_dapm_widgets[] = {
/* micbias */
SND_SOC_DAPM_SUPPLY("LDO", RT5651_PWR_ANLG1,
RT5651_PWR_LDO_BIT, 0, NULL, 0),
-   SND_SOC_DAPM_MICBIAS("micbias1", RT5651_PWR_ANLG2,
-   RT5651_PWR_MB1_BIT, 0),
+   SND_SOC_DAPM_SUPPLY("micbias1", RT5651_PWR_ANLG2,
+   RT5651_PWR_MB1_BIT, 0, NULL, 0),
/* Input Lines */
SND_SOC_DAPM_INPUT("MIC1"),
SND_SOC_DAPM_INPUT("MIC2"),
-- 
2.14.2