Re: [PATCH] Correct bad CONFIG names in drivers/usb/input/Makefile.

2007-03-26 Thread Dmitry Torokhov
On Monday 26 March 2007 18:08, Robert P. J. Day wrote:
> Correct the incorrect CONFIG_ variables currently in
> drivers/usb/input/Makefile that prevent three of the touchscreen
> source files from being built.
> 
> Signed-off-by: Robert P. J. Day <[EMAIL PROTECTED]>
> 

NAK. These modules should just go away.

-- 
Dmitry

Input: remove old USB touchscreen drivers

itmtoch, mtouchusb and touchkitusb have been replaced with
composite usbtouchscreen driver and can be removed now.

Signed-off-by: Dmitry Torokhov <[EMAIL PROTECTED]>
---

 drivers/usb/input/itmtouch.c|  271 ---
 drivers/usb/input/mtouchusb.c   |  332 -
 drivers/usb/input/touchkitusb.c |  392 
 drivers/usb/input/Makefile  |3 
 4 files changed, 998 deletions(-)

Index: work/drivers/usb/input/Makefile
===
--- work.orig/drivers/usb/input/Makefile
+++ work/drivers/usb/input/Makefile
@@ -38,9 +38,6 @@ obj-$(CONFIG_USB_KBD) += usbkbd.o
 obj-$(CONFIG_USB_KBTAB)+= kbtab.o
 obj-$(CONFIG_USB_KEYSPAN_REMOTE)   += keyspan_remote.o
 obj-$(CONFIG_USB_MOUSE)+= usbmouse.o
-obj-$(CONFIG_USB_MTOUCH)   += mtouchusb.o
-obj-$(CONFIG_USB_ITMTOUCH) += itmtouch.o
-obj-$(CONFIG_USB_EGALAX)   += touchkitusb.o
 obj-$(CONFIG_USB_TOUCHSCREEN)  += usbtouchscreen.o
 obj-$(CONFIG_USB_POWERMATE)+= powermate.o
 obj-$(CONFIG_USB_WACOM)+= wacom.o
Index: work/drivers/usb/input/itmtouch.c
===
--- work.orig/drivers/usb/input/itmtouch.c
+++ /dev/null
@@ -1,271 +0,0 @@
-/**
- * itmtouch.c  --  Driver for ITM touchscreen panel
- *
- * This program is free software; you can redistribute it and/or
- * modify it under the terms of the GNU General Public License as
- * published by the Free Software Foundation; either version 2 of the
- * License, or (at your option) any later version.
- *
- * This program is distributed in the hope that it will be useful, but
- * WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
- * General Public License for more details.
- *
- * You should have received a copy of the GNU General Public License
- * along with this program; if not, write to the Free Software
- * Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
- *
- * Based upon original work by Chris Collins <[EMAIL PROTECTED]>.
- *
- * Kudos to ITM for providing me with the datasheet for the panel,
- * even though it was a day later than I had finished writing this
- * driver.
- *
- * It has meant that I've been able to correct my interpretation of the
- * protocol packets however.
- *
- * CC -- 2003/9/29
- *
- * History
- * 1.0 & 1.1  2003 (CC) [EMAIL PROTECTED]
- *   Original version for 2.4.x kernels
- *
- * 1.2  02/03/2005 (HCE) [EMAIL PROTECTED]
- *   Complete rewrite to support Linux 2.6.10, thanks to mtouchusb.c for hints.
- *   Unfortunately no calibration support at this time.
- *
- * 1.2.1  09/03/2005 (HCE) [EMAIL PROTECTED]
- *   Code cleanup and adjusting syntax to start matching kernel standards
- * 
- * 1.2.2  10/05/2006 (MJA) [EMAIL PROTECTED]
- *   Flag for detecting if the screen was being touch was incorrectly 
- *   inverted, so no touch events were being detected. 
- *   
- */
-
-#include 
-#include 
-#include 
-#include 
-#include 
-
-/* only an 8 byte buffer necessary for a single packet */
-#define ITM_BUFSIZE8
-#define PATH_SIZE  64
-
-#define USB_VENDOR_ID_ITMINC   0x0403
-#define USB_PRODUCT_ID_TOUCHPANEL  0xf9e9
-
-#define DRIVER_AUTHOR "Hans-Christian Egtvedt <[EMAIL PROTECTED]>"
-#define DRIVER_VERSION "v1.2.2"
-#define DRIVER_DESC "USB ITM Inc Touch Panel Driver"
-#define DRIVER_LICENSE "GPL"
-
-MODULE_AUTHOR( DRIVER_AUTHOR );
-MODULE_DESCRIPTION( DRIVER_DESC );
-MODULE_LICENSE( DRIVER_LICENSE );
-
-struct itmtouch_dev {
-   struct usb_device   *usbdev; /* usb device */
-   struct input_dev*inputdev; /* input device */
-   struct urb  *readurb; /* urb */
-   charrbuf[ITM_BUFSIZE]; /* data */
-   int users;
-   char name[128];
-   char phys[64];
-};
-
-static struct usb_device_id itmtouch_ids [] = {
-   { USB_DEVICE(USB_VENDOR_ID_ITMINC, USB_PRODUCT_ID_TOUCHPANEL) },
-   { }
-};
-
-static void itmtouch_irq(struct urb *urb)
-{
-   struct itmtouch_dev *itmtouch = urb->context;
-   unsigned char *data = urb->transfer_buffer;
-   struct input_dev *dev = itmtouch->inputdev;
-   int retval;
-
-   switch (urb->status) {
-   case 0:
-   /* success */

[PATCH] Correct bad CONFIG names in drivers/usb/input/Makefile.

2007-03-26 Thread Robert P. J. Day

Correct the incorrect CONFIG_ variables currently in
drivers/usb/input/Makefile that prevent three of the touchscreen
source files from being built.

Signed-off-by: Robert P. J. Day <[EMAIL PROTECTED]>

---

it *looks* like this is the right fix, but i'm just on my way out the
door so i'll leave it to others to verify.

diff --git a/drivers/usb/input/Makefile b/drivers/usb/input/Makefile
index a9d206c..198337f 100644
--- a/drivers/usb/input/Makefile
+++ b/drivers/usb/input/Makefile
@@ -38,9 +38,9 @@ obj-$(CONFIG_USB_KBD) += usbkbd.o
 obj-$(CONFIG_USB_KBTAB)+= kbtab.o
 obj-$(CONFIG_USB_KEYSPAN_REMOTE)   += keyspan_remote.o
 obj-$(CONFIG_USB_MOUSE)+= usbmouse.o
-obj-$(CONFIG_USB_MTOUCH)   += mtouchusb.o
-obj-$(CONFIG_USB_ITMTOUCH) += itmtouch.o
-obj-$(CONFIG_USB_EGALAX)   += touchkitusb.o
+obj-$(CONFIG_USB_TOUCHSCREEN_3M)   += mtouchusb.o
+obj-$(CONFIG_USB_TOUCHSCREEN_ITM)  += itmtouch.o
+obj-$(CONFIG_USB_TOUCHSCREEN_EGALAX)   += touchkitusb.o
 obj-$(CONFIG_USB_TOUCHSCREEN)  += usbtouchscreen.o
 obj-$(CONFIG_USB_POWERMATE)+= powermate.o
 obj-$(CONFIG_USB_WACOM)+= wacom.o
-- 

Robert P. J. Day
Linux Consulting, Training and Annoying Kernel Pedantry
Waterloo, Ontario, CANADA

http://fsdev.net/wiki/index.php?title=Main_Page

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/