Re: [PATCH] EXPORT_SYMBOL() time functions
Christoph Hellwig wrote: > On Wed, Feb 21, 2007 at 02:13:38PM +0100, Rolf Eike Beer wrote: > > These functions were inlines before > > 8b9365d753d9870bb6451504c13570b81923228f. Now EXPORT_SYMBOL() them to > > allow them to be used in modules again. > > Just because they happened to be inlined that doesn't mean modules should > be using them. In fact no intree module uses them exactly because they're > not intended to be used by this kind of code. Please show the code you > want to use this for so we can see what you're really trying to do. Trying to convert a given user value (in milliseconds) to a timeout. No problem doing this with struct timespec. Eike pgpzZU2hCFZ61.pgp Description: PGP signature
Re: [PATCH] EXPORT_SYMBOL() time functions
On Wed, Feb 21, 2007 at 02:13:38PM +0100, Rolf Eike Beer wrote: > These functions were inlines before 8b9365d753d9870bb6451504c13570b81923228f. > Now EXPORT_SYMBOL() them to allow them to be used in modules again. Just because they happened to be inlined that doesn't mean modules should be using them. In fact no intree module uses them exactly because they're not intended to be used by this kind of code. Please show the code you want to use this for so we can see what you're really trying to do. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] EXPORT_SYMBOL() time functions
Arjan van de Ven wrote: > On Wed, 2007-02-21 at 14:12 +0100, Rolf Eike Beer wrote: > > These functions were inlines before > > 8b9365d753d9870bb6451504c13570b81923228f. Now EXPORT_SYMBOL() them to > > allow them to be used in modules again. > > please do not add random exports without users; exports eat up kernel > size and memory. At minimum specify which mainline modules use the > exports.. Nothing in mainline now. I just found out that the module I'm writing doesn't work anymore as timeval_to_jiffies() disappeared. If this is planned to go away from modules I should consider switching to timespec. Eike pgpk4J9C51SGQ.pgp Description: PGP signature
Re: [PATCH] EXPORT_SYMBOL() time functions
On Wed, 2007-02-21 at 14:12 +0100, Rolf Eike Beer wrote: > These functions were inlines before 8b9365d753d9870bb6451504c13570b81923228f. > Now EXPORT_SYMBOL() them to allow them to be used in modules again. please do not add random exports without users; exports eat up kernel size and memory. At minimum specify which mainline modules use the exports.. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH] EXPORT_SYMBOL() time functions
These functions were inlines before 8b9365d753d9870bb6451504c13570b81923228f.
Now EXPORT_SYMBOL() them to allow them to be used in modules again.
Signed-off-by: Rolf Eike Beer <[EMAIL PROTECTED]>
---
Sent once again, this time without PGP signature so importing into git is
easier.
commit 0a543599f4a9ea02b587bda26e0e11ae94774f61
tree aa815eab413d2575925b0964a1fa01d41439b26b
parent 6b8afc66b9d6893d3fa292b75769b58539836ff3
author Rolf Eike Beer <[EMAIL PROTECTED]> Wed, 21 Feb 2007 14:10:12 +0100
committer Rolf Eike Beer <[EMAIL PROTECTED]> Wed, 21 Feb 2007 14:10:12 +0100
kernel/time.c |3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/kernel/time.c b/kernel/time.c
index c6c80ea..0b351b2 100644
--- a/kernel/time.c
+++ b/kernel/time.c
@@ -635,6 +635,7 @@ timeval_to_jiffies(const struct timeval *value)
(((u64)usec * USEC_CONVERSION + USEC_ROUND) >>
(USEC_JIFFIE_SC - SEC_JIFFIE_SC))) >> SEC_JIFFIE_SC;
}
+EXPORT_SYMBOL(timeval_to_jiffies);
void jiffies_to_timeval(const unsigned long jiffies, struct timeval *value)
{
@@ -649,6 +650,7 @@ void jiffies_to_timeval(const unsigned long jiffies, struct
timeval *value)
tv_usec /= NSEC_PER_USEC;
value->tv_usec = tv_usec;
}
+EXPORT_SYMBOL(jiffies_to_timeval);
/*
* Convert jiffies/jiffies_64 to clock_t and back.
@@ -723,6 +725,7 @@ u64 nsec_to_clock_t(u64 x)
#endif
return x;
}
+EXPORT_SYMBOL(nsec_to_clock_t);
#if (BITS_PER_LONG < 64)
u64 get_jiffies_64(void)
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[PATCH] EXPORT_SYMBOL() time functions
These functions were inlines before 8b9365d753d9870bb6451504c13570b81923228f.
Now EXPORT_SYMBOL() them to allow them to be used in modules again.
Signed-off-by: Rolf Eike Beer <[EMAIL PROTECTED]>
---
commit 0a543599f4a9ea02b587bda26e0e11ae94774f61
tree aa815eab413d2575925b0964a1fa01d41439b26b
parent 6b8afc66b9d6893d3fa292b75769b58539836ff3
author Rolf Eike Beer <[EMAIL PROTECTED]> Wed, 21 Feb 2007 14:10:12 +0100
committer Rolf Eike Beer <[EMAIL PROTECTED]> Wed, 21 Feb 2007 14:10:12 +0100
kernel/time.c |3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/kernel/time.c b/kernel/time.c
index c6c80ea..0b351b2 100644
--- a/kernel/time.c
+++ b/kernel/time.c
@@ -635,6 +635,7 @@ timeval_to_jiffies(const struct timeval *value)
(((u64)usec * USEC_CONVERSION + USEC_ROUND) >>
(USEC_JIFFIE_SC - SEC_JIFFIE_SC))) >> SEC_JIFFIE_SC;
}
+EXPORT_SYMBOL(timeval_to_jiffies);
void jiffies_to_timeval(const unsigned long jiffies, struct timeval *value)
{
@@ -649,6 +650,7 @@ void jiffies_to_timeval(const unsigned long jiffies, struct
timeval *value)
tv_usec /= NSEC_PER_USEC;
value->tv_usec = tv_usec;
}
+EXPORT_SYMBOL(jiffies_to_timeval);
/*
* Convert jiffies/jiffies_64 to clock_t and back.
@@ -723,6 +725,7 @@ u64 nsec_to_clock_t(u64 x)
#endif
return x;
}
+EXPORT_SYMBOL(nsec_to_clock_t);
#if (BITS_PER_LONG < 64)
u64 get_jiffies_64(void)
pgptlQoaEVqET.pgp
Description: PGP signature
[PATCH] EXPORT_SYMBOL() time functions
These functions were inlines before 8b9365d753d9870bb6451504c13570b81923228f.
Now EXPORT_SYMBOL() them to allow them to be used in modules again.
Signed-off-by: Rolf Eike Beer [EMAIL PROTECTED]
---
commit 0a543599f4a9ea02b587bda26e0e11ae94774f61
tree aa815eab413d2575925b0964a1fa01d41439b26b
parent 6b8afc66b9d6893d3fa292b75769b58539836ff3
author Rolf Eike Beer [EMAIL PROTECTED] Wed, 21 Feb 2007 14:10:12 +0100
committer Rolf Eike Beer [EMAIL PROTECTED] Wed, 21 Feb 2007 14:10:12 +0100
kernel/time.c |3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/kernel/time.c b/kernel/time.c
index c6c80ea..0b351b2 100644
--- a/kernel/time.c
+++ b/kernel/time.c
@@ -635,6 +635,7 @@ timeval_to_jiffies(const struct timeval *value)
(((u64)usec * USEC_CONVERSION + USEC_ROUND)
(USEC_JIFFIE_SC - SEC_JIFFIE_SC))) SEC_JIFFIE_SC;
}
+EXPORT_SYMBOL(timeval_to_jiffies);
void jiffies_to_timeval(const unsigned long jiffies, struct timeval *value)
{
@@ -649,6 +650,7 @@ void jiffies_to_timeval(const unsigned long jiffies, struct
timeval *value)
tv_usec /= NSEC_PER_USEC;
value-tv_usec = tv_usec;
}
+EXPORT_SYMBOL(jiffies_to_timeval);
/*
* Convert jiffies/jiffies_64 to clock_t and back.
@@ -723,6 +725,7 @@ u64 nsec_to_clock_t(u64 x)
#endif
return x;
}
+EXPORT_SYMBOL(nsec_to_clock_t);
#if (BITS_PER_LONG 64)
u64 get_jiffies_64(void)
pgptlQoaEVqET.pgp
Description: PGP signature
[PATCH] EXPORT_SYMBOL() time functions
These functions were inlines before 8b9365d753d9870bb6451504c13570b81923228f.
Now EXPORT_SYMBOL() them to allow them to be used in modules again.
Signed-off-by: Rolf Eike Beer [EMAIL PROTECTED]
---
Sent once again, this time without PGP signature so importing into git is
easier.
commit 0a543599f4a9ea02b587bda26e0e11ae94774f61
tree aa815eab413d2575925b0964a1fa01d41439b26b
parent 6b8afc66b9d6893d3fa292b75769b58539836ff3
author Rolf Eike Beer [EMAIL PROTECTED] Wed, 21 Feb 2007 14:10:12 +0100
committer Rolf Eike Beer [EMAIL PROTECTED] Wed, 21 Feb 2007 14:10:12 +0100
kernel/time.c |3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/kernel/time.c b/kernel/time.c
index c6c80ea..0b351b2 100644
--- a/kernel/time.c
+++ b/kernel/time.c
@@ -635,6 +635,7 @@ timeval_to_jiffies(const struct timeval *value)
(((u64)usec * USEC_CONVERSION + USEC_ROUND)
(USEC_JIFFIE_SC - SEC_JIFFIE_SC))) SEC_JIFFIE_SC;
}
+EXPORT_SYMBOL(timeval_to_jiffies);
void jiffies_to_timeval(const unsigned long jiffies, struct timeval *value)
{
@@ -649,6 +650,7 @@ void jiffies_to_timeval(const unsigned long jiffies, struct
timeval *value)
tv_usec /= NSEC_PER_USEC;
value-tv_usec = tv_usec;
}
+EXPORT_SYMBOL(jiffies_to_timeval);
/*
* Convert jiffies/jiffies_64 to clock_t and back.
@@ -723,6 +725,7 @@ u64 nsec_to_clock_t(u64 x)
#endif
return x;
}
+EXPORT_SYMBOL(nsec_to_clock_t);
#if (BITS_PER_LONG 64)
u64 get_jiffies_64(void)
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] EXPORT_SYMBOL() time functions
On Wed, 2007-02-21 at 14:12 +0100, Rolf Eike Beer wrote: These functions were inlines before 8b9365d753d9870bb6451504c13570b81923228f. Now EXPORT_SYMBOL() them to allow them to be used in modules again. please do not add random exports without users; exports eat up kernel size and memory. At minimum specify which mainline modules use the exports.. - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] EXPORT_SYMBOL() time functions
Arjan van de Ven wrote: On Wed, 2007-02-21 at 14:12 +0100, Rolf Eike Beer wrote: These functions were inlines before 8b9365d753d9870bb6451504c13570b81923228f. Now EXPORT_SYMBOL() them to allow them to be used in modules again. please do not add random exports without users; exports eat up kernel size and memory. At minimum specify which mainline modules use the exports.. Nothing in mainline now. I just found out that the module I'm writing doesn't work anymore as timeval_to_jiffies() disappeared. If this is planned to go away from modules I should consider switching to timespec. Eike pgpk4J9C51SGQ.pgp Description: PGP signature
Re: [PATCH] EXPORT_SYMBOL() time functions
On Wed, Feb 21, 2007 at 02:13:38PM +0100, Rolf Eike Beer wrote: These functions were inlines before 8b9365d753d9870bb6451504c13570b81923228f. Now EXPORT_SYMBOL() them to allow them to be used in modules again. Just because they happened to be inlined that doesn't mean modules should be using them. In fact no intree module uses them exactly because they're not intended to be used by this kind of code. Please show the code you want to use this for so we can see what you're really trying to do. - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] EXPORT_SYMBOL() time functions
Christoph Hellwig wrote: On Wed, Feb 21, 2007 at 02:13:38PM +0100, Rolf Eike Beer wrote: These functions were inlines before 8b9365d753d9870bb6451504c13570b81923228f. Now EXPORT_SYMBOL() them to allow them to be used in modules again. Just because they happened to be inlined that doesn't mean modules should be using them. In fact no intree module uses them exactly because they're not intended to be used by this kind of code. Please show the code you want to use this for so we can see what you're really trying to do. Trying to convert a given user value (in milliseconds) to a timeout. No problem doing this with struct timespec. Eike pgpzZU2hCFZ61.pgp Description: PGP signature
