Re: [PATCH] F2FS: Fix the logic of IS_DNODE()

2013-04-08 Thread Jaegeuk Kim 
Hi,

2013-04-07 (일), 12:57 -0400, Zhihui Zhang:
> Signed-off-by: Zhihui Zhang 
> ---
>  fs/f2fs/node.h |2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/f2fs/node.h b/fs/f2fs/node.h
> index afdb130..2be47b2 100644
> --- a/fs/f2fs/node.h
> +++ b/fs/f2fs/node.h
> @@ -239,7 +239,7 @@ static inline bool IS_DNODE(struct page *node_page)
>   return false;
>   if (ofs >= 6 + 2 * NIDS_PER_BLOCK) {
>   ofs -= 6 + 2 * NIDS_PER_BLOCK;
> - if ((long int)ofs % (NIDS_PER_BLOCK + 1))
> + if (!((long int)ofs % (NIDS_PER_BLOCK + 1)))

Great catch!
I'll apply this.
Thank you.

>   return false;
>   }
>   return true;

-- 
Jaegeuk Kim
Samsung



signature.asc
Description: This is a digitally signed message part

Re: [PATCH] F2FS: Fix the logic of IS_DNODE()

2013-04-08 Thread Jaegeuk Kim 
Hi,

2013-04-07 (일), 12:57 -0400, Zhihui Zhang:
 Signed-off-by: Zhihui Zhang zzhs...@gmail.com
 ---
  fs/f2fs/node.h |2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
 
 diff --git a/fs/f2fs/node.h b/fs/f2fs/node.h
 index afdb130..2be47b2 100644
 --- a/fs/f2fs/node.h
 +++ b/fs/f2fs/node.h
 @@ -239,7 +239,7 @@ static inline bool IS_DNODE(struct page *node_page)
   return false;
   if (ofs = 6 + 2 * NIDS_PER_BLOCK) {
   ofs -= 6 + 2 * NIDS_PER_BLOCK;
 - if ((long int)ofs % (NIDS_PER_BLOCK + 1))
 + if (!((long int)ofs % (NIDS_PER_BLOCK + 1)))

Great catch!
I'll apply this.
Thank you.

   return false;
   }
   return true;

-- 
Jaegeuk Kim
Samsung



signature.asc
Description: This is a digitally signed message part

[PATCH] F2FS: Fix the logic of IS_DNODE()

2013-04-07 Thread Zhihui Zhang 
Signed-off-by: Zhihui Zhang 
---
 fs/f2fs/node.h |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/f2fs/node.h b/fs/f2fs/node.h
index afdb130..2be47b2 100644
--- a/fs/f2fs/node.h
+++ b/fs/f2fs/node.h
@@ -239,7 +239,7 @@ static inline bool IS_DNODE(struct page *node_page)
return false;
if (ofs >= 6 + 2 * NIDS_PER_BLOCK) {
ofs -= 6 + 2 * NIDS_PER_BLOCK;
-   if ((long int)ofs % (NIDS_PER_BLOCK + 1))
+   if (!((long int)ofs % (NIDS_PER_BLOCK + 1)))
return false;
}
return true;
-- 
1.7.9.5

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH] F2FS: Fix the logic of IS_DNODE()

2013-04-07 Thread Zhihui Zhang 
Signed-off-by: Zhihui Zhang zzhs...@gmail.com
---
 fs/f2fs/node.h |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/f2fs/node.h b/fs/f2fs/node.h
index afdb130..2be47b2 100644
--- a/fs/f2fs/node.h
+++ b/fs/f2fs/node.h
@@ -239,7 +239,7 @@ static inline bool IS_DNODE(struct page *node_page)
return false;
if (ofs = 6 + 2 * NIDS_PER_BLOCK) {
ofs -= 6 + 2 * NIDS_PER_BLOCK;
-   if ((long int)ofs % (NIDS_PER_BLOCK + 1))
+   if (!((long int)ofs % (NIDS_PER_BLOCK + 1)))
return false;
}
return true;
-- 
1.7.9.5

--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/