Re: [PATCH] Fix compiler warning noise with FORE200E driver

2007-12-13 Thread David Miller 
From: "Tom \"spot\" Callaway" <[EMAIL PROTECTED]>
Date: Thu, 13 Dec 2007 11:21:40 -0500

> gcc throws these warnings with:
> 
> CONFIG_ATM_FORE200E=m
> # CONFIG_ATM_FORE200E_PCA is not set
> 
> drivers/atm/fore200e.c:2695: warning: 'fore200e_pca_detect' defined but
> not used
> drivers/atm/fore200e.c:2748: warning: 'fore200e_pca_remove_one' defined
> but not used
> 
> By moving the #ifdef CONFIG_ATM_FORE200E_PCA around those two functions,
> the compiler warnings are silenced.
> 
> (btw, I'm not subscribed to lkml, so please CC me on any responses,
> although this is a wholly trivial patch, so I'm not expecting any.)
> 
> Signed-off-by: Tom "spot" Callaway <[EMAIL PROTECTED]>

Applied, thanks Tom.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH] Fix compiler warning noise with FORE200E driver

2007-12-13 Thread Tom "spot" Callaway 
gcc throws these warnings with:

CONFIG_ATM_FORE200E=m
# CONFIG_ATM_FORE200E_PCA is not set

drivers/atm/fore200e.c:2695: warning: 'fore200e_pca_detect' defined but
not used
drivers/atm/fore200e.c:2748: warning: 'fore200e_pca_remove_one' defined
but not used

By moving the #ifdef CONFIG_ATM_FORE200E_PCA around those two functions,
the compiler warnings are silenced.

(btw, I'm not subscribed to lkml, so please CC me on any responses,
although this is a wholly trivial patch, so I'm not expecting any.)

Signed-off-by: Tom "spot" Callaway <[EMAIL PROTECTED]>

--- linux-2.6.23.sparc64/drivers/atm/fore200e.c.BAD	2007-12-13 10:45:57.0 -0500
+++ linux-2.6.23.sparc64/drivers/atm/fore200e.c	2007-12-13 10:46:23.0 -0500
@@ -2689,7 +2689,7 @@
 return 0;
 }
 
-
+#ifdef CONFIG_ATM_FORE200E_PCA
 static int __devinit
 fore200e_pca_detect(struct pci_dev *pci_dev, const struct pci_device_id *pci_ent)
 {
@@ -2756,7 +2756,6 @@
 }
 
 
-#ifdef CONFIG_ATM_FORE200E_PCA
 static struct pci_device_id fore200e_pca_tbl[] = {
 { PCI_VENDOR_ID_FORE, PCI_DEVICE_ID_FORE_PCA200E, PCI_ANY_ID, PCI_ANY_ID,
   0, 0, (unsigned long) _bus[0] },

[PATCH] Fix compiler warning noise with FORE200E driver

2007-12-13 Thread Tom spot Callaway 
gcc throws these warnings with:

CONFIG_ATM_FORE200E=m
# CONFIG_ATM_FORE200E_PCA is not set

drivers/atm/fore200e.c:2695: warning: 'fore200e_pca_detect' defined but
not used
drivers/atm/fore200e.c:2748: warning: 'fore200e_pca_remove_one' defined
but not used

By moving the #ifdef CONFIG_ATM_FORE200E_PCA around those two functions,
the compiler warnings are silenced.

(btw, I'm not subscribed to lkml, so please CC me on any responses,
although this is a wholly trivial patch, so I'm not expecting any.)

Signed-off-by: Tom spot Callaway [EMAIL PROTECTED]

--- linux-2.6.23.sparc64/drivers/atm/fore200e.c.BAD	2007-12-13 10:45:57.0 -0500
+++ linux-2.6.23.sparc64/drivers/atm/fore200e.c	2007-12-13 10:46:23.0 -0500
@@ -2689,7 +2689,7 @@
 return 0;
 }
 
-
+#ifdef CONFIG_ATM_FORE200E_PCA
 static int __devinit
 fore200e_pca_detect(struct pci_dev *pci_dev, const struct pci_device_id *pci_ent)
 {
@@ -2756,7 +2756,6 @@
 }
 
 
-#ifdef CONFIG_ATM_FORE200E_PCA
 static struct pci_device_id fore200e_pca_tbl[] = {
 { PCI_VENDOR_ID_FORE, PCI_DEVICE_ID_FORE_PCA200E, PCI_ANY_ID, PCI_ANY_ID,
   0, 0, (unsigned long) fore200e_bus[0] },

Re: [PATCH] Fix compiler warning noise with FORE200E driver

2007-12-13 Thread David Miller 
From: Tom \spot\ Callaway [EMAIL PROTECTED]
Date: Thu, 13 Dec 2007 11:21:40 -0500

 gcc throws these warnings with:
 
 CONFIG_ATM_FORE200E=m
 # CONFIG_ATM_FORE200E_PCA is not set
 
 drivers/atm/fore200e.c:2695: warning: 'fore200e_pca_detect' defined but
 not used
 drivers/atm/fore200e.c:2748: warning: 'fore200e_pca_remove_one' defined
 but not used
 
 By moving the #ifdef CONFIG_ATM_FORE200E_PCA around those two functions,
 the compiler warnings are silenced.
 
 (btw, I'm not subscribed to lkml, so please CC me on any responses,
 although this is a wholly trivial patch, so I'm not expecting any.)
 
 Signed-off-by: Tom spot Callaway [EMAIL PROTECTED]

Applied, thanks Tom.

--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/