Re: [PATCH] GPU-DRM-Exynos: Delete unnecessary checks before two function calls

2015-06-27 Thread SF Markus Elfring 
>> From: Markus Elfring 
>> Date: Wed, 4 Feb 2015 21:54:45 +0100
>>
>> The functions phy_power_on() and vunmap() perform also input
>> parameter validation. Thus the test around their calls is not needed.
>>
>> This issue was detected by using the Coccinelle software.
>>
>> Signed-off-by: Markus Elfring 
>> ---
>>  drivers/gpu/drm/exynos/exynos_dp_core.c   | 6 ++
>>  drivers/gpu/drm/exynos/exynos_drm_fbdev.c | 2 +-
>>  2 files changed, 3 insertions(+), 5 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/exynos/exynos_dp_core.c 
>> b/drivers/gpu/drm/exynos/exynos_dp_core.c
>> index 34d46aa..306cf1d 100644
>> --- a/drivers/gpu/drm/exynos/exynos_dp_core.c
>> +++ b/drivers/gpu/drm/exynos/exynos_dp_core.c
>> @@ -1057,14 +1057,12 @@ static int exynos_dp_create_connector(struct 
>> exynos_drm_display *display,
>>  
>>  static void exynos_dp_phy_init(struct exynos_dp_device *dp)
>>  {
>> -if (dp->phy)
>> -phy_power_on(dp->phy);
>> +phy_power_on(dp->phy);
>>  }
>>  
>>  static void exynos_dp_phy_exit(struct exynos_dp_device *dp)
>>  {
>> -if (dp->phy)
>> -phy_power_off(dp->phy);
>> +phy_power_off(dp->phy);
>>  }
>>  
>>  static void exynos_dp_poweron(struct exynos_drm_display *display)
>> diff --git a/drivers/gpu/drm/exynos/exynos_drm_fbdev.c 
>> b/drivers/gpu/drm/exynos/exynos_drm_fbdev.c
>> index e12ea90..0dd448a 100644
>> --- a/drivers/gpu/drm/exynos/exynos_drm_fbdev.c
>> +++ b/drivers/gpu/drm/exynos/exynos_drm_fbdev.c
>> @@ -313,7 +313,7 @@ static void exynos_drm_fbdev_destroy(struct drm_device 
>> *dev,
>>  struct exynos_drm_gem_obj *exynos_gem_obj = exynos_fbd->exynos_gem_obj;
>>  struct drm_framebuffer *fb;
>>  
>> -if (is_drm_iommu_supported(dev) && exynos_gem_obj->buffer->kvaddr)
>> +if (is_drm_iommu_supported(dev))
>>  vunmap(exynos_gem_obj->buffer->kvaddr);
>>  
>>  /* release drm framebuffer and real buffer */
>>
> 
> Acked-by: Joonyoung Shim 

Do the chances increase to integrate this update suggestion
into another source code repository?

Regards,
Markus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH] GPU-DRM-Exynos: Delete unnecessary checks before two function calls

2015-06-27 Thread SF Markus Elfring 
 From: Markus Elfring elfr...@users.sourceforge.net
 Date: Wed, 4 Feb 2015 21:54:45 +0100

 The functions phy_power_on() and vunmap() perform also input
 parameter validation. Thus the test around their calls is not needed.

 This issue was detected by using the Coccinelle software.

 Signed-off-by: Markus Elfring elfr...@users.sourceforge.net
 ---
  drivers/gpu/drm/exynos/exynos_dp_core.c   | 6 ++
  drivers/gpu/drm/exynos/exynos_drm_fbdev.c | 2 +-
  2 files changed, 3 insertions(+), 5 deletions(-)

 diff --git a/drivers/gpu/drm/exynos/exynos_dp_core.c 
 b/drivers/gpu/drm/exynos/exynos_dp_core.c
 index 34d46aa..306cf1d 100644
 --- a/drivers/gpu/drm/exynos/exynos_dp_core.c
 +++ b/drivers/gpu/drm/exynos/exynos_dp_core.c
 @@ -1057,14 +1057,12 @@ static int exynos_dp_create_connector(struct 
 exynos_drm_display *display,
  
  static void exynos_dp_phy_init(struct exynos_dp_device *dp)
  {
 -if (dp-phy)
 -phy_power_on(dp-phy);
 +phy_power_on(dp-phy);
  }
  
  static void exynos_dp_phy_exit(struct exynos_dp_device *dp)
  {
 -if (dp-phy)
 -phy_power_off(dp-phy);
 +phy_power_off(dp-phy);
  }
  
  static void exynos_dp_poweron(struct exynos_drm_display *display)
 diff --git a/drivers/gpu/drm/exynos/exynos_drm_fbdev.c 
 b/drivers/gpu/drm/exynos/exynos_drm_fbdev.c
 index e12ea90..0dd448a 100644
 --- a/drivers/gpu/drm/exynos/exynos_drm_fbdev.c
 +++ b/drivers/gpu/drm/exynos/exynos_drm_fbdev.c
 @@ -313,7 +313,7 @@ static void exynos_drm_fbdev_destroy(struct drm_device 
 *dev,
  struct exynos_drm_gem_obj *exynos_gem_obj = exynos_fbd-exynos_gem_obj;
  struct drm_framebuffer *fb;
  
 -if (is_drm_iommu_supported(dev)  exynos_gem_obj-buffer-kvaddr)
 +if (is_drm_iommu_supported(dev))
  vunmap(exynos_gem_obj-buffer-kvaddr);
  
  /* release drm framebuffer and real buffer */

 
 Acked-by: Joonyoung Shim jy0922.s...@samsung.com

Do the chances increase to integrate this update suggestion
into another source code repository?

Regards,
Markus
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH] GPU-DRM-Exynos: Delete unnecessary checks before two function calls

2015-02-05 Thread Joonyoung Shim 
Hi,

On 02/05/2015 06:00 AM, SF Markus Elfring wrote:
> From: Markus Elfring 
> Date: Wed, 4 Feb 2015 21:54:45 +0100
> 
> The functions phy_power_on() and vunmap() perform also input
> parameter validation. Thus the test around their calls is not needed.
> 
> This issue was detected by using the Coccinelle software.
> 
> Signed-off-by: Markus Elfring 
> ---
>  drivers/gpu/drm/exynos/exynos_dp_core.c   | 6 ++
>  drivers/gpu/drm/exynos/exynos_drm_fbdev.c | 2 +-
>  2 files changed, 3 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/gpu/drm/exynos/exynos_dp_core.c 
> b/drivers/gpu/drm/exynos/exynos_dp_core.c
> index 34d46aa..306cf1d 100644
> --- a/drivers/gpu/drm/exynos/exynos_dp_core.c
> +++ b/drivers/gpu/drm/exynos/exynos_dp_core.c
> @@ -1057,14 +1057,12 @@ static int exynos_dp_create_connector(struct 
> exynos_drm_display *display,
>  
>  static void exynos_dp_phy_init(struct exynos_dp_device *dp)
>  {
> - if (dp->phy)
> - phy_power_on(dp->phy);
> + phy_power_on(dp->phy);
>  }
>  
>  static void exynos_dp_phy_exit(struct exynos_dp_device *dp)
>  {
> - if (dp->phy)
> - phy_power_off(dp->phy);
> + phy_power_off(dp->phy);
>  }
>  
>  static void exynos_dp_poweron(struct exynos_drm_display *display)
> diff --git a/drivers/gpu/drm/exynos/exynos_drm_fbdev.c 
> b/drivers/gpu/drm/exynos/exynos_drm_fbdev.c
> index e12ea90..0dd448a 100644
> --- a/drivers/gpu/drm/exynos/exynos_drm_fbdev.c
> +++ b/drivers/gpu/drm/exynos/exynos_drm_fbdev.c
> @@ -313,7 +313,7 @@ static void exynos_drm_fbdev_destroy(struct drm_device 
> *dev,
>   struct exynos_drm_gem_obj *exynos_gem_obj = exynos_fbd->exynos_gem_obj;
>   struct drm_framebuffer *fb;
>  
> - if (is_drm_iommu_supported(dev) && exynos_gem_obj->buffer->kvaddr)
> + if (is_drm_iommu_supported(dev))
>   vunmap(exynos_gem_obj->buffer->kvaddr);
>  
>   /* release drm framebuffer and real buffer */
> 

Acked-by: Joonyoung Shim 

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH] GPU-DRM-Exynos: Delete unnecessary checks before two function calls

2015-02-05 Thread Joonyoung Shim 
Hi,

On 02/05/2015 06:00 AM, SF Markus Elfring wrote:
 From: Markus Elfring elfr...@users.sourceforge.net
 Date: Wed, 4 Feb 2015 21:54:45 +0100
 
 The functions phy_power_on() and vunmap() perform also input
 parameter validation. Thus the test around their calls is not needed.
 
 This issue was detected by using the Coccinelle software.
 
 Signed-off-by: Markus Elfring elfr...@users.sourceforge.net
 ---
  drivers/gpu/drm/exynos/exynos_dp_core.c   | 6 ++
  drivers/gpu/drm/exynos/exynos_drm_fbdev.c | 2 +-
  2 files changed, 3 insertions(+), 5 deletions(-)
 
 diff --git a/drivers/gpu/drm/exynos/exynos_dp_core.c 
 b/drivers/gpu/drm/exynos/exynos_dp_core.c
 index 34d46aa..306cf1d 100644
 --- a/drivers/gpu/drm/exynos/exynos_dp_core.c
 +++ b/drivers/gpu/drm/exynos/exynos_dp_core.c
 @@ -1057,14 +1057,12 @@ static int exynos_dp_create_connector(struct 
 exynos_drm_display *display,
  
  static void exynos_dp_phy_init(struct exynos_dp_device *dp)
  {
 - if (dp-phy)
 - phy_power_on(dp-phy);
 + phy_power_on(dp-phy);
  }
  
  static void exynos_dp_phy_exit(struct exynos_dp_device *dp)
  {
 - if (dp-phy)
 - phy_power_off(dp-phy);
 + phy_power_off(dp-phy);
  }
  
  static void exynos_dp_poweron(struct exynos_drm_display *display)
 diff --git a/drivers/gpu/drm/exynos/exynos_drm_fbdev.c 
 b/drivers/gpu/drm/exynos/exynos_drm_fbdev.c
 index e12ea90..0dd448a 100644
 --- a/drivers/gpu/drm/exynos/exynos_drm_fbdev.c
 +++ b/drivers/gpu/drm/exynos/exynos_drm_fbdev.c
 @@ -313,7 +313,7 @@ static void exynos_drm_fbdev_destroy(struct drm_device 
 *dev,
   struct exynos_drm_gem_obj *exynos_gem_obj = exynos_fbd-exynos_gem_obj;
   struct drm_framebuffer *fb;
  
 - if (is_drm_iommu_supported(dev)  exynos_gem_obj-buffer-kvaddr)
 + if (is_drm_iommu_supported(dev))
   vunmap(exynos_gem_obj-buffer-kvaddr);
  
   /* release drm framebuffer and real buffer */
 

Acked-by: Joonyoung Shim jy0922.s...@samsung.com

Thanks.
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH] GPU-DRM-Exynos: Delete unnecessary checks before two function calls

2015-02-04 Thread SF Markus Elfring 
From: Markus Elfring 
Date: Wed, 4 Feb 2015 21:54:45 +0100

The functions phy_power_on() and vunmap() perform also input
parameter validation. Thus the test around their calls is not needed.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring 
---
 drivers/gpu/drm/exynos/exynos_dp_core.c   | 6 ++
 drivers/gpu/drm/exynos/exynos_drm_fbdev.c | 2 +-
 2 files changed, 3 insertions(+), 5 deletions(-)

diff --git a/drivers/gpu/drm/exynos/exynos_dp_core.c 
b/drivers/gpu/drm/exynos/exynos_dp_core.c
index 34d46aa..306cf1d 100644
--- a/drivers/gpu/drm/exynos/exynos_dp_core.c
+++ b/drivers/gpu/drm/exynos/exynos_dp_core.c
@@ -1057,14 +1057,12 @@ static int exynos_dp_create_connector(struct 
exynos_drm_display *display,
 
 static void exynos_dp_phy_init(struct exynos_dp_device *dp)
 {
-   if (dp->phy)
-   phy_power_on(dp->phy);
+   phy_power_on(dp->phy);
 }
 
 static void exynos_dp_phy_exit(struct exynos_dp_device *dp)
 {
-   if (dp->phy)
-   phy_power_off(dp->phy);
+   phy_power_off(dp->phy);
 }
 
 static void exynos_dp_poweron(struct exynos_drm_display *display)
diff --git a/drivers/gpu/drm/exynos/exynos_drm_fbdev.c 
b/drivers/gpu/drm/exynos/exynos_drm_fbdev.c
index e12ea90..0dd448a 100644
--- a/drivers/gpu/drm/exynos/exynos_drm_fbdev.c
+++ b/drivers/gpu/drm/exynos/exynos_drm_fbdev.c
@@ -313,7 +313,7 @@ static void exynos_drm_fbdev_destroy(struct drm_device *dev,
struct exynos_drm_gem_obj *exynos_gem_obj = exynos_fbd->exynos_gem_obj;
struct drm_framebuffer *fb;
 
-   if (is_drm_iommu_supported(dev) && exynos_gem_obj->buffer->kvaddr)
+   if (is_drm_iommu_supported(dev))
vunmap(exynos_gem_obj->buffer->kvaddr);
 
/* release drm framebuffer and real buffer */
-- 
2.2.2

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH] GPU-DRM-Exynos: Delete unnecessary checks before two function calls

2015-02-04 Thread SF Markus Elfring 
From: Markus Elfring elfr...@users.sourceforge.net
Date: Wed, 4 Feb 2015 21:54:45 +0100

The functions phy_power_on() and vunmap() perform also input
parameter validation. Thus the test around their calls is not needed.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring elfr...@users.sourceforge.net
---
 drivers/gpu/drm/exynos/exynos_dp_core.c   | 6 ++
 drivers/gpu/drm/exynos/exynos_drm_fbdev.c | 2 +-
 2 files changed, 3 insertions(+), 5 deletions(-)

diff --git a/drivers/gpu/drm/exynos/exynos_dp_core.c 
b/drivers/gpu/drm/exynos/exynos_dp_core.c
index 34d46aa..306cf1d 100644
--- a/drivers/gpu/drm/exynos/exynos_dp_core.c
+++ b/drivers/gpu/drm/exynos/exynos_dp_core.c
@@ -1057,14 +1057,12 @@ static int exynos_dp_create_connector(struct 
exynos_drm_display *display,
 
 static void exynos_dp_phy_init(struct exynos_dp_device *dp)
 {
-   if (dp-phy)
-   phy_power_on(dp-phy);
+   phy_power_on(dp-phy);
 }
 
 static void exynos_dp_phy_exit(struct exynos_dp_device *dp)
 {
-   if (dp-phy)
-   phy_power_off(dp-phy);
+   phy_power_off(dp-phy);
 }
 
 static void exynos_dp_poweron(struct exynos_drm_display *display)
diff --git a/drivers/gpu/drm/exynos/exynos_drm_fbdev.c 
b/drivers/gpu/drm/exynos/exynos_drm_fbdev.c
index e12ea90..0dd448a 100644
--- a/drivers/gpu/drm/exynos/exynos_drm_fbdev.c
+++ b/drivers/gpu/drm/exynos/exynos_drm_fbdev.c
@@ -313,7 +313,7 @@ static void exynos_drm_fbdev_destroy(struct drm_device *dev,
struct exynos_drm_gem_obj *exynos_gem_obj = exynos_fbd-exynos_gem_obj;
struct drm_framebuffer *fb;
 
-   if (is_drm_iommu_supported(dev)  exynos_gem_obj-buffer-kvaddr)
+   if (is_drm_iommu_supported(dev))
vunmap(exynos_gem_obj-buffer-kvaddr);
 
/* release drm framebuffer and real buffer */
-- 
2.2.2

--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/