Re: [PATCH] GPU-DRM-IMX: Delete an unnecessary check before drm_fbdev_cma_restore_mode()

[Philipp Zabel]

Am Sonntag, den 05.07.2015, 22:50 +0200 schrieb SF Markus Elfring:
> From: Markus Elfring 
> Date: Sun, 5 Jul 2015 22:45:23 +0200
> 
> The drm_fbdev_cma_restore_mode() function tests whether its argument
> is NULL and then returns immediately.
> Thus the test around the call is not needed.
> 
> This issue was detected by using the Coccinelle software.
> 
> Signed-off-by: Markus Elfring 
> ---
>  drivers/gpu/drm/imx/imx-drm-core.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/imx/imx-drm-core.c 
> b/drivers/gpu/drm/imx/imx-drm-core.c
> index 74f505b..9172c0e 100644
> --- a/drivers/gpu/drm/imx/imx-drm-core.c
> +++ b/drivers/gpu/drm/imx/imx-drm-core.c
> @@ -63,8 +63,7 @@ static void imx_drm_driver_lastclose(struct drm_device *drm)
>  #if IS_ENABLED(CONFIG_DRM_IMX_FB_HELPER)
>   struct imx_drm_device *imxdrm = drm->dev_private;
>  
> - if (imxdrm->fbhelper)
> - drm_fbdev_cma_restore_mode(imxdrm->fbhelper);
> + drm_fbdev_cma_restore_mode(imxdrm->fbhelper);
>  #endif
>  }
>  

Applied, sorry I missed this before.

regards
Philipp

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH] GPU-DRM-IMX: Delete an unnecessary check before drm_fbdev_cma_restore_mode()

[Philipp Zabel]

Am Sonntag, den 05.07.2015, 22:50 +0200 schrieb SF Markus Elfring:
> From: Markus Elfring 
> Date: Sun, 5 Jul 2015 22:45:23 +0200
> 
> The drm_fbdev_cma_restore_mode() function tests whether its argument
> is NULL and then returns immediately.
> Thus the test around the call is not needed.
> 
> This issue was detected by using the Coccinelle software.
> 
> Signed-off-by: Markus Elfring 
> ---
>  drivers/gpu/drm/imx/imx-drm-core.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/imx/imx-drm-core.c 
> b/drivers/gpu/drm/imx/imx-drm-core.c
> index 74f505b..9172c0e 100644
> --- a/drivers/gpu/drm/imx/imx-drm-core.c
> +++ b/drivers/gpu/drm/imx/imx-drm-core.c
> @@ -63,8 +63,7 @@ static void imx_drm_driver_lastclose(struct drm_device *drm)
>  #if IS_ENABLED(CONFIG_DRM_IMX_FB_HELPER)
>   struct imx_drm_device *imxdrm = drm->dev_private;
>  
> - if (imxdrm->fbhelper)
> - drm_fbdev_cma_restore_mode(imxdrm->fbhelper);
> + drm_fbdev_cma_restore_mode(imxdrm->fbhelper);
>  #endif
>  }
>  

Applied, sorry I missed this before.

regards
Philipp

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH] GPU-DRM-IMX: Delete an unnecessary check before drm_fbdev_cma_restore_mode()

[SF Markus Elfring]

From: Markus Elfring 
Date: Sun, 5 Jul 2015 22:45:23 +0200

The drm_fbdev_cma_restore_mode() function tests whether its argument
is NULL and then returns immediately.
Thus the test around the call is not needed.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring 
---
 drivers/gpu/drm/imx/imx-drm-core.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/imx/imx-drm-core.c 
b/drivers/gpu/drm/imx/imx-drm-core.c
index 74f505b..9172c0e 100644
--- a/drivers/gpu/drm/imx/imx-drm-core.c
+++ b/drivers/gpu/drm/imx/imx-drm-core.c
@@ -63,8 +63,7 @@ static void imx_drm_driver_lastclose(struct drm_device *drm)
 #if IS_ENABLED(CONFIG_DRM_IMX_FB_HELPER)
struct imx_drm_device *imxdrm = drm->dev_private;
 
-   if (imxdrm->fbhelper)
-   drm_fbdev_cma_restore_mode(imxdrm->fbhelper);
+   drm_fbdev_cma_restore_mode(imxdrm->fbhelper);
 #endif
 }
 
-- 
2.4.5

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH] GPU-DRM-IMX: Delete an unnecessary check before drm_fbdev_cma_restore_mode()

[SF Markus Elfring]

From: Markus Elfring elfr...@users.sourceforge.net
Date: Sun, 5 Jul 2015 22:45:23 +0200

The drm_fbdev_cma_restore_mode() function tests whether its argument
is NULL and then returns immediately.
Thus the test around the call is not needed.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring elfr...@users.sourceforge.net
---
 drivers/gpu/drm/imx/imx-drm-core.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/imx/imx-drm-core.c 
b/drivers/gpu/drm/imx/imx-drm-core.c
index 74f505b..9172c0e 100644
--- a/drivers/gpu/drm/imx/imx-drm-core.c
+++ b/drivers/gpu/drm/imx/imx-drm-core.c
@@ -63,8 +63,7 @@ static void imx_drm_driver_lastclose(struct drm_device *drm)
 #if IS_ENABLED(CONFIG_DRM_IMX_FB_HELPER)
struct imx_drm_device *imxdrm = drm-dev_private;
 
-   if (imxdrm-fbhelper)
-   drm_fbdev_cma_restore_mode(imxdrm-fbhelper);
+   drm_fbdev_cma_restore_mode(imxdrm-fbhelper);
 #endif
 }
 
-- 
2.4.5

--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/