Re: [PATCH] Input: cap1106 - fix register definition
On Tue, Sep 02, 2014 at 01:01:11PM +0200, Klaus Goger wrote: > On Sep 2, 2014, at 9:43 AM, Daniel Mack wrote: > > On 09/02/2014 08:32 AM, Klaus Goger wrote: > >> Use the correct register address for Calibration Active and Interrupt > >> Enable > >> > >> Signed-off-by: Klaus Goger > > > > These register definitions are currently unused, but your fix is > > correct. Just curious - are you planning to send patches that make use > > of them? > > I want to use CAP1106_REG_SENSITIVITY_CONTROL but I have yet to > decide how to expose it to the user. Probably adding another device tree > option. But somehow it feels like cluttering up the dts. > Once I have settled about that I will send patches. Applied, thank you. -- Dmitry -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] Input: cap1106 - fix register definition
On Tue, Sep 02, 2014 at 01:01:11PM +0200, Klaus Goger wrote: On Sep 2, 2014, at 9:43 AM, Daniel Mack zon...@gmail.com wrote: On 09/02/2014 08:32 AM, Klaus Goger wrote: Use the correct register address for Calibration Active and Interrupt Enable Signed-off-by: Klaus Goger klaus.go...@theobroma-systems.com These register definitions are currently unused, but your fix is correct. Just curious - are you planning to send patches that make use of them? I want to use CAP1106_REG_SENSITIVITY_CONTROL but I have yet to decide how to expose it to the user. Probably adding another device tree option. But somehow it feels like cluttering up the dts. Once I have settled about that I will send patches. Applied, thank you. -- Dmitry -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] Input: cap1106 - fix register definition
On Sep 2, 2014, at 9:43 AM, Daniel Mack wrote: > On 09/02/2014 08:32 AM, Klaus Goger wrote: >> Use the correct register address for Calibration Active and Interrupt >> Enable >> >> Signed-off-by: Klaus Goger > > These register definitions are currently unused, but your fix is > correct. Just curious - are you planning to send patches that make use > of them? I want to use CAP1106_REG_SENSITIVITY_CONTROL but I have yet to decide how to expose it to the user. Probably adding another device tree option. But somehow it feels like cluttering up the dts. Once I have settled about that I will send patches. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] Input: cap1106 - fix register definition
On 09/02/2014 08:32 AM, Klaus Goger wrote: > Use the correct register address for Calibration Active and Interrupt > Enable > > Signed-off-by: Klaus Goger These register definitions are currently unused, but your fix is correct. Just curious - are you planning to send patches that make use of them? Acked-by: Daniel Mack Thanks, Daniel > --- > drivers/input/keyboard/cap1106.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/input/keyboard/cap1106.c > b/drivers/input/keyboard/cap1106.c > index 180b184..d70b65a 100644 > --- a/drivers/input/keyboard/cap1106.c > +++ b/drivers/input/keyboard/cap1106.c > @@ -33,8 +33,8 @@ > #define CAP1106_REG_SENSOR_CONFIG0x22 > #define CAP1106_REG_SENSOR_CONFIG2 0x23 > #define CAP1106_REG_SAMPLING_CONFIG 0x24 > -#define CAP1106_REG_CALIBRATION 0x25 > -#define CAP1106_REG_INT_ENABLE 0x26 > +#define CAP1106_REG_CALIBRATION 0x26 > +#define CAP1106_REG_INT_ENABLE 0x27 > #define CAP1106_REG_REPEAT_RATE 0x28 > #define CAP1106_REG_MT_CONFIG0x2a > #define CAP1106_REG_MT_PATTERN_CONFIG0x2b > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH] Input: cap1106 - fix register definition
Use the correct register address for Calibration Active and Interrupt Enable Signed-off-by: Klaus Goger --- drivers/input/keyboard/cap1106.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/input/keyboard/cap1106.c b/drivers/input/keyboard/cap1106.c index 180b184..d70b65a 100644 --- a/drivers/input/keyboard/cap1106.c +++ b/drivers/input/keyboard/cap1106.c @@ -33,8 +33,8 @@ #define CAP1106_REG_SENSOR_CONFIG 0x22 #define CAP1106_REG_SENSOR_CONFIG2 0x23 #define CAP1106_REG_SAMPLING_CONFIG0x24 -#define CAP1106_REG_CALIBRATION0x25 -#define CAP1106_REG_INT_ENABLE 0x26 +#define CAP1106_REG_CALIBRATION0x26 +#define CAP1106_REG_INT_ENABLE 0x27 #define CAP1106_REG_REPEAT_RATE0x28 #define CAP1106_REG_MT_CONFIG 0x2a #define CAP1106_REG_MT_PATTERN_CONFIG 0x2b -- 1.9.0 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH] Input: cap1106 - fix register definition
Use the correct register address for Calibration Active and Interrupt Enable Signed-off-by: Klaus Goger klaus.go...@theobroma-systems.com --- drivers/input/keyboard/cap1106.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/input/keyboard/cap1106.c b/drivers/input/keyboard/cap1106.c index 180b184..d70b65a 100644 --- a/drivers/input/keyboard/cap1106.c +++ b/drivers/input/keyboard/cap1106.c @@ -33,8 +33,8 @@ #define CAP1106_REG_SENSOR_CONFIG 0x22 #define CAP1106_REG_SENSOR_CONFIG2 0x23 #define CAP1106_REG_SAMPLING_CONFIG0x24 -#define CAP1106_REG_CALIBRATION0x25 -#define CAP1106_REG_INT_ENABLE 0x26 +#define CAP1106_REG_CALIBRATION0x26 +#define CAP1106_REG_INT_ENABLE 0x27 #define CAP1106_REG_REPEAT_RATE0x28 #define CAP1106_REG_MT_CONFIG 0x2a #define CAP1106_REG_MT_PATTERN_CONFIG 0x2b -- 1.9.0 -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] Input: cap1106 - fix register definition
On 09/02/2014 08:32 AM, Klaus Goger wrote: Use the correct register address for Calibration Active and Interrupt Enable Signed-off-by: Klaus Goger klaus.go...@theobroma-systems.com These register definitions are currently unused, but your fix is correct. Just curious - are you planning to send patches that make use of them? Acked-by: Daniel Mack zon...@gmail.com Thanks, Daniel --- drivers/input/keyboard/cap1106.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/input/keyboard/cap1106.c b/drivers/input/keyboard/cap1106.c index 180b184..d70b65a 100644 --- a/drivers/input/keyboard/cap1106.c +++ b/drivers/input/keyboard/cap1106.c @@ -33,8 +33,8 @@ #define CAP1106_REG_SENSOR_CONFIG0x22 #define CAP1106_REG_SENSOR_CONFIG2 0x23 #define CAP1106_REG_SAMPLING_CONFIG 0x24 -#define CAP1106_REG_CALIBRATION 0x25 -#define CAP1106_REG_INT_ENABLE 0x26 +#define CAP1106_REG_CALIBRATION 0x26 +#define CAP1106_REG_INT_ENABLE 0x27 #define CAP1106_REG_REPEAT_RATE 0x28 #define CAP1106_REG_MT_CONFIG0x2a #define CAP1106_REG_MT_PATTERN_CONFIG0x2b -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] Input: cap1106 - fix register definition
On Sep 2, 2014, at 9:43 AM, Daniel Mack zon...@gmail.com wrote: On 09/02/2014 08:32 AM, Klaus Goger wrote: Use the correct register address for Calibration Active and Interrupt Enable Signed-off-by: Klaus Goger klaus.go...@theobroma-systems.com These register definitions are currently unused, but your fix is correct. Just curious - are you planning to send patches that make use of them? I want to use CAP1106_REG_SENSITIVITY_CONTROL but I have yet to decide how to expose it to the user. Probably adding another device tree option. But somehow it feels like cluttering up the dts. Once I have settled about that I will send patches. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
