Re: [PATCH] Input: elants_i2c - zero-extend hardware ID in firmware name
On Fri, Apr 17, 2015 at 8:43 PM, Dmitry Torokhov wrote: > Let's zero-extend hardware id number when forming firmware file name, > to avoid kernel requesting firmware like "elants_i2c_ 0.bin", which > is quite unexpected. > > Signed-off-by: Dmitry Torokhov Reviewed-by: Benson Leung -- Benson Leung Software Engineer, Chrom* OS ble...@chromium.org -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] Input: elants_i2c - zero-extend hardware ID in firmware name
On Fri, Apr 17, 2015 at 8:43 PM, Dmitry Torokhov wrote: > Let's zero-extend hardware id number when forming firmware file name, > to avoid kernel requesting firmware like "elants_i2c_ 0.bin", which > is quite unexpected. > > Signed-off-by: Dmitry Torokhov > --- > drivers/input/touchscreen/elants_i2c.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/input/touchscreen/elants_i2c.c > b/drivers/input/touchscreen/elants_i2c.c > index 43b3c9c..0efd766 100644 > --- a/drivers/input/touchscreen/elants_i2c.c > +++ b/drivers/input/touchscreen/elants_i2c.c > @@ -699,7 +699,7 @@ static int elants_i2c_fw_update(struct elants_data *ts) > char *fw_name; > int error; > > - fw_name = kasprintf(GFP_KERNEL, "elants_i2c_%4x.bin", ts->hw_version); > + fw_name = kasprintf(GFP_KERNEL, "elants_i2c_%04x.bin", > ts->hw_version); > if (!fw_name) > return -ENOMEM; > > -- > 2.2.0.rc0.207.ga3a616c > > > -- > Dmitry Looks good to me. Acked-by: Charlie Mooney -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] Input: elants_i2c - zero-extend hardware ID in firmware name
On Fri, Apr 17, 2015 at 8:43 PM, Dmitry Torokhov dmitry.torok...@gmail.com wrote: Let's zero-extend hardware id number when forming firmware file name, to avoid kernel requesting firmware like elants_i2c_ 0.bin, which is quite unexpected. Signed-off-by: Dmitry Torokhov dmitry.torok...@gmail.com --- drivers/input/touchscreen/elants_i2c.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/input/touchscreen/elants_i2c.c b/drivers/input/touchscreen/elants_i2c.c index 43b3c9c..0efd766 100644 --- a/drivers/input/touchscreen/elants_i2c.c +++ b/drivers/input/touchscreen/elants_i2c.c @@ -699,7 +699,7 @@ static int elants_i2c_fw_update(struct elants_data *ts) char *fw_name; int error; - fw_name = kasprintf(GFP_KERNEL, elants_i2c_%4x.bin, ts-hw_version); + fw_name = kasprintf(GFP_KERNEL, elants_i2c_%04x.bin, ts-hw_version); if (!fw_name) return -ENOMEM; -- 2.2.0.rc0.207.ga3a616c -- Dmitry Looks good to me. Acked-by: Charlie Mooneycharliemoo...@chromium.org -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] Input: elants_i2c - zero-extend hardware ID in firmware name
On Fri, Apr 17, 2015 at 8:43 PM, Dmitry Torokhov dmitry.torok...@gmail.com wrote: Let's zero-extend hardware id number when forming firmware file name, to avoid kernel requesting firmware like elants_i2c_ 0.bin, which is quite unexpected. Signed-off-by: Dmitry Torokhov dmitry.torok...@gmail.com Reviewed-by: Benson Leung ble...@chromium.org -- Benson Leung Software Engineer, Chrom* OS ble...@chromium.org -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH] Input: elants_i2c - zero-extend hardware ID in firmware name
Let's zero-extend hardware id number when forming firmware file name, to avoid kernel requesting firmware like "elants_i2c_ 0.bin", which is quite unexpected. Signed-off-by: Dmitry Torokhov --- drivers/input/touchscreen/elants_i2c.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/input/touchscreen/elants_i2c.c b/drivers/input/touchscreen/elants_i2c.c index 43b3c9c..0efd766 100644 --- a/drivers/input/touchscreen/elants_i2c.c +++ b/drivers/input/touchscreen/elants_i2c.c @@ -699,7 +699,7 @@ static int elants_i2c_fw_update(struct elants_data *ts) char *fw_name; int error; - fw_name = kasprintf(GFP_KERNEL, "elants_i2c_%4x.bin", ts->hw_version); + fw_name = kasprintf(GFP_KERNEL, "elants_i2c_%04x.bin", ts->hw_version); if (!fw_name) return -ENOMEM; -- 2.2.0.rc0.207.ga3a616c -- Dmitry -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH] Input: elants_i2c - zero-extend hardware ID in firmware name
Let's zero-extend hardware id number when forming firmware file name, to avoid kernel requesting firmware like elants_i2c_ 0.bin, which is quite unexpected. Signed-off-by: Dmitry Torokhov dmitry.torok...@gmail.com --- drivers/input/touchscreen/elants_i2c.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/input/touchscreen/elants_i2c.c b/drivers/input/touchscreen/elants_i2c.c index 43b3c9c..0efd766 100644 --- a/drivers/input/touchscreen/elants_i2c.c +++ b/drivers/input/touchscreen/elants_i2c.c @@ -699,7 +699,7 @@ static int elants_i2c_fw_update(struct elants_data *ts) char *fw_name; int error; - fw_name = kasprintf(GFP_KERNEL, elants_i2c_%4x.bin, ts-hw_version); + fw_name = kasprintf(GFP_KERNEL, elants_i2c_%04x.bin, ts-hw_version); if (!fw_name) return -ENOMEM; -- 2.2.0.rc0.207.ga3a616c -- Dmitry -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
