Re: [PATCH] MAINTAINERS: update audit files

2021-03-12 Thread Richard Guy Briggs
On 2021-03-12 16:38, Paul Moore wrote:
> On Thu, Mar 11, 2021 at 11:41 AM Richard Guy Briggs  wrote:
> > Add files maintaned by the audit subsystem.
> >
> > Signed-off-by: Richard Guy Briggs 
> > ---
> >  MAINTAINERS | 4 
> >  1 file changed, 4 insertions(+)
> >
> > diff --git a/MAINTAINERS b/MAINTAINERS
> > index 6eff4f720c72..a17532559665 100644
> > --- a/MAINTAINERS
> > +++ b/MAINTAINERS
> > @@ -3015,9 +3015,13 @@ L:   linux-au...@redhat.com (moderated for 
> > non-subscribers)
> >  S: Supported
> >  W: https://github.com/linux-audit
> >  T: git git://git.kernel.org/pub/scm/linux/kernel/git/pcmoore/audit.git
> > +F: arch/*/*/*audit*.[ch]
> 
> That looks like it has about two too many wildcards to hold up over time :)
> 
> I understand what you're trying to do here, and while I don't disagree
> in principle, I worry that the arch specific paths vary enough that
> trying to handle it here is going to be a bit of a mess.
> 
> > +F: arch/x86/include/asm/audit.h
> 
> The fact that we need a special entry for the single header under x86
> tends to reinforce that.  The other additions make sense, but I think
> it may be best to leave the arch specific areas alone for now.

Ok, I should have labelled this "RFC".  :-)

> > +F: include/asm-generic/audit_*.h
> >  F: include/linux/audit.h
> >  F: include/uapi/linux/audit.h
> >  F: kernel/audit*
> > +F: lib/*audit.c
> >
> >  AUXILIARY DISPLAY DRIVERS
> >  M: Miguel Ojeda Sandonis 
> > --
> > 2.27.0
> 
> paul moore

- RGB

--
Richard Guy Briggs 
Sr. S/W Engineer, Kernel Security, Base Operating Systems
Remote, Ottawa, Red Hat Canada
IRC: rgb, SunRaycer
Voice: +1.647.777.2635, Internal: (81) 32635



Re: [PATCH] MAINTAINERS: update audit files

2021-03-12 Thread Paul Moore
On Thu, Mar 11, 2021 at 11:41 AM Richard Guy Briggs  wrote:
>
> Add files maintaned by the audit subsystem.
>
> Signed-off-by: Richard Guy Briggs 
> ---
>  MAINTAINERS | 4 
>  1 file changed, 4 insertions(+)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 6eff4f720c72..a17532559665 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -3015,9 +3015,13 @@ L:   linux-au...@redhat.com (moderated for 
> non-subscribers)
>  S: Supported
>  W: https://github.com/linux-audit
>  T: git git://git.kernel.org/pub/scm/linux/kernel/git/pcmoore/audit.git
> +F: arch/*/*/*audit*.[ch]

That looks like it has about two too many wildcards to hold up over time :)

I understand what you're trying to do here, and while I don't disagree
in principle, I worry that the arch specific paths vary enough that
trying to handle it here is going to be a bit of a mess.

> +F: arch/x86/include/asm/audit.h

The fact that we need a special entry for the single header under x86
tends to reinforce that.  The other additions make sense, but I think
it may be best to leave the arch specific areas alone for now.

> +F: include/asm-generic/audit_*.h
>  F: include/linux/audit.h
>  F: include/uapi/linux/audit.h
>  F: kernel/audit*
> +F: lib/*audit.c
>
>  AUXILIARY DISPLAY DRIVERS
>  M: Miguel Ojeda Sandonis 
> --
> 2.27.0

-- 
paul moore
www.paul-moore.com


[PATCH] MAINTAINERS: update audit files

2021-03-11 Thread Richard Guy Briggs
Add files maintaned by the audit subsystem.

Signed-off-by: Richard Guy Briggs 
---
 MAINTAINERS | 4 
 1 file changed, 4 insertions(+)

diff --git a/MAINTAINERS b/MAINTAINERS
index 6eff4f720c72..a17532559665 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -3015,9 +3015,13 @@ L:   linux-au...@redhat.com (moderated for 
non-subscribers)
 S: Supported
 W: https://github.com/linux-audit
 T: git git://git.kernel.org/pub/scm/linux/kernel/git/pcmoore/audit.git
+F: arch/*/*/*audit*.[ch]
+F: arch/x86/include/asm/audit.h
+F: include/asm-generic/audit_*.h
 F: include/linux/audit.h
 F: include/uapi/linux/audit.h
 F: kernel/audit*
+F: lib/*audit.c
 
 AUXILIARY DISPLAY DRIVERS
 M: Miguel Ojeda Sandonis 
-- 
2.27.0