Re: [PATCH] MIPS: CI20: DTS: Correcting IW8103 Wifi binding
Hi Alexandre,
> Am 06.07.2020 um 22:22 schrieb Alexandre GRIVEAUX :
>
> Le 06/07/2020 à 13:15, H. Nikolaus Schaller a écrit :
>> Hi Alexandre,
>>
>>> Am 05.07.2020 um 12:32 schrieb agrive...@deutnet.info:
>>>
>>> From: Alexandre GRIVEAUX
>>>
>>> Use brcm,bcm4329-fmac instead of brcm,bcm4330-fmac.
>>>
>>> Signed-off-by: Alexandre GRIVEAUX
>>> ---
>>> arch/mips/boot/dts/ingenic/ci20.dts | 4 ++--
>>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/arch/mips/boot/dts/ingenic/ci20.dts
>>> b/arch/mips/boot/dts/ingenic/ci20.dts
>>> index 75f5bfbf2c37..82a1f126b778 100644
>>> --- a/arch/mips/boot/dts/ingenic/ci20.dts
>>> +++ b/arch/mips/boot/dts/ingenic/ci20.dts
>>> @@ -116,8 +116,8 @@
>>> pinctrl-0 = <_mmc1>;
>>>
>>> brcmf: wifi@1 {
>>> -/* reg = <4>;*/
>>> - compatible = "brcm,bcm4330-fmac";
>>> + reg = <1>;
>>> + compatible = "brcm,bcm4329-fmac";
>>> vcc-supply = <_power>;
>>> device-wakeup-gpios = < 9 GPIO_ACTIVE_HIGH>;
>>> shutdown-gpios = < 7 GPIO_ACTIVE_LOW>;
>> Do you have it working with a v5.8 kernel?
>>
>> I don't see any activity to detect the module or load firmware.
>>
>> Does it rely on some other patch?
>>
>> BR and thanks,
>> Nikolaus
>>
> Hi Nikolaus
>
>
> At this time the patch have been only "tested" for error will doing make:
>
> make ARCH=mips CROSS_COMPILE=mipsel-linux-gnu- olddefconfig && make
> ARCH=mips CROSS_COMPILE=mipsel-linux-gnu- -j8 && make ARCH=mips
> CROSS_COMPILE=mipsel-linux-gnu- -j8 uImage
>
>
> The .config come from creator-ci20 kernel 'config-3.18.3-ci20-1'
>
>
> Even with the right DT
> (Documentation/devicetree/bindings/net/wireless/brcm,bcm43xx-fmac.txt)
> it's need some config with brcm enabled I gess.
>
>
> I need to do some investigation will trying the uImage this week,
> unfortunaly kernel developpement is not my main work, it's a hobby.
No problem. For me, the CI20 is also a hobby project :)
Here is some information about the CI20 WiFi and firmware:
https://elinux.org/CI20_Hardware#WiFi.2FBT
https://elinux.org/CI20_upstream#WiFi_firmware
So to be it looks as if the
compatible = "brcm,bcm4330-fmac";
is correct. But the reg = <4> or <1> is something we have to find out.
BR,
Nikolaus
Re: [PATCH] MIPS: CI20: DTS: Correcting IW8103 Wifi binding
Le 06/07/2020 à 13:15, H. Nikolaus Schaller a écrit :
> Hi Alexandre,
>
>> Am 05.07.2020 um 12:32 schrieb agrive...@deutnet.info:
>>
>> From: Alexandre GRIVEAUX
>>
>> Use brcm,bcm4329-fmac instead of brcm,bcm4330-fmac.
>>
>> Signed-off-by: Alexandre GRIVEAUX
>> ---
>> arch/mips/boot/dts/ingenic/ci20.dts | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/arch/mips/boot/dts/ingenic/ci20.dts
>> b/arch/mips/boot/dts/ingenic/ci20.dts
>> index 75f5bfbf2c37..82a1f126b778 100644
>> --- a/arch/mips/boot/dts/ingenic/ci20.dts
>> +++ b/arch/mips/boot/dts/ingenic/ci20.dts
>> @@ -116,8 +116,8 @@
>> pinctrl-0 = <_mmc1>;
>>
>> brcmf: wifi@1 {
>> -/* reg = <4>;*/
>> -compatible = "brcm,bcm4330-fmac";
>> +reg = <1>;
>> +compatible = "brcm,bcm4329-fmac";
>> vcc-supply = <_power>;
>> device-wakeup-gpios = < 9 GPIO_ACTIVE_HIGH>;
>> shutdown-gpios = < 7 GPIO_ACTIVE_LOW>;
> Do you have it working with a v5.8 kernel?
>
> I don't see any activity to detect the module or load firmware.
>
> Does it rely on some other patch?
>
> BR and thanks,
> Nikolaus
>
Hi Nikolaus
At this time the patch have been only "tested" for error will doing make:
make ARCH=mips CROSS_COMPILE=mipsel-linux-gnu- olddefconfig && make
ARCH=mips CROSS_COMPILE=mipsel-linux-gnu- -j8 && make ARCH=mips
CROSS_COMPILE=mipsel-linux-gnu- -j8 uImage
The .config come from creator-ci20 kernel 'config-3.18.3-ci20-1'
Even with the right DT
(Documentation/devicetree/bindings/net/wireless/brcm,bcm43xx-fmac.txt)
it's need some config with brcm enabled I gess.
I need to do some investigation will trying the uImage this week,
unfortunaly kernel developpement is not my main work, it's a hobby.
Thanks.
Re: [PATCH] MIPS: CI20: DTS: Correcting IW8103 Wifi binding
Hi Alexandre,
> Am 05.07.2020 um 12:32 schrieb agrive...@deutnet.info:
>
> From: Alexandre GRIVEAUX
>
> Use brcm,bcm4329-fmac instead of brcm,bcm4330-fmac.
>
> Signed-off-by: Alexandre GRIVEAUX
> ---
> arch/mips/boot/dts/ingenic/ci20.dts | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/mips/boot/dts/ingenic/ci20.dts
> b/arch/mips/boot/dts/ingenic/ci20.dts
> index 75f5bfbf2c37..82a1f126b778 100644
> --- a/arch/mips/boot/dts/ingenic/ci20.dts
> +++ b/arch/mips/boot/dts/ingenic/ci20.dts
> @@ -116,8 +116,8 @@
> pinctrl-0 = <_mmc1>;
>
> brcmf: wifi@1 {
> -/* reg = <4>;*/
> - compatible = "brcm,bcm4330-fmac";
> + reg = <1>;
> + compatible = "brcm,bcm4329-fmac";
> vcc-supply = <_power>;
> device-wakeup-gpios = < 9 GPIO_ACTIVE_HIGH>;
> shutdown-gpios = < 7 GPIO_ACTIVE_LOW>;
Do you have it working with a v5.8 kernel?
I don't see any activity to detect the module or load firmware.
Does it rely on some other patch?
BR and thanks,
Nikolaus
[PATCH] MIPS: CI20: DTS: Correcting IW8103 Wifi binding
From: Alexandre GRIVEAUX
Use brcm,bcm4329-fmac instead of brcm,bcm4330-fmac.
Signed-off-by: Alexandre GRIVEAUX
---
arch/mips/boot/dts/ingenic/ci20.dts | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/mips/boot/dts/ingenic/ci20.dts
b/arch/mips/boot/dts/ingenic/ci20.dts
index 75f5bfbf2c37..82a1f126b778 100644
--- a/arch/mips/boot/dts/ingenic/ci20.dts
+++ b/arch/mips/boot/dts/ingenic/ci20.dts
@@ -116,8 +116,8 @@
pinctrl-0 = <_mmc1>;
brcmf: wifi@1 {
-/* reg = <4>;*/
- compatible = "brcm,bcm4330-fmac";
+ reg = <1>;
+ compatible = "brcm,bcm4329-fmac";
vcc-supply = <_power>;
device-wakeup-gpios = < 9 GPIO_ACTIVE_HIGH>;
shutdown-gpios = < 7 GPIO_ACTIVE_LOW>;
--
2.20.1
