Re: [PATCH] MIPS: Loongson1B: Change the OSC clock name

[Stephen Boyd]

On 08/16, Kelvin Cheung wrote:
> Hi Stephen,
> 
> 2016-08-16 7:28 GMT+08:00 Stephen Boyd :
> 
> > On 08/12, Keguang Zhang wrote:
> > > From: Kelvin Cheung 
> > >
> > > This patch changes the OSC clock name to "osc_clk".
> > >
> > > Signed-off-by: Kelvin Cheung 
> > > ---
> >
> > Yes, but why?
> >
> >
> Loongson1C uses a 24MHz oscillator, hence "osc_clk" sounds more appropriate
> 
> 

So then should we replace all the osc_33m_clk names with osc_clk?
This patch only modifies one name and it looks like a clkdev
lookup is created that still has osc_33m_clk for the connection
name in drivers/clk/clk-ls1x.c, so merging it would mean things
break? I also wonder what the pin is actually called in the
datasheet, because that should be what the cpufreq driver uses in
clk_get() as the connection id. If that's osc_33m_clk then it's
better to leave it alone even if the frequency is different.

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project

Re: [PATCH] MIPS: Loongson1B: Change the OSC clock name

[Stephen Boyd]

On 08/16, Kelvin Cheung wrote:
> Hi Stephen,
> 
> 2016-08-16 7:28 GMT+08:00 Stephen Boyd :
> 
> > On 08/12, Keguang Zhang wrote:
> > > From: Kelvin Cheung 
> > >
> > > This patch changes the OSC clock name to "osc_clk".
> > >
> > > Signed-off-by: Kelvin Cheung 
> > > ---
> >
> > Yes, but why?
> >
> >
> Loongson1C uses a 24MHz oscillator, hence "osc_clk" sounds more appropriate
> 
> 

So then should we replace all the osc_33m_clk names with osc_clk?
This patch only modifies one name and it looks like a clkdev
lookup is created that still has osc_33m_clk for the connection
name in drivers/clk/clk-ls1x.c, so merging it would mean things
break? I also wonder what the pin is actually called in the
datasheet, because that should be what the cpufreq driver uses in
clk_get() as the connection id. If that's osc_33m_clk then it's
better to leave it alone even if the frequency is different.

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project

Re: [PATCH] MIPS: Loongson1B: Change the OSC clock name

[Stephen Boyd]

On 08/12, Keguang Zhang wrote:
> From: Kelvin Cheung 
> 
> This patch changes the OSC clock name to "osc_clk".
> 
> Signed-off-by: Kelvin Cheung 
> ---

Yes, but why?

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project

Re: [PATCH] MIPS: Loongson1B: Change the OSC clock name

[Stephen Boyd]

On 08/12, Keguang Zhang wrote:
> From: Kelvin Cheung 
> 
> This patch changes the OSC clock name to "osc_clk".
> 
> Signed-off-by: Kelvin Cheung 
> ---

Yes, but why?

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project

[PATCH] MIPS: Loongson1B: Change the OSC clock name

[Keguang Zhang]

From: Kelvin Cheung 

This patch changes the OSC clock name to "osc_clk".

Signed-off-by: Kelvin Cheung 
---
 arch/mips/loongson32/common/platform.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/mips/loongson32/common/platform.c 
b/arch/mips/loongson32/common/platform.c
index 4d12e36..fb60602 100644
--- a/arch/mips/loongson32/common/platform.c
+++ b/arch/mips/loongson32/common/platform.c
@@ -69,7 +69,7 @@ void __init ls1x_serial_set_uartclk(struct platform_device 
*pdev)
 /* CPUFreq */
 static struct plat_ls1x_cpufreq ls1x_cpufreq_pdata = {
.clk_name   = "cpu_clk",
-   .osc_clk_name   = "osc_33m_clk",
+   .osc_clk_name   = "osc_clk",
.max_freq   = 266 * 1000,
.min_freq   = 33 * 1000,
 };
-- 
1.9.1

[PATCH] MIPS: Loongson1B: Change the OSC clock name

[Keguang Zhang]

From: Kelvin Cheung 

This patch changes the OSC clock name to "osc_clk".

Signed-off-by: Kelvin Cheung 
---
 arch/mips/loongson32/common/platform.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/mips/loongson32/common/platform.c 
b/arch/mips/loongson32/common/platform.c
index 4d12e36..fb60602 100644
--- a/arch/mips/loongson32/common/platform.c
+++ b/arch/mips/loongson32/common/platform.c
@@ -69,7 +69,7 @@ void __init ls1x_serial_set_uartclk(struct platform_device 
*pdev)
 /* CPUFreq */
 static struct plat_ls1x_cpufreq ls1x_cpufreq_pdata = {
.clk_name   = "cpu_clk",
-   .osc_clk_name   = "osc_33m_clk",
+   .osc_clk_name   = "osc_clk",
.max_freq   = 266 * 1000,
.min_freq   = 33 * 1000,
 };
-- 
1.9.1