Re: [PATCH] MIPS: microMIPS: Fix incorrect mask in insn_table_MM

[James Hogan]

On Tue, Oct 31, 2017 at 07:08:04AM +, James Hogan wrote:
> On Tue, Oct 31, 2017 at 12:35:03AM -0500, Gustavo A. R. Silva wrote:
> > Signed-off-by: Gustavo A. R. Silva 
> 
> Reviewed-by: James Hogan 

That should of course be:

Reviewed-by: James Hogan 

Re: [PATCH] MIPS: microMIPS: Fix incorrect mask in insn_table_MM

[James Hogan]

On Tue, Oct 31, 2017 at 07:08:04AM +, James Hogan wrote:
> On Tue, Oct 31, 2017 at 12:35:03AM -0500, Gustavo A. R. Silva wrote:
> > Signed-off-by: Gustavo A. R. Silva 
> 
> Reviewed-by: James Hogan 

That should of course be:

Reviewed-by: James Hogan 

Re: [PATCH] MIPS: microMIPS: Fix incorrect mask in insn_table_MM

[James Hogan]

On Tue, Oct 31, 2017 at 12:35:03AM -0500, Gustavo A. R. Silva wrote:
> It seems that this is a typo error and the proper bit masking is
> "RT | RS" instead of "RS | RS".
> 
> This issue was detected with the help of Coccinelle.
> 
> Reported-by: Julia Lawall 

May I suggest adding:
Fixes: d6b3314b49e1 ("MIPS: uasm: Add lh uam instruction")

> Signed-off-by: Gustavo A. R. Silva 

Reviewed-by: James Hogan 

Probably worthy of a stable tag too (though there will be conflicts with
ce807d5f67ed309a6f357b88cc93185d89e921d3 before 4.13):
Cc:  # 3.16+

Thanks
James

> ---
>  arch/mips/mm/uasm-micromips.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/mips/mm/uasm-micromips.c b/arch/mips/mm/uasm-micromips.c
> index c28ff53..cdb5a19 100644
> --- a/arch/mips/mm/uasm-micromips.c
> +++ b/arch/mips/mm/uasm-micromips.c
> @@ -80,7 +80,7 @@ static const struct insn const insn_table_MM[insn_invalid] 
> = {
>   [insn_jr]   = {M(mm_pool32a_op, 0, 0, 0, mm_jalr_op, 
> mm_pool32axf_op), RS},
>   [insn_lb]   = {M(mm_lb32_op, 0, 0, 0, 0, 0), RT | RS | SIMM},
>   [insn_ld]   = {0, 0},
> - [insn_lh]   = {M(mm_lh32_op, 0, 0, 0, 0, 0), RS | RS | SIMM},
> + [insn_lh]   = {M(mm_lh32_op, 0, 0, 0, 0, 0), RT | RS | SIMM},
>   [insn_ll]   = {M(mm_pool32c_op, 0, 0, (mm_ll_func << 1), 0, 0), RS 
> | RT | SIMM},
>   [insn_lld]  = {0, 0},
>   [insn_lui]  = {M(mm_pool32i_op, mm_lui_op, 0, 0, 0, 0), RS | SIMM},
> -- 
> 2.7.4
> 
> 


signature.asc
Description: Digital signature

Re: [PATCH] MIPS: microMIPS: Fix incorrect mask in insn_table_MM

[James Hogan]

On Tue, Oct 31, 2017 at 12:35:03AM -0500, Gustavo A. R. Silva wrote:
> It seems that this is a typo error and the proper bit masking is
> "RT | RS" instead of "RS | RS".
> 
> This issue was detected with the help of Coccinelle.
> 
> Reported-by: Julia Lawall 

May I suggest adding:
Fixes: d6b3314b49e1 ("MIPS: uasm: Add lh uam instruction")

> Signed-off-by: Gustavo A. R. Silva 

Reviewed-by: James Hogan 

Probably worthy of a stable tag too (though there will be conflicts with
ce807d5f67ed309a6f357b88cc93185d89e921d3 before 4.13):
Cc:  # 3.16+

Thanks
James

> ---
>  arch/mips/mm/uasm-micromips.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/mips/mm/uasm-micromips.c b/arch/mips/mm/uasm-micromips.c
> index c28ff53..cdb5a19 100644
> --- a/arch/mips/mm/uasm-micromips.c
> +++ b/arch/mips/mm/uasm-micromips.c
> @@ -80,7 +80,7 @@ static const struct insn const insn_table_MM[insn_invalid] 
> = {
>   [insn_jr]   = {M(mm_pool32a_op, 0, 0, 0, mm_jalr_op, 
> mm_pool32axf_op), RS},
>   [insn_lb]   = {M(mm_lb32_op, 0, 0, 0, 0, 0), RT | RS | SIMM},
>   [insn_ld]   = {0, 0},
> - [insn_lh]   = {M(mm_lh32_op, 0, 0, 0, 0, 0), RS | RS | SIMM},
> + [insn_lh]   = {M(mm_lh32_op, 0, 0, 0, 0, 0), RT | RS | SIMM},
>   [insn_ll]   = {M(mm_pool32c_op, 0, 0, (mm_ll_func << 1), 0, 0), RS 
> | RT | SIMM},
>   [insn_lld]  = {0, 0},
>   [insn_lui]  = {M(mm_pool32i_op, mm_lui_op, 0, 0, 0, 0), RS | SIMM},
> -- 
> 2.7.4
> 
> 


signature.asc
Description: Digital signature

[PATCH] MIPS: microMIPS: Fix incorrect mask in insn_table_MM

[Gustavo A. R. Silva]

It seems that this is a typo error and the proper bit masking is
"RT | RS" instead of "RS | RS".

This issue was detected with the help of Coccinelle.

Reported-by: Julia Lawall 
Signed-off-by: Gustavo A. R. Silva 
---
 arch/mips/mm/uasm-micromips.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/mips/mm/uasm-micromips.c b/arch/mips/mm/uasm-micromips.c
index c28ff53..cdb5a19 100644
--- a/arch/mips/mm/uasm-micromips.c
+++ b/arch/mips/mm/uasm-micromips.c
@@ -80,7 +80,7 @@ static const struct insn const insn_table_MM[insn_invalid] = {
[insn_jr]   = {M(mm_pool32a_op, 0, 0, 0, mm_jalr_op, 
mm_pool32axf_op), RS},
[insn_lb]   = {M(mm_lb32_op, 0, 0, 0, 0, 0), RT | RS | SIMM},
[insn_ld]   = {0, 0},
-   [insn_lh]   = {M(mm_lh32_op, 0, 0, 0, 0, 0), RS | RS | SIMM},
+   [insn_lh]   = {M(mm_lh32_op, 0, 0, 0, 0, 0), RT | RS | SIMM},
[insn_ll]   = {M(mm_pool32c_op, 0, 0, (mm_ll_func << 1), 0, 0), RS 
| RT | SIMM},
[insn_lld]  = {0, 0},
[insn_lui]  = {M(mm_pool32i_op, mm_lui_op, 0, 0, 0, 0), RS | SIMM},
-- 
2.7.4

[PATCH] MIPS: microMIPS: Fix incorrect mask in insn_table_MM

[Gustavo A. R. Silva]

It seems that this is a typo error and the proper bit masking is
"RT | RS" instead of "RS | RS".

This issue was detected with the help of Coccinelle.

Reported-by: Julia Lawall 
Signed-off-by: Gustavo A. R. Silva 
---
 arch/mips/mm/uasm-micromips.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/mips/mm/uasm-micromips.c b/arch/mips/mm/uasm-micromips.c
index c28ff53..cdb5a19 100644
--- a/arch/mips/mm/uasm-micromips.c
+++ b/arch/mips/mm/uasm-micromips.c
@@ -80,7 +80,7 @@ static const struct insn const insn_table_MM[insn_invalid] = {
[insn_jr]   = {M(mm_pool32a_op, 0, 0, 0, mm_jalr_op, 
mm_pool32axf_op), RS},
[insn_lb]   = {M(mm_lb32_op, 0, 0, 0, 0, 0), RT | RS | SIMM},
[insn_ld]   = {0, 0},
-   [insn_lh]   = {M(mm_lh32_op, 0, 0, 0, 0, 0), RS | RS | SIMM},
+   [insn_lh]   = {M(mm_lh32_op, 0, 0, 0, 0, 0), RT | RS | SIMM},
[insn_ll]   = {M(mm_pool32c_op, 0, 0, (mm_ll_func << 1), 0, 0), RS 
| RT | SIMM},
[insn_lld]  = {0, 0},
[insn_lui]  = {M(mm_pool32i_op, mm_lui_op, 0, 0, 0, 0), RS | SIMM},
-- 
2.7.4