Re: [PATCH] MIPS: pic32mzda: fix linker error for pic32_get_pbclk().

2016-06-02 Thread Purna Chandra Mandal 
On 06/02/2016 02:45 PM, Harvey Hunt wrote:
> Hi Purna,
>
> On 02/06/16 06:20, Purna Chandra Mandal wrote:
>> Early clock API pic32_get_pbclk() is defined in early_clk.c and
>> used by time.c and early_console.c. When CONFIG_EARLY_PRINTK isn't
>> set, early_clk.c isn't compiled and so a linker error is reported
>> while referring the API from time.c.
>
> Maybe "early_clk.c isn't compiled and so time.c fails to link"?
>
ack.

>>
>> Fix it by compiling early_clk.c always. Also sort files in
>> alphabetical order.
>>
>> Cc: Harvey Hunt 
>> Cc: Ralf Baechle 
>> Cc: linux-m...@linux-mips.org
>> Cc: Joshua Henderson 
>>
>> Signed-off-by: Purna Chandra Mandal 
>>
>> ---
>>
>>  arch/mips/pic32/pic32mzda/Makefile | 5 ++---
>>  1 file changed, 2 insertions(+), 3 deletions(-)
>>
>> diff --git a/arch/mips/pic32/pic32mzda/Makefile 
>> b/arch/mips/pic32/pic32mzda/Makefile
>> index 4a4c272..c286496 100644
>> --- a/arch/mips/pic32/pic32mzda/Makefile
>> +++ b/arch/mips/pic32/pic32mzda/Makefile
>> @@ -2,8 +2,7 @@
>>  # Joshua Henderson, 
>>  # Copyright (C) 2015 Microchip Technology, Inc.  All rights reserved.
>>  #
>> -obj-y:= init.o time.o config.o
>> +obj-y:= config.o early_clk.o init.o time.o
>>
>>  obj-$(CONFIG_EARLY_PRINTK)+= early_console.o  \
>> -   early_pin.o\
>> -   early_clk.o
>> +   early_pin.o
>>
>
> Perhaps add:
>
> Reported-by: Harvey Hunt 
>
> Thanks for fixing this,
>
> Reviewed-by: Harvey Hunt 
>
Thanks Harvey.

> Thanks,
>
> Harvey

Re: [PATCH] MIPS: pic32mzda: fix linker error for pic32_get_pbclk().

2016-06-02 Thread Purna Chandra Mandal 
On 06/02/2016 02:45 PM, Harvey Hunt wrote:
> Hi Purna,
>
> On 02/06/16 06:20, Purna Chandra Mandal wrote:
>> Early clock API pic32_get_pbclk() is defined in early_clk.c and
>> used by time.c and early_console.c. When CONFIG_EARLY_PRINTK isn't
>> set, early_clk.c isn't compiled and so a linker error is reported
>> while referring the API from time.c.
>
> Maybe "early_clk.c isn't compiled and so time.c fails to link"?
>
ack.

>>
>> Fix it by compiling early_clk.c always. Also sort files in
>> alphabetical order.
>>
>> Cc: Harvey Hunt 
>> Cc: Ralf Baechle 
>> Cc: linux-m...@linux-mips.org
>> Cc: Joshua Henderson 
>>
>> Signed-off-by: Purna Chandra Mandal 
>>
>> ---
>>
>>  arch/mips/pic32/pic32mzda/Makefile | 5 ++---
>>  1 file changed, 2 insertions(+), 3 deletions(-)
>>
>> diff --git a/arch/mips/pic32/pic32mzda/Makefile 
>> b/arch/mips/pic32/pic32mzda/Makefile
>> index 4a4c272..c286496 100644
>> --- a/arch/mips/pic32/pic32mzda/Makefile
>> +++ b/arch/mips/pic32/pic32mzda/Makefile
>> @@ -2,8 +2,7 @@
>>  # Joshua Henderson, 
>>  # Copyright (C) 2015 Microchip Technology, Inc.  All rights reserved.
>>  #
>> -obj-y:= init.o time.o config.o
>> +obj-y:= config.o early_clk.o init.o time.o
>>
>>  obj-$(CONFIG_EARLY_PRINTK)+= early_console.o  \
>> -   early_pin.o\
>> -   early_clk.o
>> +   early_pin.o
>>
>
> Perhaps add:
>
> Reported-by: Harvey Hunt 
>
> Thanks for fixing this,
>
> Reviewed-by: Harvey Hunt 
>
Thanks Harvey.

> Thanks,
>
> Harvey

Re: [PATCH] MIPS: pic32mzda: fix linker error for pic32_get_pbclk().

2016-06-02 Thread Harvey Hunt 

Hi Purna,

On 02/06/16 06:20, Purna Chandra Mandal wrote:

Early clock API pic32_get_pbclk() is defined in early_clk.c and
used by time.c and early_console.c. When CONFIG_EARLY_PRINTK isn't
set, early_clk.c isn't compiled and so a linker error is reported
while referring the API from time.c.


Maybe "early_clk.c isn't compiled and so time.c fails to link"?



Fix it by compiling early_clk.c always. Also sort files in
alphabetical order.

Cc: Harvey Hunt 
Cc: Ralf Baechle 
Cc: linux-m...@linux-mips.org
Cc: Joshua Henderson 

Signed-off-by: Purna Chandra Mandal 

---

 arch/mips/pic32/pic32mzda/Makefile | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/arch/mips/pic32/pic32mzda/Makefile 
b/arch/mips/pic32/pic32mzda/Makefile
index 4a4c272..c286496 100644
--- a/arch/mips/pic32/pic32mzda/Makefile
+++ b/arch/mips/pic32/pic32mzda/Makefile
@@ -2,8 +2,7 @@
 # Joshua Henderson, 
 # Copyright (C) 2015 Microchip Technology, Inc.  All rights reserved.
 #
-obj-y  := init.o time.o config.o
+obj-y  := config.o early_clk.o init.o time.o

 obj-$(CONFIG_EARLY_PRINTK) += early_console.o  \
-  early_pin.o  \
-  early_clk.o
+  early_pin.o



Perhaps add:

Reported-by: Harvey Hunt 

Thanks for fixing this,

Reviewed-by: Harvey Hunt 

Thanks,

Harvey

Re: [PATCH] MIPS: pic32mzda: fix linker error for pic32_get_pbclk().

2016-06-02 Thread Harvey Hunt 

Hi Purna,

On 02/06/16 06:20, Purna Chandra Mandal wrote:

Early clock API pic32_get_pbclk() is defined in early_clk.c and
used by time.c and early_console.c. When CONFIG_EARLY_PRINTK isn't
set, early_clk.c isn't compiled and so a linker error is reported
while referring the API from time.c.


Maybe "early_clk.c isn't compiled and so time.c fails to link"?



Fix it by compiling early_clk.c always. Also sort files in
alphabetical order.

Cc: Harvey Hunt 
Cc: Ralf Baechle 
Cc: linux-m...@linux-mips.org
Cc: Joshua Henderson 

Signed-off-by: Purna Chandra Mandal 

---

 arch/mips/pic32/pic32mzda/Makefile | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/arch/mips/pic32/pic32mzda/Makefile 
b/arch/mips/pic32/pic32mzda/Makefile
index 4a4c272..c286496 100644
--- a/arch/mips/pic32/pic32mzda/Makefile
+++ b/arch/mips/pic32/pic32mzda/Makefile
@@ -2,8 +2,7 @@
 # Joshua Henderson, 
 # Copyright (C) 2015 Microchip Technology, Inc.  All rights reserved.
 #
-obj-y  := init.o time.o config.o
+obj-y  := config.o early_clk.o init.o time.o

 obj-$(CONFIG_EARLY_PRINTK) += early_console.o  \
-  early_pin.o  \
-  early_clk.o
+  early_pin.o



Perhaps add:

Reported-by: Harvey Hunt 

Thanks for fixing this,

Reviewed-by: Harvey Hunt 

Thanks,

Harvey

[PATCH] MIPS: pic32mzda: fix linker error for pic32_get_pbclk().

2016-06-01 Thread Purna Chandra Mandal 
Early clock API pic32_get_pbclk() is defined in early_clk.c and
used by time.c and early_console.c. When CONFIG_EARLY_PRINTK isn't
set, early_clk.c isn't compiled and so a linker error is reported
while referring the API from time.c.

Fix it by compiling early_clk.c always. Also sort files in
alphabetical order.

Cc: Harvey Hunt 
Cc: Ralf Baechle 
Cc: linux-m...@linux-mips.org
Cc: Joshua Henderson 

Signed-off-by: Purna Chandra Mandal 

---

 arch/mips/pic32/pic32mzda/Makefile | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/arch/mips/pic32/pic32mzda/Makefile 
b/arch/mips/pic32/pic32mzda/Makefile
index 4a4c272..c286496 100644
--- a/arch/mips/pic32/pic32mzda/Makefile
+++ b/arch/mips/pic32/pic32mzda/Makefile
@@ -2,8 +2,7 @@
 # Joshua Henderson, 
 # Copyright (C) 2015 Microchip Technology, Inc.  All rights reserved.
 #
-obj-y  := init.o time.o config.o
+obj-y  := config.o early_clk.o init.o time.o
 
 obj-$(CONFIG_EARLY_PRINTK) += early_console.o  \
-  early_pin.o  \
-  early_clk.o
+  early_pin.o
-- 
1.8.3.1

[PATCH] MIPS: pic32mzda: fix linker error for pic32_get_pbclk().

2016-06-01 Thread Purna Chandra Mandal 
Early clock API pic32_get_pbclk() is defined in early_clk.c and
used by time.c and early_console.c. When CONFIG_EARLY_PRINTK isn't
set, early_clk.c isn't compiled and so a linker error is reported
while referring the API from time.c.

Fix it by compiling early_clk.c always. Also sort files in
alphabetical order.

Cc: Harvey Hunt 
Cc: Ralf Baechle 
Cc: linux-m...@linux-mips.org
Cc: Joshua Henderson 

Signed-off-by: Purna Chandra Mandal 

---

 arch/mips/pic32/pic32mzda/Makefile | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/arch/mips/pic32/pic32mzda/Makefile 
b/arch/mips/pic32/pic32mzda/Makefile
index 4a4c272..c286496 100644
--- a/arch/mips/pic32/pic32mzda/Makefile
+++ b/arch/mips/pic32/pic32mzda/Makefile
@@ -2,8 +2,7 @@
 # Joshua Henderson, 
 # Copyright (C) 2015 Microchip Technology, Inc.  All rights reserved.
 #
-obj-y  := init.o time.o config.o
+obj-y  := config.o early_clk.o init.o time.o
 
 obj-$(CONFIG_EARLY_PRINTK) += early_console.o  \
-  early_pin.o  \
-  early_clk.o
+  early_pin.o
-- 
1.8.3.1