Re: [PATCH] Malformatted switch statment
From: Joris Gutjahr Date: Sun, 28 Oct 2018 17:45:46 +0100 > I fixed this coding style error I got after running > checkpatch --file on this file. > The problem was that the whole case block was on one line. > > Signed-off-by: Joris Gutjahr Frankly I think the existing code is more compact and easier to read and understand. Checkpatch is a tool, and it's results need be interpreated and evaluated by human beings. It's not to be taken as the final verdict. I'm not applying this, sorry.
Re: [PATCH] Malformatted switch statment
From: Joris Gutjahr Date: Sun, 28 Oct 2018 17:45:46 +0100 > I fixed this coding style error I got after running > checkpatch --file on this file. > The problem was that the whole case block was on one line. > > Signed-off-by: Joris Gutjahr Frankly I think the existing code is more compact and easier to read and understand. Checkpatch is a tool, and it's results need be interpreated and evaluated by human beings. It's not to be taken as the final verdict. I'm not applying this, sorry.
[PATCH] Malformatted switch statment
I fixed this coding style error I got after running
checkpatch --file on this file.
The problem was that the whole case block was on one line.
Signed-off-by: Joris Gutjahr
---
drivers/ide/amd74xx.c | 12 +---
1 file changed, 9 insertions(+), 3 deletions(-)
diff --git a/drivers/ide/amd74xx.c b/drivers/ide/amd74xx.c
index cbfe846911d1..fa39f279bf53 100644
--- a/drivers/ide/amd74xx.c
+++ b/drivers/ide/amd74xx.c
@@ -273,9 +273,15 @@ static int amd74xx_probe(struct pci_dev *dev, const struct
pci_device_id *id)
amd_clock = (ide_pci_clk ? ide_pci_clk : 33) * 1000;
switch (amd_clock) {
- case 33000: amd_clock = 3; break;
- case 37000: amd_clock = 37500; break;
- case 41000: amd_clock = 41666; break;
+ case 33000:
+ amd_clock = 3;
+ break;
+ case 37000:
+ amd_clock = 37500;
+ break;
+ case 41000:
+ amd_clock = 41666;
+ break;
}
if (amd_clock < 2 || amd_clock > 5) {
--
2.19.1
[PATCH] Malformatted switch statment
I fixed this coding style error I got after running
checkpatch --file on this file.
The problem was that the whole case block was on one line.
Signed-off-by: Joris Gutjahr
---
drivers/ide/amd74xx.c | 12 +---
1 file changed, 9 insertions(+), 3 deletions(-)
diff --git a/drivers/ide/amd74xx.c b/drivers/ide/amd74xx.c
index cbfe846911d1..fa39f279bf53 100644
--- a/drivers/ide/amd74xx.c
+++ b/drivers/ide/amd74xx.c
@@ -273,9 +273,15 @@ static int amd74xx_probe(struct pci_dev *dev, const struct
pci_device_id *id)
amd_clock = (ide_pci_clk ? ide_pci_clk : 33) * 1000;
switch (amd_clock) {
- case 33000: amd_clock = 3; break;
- case 37000: amd_clock = 37500; break;
- case 41000: amd_clock = 41666; break;
+ case 33000:
+ amd_clock = 3;
+ break;
+ case 37000:
+ amd_clock = 37500;
+ break;
+ case 41000:
+ amd_clock = 41666;
+ break;
}
if (amd_clock < 2 || amd_clock > 5) {
--
2.19.1
