Re: [PATCH] Nvidia AGP: Use refcount aware PCI interfaces
On Mon, 23 Apr 2007 10:21:14 -0400 Dave Jones <[EMAIL PROTECTED]> wrote: > On Mon, Apr 23, 2007 at 02:50:27PM +0100, Alan Cox wrote: > > Signed-off-by: Alan Cox <[EMAIL PROTECTED]> > > This is lacking a changelog. What's the purpose of changing this? > Is pci_find_slot() obsolete and going away? (If so, it should be That is the intention because most users of pci_find_slot are unsafe. Alan - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] Nvidia AGP: Use refcount aware PCI interfaces
On Mon, Apr 23, 2007 at 02:50:27PM +0100, Alan Cox wrote: > Signed-off-by: Alan Cox <[EMAIL PROTECTED]> This is lacking a changelog. What's the purpose of changing this? Is pci_find_slot() obsolete and going away? (If so, it should be marked as such). These devices aren't hotpluggable, so I'm not sure why they need to be reference counted. Inquisitive minds would like to know more. Dave -- http://www.codemonkey.org.uk - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH] Nvidia AGP: Use refcount aware PCI interfaces
Signed-off-by: Alan Cox <[EMAIL PROTECTED]>
diff -u --new-file --recursive --exclude-from /usr/src/exclude
linux.vanilla-2.6.21-rc6-mm1/drivers/char/agp/nvidia-agp.c
linux-2.6.21-rc6-mm1/drivers/char/agp/nvidia-agp.c
--- linux.vanilla-2.6.21-rc6-mm1/drivers/char/agp/nvidia-agp.c 2007-04-12
14:15:03.0 +0100
+++ linux-2.6.21-rc6-mm1/drivers/char/agp/nvidia-agp.c 2007-04-23
11:53:12.560578080 +0100
@@ -320,11 +320,11 @@
u8 cap_ptr;
nvidia_private.dev_1 =
- pci_find_slot((unsigned int)pdev->bus->number, PCI_DEVFN(0, 1));
+ pci_get_bus_and_slot((unsigned int)pdev->bus->number,
PCI_DEVFN(0, 1));
nvidia_private.dev_2 =
- pci_find_slot((unsigned int)pdev->bus->number, PCI_DEVFN(0, 2));
+ pci_get_bus_and_slot((unsigned int)pdev->bus->number,
PCI_DEVFN(0, 2));
nvidia_private.dev_3 =
- pci_find_slot((unsigned int)pdev->bus->number, PCI_DEVFN(30,
0));
+ pci_get_bus_and_slot((unsigned int)pdev->bus->number,
PCI_DEVFN(30, 0));
if (!nvidia_private.dev_1 || !nvidia_private.dev_2 ||
!nvidia_private.dev_3) {
printk(KERN_INFO PFX "Detected an NVIDIA nForce/nForce2 "
@@ -443,6 +443,9 @@
static void __exit agp_nvidia_cleanup(void)
{
pci_unregister_driver(_nvidia_pci_driver);
+ pci_dev_put(nvidia_private.dev_1);
+ pci_dev_put(nvidia_private.dev_2);
+ pci_dev_put(nvidia_private.dev_3);
}
module_init(agp_nvidia_init);
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[PATCH] Nvidia AGP: Use refcount aware PCI interfaces
Signed-off-by: Alan Cox [EMAIL PROTECTED]
diff -u --new-file --recursive --exclude-from /usr/src/exclude
linux.vanilla-2.6.21-rc6-mm1/drivers/char/agp/nvidia-agp.c
linux-2.6.21-rc6-mm1/drivers/char/agp/nvidia-agp.c
--- linux.vanilla-2.6.21-rc6-mm1/drivers/char/agp/nvidia-agp.c 2007-04-12
14:15:03.0 +0100
+++ linux-2.6.21-rc6-mm1/drivers/char/agp/nvidia-agp.c 2007-04-23
11:53:12.560578080 +0100
@@ -320,11 +320,11 @@
u8 cap_ptr;
nvidia_private.dev_1 =
- pci_find_slot((unsigned int)pdev-bus-number, PCI_DEVFN(0, 1));
+ pci_get_bus_and_slot((unsigned int)pdev-bus-number,
PCI_DEVFN(0, 1));
nvidia_private.dev_2 =
- pci_find_slot((unsigned int)pdev-bus-number, PCI_DEVFN(0, 2));
+ pci_get_bus_and_slot((unsigned int)pdev-bus-number,
PCI_DEVFN(0, 2));
nvidia_private.dev_3 =
- pci_find_slot((unsigned int)pdev-bus-number, PCI_DEVFN(30,
0));
+ pci_get_bus_and_slot((unsigned int)pdev-bus-number,
PCI_DEVFN(30, 0));
if (!nvidia_private.dev_1 || !nvidia_private.dev_2 ||
!nvidia_private.dev_3) {
printk(KERN_INFO PFX Detected an NVIDIA nForce/nForce2
@@ -443,6 +443,9 @@
static void __exit agp_nvidia_cleanup(void)
{
pci_unregister_driver(agp_nvidia_pci_driver);
+ pci_dev_put(nvidia_private.dev_1);
+ pci_dev_put(nvidia_private.dev_2);
+ pci_dev_put(nvidia_private.dev_3);
}
module_init(agp_nvidia_init);
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] Nvidia AGP: Use refcount aware PCI interfaces
On Mon, Apr 23, 2007 at 02:50:27PM +0100, Alan Cox wrote: Signed-off-by: Alan Cox [EMAIL PROTECTED] This is lacking a changelog. What's the purpose of changing this? Is pci_find_slot() obsolete and going away? (If so, it should be marked as such). These devices aren't hotpluggable, so I'm not sure why they need to be reference counted. Inquisitive minds would like to know more. Dave -- http://www.codemonkey.org.uk - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] Nvidia AGP: Use refcount aware PCI interfaces
On Mon, 23 Apr 2007 10:21:14 -0400 Dave Jones [EMAIL PROTECTED] wrote: On Mon, Apr 23, 2007 at 02:50:27PM +0100, Alan Cox wrote: Signed-off-by: Alan Cox [EMAIL PROTECTED] This is lacking a changelog. What's the purpose of changing this? Is pci_find_slot() obsolete and going away? (If so, it should be That is the intention because most users of pci_find_slot are unsafe. Alan - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
