Re: [PATCH] PCI: functions/pci-epf-test: fix missing destroy_workqueue() on error in pci_epf_test_init

[Kishon Vijay Abraham I]

Hi Qinglang,

On 18/01/21 6:17 pm, Lorenzo Pieralisi wrote:
> On Wed, Oct 28, 2020 at 05:15:49PM +0800, Qinglang Miao wrote:
>> Add the missing destroy_workqueue() before return from
>> pci_epf_test_init() in the error handling case.
>>
>> Signed-off-by: Qinglang Miao 
>> ---
>>  drivers/pci/endpoint/functions/pci-epf-test.c | 1 +
>>  1 file changed, 1 insertion(+)
> 
> Need Kishon's ack.
> 
> Lorenzo

Can you also add destroy_workqueue() in pci_epf_test_exit()?

Thank You,
Kishon

> 
>> diff --git a/drivers/pci/endpoint/functions/pci-epf-test.c 
>> b/drivers/pci/endpoint/functions/pci-epf-test.c
>> index e4e51d884..6854f2525 100644
>> --- a/drivers/pci/endpoint/functions/pci-epf-test.c
>> +++ b/drivers/pci/endpoint/functions/pci-epf-test.c
>> @@ -918,6 +918,7 @@ static int __init pci_epf_test_init(void)
>>  ret = pci_epf_register_driver(&test_driver);
>>  if (ret) {
>>  pr_err("Failed to register pci epf test driver --> %d\n", ret);
>> +destroy_workqueue(kpcitest_workqueue);
>>  return ret;
>>  }
>>  
>> -- 
>> 2.23.0
>>

Re: [PATCH] PCI: functions/pci-epf-test: fix missing destroy_workqueue() on error in pci_epf_test_init

[Lorenzo Pieralisi]

On Wed, Oct 28, 2020 at 05:15:49PM +0800, Qinglang Miao wrote:
> Add the missing destroy_workqueue() before return from
> pci_epf_test_init() in the error handling case.
> 
> Signed-off-by: Qinglang Miao 
> ---
>  drivers/pci/endpoint/functions/pci-epf-test.c | 1 +
>  1 file changed, 1 insertion(+)

Need Kishon's ack.

Lorenzo

> diff --git a/drivers/pci/endpoint/functions/pci-epf-test.c 
> b/drivers/pci/endpoint/functions/pci-epf-test.c
> index e4e51d884..6854f2525 100644
> --- a/drivers/pci/endpoint/functions/pci-epf-test.c
> +++ b/drivers/pci/endpoint/functions/pci-epf-test.c
> @@ -918,6 +918,7 @@ static int __init pci_epf_test_init(void)
>   ret = pci_epf_register_driver(&test_driver);
>   if (ret) {
>   pr_err("Failed to register pci epf test driver --> %d\n", ret);
> + destroy_workqueue(kpcitest_workqueue);
>   return ret;
>   }
>  
> -- 
> 2.23.0
> 

[PATCH] PCI: functions/pci-epf-test: fix missing destroy_workqueue() on error in pci_epf_test_init

[Qinglang Miao]

Add the missing destroy_workqueue() before return from
pci_epf_test_init() in the error handling case.

Signed-off-by: Qinglang Miao 
---
 drivers/pci/endpoint/functions/pci-epf-test.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/pci/endpoint/functions/pci-epf-test.c 
b/drivers/pci/endpoint/functions/pci-epf-test.c
index e4e51d884..6854f2525 100644
--- a/drivers/pci/endpoint/functions/pci-epf-test.c
+++ b/drivers/pci/endpoint/functions/pci-epf-test.c
@@ -918,6 +918,7 @@ static int __init pci_epf_test_init(void)
ret = pci_epf_register_driver(&test_driver);
if (ret) {
pr_err("Failed to register pci epf test driver --> %d\n", ret);
+   destroy_workqueue(kpcitest_workqueue);
return ret;
}
 
-- 
2.23.0