Re: [PATCH] Revert "mtd: spi-nor: Prefer asynchronous probe"

[Vignesh Raghavendra]

On Mon, 5 Oct 2020 14:33:21 +0530, Vignesh Raghavendra wrote:
> This reverts commit 03edda0e1edaa3c2e99239c66e3c14d749318fd6.
> 
> This leads to warn dump like [1] on some platforms and reorders MTD
> devices thus may break user space expectations. So revert the change.
> 
> [1]:
> 
> [...]

Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git 
spi-nor/next, thanks!
[1/1] Revert "mtd: spi-nor: Prefer asynchronous probe"
  https://git.kernel.org/mtd/c/9a3422a110

--
Regards
Vignesh

Re: [PATCH] Revert "mtd: spi-nor: Prefer asynchronous probe"

[Doug Anderson]

Hi,

On Mon, Oct 5, 2020 at 2:03 AM Vignesh Raghavendra  wrote:
>
> This reverts commit 03edda0e1edaa3c2e99239c66e3c14d749318fd6.
>
> This leads to warn dump like [1] on some platforms and reorders MTD
> devices thus may break user space expectations. So revert the change.
>
> [1]:
>
> [1.849801] [ cut here ]
> [1.854271] mscc_felix :00:00.5: device is disabled, skipping
> [1.858753] WARNING: CPU: 1 PID: 7 at kernel/kmod.c:136 
> __request_module+0x3a4/0x568
>
> [...]
>
> Reported-by: Michael Walle 
> Signed-off-by: Vignesh Raghavendra 
> ---
>  drivers/mtd/spi-nor/core.c | 1 -
>  1 file changed, 1 deletion(-)

Thank you for the revert and sorry for the breakage.

Reviewed-by: Douglas Anderson 

[PATCH] Revert "mtd: spi-nor: Prefer asynchronous probe"

[Vignesh Raghavendra]

This reverts commit 03edda0e1edaa3c2e99239c66e3c14d749318fd6.

This leads to warn dump like [1] on some platforms and reorders MTD
devices thus may break user space expectations. So revert the change.

[1]:

[1.849801] [ cut here ]
[1.854271] mscc_felix :00:00.5: device is disabled, skipping
[1.858753] WARNING: CPU: 1 PID: 7 at kernel/kmod.c:136 
__request_module+0x3a4/0x568

[...]

Reported-by: Michael Walle 
Signed-off-by: Vignesh Raghavendra 
---
 drivers/mtd/spi-nor/core.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/mtd/spi-nor/core.c b/drivers/mtd/spi-nor/core.c
index 2add4a01fce2..0369d98b2d12 100644
--- a/drivers/mtd/spi-nor/core.c
+++ b/drivers/mtd/spi-nor/core.c
@@ -3451,7 +3451,6 @@ static struct spi_mem_driver spi_nor_driver = {
.driver = {
.name = "spi-nor",
.of_match_table = spi_nor_of_table,
-   .probe_type = PROBE_PREFER_ASYNCHRONOUS,
},
.id_table = spi_nor_dev_ids,
},
-- 
2.28.0